)]}'
{"roles/osh-run-script/tasks/main.yaml":[{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"db6e96f5f4a845c6dcae2c0a9d8c7fdf35cbe108","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    OSH_EXTRA_HELM_ARGS: \"{{ zuul_osh_extra_helm_args_relative_path | default(\u0027\u0027) }}\""},{"line_number":22,"context_line":"    OSH_PATH: \"{{ zuul_osh_relative_path | default(\u0027../openstack-helm/\u0027) }}\""},{"line_number":23,"context_line":"    OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027../openstack-helm-infra/\u0027) }}\""},{"line_number":24,"context_line":"    OPENSTACK_RELEASE: \"{{ osh_params.openstack_release | default(\u0027\u0027) }}\""},{"line_number":25,"context_line":"    CONTAINER_DISTRO_NAME: \"{{ osh_params.container_distro_name | default(\u0027\u0027) }}\""},{"line_number":26,"context_line":"    CONTAINER_DISTRO_VERSION: \"{{ osh_params.container_distro_version | default(\u0027\u0027) }}\""},{"line_number":27,"context_line":"    FEATURE_GATES: \"{{ osh_params.feature_gates | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c6610213","line":24,"updated":"2019-12-12 09:54:46.000000000","message":"Does empty default make sense? We could default to newton maybe?","commit_id":"cace08c016957e9e1a8b1582bb4c0b56f19c1461"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"69b4c1a53aca4345101bda5d6aa8e956534f6548","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    OSH_EXTRA_HELM_ARGS: \"{{ zuul_osh_extra_helm_args_relative_path | default(\u0027\u0027) }}\""},{"line_number":22,"context_line":"    OSH_PATH: \"{{ zuul_osh_relative_path | default(\u0027../openstack-helm/\u0027) }}\""},{"line_number":23,"context_line":"    OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027../openstack-helm-infra/\u0027) }}\""},{"line_number":24,"context_line":"    OPENSTACK_RELEASE: \"{{ osh_params.openstack_release | default(\u0027\u0027) }}\""},{"line_number":25,"context_line":"    CONTAINER_DISTRO_NAME: \"{{ osh_params.container_distro_name | default(\u0027\u0027) }}\""},{"line_number":26,"context_line":"    CONTAINER_DISTRO_VERSION: \"{{ osh_params.container_distro_version | default(\u0027\u0027) }}\""},{"line_number":27,"context_line":"    FEATURE_GATES: \"{{ osh_params.feature_gates | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e9909144","line":24,"in_reply_to":"3fa7e38b_c6610213","updated":"2019-12-12 10:28:42.000000000","message":"yeah I was wondering about this. I expect the env script to check for empty values and just override with the default one in there (ocata)\n\nHaving a default in here seems a bit confusing IMO, becaues you get 2 different places to set this value (here and the get-env script)\n\nI would wait to see what other CI friends say regarding this","commit_id":"cace08c016957e9e1a8b1582bb4c0b56f19c1461"}]}