)]}'
{"local-storage/Chart.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"5e11739619676fb7247366b0e8435c31eafb24b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_6ba59547","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"updated":"2020-01-07 20:30:01.000000000","message":"We\u0027re not really copyrighting anything, this line can be removed.\n\nSame for the others.","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"d6ca6b6636e269f89a972e7bd0d4eb4ad678c1aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_96b4b41e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"in_reply_to":"3fa7e38b_6ba59547","updated":"2020-01-07 20:59:12.000000000","message":"IANAL, but other charts do include the copyright on these files. What makes this chart different?","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ef8af2a8af199c87f4d18d37b8d810cfb6f048ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_76fc98b5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"in_reply_to":"3fa7e38b_96b4b41e","updated":"2020-01-07 21:01:34.000000000","message":"They shouldn\u0027t, they need to be cleaned up eventually.","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"}],"local-storage/templates/pv-local.yaml":[{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"68eaadcc031dc29227a4c04d6e3ca711366ebb3f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ca3c23c2","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"updated":"2019-12-20 20:45:24.000000000","message":"I think the \u0027key\u0027 and \u0027value\u0027 here can be any label and selector applied to a node. Something like:\n\n        - key: control-plane\n          operator: In\n          values:\n          - enabled","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"33c44c34f95042660174a03134d001bcba7db28c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_54b51118","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_17dfa667","updated":"2019-12-30 10:29:14.000000000","message":"This should be fine as it\u0027s only for pods node affinity. The actual PVs are created based on the mount path available on the node.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"0c42ecc2a52efb4f7364a3d1fbe0cfec8f1cba59","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_b439e5a2","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_bdf1da02","updated":"2019-12-30 10:30:40.000000000","message":"Done. Instead of nodes, I have used the mount paths as we discussed earlier.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"736af02d8f8388fc5ea9e66d42698becb9000288","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_b4da5047","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_bdf1da02","updated":"2019-12-26 06:33:32.000000000","message":"Looking into it.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"22bc6693440018c8c84a18ce1f638498510f081b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_bdf1da02","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_ca3c23c2","updated":"2019-12-24 16:18:02.000000000","message":"If we want seperate PV\u0027s for each node then we can put the L20-L44 in a for loop and depending on the nodes we can generate each separate PV.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"736af02d8f8388fc5ea9e66d42698becb9000288","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f4d44821","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_ca3c23c2","updated":"2019-12-26 06:33:32.000000000","message":"Made changes to match labels as defined for ElasticSearch pod. This makes sense. Thanks Nishant.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"8ab931104411ce6c5acba6e4942fdaf453d29a32","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    required:\r"},{"line_number":37,"context_line":"      nodeSelectorTerms:\r"},{"line_number":38,"context_line":"      - matchExpressions:\r"},{"line_number":39,"context_line":"        - key: kubernetes.io/hostname\r"},{"line_number":40,"context_line":"          operator: In\r"},{"line_number":41,"context_line":"          values:\r"},{"line_number":42,"context_line":"          #TODO: This will be modified to replace with actual list of node names.\r"},{"line_number":43,"context_line":"          - dummy\r"},{"line_number":44,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_17dfa667","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":10},"in_reply_to":"3fa7e38b_f4d44821","updated":"2019-12-26 09:36:49.000000000","message":"This may not work. If the same label is added to multiple nodes, how it will be decided where the PV is going to be created? Though I know this means for node-affinity respect to pod deployment, but looks like PV deployment also looks into this for selecting the node.","commit_id":"604c38ed3b3fcd7a4f9e338f31b8fc36f1e0e68b"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"{{- if .Values.manifests.pv_local }}\r"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}\r"},{"line_number":19,"context_line":"{{- range $pv :\u003d .Values.persistentvolumes }}\r"},{"line_number":20,"context_line":"---\r"},{"line_number":21,"context_line":"apiVersion: v1\r"},{"line_number":22,"context_line":"kind: PersistentVolume\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_6c32af5f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":45},"updated":"2020-01-03 21:29:47.000000000","message":"This is not the correct path to range over. Also, this isn\u0027t the correct way to use range. It should be:\n\n{{- range .Values.conf.persistentvolumes }}","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"{{- if .Values.manifests.pv_local }}\r"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}\r"},{"line_number":19,"context_line":"{{- range $pv :\u003d .Values.persistentvolumes }}\r"},{"line_number":20,"context_line":"---\r"},{"line_number":21,"context_line":"apiVersion: v1\r"},{"line_number":22,"context_line":"kind: PersistentVolume\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_958a87ba","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":45},"in_reply_to":"3fa7e38b_6c32af5f","updated":"2020-01-06 08:36:41.000000000","message":"Done. Thanks for pointing out. I am still novice in Helm and OSH. A good way to learn. Other way, I have seen getting implemented but this seems to be the better way.","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1\r"},{"line_number":22,"context_line":"kind: PersistentVolume\r"},{"line_number":23,"context_line":"metadata:\r"},{"line_number":24,"context_line":"  name: {{ $pv.name }}\r"},{"line_number":25,"context_line":"  labels:\r"},{"line_number":26,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":27,"context_line":"spec:\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_cc4083a6","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":19},"updated":"2020-01-03 21:29:47.000000000","message":"Within the range block, scope is reduced, and the current item is available at \u0027.\u0027 - you could either declare {{- $pv :\u003d . }} or simply use {{- .name }} - whichever you prefer.\n\nThis comment applies to the other references to $pv within this file.","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1\r"},{"line_number":22,"context_line":"kind: PersistentVolume\r"},{"line_number":23,"context_line":"metadata:\r"},{"line_number":24,"context_line":"  name: {{ $pv.name }}\r"},{"line_number":25,"context_line":"  labels:\r"},{"line_number":26,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":27,"context_line":"spec:\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_55bacf70","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":19},"in_reply_to":"3fa7e38b_cc4083a6","updated":"2020-01-06 08:36:41.000000000","message":"Done. Made changes. One query, is it {{ .name }} or {{- .name }}?","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":23,"context_line":"metadata:\r"},{"line_number":24,"context_line":"  name: {{ $pv.name }}\r"},{"line_number":25,"context_line":"  labels:\r"},{"line_number":26,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":27,"context_line":"spec:\r"},{"line_number":28,"context_line":"  capacity:\r"},{"line_number":29,"context_line":"    storage: {{ $pv.storage_capacity }}\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_4c06d376","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":17},"updated":"2020-01-03 21:29:47.000000000","message":"This helm toolkit function requires two additional arguments. The first gives an \"application\u003d...\" label and the second give a \"component\u003d...\" label.","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"metadata:\r"},{"line_number":24,"context_line":"  name: {{ $pv.name }}\r"},{"line_number":25,"context_line":"  labels:\r"},{"line_number":26,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":27,"context_line":"spec:\r"},{"line_number":28,"context_line":"  capacity:\r"},{"line_number":29,"context_line":"    storage: {{ $pv.storage_capacity }}\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_75bfcb5f","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":17},"in_reply_to":"3fa7e38b_4c06d376","updated":"2020-01-06 08:36:41.000000000","message":"Done. Thanks for pointing out. Seems a copy paste error :)","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    storage: {{ $pv.storage_capacity }}\r"},{"line_number":30,"context_line":"  accessModes: {{ $pv.access_modes }}\r"},{"line_number":31,"context_line":"  persistentVolumeReclaimPolicy: {{ $pv.reclaimpolicy }}\r"},{"line_number":32,"context_line":"  storageClassName: {{ .Values.conf.storageclass.name }}\r"},{"line_number":33,"context_line":"  local:\r"},{"line_number":34,"context_line":"    path: {{ $pv.local_path }}\r"},{"line_number":35,"context_line":"  nodeAffinity:\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_0c245b0d","line":32,"range":{"start_line":32,"start_character":23,"end_line":32,"end_character":53},"updated":"2020-01-03 21:29:47.000000000","message":"Because we\u0027re in a range block, \u0027.\u0027 currently refers to the item being iterated over, so .Values. ... will not resolve.\n\nYou should add a reference to the $envAll variable here, ie:\n\n$envAll.Values. ...\n\nThis applies to the nodeSelectorTerms further down as well.","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    storage: {{ $pv.storage_capacity }}\r"},{"line_number":30,"context_line":"  accessModes: {{ $pv.access_modes }}\r"},{"line_number":31,"context_line":"  persistentVolumeReclaimPolicy: {{ $pv.reclaimpolicy }}\r"},{"line_number":32,"context_line":"  storageClassName: {{ .Values.conf.storageclass.name }}\r"},{"line_number":33,"context_line":"  local:\r"},{"line_number":34,"context_line":"    path: {{ $pv.local_path }}\r"},{"line_number":35,"context_line":"  nodeAffinity:\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_15b0d78c","line":32,"range":{"start_line":32,"start_character":23,"end_line":32,"end_character":53},"in_reply_to":"3fa7e38b_0c245b0d","updated":"2020-01-06 08:36:41.000000000","message":"Done.","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9f60089d6763ee4a46a1922f2a805a417791bae4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    storage: {{ .storage_capacity }}\r"},{"line_number":30,"context_line":"  accessModes: {{ .access_modes }}\r"},{"line_number":31,"context_line":"  persistentVolumeReclaimPolicy: {{ .reclaim_policy }}\r"},{"line_number":32,"context_line":"  storageClassName: {{ $envAll.Values.conf.storage_class.name }}\r"},{"line_number":33,"context_line":"  local:\r"},{"line_number":34,"context_line":"    path: {{ .local_path }}\r"},{"line_number":35,"context_line":"  nodeAffinity:\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_64d95b26","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":64},"updated":"2020-01-06 14:58:54.000000000","message":"See comment about using the release name","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"710c9a2314cfc3894e1c4585a12e126fc33283b9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    storage: {{ .storage_capacity }}\r"},{"line_number":30,"context_line":"  accessModes: {{ .access_modes }}\r"},{"line_number":31,"context_line":"  persistentVolumeReclaimPolicy: {{ .reclaim_policy }}\r"},{"line_number":32,"context_line":"  storageClassName: {{ $envAll.Values.conf.storage_class.name }}\r"},{"line_number":33,"context_line":"  local:\r"},{"line_number":34,"context_line":"    path: {{ .local_path }}\r"},{"line_number":35,"context_line":"  nodeAffinity:\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_8d7b5bf1","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":64},"in_reply_to":"3fa7e38b_64d95b26","updated":"2020-01-06 17:45:42.000000000","message":"Done","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"}],"local-storage/templates/storageclass-local.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:\r"},{"line_number":23,"context_line":"  name: {{ .Values.conf.storageclass.name }}\r"},{"line_number":24,"context_line":"  labels:\r"},{"line_number":25,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":26,"context_line":"provisioner: kubernetes.io/no-provisioner\r"},{"line_number":27,"context_line":"volumeBindingMode: WaitForFirstConsumer\r"},{"line_number":28,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_8c5e0b77","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":17},"updated":"2020-01-03 21:29:47.000000000","message":"I have the same comment here as in the other document regarding this helm toolkit function. For the toolkit I find the best (only?) documentation is the source itself within openstack-helm-infra","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:\r"},{"line_number":23,"context_line":"  name: {{ .Values.conf.storageclass.name }}\r"},{"line_number":24,"context_line":"  labels:\r"},{"line_number":25,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":26,"context_line":"provisioner: kubernetes.io/no-provisioner\r"},{"line_number":27,"context_line":"volumeBindingMode: WaitForFirstConsumer\r"},{"line_number":28,"context_line":"{{- end }}\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_35b5d37d","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":17},"in_reply_to":"3fa7e38b_8c5e0b77","updated":"2020-01-06 08:36:41.000000000","message":"Done","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9f60089d6763ee4a46a1922f2a805a417791bae4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: storage.k8s.io/v1\r"},{"line_number":21,"context_line":"kind: StorageClass\r"},{"line_number":22,"context_line":"metadata:\r"},{"line_number":23,"context_line":"  name: {{ .Values.conf.storage_class.name }}\r"},{"line_number":24,"context_line":"  labels:\r"},{"line_number":25,"context_line":"{{ tuple $envAll \"localstorage\" \"localstorageclass\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":26,"context_line":"provisioner: kubernetes.io/no-provisioner\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_a4bd13b3","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":45},"updated":"2020-01-06 14:58:54.000000000","message":"Since the intention is to have a Chart release define a storage class and the persistent volumes tied to it, we should just use the Release name here.  It reduces the number of items to override and configure in cases where multiple storage class chart releases are deployed.","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"710c9a2314cfc3894e1c4585a12e126fc33283b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: storage.k8s.io/v1\r"},{"line_number":21,"context_line":"kind: StorageClass\r"},{"line_number":22,"context_line":"metadata:\r"},{"line_number":23,"context_line":"  name: {{ .Values.conf.storage_class.name }}\r"},{"line_number":24,"context_line":"  labels:\r"},{"line_number":25,"context_line":"{{ tuple $envAll \"localstorage\" \"localstorageclass\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}\r"},{"line_number":26,"context_line":"provisioner: kubernetes.io/no-provisioner\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_ed7a0fee","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":45},"in_reply_to":"3fa7e38b_a4bd13b3","updated":"2020-01-06 17:45:42.000000000","message":"Done","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"}],"local-storage/values.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"2f716975ed602db56d5ea47961eab388a8749606","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name: local-pv\r"},{"line_number":20,"context_line":"    reclaimpolicy: retain\r"},{"line_number":21,"context_line":"    capacity:\r"},{"line_number":22,"context_line":"      storage: \"100Gi\"\r"},{"line_number":23,"context_line":"    accessModes: [ \"ReadWriteOnce\" ]\r"},{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"labels:\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_ed59c85a","line":22,"updated":"2020-01-02 18:19:15.000000000","message":"Specifying the storage capacity here means that it would need to be the same across all provisioned PVs, which would limit the use cases for the chart.  \n\nWhat about making conf.persistentvolumes a list of configurations, each of which has its own name, reclaimpolicy, capacity, accessModes, and path?  Basically, merging the volume.local YAML you have below into conf, and adding an \"s\" to persistentvolume and making it a list?","commit_id":"39adc7a991ffc4af52531ff88865f4de217564b7"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"5e6254e952d3eac11825907c864734a0610398f6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name: local-pv\r"},{"line_number":20,"context_line":"    reclaimpolicy: retain\r"},{"line_number":21,"context_line":"    capacity:\r"},{"line_number":22,"context_line":"      storage: \"100Gi\"\r"},{"line_number":23,"context_line":"    accessModes: [ \"ReadWriteOnce\" ]\r"},{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"labels:\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_b2f6c38f","line":22,"in_reply_to":"3fa7e38b_17cf8928","updated":"2020-01-03 11:23:16.000000000","message":"Done. For our current requirement, all PVs will be have similar configuration hence, earlier implementation was making sense. However, for making it more flexible for future requirement where individual PVs can be configured separately, your suggestions makes better sense. Made changes accordingly to comply your suggestion.","commit_id":"39adc7a991ffc4af52531ff88865f4de217564b7"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"f555736b38874bb167f6f337332c41575272f315","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name: local-pv\r"},{"line_number":20,"context_line":"    reclaimpolicy: retain\r"},{"line_number":21,"context_line":"    capacity:\r"},{"line_number":22,"context_line":"      storage: \"100Gi\"\r"},{"line_number":23,"context_line":"    accessModes: [ \"ReadWriteOnce\" ]\r"},{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"labels:\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_dbe59b08","line":22,"in_reply_to":"3fa7e38b_b2f6c38f","updated":"2020-01-03 14:40:01.000000000","message":"Thanks! Agree, not needed for the immediate use case.","commit_id":"39adc7a991ffc4af52531ff88865f4de217564b7"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"b5f50a6f1901bd2816410c139f8d8d6918a66c03","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name: local-pv\r"},{"line_number":20,"context_line":"    reclaimpolicy: retain\r"},{"line_number":21,"context_line":"    capacity:\r"},{"line_number":22,"context_line":"      storage: \"100Gi\"\r"},{"line_number":23,"context_line":"    accessModes: [ \"ReadWriteOnce\" ]\r"},{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"labels:\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_17cf8928","line":22,"in_reply_to":"3fa7e38b_ed59c85a","updated":"2020-01-03 09:58:45.000000000","message":"Absolutely makes sense. I will modify it to make it a list.","commit_id":"39adc7a991ffc4af52531ff88865f4de217564b7"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"54b03c536bdf53e5138ed1034790cd31d3cc7447","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License.\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"conf:\r"},{"line_number":16,"context_line":"  storageclass:\r"},{"line_number":17,"context_line":"    name: local-storage\r"},{"line_number":18,"context_line":"  # For each mount path, one PV should be created.\r"},{"line_number":19,"context_line":"  # If there are two mount paths for local storage are available on two nodes,\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_8c75ab02","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":14},"updated":"2020-01-03 21:29:47.000000000","message":"nit: I\u0027m not sure if this is universal or just what I\u0027m used to seeing in osh. How do you feel about separating these words with an \u0027_\u0027\n\nI\u0027d suggest the same for the other concatenated keys in this file - persistentvolumes and reclaimpolicy","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"a7903bb7329e0c5d3f1e058b629670d23893d85a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License.\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"conf:\r"},{"line_number":16,"context_line":"  storageclass:\r"},{"line_number":17,"context_line":"    name: local-storage\r"},{"line_number":18,"context_line":"  # For each mount path, one PV should be created.\r"},{"line_number":19,"context_line":"  # If there are two mount paths for local storage are available on two nodes,\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_d5ad5f32","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":14},"in_reply_to":"3fa7e38b_8c75ab02","updated":"2020-01-06 08:36:41.000000000","message":"Done","commit_id":"46b2406428f6e7ddecc45cc64dcd882e2261c157"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9f60089d6763ee4a46a1922f2a805a417791bae4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License.\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"conf:\r"},{"line_number":16,"context_line":"  storage_class:\r"},{"line_number":17,"context_line":"    name: local-storage\r"},{"line_number":18,"context_line":"  # For each mount path, one PV should be created.\r"},{"line_number":19,"context_line":"  # If there are two mount paths for local storage are available on two nodes,\r"},{"line_number":20,"context_line":"  # then two PVs details should be defined. Example:\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_e4cc6b63","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"updated":"2020-01-06 14:58:54.000000000","message":"See comment about using the release name","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"710c9a2314cfc3894e1c4585a12e126fc33283b9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License.\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"conf:\r"},{"line_number":16,"context_line":"  storage_class:\r"},{"line_number":17,"context_line":"    name: local-storage\r"},{"line_number":18,"context_line":"  # For each mount path, one PV should be created.\r"},{"line_number":19,"context_line":"  # If there are two mount paths for local storage are available on two nodes,\r"},{"line_number":20,"context_line":"  # then two PVs details should be defined. Example:\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_ad8097bf","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"in_reply_to":"3fa7e38b_e4cc6b63","updated":"2020-01-06 17:45:42.000000000","message":"Done","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9f60089d6763ee4a46a1922f2a805a417791bae4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  # Similarly if three nodes each have disk mount path /var/lib/kubernetes\r"},{"line_number":32,"context_line":"  # which will be acting as local storage for each node, then Persistentvolumes\r"},{"line_number":33,"context_line":"  # should be updated with three entries.\r"},{"line_number":34,"context_line":"  # Below are placeholder values. these values must be changed or overridden to match\r"},{"line_number":35,"context_line":"  # the actual PVs that needs to be created.\r"},{"line_number":36,"context_line":"  persistent_volumes:\r"},{"line_number":37,"context_line":"    - name: local-pv-1\r"},{"line_number":38,"context_line":"      reclaim_policy: retain\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_648b9b16","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":44},"updated":"2020-01-06 14:58:54.000000000","message":"I\u0027d much prefer the below be commented out examples with the default just being an empty list, as we should avoid having default values that we then declare should be changed or overridden.  The reason being that if the defaults can\u0027t and aren\u0027t expected to be used, they\u0027re not really defaults at all.","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"710c9a2314cfc3894e1c4585a12e126fc33283b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  # Similarly if three nodes each have disk mount path /var/lib/kubernetes\r"},{"line_number":32,"context_line":"  # which will be acting as local storage for each node, then Persistentvolumes\r"},{"line_number":33,"context_line":"  # should be updated with three entries.\r"},{"line_number":34,"context_line":"  # Below are placeholder values. these values must be changed or overridden to match\r"},{"line_number":35,"context_line":"  # the actual PVs that needs to be created.\r"},{"line_number":36,"context_line":"  persistent_volumes:\r"},{"line_number":37,"context_line":"    - name: local-pv-1\r"},{"line_number":38,"context_line":"      reclaim_policy: retain\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d091e6f8","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":44},"in_reply_to":"3fa7e38b_648b9b16","updated":"2020-01-06 17:45:42.000000000","message":"Done","commit_id":"569940ae174643401283bcb81ee8c286e76984bb"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"ad3ffda8cc89a795a829378370d37989fba53b42","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_b6ac50ee","line":41,"range":{"start_line":40,"start_character":9,"end_line":41,"end_character":27},"updated":"2020-01-07 20:58:42.000000000","message":"Sorry I am a noob here, but seems odd to disable all the manifests by default?   Shouldn\u0027t there be some \"default\" or \"recommended dummy value\" or something?  I know they are enable in the gate job, but seems kind of counter-intuitive here.","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"54b4d8bf0a30de4f369997c62d3b7de44f30f453","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_423f4cb1","line":41,"range":{"start_line":40,"start_character":9,"end_line":41,"end_character":27},"in_reply_to":"3fa7e38b_54162aa3","updated":"2020-01-08 17:05:34.000000000","message":"it should be enabled by default, the operator is able to choose whether or not they deploy this chart.","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"abe85f705722d27cc810ba79cac2a0ee78bcddfc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_91ba7eb7","line":41,"range":{"start_line":40,"start_character":9,"end_line":41,"end_character":27},"in_reply_to":"3fa7e38b_56bddcd4","updated":"2020-01-07 22:27:23.000000000","message":"Well that\u0027s the thing, it is not intuitively obvious how to really use this.  Is pairing with another deployment required?  How is this being tested perhaps?  Also is it any harm if we just set the default to true, would it crap during rendering otherwise?  Maybe document what the minimal mandatory input is?","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":27772,"name":"Smruti Soumitra Khuntia","email":"soumitra.khuntia@att.com","username":"soumitra.khuntia"},"change_message_id":"6485f719741bf91aa800289204b434e0ec7f3359","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_54162aa3","line":41,"range":{"start_line":40,"start_character":9,"end_line":41,"end_character":27},"in_reply_to":"3fa7e38b_91ba7eb7","updated":"2020-01-08 15:56:38.000000000","message":"I would prefer to have this disabled by default. That\u0027s because having local storage is not a mandatory requirement.  (currently CEPH backend is used in all cases for statefulsets by default) and as and when required, the charts can be enabled by overriding the value. Initally plan is to have ES to use local storage having SSD backends and then expand it to other statefulsets. But then that\u0027s as per specific requirement and not necessarily we need to have local storage storage class and PVs available by default especially for upstream.","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"64de60ccaca06a692706804c2ca3e08ee21d4f9a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_56bddcd4","line":41,"range":{"start_line":40,"start_character":9,"end_line":41,"end_character":27},"in_reply_to":"3fa7e38b_b6ac50ee","updated":"2020-01-07 21:44:00.000000000","message":"I agree, this is counter to what we have in our other charts.\n\nHowever, I\u0027m not sure what good defaults would look like here. Should this chart create anything if it isn\u0027t paired with another deployment that would use what was created?","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"54b4d8bf0a30de4f369997c62d3b7de44f30f453","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  # which will be acting as local storage for each node, then Persistentvolumes"},{"line_number":32,"context_line":"  # should be updated with three entries."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"labels:"},{"line_number":35,"context_line":"  node_affinity:"},{"line_number":36,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3fa7e38b_22b2504b","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":32},"updated":"2020-01-08 17:05:34.000000000","message":"nit: should be above conf.\n\nAlso - can this chart support multiple releases into a cluster? I\u0027ve not fully checked, but I can forsee scenarios where we may want to have multiple releases, eg to support nova (or whathaveyou) ephemeral as a local pv.","commit_id":"5a72a6654b425fe8f447e526dee141583bf2a537"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"54b4d8bf0a30de4f369997c62d3b7de44f30f453","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":37,"context_line":"    node_selector_value: enabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"manifests:"},{"line_number":40,"context_line":"  storage_class: false"},{"line_number":41,"context_line":"  persistent_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3fa7e38b_029cf4bc","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":27},"updated":"2020-01-08 17:05:34.000000000","message":"these should be true by default. I see the convo in ps 22 - its an operator decision as to whether or not to deploy the chart, we should not burden them further.","commit_id":"5a72a6654b425fe8f447e526dee141583bf2a537"}],"tools/deployment/osh-infra-local-storage/040-local-storage.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"67ac4760f77a398fbba4a4e4094c28a8f1114489","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      reclaim_policy: Delete"},{"line_number":31,"context_line":"      storage_capacity: \"1Gi\""},{"line_number":32,"context_line":"      access_modes: [ \"ReadWriteOnce\" ]"},{"line_number":33,"context_line":"      local_path: /var/lib/kubelet/0"},{"line_number":34,"context_line":"    - name: local-persistent-volume-1"},{"line_number":35,"context_line":"      reclaim_policy: Delete"},{"line_number":36,"context_line":"      storage_capacity: \"1Gi\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"3fa7e38b_4b9699f1","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":36},"updated":"2020-01-07 20:24:19.000000000","message":"why are we making these pv\u0027s live inside /var/lib/kubelet? It seems an odd place?","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"d6ca6b6636e269f89a972e7bd0d4eb4ad678c1aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      reclaim_policy: Delete"},{"line_number":31,"context_line":"      storage_capacity: \"1Gi\""},{"line_number":32,"context_line":"      access_modes: [ \"ReadWriteOnce\" ]"},{"line_number":33,"context_line":"      local_path: /var/lib/kubelet/0"},{"line_number":34,"context_line":"    - name: local-persistent-volume-1"},{"line_number":35,"context_line":"      reclaim_policy: Delete"},{"line_number":36,"context_line":"      storage_capacity: \"1Gi\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"3fa7e38b_163e8489","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":36},"in_reply_to":"3fa7e38b_4b9699f1","updated":"2020-01-07 20:59:12.000000000","message":"Done","commit_id":"e201140ac6375afea2fd735712bb1258f91a35da"}],"tools/deployment/osh-infra-local-storage/040-prometheus.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2aaa8c67f5e4b6e21dbb5d30792e0bef11558aeb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"../osh-infra-monitoring/050-prometheus.sh"}],"source_content_type":"x-git/symlink","patch_set":35,"id":"3fa7e38b_2f58e922","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":41},"updated":"2020-01-09 13:37:36.000000000","message":"You\u0027ll need to maintain a separate file here instead of using this symlink path.  The reason being that currently this symlinked file overrides the FEATURE_GATES env var to address challenges with the how the override file names are generated. This was required when we moved to define all rules outside of the chart.  See: https://github.com/openstack/openstack-helm-infra/blob/master/tools/deployment/osh-infra-monitoring/050-prometheus.sh#L22-L23","commit_id":"0781e9ecc89a88ec150c6219c62d6ee3a1c2bfcf"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4cff0c95ef58ec964fe4c70278c581d40351b8fe","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        - ./tools/deployment/osh-infra-local-storage/000-install-packages.sh"},{"line_number":485,"context_line":"        - ./tools/deployment/osh-infra-local-storage/005-deploy-k8s.sh"},{"line_number":486,"context_line":"        - ./tools/deployment/osh-infra-local-storage/010-ingress.sh"},{"line_number":487,"context_line":"        - ./tools/deployment/osh-infra-local-storage/020-ceph.sh"},{"line_number":488,"context_line":"        - ./tools/deployment/osh-infra-local-storage/025-ceph-ns-activate.sh"},{"line_number":489,"context_line":"        - ./tools/deployment/osh-infra-local-storage/030-radosgw-osh-infra.sh"},{"line_number":490,"context_line":"        - ./tools/deployment/osh-infra-local-storage/040-local-storage.sh"},{"line_number":491,"context_line":"        - ./tools/deployment/osh-infra-local-storage/050-elasticsearch.sh"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_04b8a00f","line":489,"range":{"start_line":487,"start_character":0,"end_line":489,"end_character":77},"updated":"2020-01-06 21:47:44.000000000","message":"To simplify this job, can we remove all of the ceph deployment steps?  That allows us to trim down the resource requirements for the job.  Also, can we deploy all stateful services as part of this job, or at least the heavy hitters (prometheus, Elasticsearch, mariadb, etc)?","commit_id":"b6871f551a9329522bf8894078aff5336b95d2fb"}]}