)]}'
{"zuul.d/jobs.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"f4ff8a6ddd51ebd81fccc0fa7cd0f39e90f02994","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"},{"line_number":217,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":218,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":219,"context_line":"    vars:"},{"line_number":220,"context_line":"      gate_scripts:"},{"line_number":221,"context_line":"        - ./tools/deployment/federated-monitoring/000-install-packages.sh"},{"line_number":222,"context_line":"        - ./tools/deployment/federated-monitoring/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_99494430","line":219,"updated":"2020-01-08 04:08:29.000000000","message":"Might want to include these here as well, since it\u0027s a monitoring check.\n\nAlthough these are just rule declarations for prometheus - I wouldn\u0027t expect the results of any of these jobs to change based on their presence.","commit_id":"6d2ee4ad82755a53de149b54a537ba636cd2e15f"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c7dc8b4c5e7d85e105f06b212689f199232b3573","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"},{"line_number":217,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":218,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":219,"context_line":"    vars:"},{"line_number":220,"context_line":"      gate_scripts:"},{"line_number":221,"context_line":"        - ./tools/deployment/federated-monitoring/000-install-packages.sh"},{"line_number":222,"context_line":"        - ./tools/deployment/federated-monitoring/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_79980875","line":219,"in_reply_to":"3fa7e38b_99494430","updated":"2020-01-08 04:43:52.000000000","message":"From discussion with Pete, this PS is intended to build on top of [0], so the intend is to target the 050-prometheus script with the feature_gate. In this job, the 060-prometheus script isn\u0027t a symlink to the other one, rather it is a separate script with its own override logic [1]. As mentioned, this should be refactor in a follow-on patch.\n\n[0] https://review.opendev.org/#/c/697298/\n[1] https://github.com/openstack/openstack-helm-infra/blob/f6775eaae034c58926f16abc5cceb3ccc18f8fe0/tools/deployment/federated-monitoring/060-prometheus.sh#L53","commit_id":"6d2ee4ad82755a53de149b54a537ba636cd2e15f"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"f4ff8a6ddd51ebd81fccc0fa7cd0f39e90f02994","unresolved":false,"context_lines":[{"line_number":245,"context_line":"      osh_params:"},{"line_number":246,"context_line":"        container_distro_name: ubuntu"},{"line_number":247,"context_line":"        container_distro_version: bionic"},{"line_number":248,"context_line":"        feature_gates: elasticsearch"},{"line_number":249,"context_line":"      gate_scripts:"},{"line_number":250,"context_line":"        - ./tools/deployment/network-policy/000-install-packages.sh"},{"line_number":251,"context_line":"        - ./tools/deployment/network-policy/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_195794cb","line":248,"range":{"start_line":248,"start_character":23,"end_line":248,"end_character":36},"updated":"2020-01-08 04:08:29.000000000","message":"Seeing this feature gate out here by itself makes me wonder if we should rename the prometheus feature gates / override files (Maybe just appending a \"-rules\" to them). \n\nIf I didn\u0027t know better, I\u0027d assume this was testing some feature of the elasticsearch chart, but it\u0027s just loading alerting rules into prometheus.","commit_id":"6d2ee4ad82755a53de149b54a537ba636cd2e15f"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c7dc8b4c5e7d85e105f06b212689f199232b3573","unresolved":false,"context_lines":[{"line_number":245,"context_line":"      osh_params:"},{"line_number":246,"context_line":"        container_distro_name: ubuntu"},{"line_number":247,"context_line":"        container_distro_version: bionic"},{"line_number":248,"context_line":"        feature_gates: elasticsearch"},{"line_number":249,"context_line":"      gate_scripts:"},{"line_number":250,"context_line":"        - ./tools/deployment/network-policy/000-install-packages.sh"},{"line_number":251,"context_line":"        - ./tools/deployment/network-policy/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_59bd0cd5","line":248,"range":{"start_line":248,"start_character":23,"end_line":248,"end_character":36},"in_reply_to":"3fa7e38b_195794cb","updated":"2020-01-08 04:43:52.000000000","message":"This was fixed in patch set REF/3 so they are inline with the other feature_gates string.","commit_id":"6d2ee4ad82755a53de149b54a537ba636cd2e15f"}]}