)]}'
{"openvswitch/templates/daemonset-ovs-vswitchd.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"86fb9f29d4c1b223f30c50c2b738154877e874db","unresolved":false,"context_lines":[{"line_number":90,"context_line":"              readOnly: true"},{"line_number":91,"context_line":"      containers:"},{"line_number":92,"context_line":"        - name: openvswitch-vswitchd"},{"line_number":93,"context_line":"{{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":94,"context_line":"{{/* Run the container in priviledged mode due to the need for root"},{"line_number":95,"context_line":"permissions when using the uio_pci_generic driver. */}}"},{"line_number":96,"context_line":"{{- $_ :\u003d set $envAll.Values.pod.security_context.openvswitch_vswitchd.container.vswitchd \"privileged\" true -}}"},{"line_number":97,"context_line":"{{- end }}"},{"line_number":98,"context_line":"{{ tuple $envAll \"openvswitch_vswitchd\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":99,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"openvswitch_vswitchd\" \"container\" \"vswitchd\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":100,"context_line":"{{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":101,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":102,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":103,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":104,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"},{"line_number":105,"context_line":"{{/* Limiting CPU cores would severely affect packet throughput"},{"line_number":106,"context_line":"It should be handled through lcore and pmd core masks. */}}"},{"line_number":107,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.requests \"cpu\" }}"},{"line_number":108,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.limits \"cpu\" }}"},{"line_number":109,"context_line":"{{- end }}"},{"line_number":110,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.ovs.vswitchd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":111,"context_line":"          # ensures this container can speak to the ovs database"},{"line_number":112,"context_line":"          # successfully before its marked as ready"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_2202a90d","line":109,"range":{"start_line":93,"start_character":0,"end_line":109,"end_character":10},"updated":"2020-01-20 20:53:37.000000000","message":"This whole section is becoming difficult to read, I know you didn\u0027t add those lines above, but I think it kind of fits into fact we should clean this up a bit to make it more manageable.  How about just specify what we want to configure if dpdk or something else if non-dpdk?\n\n{{- if .Values.conf.ovs_dpdk.enabled }}\nset vswitchd/requests/memory and limits/memory\n{{- else}} /* non-dpdk */\nset everything other than hugepages\n{{ -end }}","commit_id":"a75b75a50200b965c8f46f212f50edadb0bbe495"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"4dab18f15d24928b58dc3a07b5fca2e851ef4cb9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"              readOnly: true"},{"line_number":91,"context_line":"      containers:"},{"line_number":92,"context_line":"        - name: openvswitch-vswitchd"},{"line_number":93,"context_line":"{{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":94,"context_line":"{{/* Run the container in priviledged mode due to the need for root"},{"line_number":95,"context_line":"permissions when using the uio_pci_generic driver. */}}"},{"line_number":96,"context_line":"{{- $_ :\u003d set $envAll.Values.pod.security_context.openvswitch_vswitchd.container.vswitchd \"privileged\" true -}}"},{"line_number":97,"context_line":"{{- end }}"},{"line_number":98,"context_line":"{{ tuple $envAll \"openvswitch_vswitchd\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":99,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"openvswitch_vswitchd\" \"container\" \"vswitchd\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":100,"context_line":"{{- if .Values.conf.ovs_dpdk.enabled }}"},{"line_number":101,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":102,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":103,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":104,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"},{"line_number":105,"context_line":"{{/* Limiting CPU cores would severely affect packet throughput"},{"line_number":106,"context_line":"It should be handled through lcore and pmd core masks. */}}"},{"line_number":107,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.requests \"cpu\" }}"},{"line_number":108,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.limits \"cpu\" }}"},{"line_number":109,"context_line":"{{- end }}"},{"line_number":110,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.ovs.vswitchd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":111,"context_line":"          # ensures this container can speak to the ovs database"},{"line_number":112,"context_line":"          # successfully before its marked as ready"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f85f6071","line":109,"range":{"start_line":93,"start_character":0,"end_line":109,"end_character":10},"in_reply_to":"3fa7e38b_2202a90d","updated":"2020-01-20 22:52:57.000000000","message":"Done","commit_id":"a75b75a50200b965c8f46f212f50edadb0bbe495"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"ad206db8f3bd96aa92846e48c5ab5cfd57550c9b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"{{/* Run the container in priviledged mode due to the need for root"},{"line_number":95,"context_line":"permissions when using the uio_pci_generic driver. */}}"},{"line_number":96,"context_line":"{{- $_ :\u003d set $envAll.Values.pod.security_context.openvswitch_vswitchd.container.vswitchd \"privileged\" true -}}"},{"line_number":97,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":98,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":99,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":100,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d1a7d3ba","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":81},"updated":"2020-01-21 16:00:51.000000000","message":"Does it make sense to \"enforce\" hugepages (like make sure either 1G or 2M hugepages are configured), or is hugepages \"optional\"?  The comment seems to imply it is mandatory, but in test, it seems to work without it, so I don\u0027t know  :)\n\nIf so, we make need to add a check to see if at least 1 is configured, and in case if BOTH is configured (1G and 2M), then just set 1 or go ahead and set both?","commit_id":"c525f8629ed5892c0825a47c5b8cc5086d2fd999"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"5febb742e5c405d9c032b31410ff7a0e3960abe7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"{{/* Run the container in priviledged mode due to the need for root"},{"line_number":95,"context_line":"permissions when using the uio_pci_generic driver. */}}"},{"line_number":96,"context_line":"{{- $_ :\u003d set $envAll.Values.pod.security_context.openvswitch_vswitchd.container.vswitchd \"privileged\" true -}}"},{"line_number":97,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":98,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":99,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":100,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a95bcb52","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":81},"in_reply_to":"3fa7e38b_d1a7d3ba","updated":"2020-01-21 22:30:31.000000000","message":"I\u0027m not sure how it behaves and the original intention behind it. There is not much documentation around it. It definitely worked without it when I tested it. I\u0027d leave it as is.","commit_id":"c525f8629ed5892c0825a47c5b8cc5086d2fd999"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"ad206db8f3bd96aa92846e48c5ab5cfd57550c9b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":98,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":99,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":100,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"},{"line_number":101,"context_line":"{{/* Limiting CPU cores would severely affect packet throughput"},{"line_number":102,"context_line":"It should be handled through lcore and pmd core masks. */}}"},{"line_number":103,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.requests \"cpu\" }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_11d48b1e","line":100,"range":{"start_line":100,"start_character":13,"end_line":100,"end_character":14},"updated":"2020-01-21 16:00:51.000000000","message":"Actually, the pod.resources.enabled is in the values.yaml right? so I think there is no need to set it here only for dpdk.  I think it works better to allow user to enable/disable it in values and we just read it from there.  Probably add a if check before line 93, so the resources can be set for both dpdk and non-dpdk ovs properly.\n\nif .Values.pod.resources.enabled\n  if .Values.conf.ovs_dpdk.enabled\n     set/unset stuff\n  else\n     set/unset stuff for non-ovsdpdk\n  endif\nendif","commit_id":"c525f8629ed5892c0825a47c5b8cc5086d2fd999"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"ff7afb715f41e57ce6392c0420b9eed02ec101f7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":98,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":99,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":100,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"},{"line_number":101,"context_line":"{{/* Limiting CPU cores would severely affect packet throughput"},{"line_number":102,"context_line":"It should be handled through lcore and pmd core masks. */}}"},{"line_number":103,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.requests \"cpu\" }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4c15859a","line":100,"range":{"start_line":100,"start_character":13,"end_line":100,"end_character":14},"in_reply_to":"3fa7e38b_11d48b1e","updated":"2020-01-21 23:19:26.000000000","message":"I reversed the if condition sequence and removed the confusing hugepage statement. User has to define them in values.yaml","commit_id":"c525f8629ed5892c0825a47c5b8cc5086d2fd999"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"5febb742e5c405d9c032b31410ff7a0e3960abe7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{/* When running with DPDK, we need to specify the type and amount of hugepages."},{"line_number":98,"context_line":"The following line enables resource handling in general, but the type and amount"},{"line_number":99,"context_line":"of hugepages must still be defined in the values.yaml.*/}}"},{"line_number":100,"context_line":"{{ $_ :\u003d set $envAll.Values.pod.resources \"enabled\" true }}"},{"line_number":101,"context_line":"{{/* Limiting CPU cores would severely affect packet throughput"},{"line_number":102,"context_line":"It should be handled through lcore and pmd core masks. */}}"},{"line_number":103,"context_line":"{{ $_ :\u003d unset $envAll.Values.pod.resources.ovs.vswitchd.requests \"cpu\" }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e932230e","line":100,"range":{"start_line":100,"start_character":13,"end_line":100,"end_character":14},"in_reply_to":"3fa7e38b_11d48b1e","updated":"2020-01-21 22:30:31.000000000","message":"pod.resources.enabled is set to false by default in upstream. For DPDK, it is set to true explicitly. I think the reason could be due to hugepage requirement.","commit_id":"c525f8629ed5892c0825a47c5b8cc5086d2fd999"}]}