)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"37e1b51926100e6102c21ec6c891ee9a53e5e081","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chinasubbareddy Mallavarapu \u003ccr3938@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-29 13:19:35 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[wip][ceph-osd]  wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is wait for all the osd devices before intilizing ."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_e8ccf262","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":45},"updated":"2020-01-29 19:27:10.000000000","message":"initialize","commit_id":"f7e1b0a95c90804838c8cfbafede1c58d1ce8600"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"37e1b51926100e6102c21ec6c891ee9a53e5e081","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[wip][ceph-osd]  wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is wait for all the osd devices before intilizing ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I68e1d4c8c1ade39f856c69333585dfcba3ea35ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a8d27afc","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":54},"updated":"2020-01-29 19:27:10.000000000","message":"initializing","commit_id":"f7e1b0a95c90804838c8cfbafede1c58d1ce8600"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"7e48bdb5765152470e00fc99fb664d1206dc1428","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chinasubbareddy Mallavarapu \u003ccr3938@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-29 13:47:31 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is wait for all the osd devices before intilizing and also"},{"line_number":10,"context_line":"add few checks to make sure disk is used or not ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_e3aad3d0","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":39},"updated":"2020-01-29 19:59:38.000000000","message":"initialize","commit_id":"2b82fbe62118630bb34f0cf979471411092b1fa5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"7e48bdb5765152470e00fc99fb664d1206dc1428","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is wait for all the osd devices before intilizing and also"},{"line_number":10,"context_line":"add few checks to make sure disk is used or not ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I68e1d4c8c1ade39f856c69333585dfcba3ea35ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_630103b5","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":12},"updated":"2020-01-29 19:59:38.000000000","message":"adds a wait","commit_id":"2b82fbe62118630bb34f0cf979471411092b1fa5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"7e48bdb5765152470e00fc99fb664d1206dc1428","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is wait for all the osd devices before intilizing and also"},{"line_number":10,"context_line":"add few checks to make sure disk is used or not ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I68e1d4c8c1ade39f856c69333585dfcba3ea35ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_23078bca","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":54},"updated":"2020-01-29 19:59:38.000000000","message":"initializing","commit_id":"2b82fbe62118630bb34f0cf979471411092b1fa5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4cb9368f4daaa1a4ff320ecda2256d7e5cc811d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chinasubbareddy Mallavarapu \u003ccr3938@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-29 13:59:09 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to wait for all the osd devices before intilizing and also"},{"line_number":10,"context_line":"to add few more checks to make sure disk is used or not ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a3193bd2","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":39},"updated":"2020-01-29 20:27:07.000000000","message":"initialize","commit_id":"e21e20e299faa3e88eec8c369fa3039df8a34720"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4cb9368f4daaa1a4ff320ecda2256d7e5cc811d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intilize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to wait for all the osd devices before intilizing and also"},{"line_number":10,"context_line":"to add few more checks to make sure disk is used or not ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I68e1d4c8c1ade39f856c69333585dfcba3ea35ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_8378bff6","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":57},"updated":"2020-01-29 20:27:07.000000000","message":"initializing","commit_id":"e21e20e299faa3e88eec8c369fa3039df8a34720"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"712280bed952dcdb3bb71f59d080cc87fe40e4df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chinasubbareddy Mallavarapu \u003ccr3938@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-29 14:30:10 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intialize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to wait for all the osd devices before intializing and also"},{"line_number":10,"context_line":"to add few more checks to make sure disk is used or not ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_23978bec","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":40},"updated":"2020-01-29 20:32:50.000000000","message":"initialize","commit_id":"0952aa43d3a4295b6a577ca76f3cba873ec4cfca"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"712280bed952dcdb3bb71f59d080cc87fe40e4df","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Wait for devices to intialize the osd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to wait for all the osd devices before intializing and also"},{"line_number":10,"context_line":"to add few more checks to make sure disk is used or not ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I68e1d4c8c1ade39f856c69333585dfcba3ea35ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_439ac711","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":58},"updated":"2020-01-29 20:32:50.000000000","message":"initializing","commit_id":"0952aa43d3a4295b6a577ca76f3cba873ec4cfca"}],"ceph-osd/templates/bin/osd/ceph-volume/_init-with-ceph-volume.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"37e1b51926100e6102c21ec6c891ee9a53e5e081","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      if ceph osd ls |grep ${OSD_ID}; then"},{"line_number":87,"context_line":"        echo \"Running bluestore mode and ${OSD_DEVICE} already bootstrapped\""},{"line_number":88,"context_line":"      else"},{"line_number":89,"context_line":"        echo \"found the wrong osd id which is not belongs to current ceph cluster\""},{"line_number":90,"context_line":"        exit 1"},{"line_number":91,"context_line":"      fi  "},{"line_number":92,"context_line":"    elif [[ $(sgdisk --print ${OSD_DEVICE} | grep \"F800\") ]]; then"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_a8eb5aa2","line":89,"range":{"start_line":89,"start_character":43,"end_line":89,"end_character":57},"updated":"2020-01-29 19:27:10.000000000","message":"does not belong","commit_id":"f7e1b0a95c90804838c8cfbafede1c58d1ce8600"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"37e1b51926100e6102c21ec6c891ee9a53e5e081","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      else"},{"line_number":89,"context_line":"        echo \"found the wrong osd id which is not belongs to current ceph cluster\""},{"line_number":90,"context_line":"        exit 1"},{"line_number":91,"context_line":"      fi  "},{"line_number":92,"context_line":"    elif [[ $(sgdisk --print ${OSD_DEVICE} | grep \"F800\") ]]; then"},{"line_number":93,"context_line":"      DM_DEV\u003d${OSD_DEVICE}$(sgdisk --print ${OSD_DEVICE} | grep \"F800\" | awk \u0027{print $1}\u0027)"},{"line_number":94,"context_line":"      CEPH_DISK_USED\u003d1"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa7e38b_48098680","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":10},"updated":"2020-01-29 19:27:10.000000000","message":"whitespace","commit_id":"f7e1b0a95c90804838c8cfbafede1c58d1ce8600"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"7e48bdb5765152470e00fc99fb664d1206dc1428","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      DM_DEV\u003d${OSD_DEVICE}$(sgdisk --print ${OSD_DEVICE} | grep \"F800\" | awk \u0027{print $1}\u0027)"},{"line_number":94,"context_line":"      CEPH_DISK_USED\u003d1"},{"line_number":95,"context_line":"    elif [[ dmsetup ls |grep -i ${OSD_DEVICE} ]]; then"},{"line_number":96,"context_line":"      OSD_DMSETUP_LIST\u003d1"},{"line_number":97,"context_line":"    else"},{"line_number":98,"context_line":"      if [[ ${OSD_FORCE_REPAIR} -eq 1 ]] \u0026\u0026 [ ${OSD_DMSETUP_LIST:-0} -ne 1 ]; then"},{"line_number":99,"context_line":"        echo \"It looks like ${OSD_DEVICE} isn\u0027t consistent, however OSD_FORCE_REPAIR is enabled so we are zapping the device anyway\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_23eb0b11","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":22},"updated":"2020-01-29 19:59:38.000000000","message":"This will work fine, but couldn\u0027t we just use CEPH_DISK_USED here instead of adding a new variable? That way any of the above checks can also prevent the zap on line 100 from happening if they manage to get there somehow.","commit_id":"2b82fbe62118630bb34f0cf979471411092b1fa5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4cb9368f4daaa1a4ff320ecda2256d7e5cc811d8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      CEPH_DISK_USED\u003d1"},{"line_number":95,"context_line":"    else"},{"line_number":96,"context_line":"      if dmsetup ls |grep -i ${OSD_DEVICE}; then"},{"line_number":97,"context_line":"        OSD_DMSETUP_LIST\u003d1"},{"line_number":98,"context_line":"      fi"},{"line_number":99,"context_line":"      if [[ ${OSD_FORCE_REPAIR} -eq 1 ]] \u0026\u0026 [ ${OSD_DMSETUP_LIST:-0} -ne 1 ]; then"},{"line_number":100,"context_line":"        echo \"It looks like ${OSD_DEVICE} isn\u0027t consistent, however OSD_FORCE_REPAIR is enabled so we are zapping the device anyway\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_c369d722","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":24},"updated":"2020-01-29 20:27:07.000000000","message":"This will work fine, but couldn\u0027t we just use CEPH_DISK_USED here instead of adding a new variable? That way any of the above checks can also prevent the zap on line 100 from happening if they manage to get there somehow.","commit_id":"e21e20e299faa3e88eec8c369fa3039df8a34720"}]}