)]}'
{"ceph-client/templates/bin/utils/_checkPGs.py.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"345bf604c12e6a99c4ae7a4c1c19e8a412906eba","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isNautilus(self):"},{"line_number":110,"context_line":"      grepResult \u003d int(subprocess.check_output(\u0027ceph mon versions | egrep -q \"nautilus\" | echo $?\u0027, shell\u003dTrue))"},{"line_number":111,"context_line":"      return True if grepResult \u003d\u003d 0 else False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_fb431396","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":6},"updated":"2020-02-04 15:19:59.000000000","message":"nit: can we indent with pep8 (multiple of 4)","commit_id":"6b13e3611e109484a948f58fa00f9f79cfb99b26"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"71a076df6ee7eafc122265cd32706b58a2fc1927","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def checkPGs(self, poolName):"},{"line_number":132,"context_line":"        poolPGs \u003d self.poolPGs[\u0027pg_stats\u0027] if self.isNautilus() else self.poolPGs"},{"line_number":133,"context_line":"        if not len(poolPGs) \u003e 0:"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        print(\u0027Checking PGs in pool {} ...\u0027.format(poolName)),"},{"line_number":136,"context_line":"        badPGs \u003d False"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_9b5bff87","line":133,"range":{"start_line":133,"start_character":10,"end_line":133,"end_character":32},"updated":"2020-02-04 15:17:14.000000000","message":"would this not be clearer just be:\n\n    if len(poolPGs) \u003d\u003d 0:?","commit_id":"6b13e3611e109484a948f58fa00f9f79cfb99b26"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"345bf604c12e6a99c4ae7a4c1c19e8a412906eba","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def checkPGs(self, poolName):"},{"line_number":132,"context_line":"        poolPGs \u003d self.poolPGs[\u0027pg_stats\u0027] if self.isNautilus() else self.poolPGs"},{"line_number":133,"context_line":"        if not len(poolPGs) \u003e 0:"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        print(\u0027Checking PGs in pool {} ...\u0027.format(poolName)),"},{"line_number":136,"context_line":"        badPGs \u003d False"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"3fa7e38b_1bd4efbb","line":133,"range":{"start_line":133,"start_character":10,"end_line":133,"end_character":32},"in_reply_to":"3fa7e38b_9b5bff87","updated":"2020-02-04 15:19:59.000000000","message":"agreed","commit_id":"6b13e3611e109484a948f58fa00f9f79cfb99b26"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"4f3ce8e7c25e6298b3b99185e9ad606a8f4c1566","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isNautilus(self):"},{"line_number":110,"context_line":"        grepResult \u003d int(subprocess.check_output(\u0027ceph mon versions | egrep -q \"nautilus\" | echo $?\u0027, shell\u003dTrue))"},{"line_number":111,"context_line":"        return True if grepResult \u003d\u003d 0 else False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_c102e871","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":114},"updated":"2020-02-04 16:46:44.000000000","message":"Could you add a \"  # nosec\" to the end of this line so it won\u0027t fail bandit?","commit_id":"92dfac645a564f46fe6c74a3c706a3598a758b8a"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"4f3ce8e7c25e6298b3b99185e9ad606a8f4c1566","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isNautilus(self):"},{"line_number":110,"context_line":"        grepResult \u003d int(subprocess.check_output(\u0027ceph mon versions | egrep -q \"nautilus\" | echo $?\u0027, shell\u003dTrue))"},{"line_number":111,"context_line":"        return True if grepResult \u003d\u003d 0 else False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"},{"line_number":114,"context_line":"        \"\"\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_61f9b480","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":49},"updated":"2020-02-04 16:46:44.000000000","message":"This could be shortened to \"return grepResult \u003d\u003d 0\"","commit_id":"92dfac645a564f46fe6c74a3c706a3598a758b8a"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"4f3ce8e7c25e6298b3b99185e9ad606a8f4c1566","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def checkPGs(self, poolName):"},{"line_number":132,"context_line":"        poolPGs \u003d self.poolPGs[\u0027pg_stats\u0027] if self.isNautilus() else self.poolPGs"},{"line_number":133,"context_line":"        if len(poolPGs) \u003d\u003d 0:"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        print(\u0027Checking PGs in pool {} ...\u0027.format(poolName)),"},{"line_number":136,"context_line":"        badPGs \u003d False"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_21f3bca2","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":28},"updated":"2020-02-04 16:46:44.000000000","message":"This could be shortened to \"if poolPGs:\"","commit_id":"92dfac645a564f46fe6c74a3c706a3598a758b8a"}]}