)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bee5c5f5e182582d3cd2c42a8628236c7220106","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luna Das \u003ccse2013luna@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 23:08:54 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Helm Charts for MetaController"},{"line_number":8,"context_line":"and DaemonJobController."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This charts bootstraps a metacontroller on a"},{"line_number":11,"context_line":"Kubernetes cluster using the Helm package manager."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"3fa7e38b_8d781ec2","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":24},"updated":"2020-02-12 22:21:49.000000000","message":"Please keep the commit title to 1 line.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luna Das \u003ccse2013luna@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-26 20:54:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Helm Charts for MetaController"},{"line_number":8,"context_line":"and DaemonJobController."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This charts bootstraps a metacontroller on a"},{"line_number":11,"context_line":"Kubernetes cluster using the Helm package manager."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_3faaf7d1","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":24},"updated":"2020-02-27 05:29:22.000000000","message":"should be a single line","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luna Das \u003ccse2013luna@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-26 20:54:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Helm Charts for MetaController"},{"line_number":8,"context_line":"and DaemonJobController."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This charts bootstraps a metacontroller on a"},{"line_number":11,"context_line":"Kubernetes cluster using the Helm package manager."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_14735d4f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":24},"in_reply_to":"1fa4df85_3faaf7d1","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This charts bootstraps a metacontroller on a"},{"line_number":11,"context_line":"Kubernetes cluster using the Helm package manager."},{"line_number":12,"context_line":"This enables you to deploy custom controllers as"},{"line_number":13,"context_line":"service + deployment pairs.A DaemonJobController"},{"line_number":14,"context_line":"chart bootstraps the CompositeController and register"},{"line_number":15,"context_line":"DaemonJob CRD , the daemonjob controller executes"},{"line_number":16,"context_line":"DaemonJob(CR\u0027s) in kubernetes Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_dfb8832b","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":28},"updated":"2020-02-27 05:29:22.000000000","message":"nit: space","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This charts bootstraps a metacontroller on a"},{"line_number":11,"context_line":"Kubernetes cluster using the Helm package manager."},{"line_number":12,"context_line":"This enables you to deploy custom controllers as"},{"line_number":13,"context_line":"service + deployment pairs.A DaemonJobController"},{"line_number":14,"context_line":"chart bootstraps the CompositeController and register"},{"line_number":15,"context_line":"DaemonJob CRD , the daemonjob controller executes"},{"line_number":16,"context_line":"DaemonJob(CR\u0027s) in kubernetes Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_b48fe921","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":28},"in_reply_to":"1fa4df85_dfb8832b","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This enables you to deploy custom controllers as"},{"line_number":13,"context_line":"service + deployment pairs.A DaemonJobController"},{"line_number":14,"context_line":"chart bootstraps the CompositeController and register"},{"line_number":15,"context_line":"DaemonJob CRD , the daemonjob controller executes"},{"line_number":16,"context_line":"DaemonJob(CR\u0027s) in kubernetes Cluster."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic946f564ea1cf07e89c90a598e59230dc240950c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_bf87c761","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":14},"updated":"2020-02-27 05:29:22.000000000","message":"nit: extra space","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This enables you to deploy custom controllers as"},{"line_number":13,"context_line":"service + deployment pairs.A DaemonJobController"},{"line_number":14,"context_line":"chart bootstraps the CompositeController and register"},{"line_number":15,"context_line":"DaemonJob CRD , the daemonjob controller executes"},{"line_number":16,"context_line":"DaemonJob(CR\u0027s) in kubernetes Cluster."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic946f564ea1cf07e89c90a598e59230dc240950c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":63,"id":"1fa4df85_d492a54b","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":14},"in_reply_to":"1fa4df85_bf87c761","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"}],"daemonjob-controller/templates/_helpers.tpl":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Expand the name of the chart."},{"line_number":4,"context_line":"*/}}"},{"line_number":5,"context_line":"{{- define \"daemonjob-controller.name\" -}}"},{"line_number":6,"context_line":"{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":7,"context_line":"{{- end -}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{{/*"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_d1d1e557","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":72},"updated":"2020-02-11 20:19:03.000000000","message":"This seems to appear in a lot of places. Consider using a nested define to encapsulate this.\n\nAlso, is there an existing helm-toolkit function which may provide the same functionality already?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"eef09dfd05cd8aa271516991c47ee174eb406c5a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Expand the name of the chart."},{"line_number":4,"context_line":"*/}}"},{"line_number":5,"context_line":"{{- define \"daemonjob-controller.name\" -}}"},{"line_number":6,"context_line":"{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":7,"context_line":"{{- end -}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{{/*"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_4cedccb7","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":72},"in_reply_to":"3fa7e38b_d10bbad1","updated":"2020-02-20 19:26:50.000000000","message":"These functions can be deleted , as already existing gotpl function exists in helm-toolkit","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"eb6cef78acb6ef728edf160377963c736efb1cf3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Expand the name of the chart."},{"line_number":4,"context_line":"*/}}"},{"line_number":5,"context_line":"{{- define \"daemonjob-controller.name\" -}}"},{"line_number":6,"context_line":"{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":7,"context_line":"{{- end -}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{{/*"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_d10bbad1","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":72},"in_reply_to":"3fa7e38b_d1d1e557","updated":"2020-02-18 21:32:02.000000000","message":"WIP","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Create chart name and version as used by the chart label."},{"line_number":29,"context_line":"*/}}"},{"line_number":30,"context_line":"{{- define \"daemonjob-controller.chart\" -}}"},{"line_number":31,"context_line":"{{- printf \"%s-%s\" .Chart.Name .Chart.Version | replace \"+\" \"_\" | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":32,"context_line":"{{- end -}}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{{/*"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_91c7ed97","line":31,"range":{"start_line":31,"start_character":46,"end_line":31,"end_character":91},"updated":"2020-02-11 20:19:03.000000000","message":"A similar but different/inconsistent variation of the DNS naming spec enforcement; should settle on a single implementation.","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"}],"daemonjob-controller/templates/_sync-hook.py.tpl":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2019 Google Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_11e45d0a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"updated":"2020-02-11 20:19:03.000000000","message":"This being a fairly small and self-contained script, this may be okay to store here. However at some point it might be worth considering treating this code like other airship projects, which have their own image/makefile along with PEP8 testing, unit testing, etc.","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  daemon[\u0027apiVersion\u0027] \u003d \u0027apps/v1\u0027"},{"line_number":33,"context_line":"  daemon[\u0027kind\u0027] \u003d \u0027DaemonSet\u0027"},{"line_number":34,"context_line":"  daemon[\u0027metadata\u0027] \u003d {}"},{"line_number":35,"context_line":"  daemon[\u0027metadata\u0027][\u0027name\u0027] \u003d \u0027%s-dj\u0027 % (job[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":36,"context_line":"  daemon[\u0027metadata\u0027][\u0027labels\u0027] \u003d copy.deepcopy(job[\u0027spec\u0027][\u0027template\u0027][\u0027metadata\u0027][\u0027labels\u0027])"},{"line_number":37,"context_line":"  daemon[\u0027spec\u0027] \u003d {}"},{"line_number":38,"context_line":"  daemon[\u0027spec\u0027][\u0027template\u0027] \u003d copy.deepcopy(job[\u0027spec\u0027][\u0027template\u0027])"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_1148dd28","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":65},"updated":"2020-02-11 20:19:03.000000000","message":"Consider some up-front error checking/reporting which verifies presence of needed fields, instead of a potential key-value failure here if expected/referenced fields from job are missing.","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bee5c5f5e182582d3cd2c42a8628236c7220106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_4d5f864c","updated":"2020-02-12 22:21:49.000000000","message":"Are we just copying from google\u0027s repo?\n\nhttps://github.com/GoogleCloudPlatform/metacontroller/blob/master/examples/daemonjob/sync.py","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"cbf38b20801073874398d4aa7755ac4b6324c67a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_e88bc01e","in_reply_to":"3fa7e38b_4d5f864c","updated":"2020-02-12 22:53:33.000000000","message":"the above sync.py is python 2.7 compatible , we are using python 3.6, I made changes to sync.py to make it compatible with python 3.x","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"}],"daemonjob-controller/templates/bin/_sync-hook.py.tpl":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"541a4ae5ce4fc289467f7b8f9df65a5c11d96d7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Copyright 2020 The Openstack-Helm Authors."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":68,"id":"1fa4df85_6cf5cbec","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":42},"updated":"2020-03-04 20:22:21.000000000","message":"If we are re-using this from google, don\u0027t re-copyright it here with the osh-authors.\n\nAlso this copyright isn\u0027t really needed elsewhere, there\u0027s no real existing \"osh authors\" group to claim copyright.","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"6b2348027b083c933b670b53562492d15aeb3a84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Copyright 2020 The Openstack-Helm Authors."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":68,"id":"1fa4df85_cc187f1f","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":42},"in_reply_to":"1fa4df85_6cf5cbec","updated":"2020-03-04 20:35:39.000000000","message":"Not actually, I changed to the code to make it compatible with python 3.6 so we can use the copyright with osh-authors, I guess","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"f004e8feccd259943ee90e24afbcd5e6a2f3c53a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Copyright 2020 The Openstack-Helm Authors."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":68,"id":"1fa4df85_ccd71fee","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":42},"in_reply_to":"1fa4df85_cc187f1f","updated":"2020-03-04 20:49:28.000000000","message":"For this template specifically we should not be using this copyright here.","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b6d7db3c64ec02604b151da0e765954b377b4730","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":72,"id":"1fa4df85_12a69f54","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"updated":"2020-03-05 18:00:43.000000000","message":"python3?","commit_id":"8ca9e91d0b0b58bbde83b1263cf5286e305b5c86"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"ee842be7608fb34102b9ea7c5bb589eff1896886","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":72,"id":"1fa4df85_d569d1f8","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"in_reply_to":"1fa4df85_12a69f54","updated":"2020-03-05 19:05:33.000000000","message":"it takes the python3 interpreter.no need for python3","commit_id":"8ca9e91d0b0b58bbde83b1263cf5286e305b5c86"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7f58fd0c458ad625a945bf6a833f1ee44d8963af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"You may obtain a copy of the License at"}],"source_content_type":"text/x-smarty","patch_set":76,"id":"1fa4df85_69efd41d","line":2,"updated":"2020-03-06 20:04:50.000000000","message":"Add the google copyright here, while this was modified to support py3, much of this is still google\u0027s IP.\n\nhttps://github.com/GoogleCloudPlatform/metacontroller/blob/master/examples/daemonjob/sync.py#L3","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"You may obtain a copy of the License at"}],"source_content_type":"text/x-smarty","patch_set":76,"id":"1fa4df85_533e30c1","line":2,"in_reply_to":"1fa4df85_69efd41d","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"}],"daemonjob-controller/templates/composite-controller.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  hooks:"},{"line_number":14,"context_line":"    sync:"},{"line_number":15,"context_line":"      webhook:"},{"line_number":16,"context_line":"        url: http://daemonjob-controller.metacontroller/sync"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_518f3575","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":60},"updated":"2020-02-11 20:19:03.000000000","message":"Does this URL need some configurable FQDN component?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"d00f1496e8a591b7abffcbc55fcacf58e80770d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  hooks:"},{"line_number":14,"context_line":"    sync:"},{"line_number":15,"context_line":"      webhook:"},{"line_number":16,"context_line":"        url: http://daemonjob-controller.metacontroller/sync"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_f1fcb6bd","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":60},"in_reply_to":"3fa7e38b_518f3575","updated":"2020-02-18 21:31:12.000000000","message":"WIP","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_94fa6241","updated":"2020-02-13 05:43:38.000000000","message":"all these files are missing the apache 2.0 headers","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"e4e0cce85bc19901a2fa63230f5345d821933cc7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  hooks:"},{"line_number":30,"context_line":"    sync:"},{"line_number":31,"context_line":"      webhook:"},{"line_number":32,"context_line":"        url: http://daemonjob-controller.metacontroller/sync"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"3fa7e38b_1d6a9c17","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":60},"updated":"2020-02-20 23:06:26.000000000","message":"Shouldn\u0027t the URL have some configurable fqdn component driven by values.yaml?","commit_id":"1618504a7714d87eb3d1e8def465b88ee9e3c7cc"}],"daemonjob-controller/templates/crd.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"42d439d526af40bd9b367346d0ed58a19fd74614","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.crds_create }}"},{"line_number":18,"context_line":"{{- if not (.Capabilities.APIVersions.Has \"ctl.example.com/v1\") }}"},{"line_number":19,"context_line":"apiVersion: apiextensions.k8s.io/v1beta1"},{"line_number":20,"context_line":"kind: CustomResourceDefinition"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: daemonjobs.ctl.example.com"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"1fa4df85_2a04f249","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":40},"updated":"2020-02-27 15:25:31.000000000","message":"should this be apiextensions.k8s.io/v1","commit_id":"7a2f5250e7781286da5d4bd14573843ed230a310"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"e59ee7bff72ba108b7ad8b336bffe329342a37c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.crds_create }}"},{"line_number":18,"context_line":"{{- if not (.Capabilities.APIVersions.Has \"ctl.example.com/v1\") }}"},{"line_number":19,"context_line":"apiVersion: apiextensions.k8s.io/v1beta1"},{"line_number":20,"context_line":"kind: CustomResourceDefinition"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: daemonjobs.ctl.example.com"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"1fa4df85_8ea7f1a7","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":40},"in_reply_to":"1fa4df85_2a04f249","updated":"2020-03-03 22:28:57.000000000","message":"Done","commit_id":"7a2f5250e7781286da5d4bd14573843ed230a310"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"42d439d526af40bd9b367346d0ed58a19fd74614","unresolved":false,"context_lines":[{"line_number":19,"context_line":"apiVersion: apiextensions.k8s.io/v1beta1"},{"line_number":20,"context_line":"kind: CustomResourceDefinition"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: daemonjobs.ctl.example.com"},{"line_number":23,"context_line":"  annotations:"},{"line_number":24,"context_line":"    \"helm.sh/hook\": crd-install"},{"line_number":25,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"1fa4df85_ea925af6","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":34},"updated":"2020-02-27 15:25:31.000000000","message":"can this be overwritten, or would this always end up being example.com?","commit_id":"7a2f5250e7781286da5d4bd14573843ed230a310"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"42d439d526af40bd9b367346d0ed58a19fd74614","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"helm.sh/hook\": crd-install"},{"line_number":25,"context_line":"spec:"},{"line_number":26,"context_line":"  group: ctl.example.com"},{"line_number":27,"context_line":"  version: v1"},{"line_number":28,"context_line":"  scope: Namespaced"},{"line_number":29,"context_line":"  names:"},{"line_number":30,"context_line":"    plural: daemonjobs"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"1fa4df85_ca343efe","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":13},"updated":"2020-02-27 15:25:31.000000000","message":"should this be versions?\n\nhttps://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#customresourcedefinitionspec-v1-apiextensions-k8s-io","commit_id":"7a2f5250e7781286da5d4bd14573843ed230a310"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"e59ee7bff72ba108b7ad8b336bffe329342a37c8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"helm.sh/hook\": crd-install"},{"line_number":25,"context_line":"spec:"},{"line_number":26,"context_line":"  group: ctl.example.com"},{"line_number":27,"context_line":"  version: v1"},{"line_number":28,"context_line":"  scope: Namespaced"},{"line_number":29,"context_line":"  names:"},{"line_number":30,"context_line":"    plural: daemonjobs"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"1fa4df85_e3bfe5cd","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":13},"in_reply_to":"1fa4df85_ca343efe","updated":"2020-03-03 22:28:57.000000000","message":"In apiextensions.k8s.io/v1beta1, there was a version field instead of versions. The version field is deprecated and optional, but if it is not empty, it must match the first item in the versions field.\n\nDone","commit_id":"7a2f5250e7781286da5d4bd14573843ed230a310"}],"daemonjob-controller/templates/deployment.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: {{ template \"daemonjob-controller.fullname\" . }}"},{"line_number":5,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  replicas: 1"},{"line_number":8,"context_line":"  selector:"},{"line_number":9,"context_line":"    matchLabels:"},{"line_number":10,"context_line":"      app: {{ template \"daemonjob-controller.fullname\" . }}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_31a959dd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2020-02-11 20:19:03.000000000","message":"What are the implications to high availability when running with 1 replica for this chart?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"18b8f34b0b0c6211cd3555ea716669c3e7f01b1a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: {{ template \"daemonjob-controller.fullname\" . }}"},{"line_number":5,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  replicas: 1"},{"line_number":8,"context_line":"  selector:"},{"line_number":9,"context_line":"    matchLabels:"},{"line_number":10,"context_line":"      app: {{ template \"daemonjob-controller.fullname\" . }}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_dd5de47b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"in_reply_to":"3fa7e38b_31a959dd","updated":"2020-02-20 23:04:15.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- $serviceAccountName :\u003d \"daemonjob-controller-serviceaccount\" }}"},{"line_number":20,"context_line":"{{ tuple $envAll \"daemonjob_controller\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_9f4d2b74","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":19},"updated":"2020-02-27 05:29:22.000000000","message":"should this not wrapped by a .values.manifests as well?","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"}],"daemonjob-controller/templates/service.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: Service"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_5fa57303","line":17,"updated":"2020-02-27 05:29:22.000000000","message":"ditto: need to wrap this with a .Values.manifests","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: Service"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_14efddb0","line":17,"in_reply_to":"1fa4df85_5fa57303","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"}],"daemonjob-controller/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    python: docker.io/python:3.6"},{"line_number":24,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":25,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":26,"context_line":"  local_registry:"},{"line_number":27,"context_line":"    active: false"},{"line_number":28,"context_line":"    exclude:"},{"line_number":29,"context_line":"      - dep_check"},{"line_number":30,"context_line":"      - image_repo_sync"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"manifests:"},{"line_number":33,"context_line":"  crds_create: true"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_f49076f5","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":23},"updated":"2020-02-13 05:43:38.000000000","message":"I am not sure if we should deviate from how the other charts are structured, but these settings would not apply if you do deviate from how the rest of OSH charts are created.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    python: docker.io/python:3.6"},{"line_number":24,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":25,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":26,"context_line":"  local_registry:"},{"line_number":27,"context_line":"    active: false"},{"line_number":28,"context_line":"    exclude:"},{"line_number":29,"context_line":"      - dep_check"},{"line_number":30,"context_line":"      - image_repo_sync"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"manifests:"},{"line_number":33,"context_line":"  crds_create: true"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_117392b5","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":23},"in_reply_to":"3fa7e38b_f49076f5","updated":"2020-02-18 21:24:30.000000000","message":"WIP","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b6d7db3c64ec02604b151da0e765954b377b4730","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"images:"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    python: docker.io/python:3.6"},{"line_number":22,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":23,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":24,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1fa4df85_52b0978a","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":32},"updated":"2020-03-05 18:00:43.000000000","message":"Could we use 3.6-slim - 55MB, instead of this one, which is 337MB?","commit_id":"8ca9e91d0b0b58bbde83b1263cf5286e305b5c86"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"34c729d36f8bafb4ab12628ec6ea32ab4dcf3910","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"images:"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    python: docker.io/python:3.6"},{"line_number":22,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":23,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":24,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1fa4df85_88590036","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":32},"in_reply_to":"1fa4df85_52b0978a","updated":"2020-03-05 19:20:05.000000000","message":"Done","commit_id":"8ca9e91d0b0b58bbde83b1263cf5286e305b5c86"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"e5d4cf4a0e2b9d2e4780f2fb777c7a789bd6c8f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"images:"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    python: docker.io/python:3.6"},{"line_number":22,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":23,"context_line":"  pullPolicy: IfNotPresent"},{"line_number":24,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1fa4df85_08451043","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":32},"in_reply_to":"1fa4df85_52b0978a","updated":"2020-03-05 19:21:11.000000000","message":"yes, we can definitely use that lighter image , that makes sense.update in my PS","commit_id":"8ca9e91d0b0b58bbde83b1263cf5286e305b5c86"}],"metacontroller/templates/_helpers.tpl":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Expand the name of the chart."},{"line_number":4,"context_line":"*/}}"},{"line_number":5,"context_line":"{{- define \"metacontroller.name\" -}}"},{"line_number":6,"context_line":"{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":7,"context_line":"{{- end -}}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_1110dd4b","line":5,"updated":"2020-02-11 20:19:03.000000000","message":"my preference would be to use some leading spaces to make nested template operations readable.","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"Expand the name of the chart."},{"line_number":4,"context_line":"*/}}"},{"line_number":5,"context_line":"{{- define \"metacontroller.name\" -}}"},{"line_number":6,"context_line":"{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":7,"context_line":"{{- end -}}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_91d1c25d","line":5,"in_reply_to":"3fa7e38b_1110dd4b","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{{- printf \"%s-%s\" .Release.Name $name | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":23,"context_line":"{{- end -}}"},{"line_number":24,"context_line":"{{- end -}}"},{"line_number":25,"context_line":"{{- end -}}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{/*"},{"line_number":28,"context_line":"Create chart name and version as used by the chart label."}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_d14c8576","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":9},"updated":"2020-02-11 20:19:03.000000000","message":"in most cases, you don\u0027t want to delete right-hand whitespace. In my experience, this usually leads to mashed together lines (e.g., foo\\nbar becomes foobar) because it eats the newline \\n at the end of line.\n\nDo you have test coverage for this GoTpl?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{{- printf \"%s-%s\" .Release.Name $name | trunc 63 | trimSuffix \"-\" -}}"},{"line_number":23,"context_line":"{{- end -}}"},{"line_number":24,"context_line":"{{- end -}}"},{"line_number":25,"context_line":"{{- end -}}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{/*"},{"line_number":28,"context_line":"Create chart name and version as used by the chart label."}],"source_content_type":"text/x-smarty","patch_set":17,"id":"3fa7e38b_51db4a79","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":9},"in_reply_to":"3fa7e38b_d14c8576","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bee5c5f5e182582d3cd2c42a8628236c7220106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_ed1bd280","updated":"2020-02-12 22:21:49.000000000","message":"This looks exactly like https://github.com/helm/charts/blob/master/incubator/kafka/templates/_helpers.tpl","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"4fcc56aca3bee4280d373fb5572c5bf5b980bf28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_886fac5f","in_reply_to":"3fa7e38b_ed1bd280","updated":"2020-02-12 22:58:10.000000000","message":"These codes are created by \n```helm create \u003cchart-name\u003e``` scaffolding","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"}],"metacontroller/templates/role.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ if .Values.manifests.rbac_create }}"},{"line_number":2,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":3,"context_line":"kind: ClusterRole"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_b4e19e99","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":5},"updated":"2020-02-13 05:43:38.000000000","message":"nit: missing -, now these just generate blank lines in the rendered manifests","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ if .Values.manifests.rbac_create }}"},{"line_number":2,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":3,"context_line":"kind: ClusterRole"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_315b2e24","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":5},"in_reply_to":"3fa7e38b_b4e19e99","updated":"2020-02-18 21:24:30.000000000","message":"Done","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":3,"context_line":"kind: ClusterRole"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  name: {{ template \"metacontroller.fullname\" . }}"},{"line_number":6,"context_line":"rules:"},{"line_number":7,"context_line":"- apiGroups:"},{"line_number":8,"context_line":"  - \"*\""},{"line_number":9,"context_line":"  resources:"},{"line_number":10,"context_line":"  - \"*\""},{"line_number":11,"context_line":"  verbs:"},{"line_number":12,"context_line":"  - \"*\""},{"line_number":13,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_74ffa634","line":12,"range":{"start_line":5,"start_character":0,"end_line":12,"end_character":7},"updated":"2020-02-13 05:43:38.000000000","message":"does this need to be so permissive?","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":3,"context_line":"kind: ClusterRole"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  name: {{ template \"metacontroller.fullname\" . }}"},{"line_number":6,"context_line":"rules:"},{"line_number":7,"context_line":"- apiGroups:"},{"line_number":8,"context_line":"  - \"*\""},{"line_number":9,"context_line":"  resources:"},{"line_number":10,"context_line":"  - \"*\""},{"line_number":11,"context_line":"  verbs:"},{"line_number":12,"context_line":"  - \"*\""},{"line_number":13,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_119872c9","line":12,"range":{"start_line":5,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"3fa7e38b_74ffa634","updated":"2020-02-18 21:24:30.000000000","message":"I guess its no harm to keep it Permissive.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"}],"metacontroller/templates/statefulset.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  labels:"},{"line_number":7,"context_line":"    app: {{ template \"metacontroller.fullname\" . }}"},{"line_number":8,"context_line":"spec:"},{"line_number":9,"context_line":"  replicas: 1"},{"line_number":10,"context_line":"  selector:"},{"line_number":11,"context_line":"    matchLabels:"},{"line_number":12,"context_line":"      app: {{ template \"metacontroller.fullname\" . }}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_11ac5de9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2020-02-11 20:19:03.000000000","message":"What are the implications to high availability running 1 replica of this chart?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  labels:"},{"line_number":7,"context_line":"    app: {{ template \"metacontroller.fullname\" . }}"},{"line_number":8,"context_line":"spec:"},{"line_number":9,"context_line":"  replicas: 1"},{"line_number":10,"context_line":"  selector:"},{"line_number":11,"context_line":"    matchLabels:"},{"line_number":12,"context_line":"      app: {{ template \"metacontroller.fullname\" . }}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_71bd2603","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"3fa7e38b_11ac5de9","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2b1fb0feb598269b21c76a8a23dead3d2f246ce7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"matacontroller-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"matacontroller\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ $controllerName :\u003d printf \"%s-%s\" .Release.Namespace $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_58e6f646","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":42},"updated":"2020-02-27 16:15:49.000000000","message":"metacontroller","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"af3f5ae4dd4b7c32b904692c827e6eba55226820","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"matacontroller-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"matacontroller\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ $controllerName :\u003d printf \"%s-%s\" .Release.Namespace $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_0eb541cd","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":42},"in_reply_to":"1fa4df85_58e6f646","updated":"2020-03-03 22:29:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2b1fb0feb598269b21c76a8a23dead3d2f246ce7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"matacontroller-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"matacontroller\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ $controllerName :\u003d printf \"%s-%s\" .Release.Namespace $serviceAccountName }}"},{"line_number":24,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_78e3b234","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":32},"updated":"2020-02-27 16:15:49.000000000","message":"ditto","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"af3f5ae4dd4b7c32b904692c827e6eba55226820","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"matacontroller-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"matacontroller\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ $controllerName :\u003d printf \"%s-%s\" .Release.Namespace $serviceAccountName }}"},{"line_number":24,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_aecd0d67","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":32},"in_reply_to":"1fa4df85_78e3b234","updated":"2020-03-03 22:29:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":87,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.metacontroller | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 8 }}"},{"line_number":88,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"metacontroller\" \"container\" \"metacontroller\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 8 }}"},{"line_number":89,"context_line":"        command:"},{"line_number":90,"context_line":"          - /usr/bin/metacontroller"},{"line_number":91,"context_line":"        args:"},{"line_number":92,"context_line":"        - --logtostderr"},{"line_number":93,"context_line":"        - -v\u003d4"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_1f6a9bb2","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":12},"updated":"2020-02-27 05:29:22.000000000","message":"this indent isn\u0027t consistent with The the other indent.","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.metacontroller | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 8 }}"},{"line_number":88,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"metacontroller\" \"container\" \"metacontroller\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 8 }}"},{"line_number":89,"context_line":"        command:"},{"line_number":90,"context_line":"          - /usr/bin/metacontroller"},{"line_number":91,"context_line":"        args:"},{"line_number":92,"context_line":"        - --logtostderr"},{"line_number":93,"context_line":"        - -v\u003d4"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_9403cd73","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":12},"in_reply_to":"1fa4df85_1f6a9bb2","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"}],"metacontroller/values.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    exclude:"},{"line_number":30,"context_line":"      - dep_check"},{"line_number":31,"context_line":"      - image_repo_sync"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_7f31dd08","line":32,"updated":"2020-02-11 20:19:03.000000000","message":"do you need to define any labels?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    exclude:"},{"line_number":30,"context_line":"      - dep_check"},{"line_number":31,"context_line":"      - image_repo_sync"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_718f6677","line":32,"in_reply_to":"3fa7e38b_7f31dd08","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"manifests:"},{"line_number":37,"context_line":"  crds_create: true"},{"line_number":38,"context_line":"  service_account_create: true"},{"line_number":39,"context_line":"  rbac_create: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_1f4d4992","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":10},"updated":"2020-02-11 20:19:03.000000000","message":"Most of the other charts have a value which can be set to enable/disable certain components of the chart. Not mandatory AFAIK, but nice to have.","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"manifests:"},{"line_number":37,"context_line":"  crds_create: true"},{"line_number":38,"context_line":"  service_account_create: true"},{"line_number":39,"context_line":"  rbac_create: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_918c6282","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":10},"in_reply_to":"3fa7e38b_1f4d4992","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    metacontroller: docker.io/metacontroller/metacontroller:v0.4.0"},{"line_number":24,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":25,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":26,"context_line":"  pull_policy: IfNotPresent"},{"line_number":27,"context_line":"  local_registry:"},{"line_number":28,"context_line":"    active: false"},{"line_number":29,"context_line":"    exclude:"},{"line_number":30,"context_line":"      - dep_check"},{"line_number":31,"context_line":"      - image_repo_sync"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_d499ba1c","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":23},"updated":"2020-02-13 05:43:38.000000000","message":"ditto","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - dep_check"},{"line_number":31,"context_line":"      - image_repo_sync"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"serviceAccount:"},{"line_number":34,"context_line":"  name:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"manifests:"},{"line_number":37,"context_line":"  crds_create: true"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3fa7e38b_149432e6","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":7},"updated":"2020-02-13 05:43:38.000000000","message":"?","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"e4e0cce85bc19901a2fa63230f5345d821933cc7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        memory: \"128Mi\""},{"line_number":65,"context_line":"        cpu: \"500m\""},{"line_number":66,"context_line":"  replicas:"},{"line_number":67,"context_line":"    metacontroller: 1"},{"line_number":68,"context_line":"  affinity:"},{"line_number":69,"context_line":"    anti:"},{"line_number":70,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"3fa7e38b_7d7b90f2","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":21},"updated":"2020-02-20 23:06:26.000000000","message":"Has this been tested with multiple replicas? Does high availability work?","commit_id":"1618504a7714d87eb3d1e8def465b88ee9e3c7cc"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"227011132c0174c8e7970fdcd62eb3b87101a6a9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        memory: \"128Mi\""},{"line_number":65,"context_line":"        cpu: \"500m\""},{"line_number":66,"context_line":"  replicas:"},{"line_number":67,"context_line":"    metacontroller: 1"},{"line_number":68,"context_line":"  affinity:"},{"line_number":69,"context_line":"    anti:"},{"line_number":70,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"3fa7e38b_d8b732f7","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":21},"in_reply_to":"3fa7e38b_38df663a","updated":"2020-02-20 23:58:53.000000000","message":"updated with 3 , from gate , pod-logs it seems working","commit_id":"1618504a7714d87eb3d1e8def465b88ee9e3c7cc"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bbb8d6f9a21df61d4e2f6f4566f97823c5d04d1e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        memory: \"128Mi\""},{"line_number":65,"context_line":"        cpu: \"500m\""},{"line_number":66,"context_line":"  replicas:"},{"line_number":67,"context_line":"    metacontroller: 1"},{"line_number":68,"context_line":"  affinity:"},{"line_number":69,"context_line":"    anti:"},{"line_number":70,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"3fa7e38b_38df663a","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":21},"in_reply_to":"3fa7e38b_7d7b90f2","updated":"2020-02-20 23:57:44.000000000","message":"Done","commit_id":"1618504a7714d87eb3d1e8def465b88ee9e3c7cc"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"2cdfcda7ee1421a2eedba79fa43382611d162e52","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        memory: \"128Mi\""},{"line_number":65,"context_line":"        cpu: \"500m\""},{"line_number":66,"context_line":"  replicas:"},{"line_number":67,"context_line":"    metacontroller: 1"},{"line_number":68,"context_line":"  affinity:"},{"line_number":69,"context_line":"    anti:"},{"line_number":70,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"3fa7e38b_f896ae4a","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":21},"in_reply_to":"3fa7e38b_d8b732f7","updated":"2020-02-21 00:01:50.000000000","message":"I will add the test providing the number of replica from values_overrides in gate job. I directly have updated 3 in ps 61, and things seems to be working","commit_id":"1618504a7714d87eb3d1e8def465b88ee9e3c7cc"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  statefulset: true"},{"line_number":105,"context_line":"  job_image_repo_sync: true"},{"line_number":106,"context_line":"  crds: true"},{"line_number":107,"context_line":"  service_account: true"},{"line_number":108,"context_line":"  rbac: true"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_9f768ba4","line":107,"range":{"start_line":107,"start_character":1,"end_line":107,"end_character":17},"updated":"2020-02-27 05:29:22.000000000","message":"where is this manifest used?","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  statefulset: true"},{"line_number":105,"context_line":"  job_image_repo_sync: true"},{"line_number":106,"context_line":"  crds: true"},{"line_number":107,"context_line":"  service_account: true"},{"line_number":108,"context_line":"  rbac: true"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_549eb554","line":107,"range":{"start_line":107,"start_character":1,"end_line":107,"end_character":17},"in_reply_to":"1fa4df85_9f768ba4","updated":"2020-02-27 13:31:35.000000000","message":"Done","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"}],"tools/deployment/common/daemonjob-controller.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":79,"context_line":"echo \"Wait until CRD is available...\""},{"line_number":80,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"kubectl apply -f /tmp/sample-daemonjob.yaml"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-sh","patch_set":63,"id":"1fa4df85_ff177f44","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":43},"updated":"2020-02-27 05:29:22.000000000","message":"how can one tell the chart works - this script ends with an apply.","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"7f0c62eeff023d91b15ee55bb2f04c9480c0c6b1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"echo \"Wait until CRD is available...\""},{"line_number":80,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"kubectl apply -f /tmp/sample-daemonjob.yaml"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-sh","patch_set":63,"id":"1fa4df85_54cc7560","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":43},"in_reply_to":"1fa4df85_ff177f44","updated":"2020-02-27 13:31:35.000000000","message":"yes, we need to have a checking  verify Daemonjob(CR) works as expected.\nDaemonsets(runtime) came up , complete their tasks and goes away.\nI have added that in the latest ps.\n\nthough from the metacontroller server logs I have verified the fact earlier.","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"echo \"$composite_controller_cr, a CompositeController created succesfully\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":35,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_3ad6002a","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":73},"updated":"2020-03-06 16:52:58.000000000","message":"awk \u0027/ctl\\.example\\.com/ {print $1}\u0027","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":32,"context_line":"echo \"$composite_controller_cr, a CompositeController created succesfully\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":35,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_b358c430","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":73},"in_reply_to":"1fa4df85_3ad6002a","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":35,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_7aef98e8","line":37,"range":{"start_line":37,"start_character":5,"end_line":37,"end_character":44},"updated":"2020-03-06 16:52:58.000000000","message":"At this point it\u0027s not yet created, right? Line 34 says it\u0027s not yet created.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":35,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_935588fc","line":37,"range":{"start_line":37,"start_character":5,"end_line":37,"end_character":44},"in_reply_to":"1fa4df85_7aef98e8","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_5ac2dc5a","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":83},"updated":"2020-03-06 16:52:58.000000000","message":"awk \u0027/daemonjob-controller/ {print $1}\u0027","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_f352bc12","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":83},"in_reply_to":"1fa4df85_5ac2dc5a","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"until [[ $daemonjob_controller_status \u003d\u003d \u0027Running\u0027 ]]"},{"line_number":44,"context_line":"do"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_3aa4c0b9","line":41,"range":{"start_line":41,"start_character":63,"end_line":41,"end_character":107},"updated":"2020-03-06 16:52:58.000000000","message":"Same as above here and below.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"until [[ $daemonjob_controller_status \u003d\u003d \u0027Running\u0027 ]]"},{"line_number":44,"context_line":"do"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_d34f8068","line":41,"range":{"start_line":41,"start_character":63,"end_line":41,"end_character":107},"in_reply_to":"1fa4df85_3aa4c0b9","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"until [[ $daemonjob_controller_status \u003d\u003d \u0027Running\u0027 ]]"},{"line_number":44,"context_line":"do"},{"line_number":45,"context_line":"  daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":46,"context_line":"  kubectl describe pod $pod -n $namespace"},{"line_number":47,"context_line":"  echo \"DaemonjobController is not still up and running\""},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":51,"context_line":"helm status daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_9a713447","line":48,"range":{"start_line":43,"start_character":0,"end_line":48,"end_character":4},"updated":"2020-03-06 16:52:58.000000000","message":"Add some sleep (sleep 10), and a counter to exit after certain number of attempts. Otherwise job could run for hours.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7f58fd0c458ad625a945bf6a833f1ee44d8963af","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"until [[ $daemonjob_controller_status \u003d\u003d \u0027Running\u0027 ]]"},{"line_number":44,"context_line":"do"},{"line_number":45,"context_line":"  daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":46,"context_line":"  kubectl describe pod $pod -n $namespace"},{"line_number":47,"context_line":"  echo \"DaemonjobController is not still up and running\""},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":51,"context_line":"helm status daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_e9718477","line":48,"range":{"start_line":43,"start_character":0,"end_line":48,"end_character":4},"in_reply_to":"1fa4df85_9a713447","updated":"2020-03-06 20:04:50.000000000","message":"++, zuul has an auto-timeout but it takes a few hours.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#NOTE: Check daemonjob_controller is Running"},{"line_number":41,"context_line":"daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"until [[ $daemonjob_controller_status \u003d\u003d \u0027Running\u0027 ]]"},{"line_number":44,"context_line":"do"},{"line_number":45,"context_line":"  daemonjob_controller_status\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $3}\u0027)"},{"line_number":46,"context_line":"  kubectl describe pod $pod -n $namespace"},{"line_number":47,"context_line":"  echo \"DaemonjobController is not still up and running\""},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":51,"context_line":"helm status daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_332ff488","line":48,"range":{"start_line":43,"start_character":0,"end_line":48,"end_character":4},"in_reply_to":"1fa4df85_9a713447","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"dj\u003d\"daemonjobs\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"echo \"Wait until CRD is available...\""},{"line_number":80,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"kubectl apply -f /tmp/sample-daemonjob.yaml"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_1a9b0466","line":80,"range":{"start_line":80,"start_character":32,"end_line":80,"end_character":33},"updated":"2020-03-06 16:52:58.000000000","message":"May be 5-10 sec. here and below.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"daemonset_pod\u003d$(kubectl get pods --all-namespaces | grep hello-world-dj | awk \u0027{print $2}\u0027)"},{"line_number":85,"context_line":"kubectl describe pod $daemonset_pod"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"echo \"Wait for successful completion...\""},{"line_number":88,"context_line":"until [[ \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\" \u003d\u003d \"True\" ]]; do sleep 1; done"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"echo \"Check that DaemonSet gets cleaned up after finishing...\""},{"line_number":91,"context_line":"until [[ \"$(kubectl get daemonset hello-world-dj 2\u003e\u00261)\" \u003d~ NotFound ]]; do sleep 1; done"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-sh","patch_set":76,"id":"1fa4df85_1a022470","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":88},"updated":"2020-03-06 16:52:58.000000000","message":"Same here. I don\u0027t see any timeouts and limits. Job could run for hours, deployment could not succeed, but still it would should green SUCCESS.","commit_id":"419fae8270e889ed42c1c71c215042496c585c8d"}],"tools/deployment/common/metacontroller.sh":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"./tools/deployment/common/wait-for-pods.sh metacontroller"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"#NOTE: Check metacontroller is Running"},{"line_number":38,"context_line":"#metacontroller_status\u003d$(kubectl get pods -n $namespace | grep metacontroller | awk \u0027{print $3}\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#NOTE: Check crds of APIGroup metacontroller.k8s.io successfully created"},{"line_number":41,"context_line":"crds\u003d$(kubectl get crd | grep metacontroller.k8s.io | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_5ad89c79","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":1},"updated":"2020-03-06 16:52:58.000000000","message":"Is it needed?","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"./tools/deployment/common/wait-for-pods.sh metacontroller"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"#NOTE: Check metacontroller is Running"},{"line_number":38,"context_line":"#metacontroller_status\u003d$(kubectl get pods -n $namespace | grep metacontroller | awk \u0027{print $3}\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#NOTE: Check crds of APIGroup metacontroller.k8s.io successfully created"},{"line_number":41,"context_line":"crds\u003d$(kubectl get crd | grep metacontroller.k8s.io | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_7ae55837","line":38,"range":{"start_line":38,"start_character":58,"end_line":38,"end_character":96},"updated":"2020-03-06 16:52:58.000000000","message":"awk \u0027/metacontroller/ {print $3}\u0027","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":35,"context_line":"./tools/deployment/common/wait-for-pods.sh metacontroller"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"#NOTE: Check metacontroller is Running"},{"line_number":38,"context_line":"#metacontroller_status\u003d$(kubectl get pods -n $namespace | grep metacontroller | awk \u0027{print $3}\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#NOTE: Check crds of APIGroup metacontroller.k8s.io successfully created"},{"line_number":41,"context_line":"crds\u003d$(kubectl get crd | grep metacontroller.k8s.io | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_733eccb8","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":1},"in_reply_to":"1fa4df85_5ad89c79","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"for i in $crds"},{"line_number":45,"context_line":"do"},{"line_number":46,"context_line":"  case $i in"},{"line_number":47,"context_line":"   \"compositecontrollers.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":48,"context_line":"   \"controllerrevisions.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":49,"context_line":"   \"decoratorcontrollers.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":50,"context_line":"   *) echo \"This is a wrong crd!!!\";;"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_502e4292","line":47,"range":{"start_line":47,"start_character":57,"end_line":47,"end_character":76},"updated":"2020-03-06 16:52:58.000000000","message":"$((...)), because `` is deprecated, and this is just math calculations. You can use ++ operator.","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":44,"context_line":"for i in $crds"},{"line_number":45,"context_line":"do"},{"line_number":46,"context_line":"  case $i in"},{"line_number":47,"context_line":"   \"compositecontrollers.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":48,"context_line":"   \"controllerrevisions.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":49,"context_line":"   \"decoratorcontrollers.metacontroller.k8s.io\") COUNTER\u003d`expr $COUNTER + 1`;;"},{"line_number":50,"context_line":"   *) echo \"This is a wrong crd!!!\";;"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_1349985e","line":47,"range":{"start_line":47,"start_character":57,"end_line":47,"end_character":76},"in_reply_to":"1fa4df85_502e4292","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f423139ea947dbafb86bf8deddd4c9874763730d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  esac"},{"line_number":52,"context_line":"done"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"if test $COUNTER -eq 3; then"},{"line_number":55,"context_line":"  echo \"crds created succesfully\""},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"helm status metacontroller"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_daf6ccd7","line":58,"range":{"start_line":54,"start_character":0,"end_line":58,"end_character":26},"updated":"2020-03-06 16:52:58.000000000","message":"I couldn\u0027t find how this could exit with error, in case CRD did not deploy. This gate would always be showing green SUCCESS, thus would be useless.","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"9fcc12a78c911c265a6340deab8f19e09928ac67","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  esac"},{"line_number":52,"context_line":"done"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"if test $COUNTER -eq 3; then"},{"line_number":55,"context_line":"  echo \"crds created succesfully\""},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"helm status metacontroller"}],"source_content_type":"text/x-sh","patch_set":74,"id":"1fa4df85_d378e090","line":58,"range":{"start_line":54,"start_character":0,"end_line":58,"end_character":26},"in_reply_to":"1fa4df85_daf6ccd7","updated":"2020-03-09 17:24:03.000000000","message":"Done","commit_id":"4bb73a4c662c37ddff1931b72bf3f56406a84a98"}],"tools/deployment/metacontroller/000-install-packages.sh":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_9fb37999","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2020-02-11 20:19:03.000000000","message":"We already have such a script under common directory. Why not re-use existing script, or add to that script as needed?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_5186ea61","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"in_reply_to":"3fa7e38b_9fb37999","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"}],"tools/deployment/metacontroller/001-deploy-k8s.sh":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"# Copyright 2019, AT\u0026T Intellectual Property"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_bf5d1555","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2020-02-11 20:19:03.000000000","message":"We already have such a script under common directory. Why not re-use existing script, or add to that script as needed?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"# Copyright 2019, AT\u0026T Intellectual Property"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_b1eabe0a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"in_reply_to":"3fa7e38b_bf5d1555","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bee5c5f5e182582d3cd2c42a8628236c7220106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_8dffbe01","updated":"2020-02-12 22:21:49.000000000","message":"Does this file do anything specific to the metacontroller?\nIf not, we can symlink to an already existing file","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"4fcc56aca3bee4280d373fb5572c5bf5b980bf28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3fa7e38b_88a48ca5","in_reply_to":"3fa7e38b_8dffbe01","updated":"2020-02-12 22:58:10.000000000","message":"yes, I can utilise the existing gate script folders","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"}],"tools/deployment/metacontroller/002-metacontroller.sh":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"27cfcdb345a3b240200e42d7f96f6c1c0cf6b2af","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"watch -n1 kubectl get ds,dj,po"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"#kubectl logs -f metacontroller-0 -n metacontroller"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"#kubectl get $dj --all-namespaces"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#until kubectl get daemonset hello-world-dj; do sleep 1; done"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"#kubectl get daemonset hello-world-dj"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#echo \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\""},{"line_number":132,"context_line":"#echo \"Wait for successful completion...\";"},{"line_number":133,"context_line":"#dj\u003d\"daemonjobs\";"},{"line_number":134,"context_line":"#until [[ \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\" \u003d\u003d \"True\" ]]; do echo executing;sleep 1; done;"},{"line_number":135,"context_line":"#echo \"Check that DaemonSet gets cleaned up after finishing...\";"},{"line_number":136,"context_line":"#until [[ \"$(kubectl get daemonset hello-world-dj 2\u003e\u00261)\" \u003d~ NotFound ]]; do sleep 1; done;"},{"line_number":137,"context_line":"#sleep 20"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#echo \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\""},{"line_number":140,"context_line":"##NOTE: Cleaup crds"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"#kubectl delete crd compositecontrollers.metacontroller.k8s.io"},{"line_number":143,"context_line":"#kubectl delete crd controllerrevisions.metacontroller.k8s.io"},{"line_number":144,"context_line":"#kubectl delete crd decoratorcontrollers.metacontroller.k8s.io"},{"line_number":145,"context_line":"#kubectl delete crd daemonjobs.ctl.example.com"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_df625115","line":145,"range":{"start_line":123,"start_character":0,"end_line":145,"end_character":46},"updated":"2020-02-11 20:19:03.000000000","message":"Lots of commented stuff - why?","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"bac8536747b7d9a0754f35263078c0717e4d3571","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"watch -n1 kubectl get ds,dj,po"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"#kubectl logs -f metacontroller-0 -n metacontroller"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"#kubectl get $dj --all-namespaces"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#until kubectl get daemonset hello-world-dj; do sleep 1; done"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"#kubectl get daemonset hello-world-dj"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#echo \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\""},{"line_number":132,"context_line":"#echo \"Wait for successful completion...\";"},{"line_number":133,"context_line":"#dj\u003d\"daemonjobs\";"},{"line_number":134,"context_line":"#until [[ \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\" \u003d\u003d \"True\" ]]; do echo executing;sleep 1; done;"},{"line_number":135,"context_line":"#echo \"Check that DaemonSet gets cleaned up after finishing...\";"},{"line_number":136,"context_line":"#until [[ \"$(kubectl get daemonset hello-world-dj 2\u003e\u00261)\" \u003d~ NotFound ]]; do sleep 1; done;"},{"line_number":137,"context_line":"#sleep 20"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#echo \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\""},{"line_number":140,"context_line":"##NOTE: Cleaup crds"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"#kubectl delete crd compositecontrollers.metacontroller.k8s.io"},{"line_number":143,"context_line":"#kubectl delete crd controllerrevisions.metacontroller.k8s.io"},{"line_number":144,"context_line":"#kubectl delete crd decoratorcontrollers.metacontroller.k8s.io"},{"line_number":145,"context_line":"#kubectl delete crd daemonjobs.ctl.example.com"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_51ad8ae5","line":145,"range":{"start_line":123,"start_character":0,"end_line":145,"end_character":46},"in_reply_to":"3fa7e38b_df625115","updated":"2020-02-18 21:27:37.000000000","message":"Done","commit_id":"f42f045a304e3069960f6c15563dec6d7f84af67"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"make metacontroller"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Deploy command"},{"line_number":31,"context_line":"helm upgrade --install metacontroller ./metacontroller \\"},{"line_number":32,"context_line":"    --namespace\u003d$namespace"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#NOTE: Wait for deploy"},{"line_number":35,"context_line":"./tools/deployment/common/wait-for-pods.sh metacontroller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_14bd1266","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":26},"updated":"2020-02-13 05:43:38.000000000","message":"need support for feature gate (overrides)","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"make metacontroller"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Deploy command"},{"line_number":31,"context_line":"helm upgrade --install metacontroller ./metacontroller \\"},{"line_number":32,"context_line":"    --namespace\u003d$namespace"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#NOTE: Wait for deploy"},{"line_number":35,"context_line":"./tools/deployment/common/wait-for-pods.sh metacontroller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_1125d2ad","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":26},"in_reply_to":"3fa7e38b_14bd1266","updated":"2020-02-18 21:24:30.000000000","message":"Done","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#NOTE: Deploy command"},{"line_number":69,"context_line":"helm upgrade --install daemonjob-controller ./daemonjob-controller \\"},{"line_number":70,"context_line":"    --namespace\u003d$namespace"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#NOTE: Wait for deploy"},{"line_number":73,"context_line":"./tools/deployment/common/wait-for-pods.sh daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_348a8ebc","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":26},"updated":"2020-02-13 05:43:38.000000000","message":"this need to support feature gate","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#NOTE: Deploy command"},{"line_number":69,"context_line":"helm upgrade --install daemonjob-controller ./daemonjob-controller \\"},{"line_number":70,"context_line":"    --namespace\u003d$namespace"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#NOTE: Wait for deploy"},{"line_number":73,"context_line":"./tools/deployment/common/wait-for-pods.sh daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_7133e6f9","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":26},"in_reply_to":"3fa7e38b_348a8ebc","updated":"2020-02-18 21:24:30.000000000","message":"WIP","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d05ccb47b6f6473dafe1cc940fccc7d11e0b0bb1","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"dj\u003d\"daemonjobs\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#NOTE: Wait until CRD is available"},{"line_number":118,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":121,"context_line":"helm status daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_f4b9567b","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":39},"updated":"2020-02-13 05:43:38.000000000","message":"should these time out or are we expecting the gate to stop a potentiate waiting indefinitely.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"84ffb6e88f4282bc1332385366d3e587686590d5","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"dj\u003d\"daemonjobs\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#NOTE: Wait until CRD is available"},{"line_number":118,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":121,"context_line":"helm status daemonjob-controller"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_b14e3e6b","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":39},"in_reply_to":"3fa7e38b_f4b9567b","updated":"2020-02-18 21:24:30.000000000","message":"we are expecting the gate to stop a potentiate waiting indefinitely.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bee5c5f5e182582d3cd2c42a8628236c7220106","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  echo \"No crd exists of APIGroup ctl.example.com\""},{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#NOTE: Deploy command"},{"line_number":69,"context_line":"helm upgrade --install daemonjob-controller ./daemonjob-controller \\"},{"line_number":70,"context_line":"    --namespace\u003d$namespace"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#NOTE: Wait for deploy"},{"line_number":73,"context_line":"./tools/deployment/common/wait-for-pods.sh daemonjob-controller"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"composite_controller_cr\u003d$(kubectl get compositecontrollers | awk \u0027{print $1}\u0027)"},{"line_number":76,"context_line":"echo \"$composite_controller_cr, a CompositeController created succesfully\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":79,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":80,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"a\u003d0"},{"line_number":86,"context_line":"until [ ! $a -lt 150 ]"},{"line_number":87,"context_line":"do"},{"line_number":88,"context_line":"  kubectl describe pod $pod -n $namespace"},{"line_number":89,"context_line":"  echo $a"},{"line_number":90,"context_line":"  a\u003d`expr $a + 1`"},{"line_number":91,"context_line":"done"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"#NOTE: Deploy command"},{"line_number":94,"context_line":"tee /tmp/sample-daemonjob.yaml \u003c\u003c EOF"},{"line_number":95,"context_line":"apiVersion: ctl.example.com/v1"},{"line_number":96,"context_line":"kind: DaemonJob"},{"line_number":97,"context_line":"metadata:"},{"line_number":98,"context_line":"  name: hello-world"},{"line_number":99,"context_line":"spec:"},{"line_number":100,"context_line":"  template:"},{"line_number":101,"context_line":"    metadata:"},{"line_number":102,"context_line":"      labels:"},{"line_number":103,"context_line":"        app: hello-world"},{"line_number":104,"context_line":"    spec:"},{"line_number":105,"context_line":"      containers:"},{"line_number":106,"context_line":"      - name: hello-world"},{"line_number":107,"context_line":"        image: busybox"},{"line_number":108,"context_line":"        command: [\"sh\", \"-c\", \"echo \u0027Hello world\u0027 \u0026\u0026 sleep 10\"]"},{"line_number":109,"context_line":"        resources:"},{"line_number":110,"context_line":"          requests:"},{"line_number":111,"context_line":"            cpu: 10m"},{"line_number":112,"context_line":"    terminationGracePeriodSeconds: 10"},{"line_number":113,"context_line":"EOF"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"dj\u003d\"daemonjobs\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#NOTE: Wait until CRD is available"},{"line_number":118,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":121,"context_line":"helm status daemonjob-controller"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"kubectl apply -f /tmp/sample-daemonjob.yaml"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"until kubectl get daemonset hello-world-dj; do sleep 1; done"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"until [[ \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\" \u003d\u003d \"True\" ]]; do echo executing;sleep 1; done;"},{"line_number":128,"context_line":"until [[ \"$(kubectl get daemonset hello-world-dj 2\u003e\u00261)\" \u003d~ NotFound ]]; do sleep 1; done;"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"kubectl delete crd compositecontrollers.metacontroller.k8s.io"},{"line_number":131,"context_line":"kubectl delete crd controllerrevisions.metacontroller.k8s.io"},{"line_number":132,"context_line":"kubectl delete crd decoratorcontrollers.metacontroller.k8s.io"},{"line_number":133,"context_line":"kubectl delete crd daemonjobs.ctl.example.com"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_28047812","line":133,"range":{"start_line":68,"start_character":0,"end_line":133,"end_character":45},"updated":"2020-02-12 22:21:49.000000000","message":"Can you split this into it\u0027s own script?","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"4fcc56aca3bee4280d373fb5572c5bf5b980bf28","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  echo \"No crd exists of APIGroup ctl.example.com\""},{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#NOTE: Deploy command"},{"line_number":69,"context_line":"helm upgrade --install daemonjob-controller ./daemonjob-controller \\"},{"line_number":70,"context_line":"    --namespace\u003d$namespace"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#NOTE: Wait for deploy"},{"line_number":73,"context_line":"./tools/deployment/common/wait-for-pods.sh daemonjob-controller"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"composite_controller_cr\u003d$(kubectl get compositecontrollers | awk \u0027{print $1}\u0027)"},{"line_number":76,"context_line":"echo \"$composite_controller_cr, a CompositeController created succesfully\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"#NOTE: Check no crd exists of APIGroup ctl.example.com"},{"line_number":79,"context_line":"daemonjob_crd\u003d$(kubectl get crd | grep ctl.example.com | awk \u0027{print $1}\u0027)"},{"line_number":80,"context_line":"echo \"$daemonjob_crd is succesfully created\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"pod\u003d$(kubectl get pods -n $namespace | grep daemonjob-controller | awk \u0027{print $1}\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"a\u003d0"},{"line_number":86,"context_line":"until [ ! $a -lt 150 ]"},{"line_number":87,"context_line":"do"},{"line_number":88,"context_line":"  kubectl describe pod $pod -n $namespace"},{"line_number":89,"context_line":"  echo $a"},{"line_number":90,"context_line":"  a\u003d`expr $a + 1`"},{"line_number":91,"context_line":"done"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"#NOTE: Deploy command"},{"line_number":94,"context_line":"tee /tmp/sample-daemonjob.yaml \u003c\u003c EOF"},{"line_number":95,"context_line":"apiVersion: ctl.example.com/v1"},{"line_number":96,"context_line":"kind: DaemonJob"},{"line_number":97,"context_line":"metadata:"},{"line_number":98,"context_line":"  name: hello-world"},{"line_number":99,"context_line":"spec:"},{"line_number":100,"context_line":"  template:"},{"line_number":101,"context_line":"    metadata:"},{"line_number":102,"context_line":"      labels:"},{"line_number":103,"context_line":"        app: hello-world"},{"line_number":104,"context_line":"    spec:"},{"line_number":105,"context_line":"      containers:"},{"line_number":106,"context_line":"      - name: hello-world"},{"line_number":107,"context_line":"        image: busybox"},{"line_number":108,"context_line":"        command: [\"sh\", \"-c\", \"echo \u0027Hello world\u0027 \u0026\u0026 sleep 10\"]"},{"line_number":109,"context_line":"        resources:"},{"line_number":110,"context_line":"          requests:"},{"line_number":111,"context_line":"            cpu: 10m"},{"line_number":112,"context_line":"    terminationGracePeriodSeconds: 10"},{"line_number":113,"context_line":"EOF"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"dj\u003d\"daemonjobs\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#NOTE: Wait until CRD is available"},{"line_number":118,"context_line":"until kubectl get $dj; do sleep 1; done"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#NOTE: Validate DaemonjobController Deployment info"},{"line_number":121,"context_line":"helm status daemonjob-controller"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"kubectl apply -f /tmp/sample-daemonjob.yaml"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"until kubectl get daemonset hello-world-dj; do sleep 1; done"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"until [[ \"$(kubectl get $dj hello-world -o \u0027jsonpath\u003d{.status.conditions[0].status}\u0027)\" \u003d\u003d \"True\" ]]; do echo executing;sleep 1; done;"},{"line_number":128,"context_line":"until [[ \"$(kubectl get daemonset hello-world-dj 2\u003e\u00261)\" \u003d~ NotFound ]]; do sleep 1; done;"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"kubectl delete crd compositecontrollers.metacontroller.k8s.io"},{"line_number":131,"context_line":"kubectl delete crd controllerrevisions.metacontroller.k8s.io"},{"line_number":132,"context_line":"kubectl delete crd decoratorcontrollers.metacontroller.k8s.io"},{"line_number":133,"context_line":"kubectl delete crd daemonjobs.ctl.example.com"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"3fa7e38b_08917c45","line":133,"range":{"start_line":68,"start_character":0,"end_line":133,"end_character":45},"in_reply_to":"3fa7e38b_28047812","updated":"2020-02-12 22:58:10.000000000","message":"I agree, I\u0027m planning to break this up into individual component scripts.","commit_id":"eb32a752cb43fd83259b0ed6c5cc4c5b0392cda7"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fca6931fe73075d318ca4940f2ecba1458ba3b80","unresolved":false,"context_lines":[{"line_number":293,"context_line":"      osh_params:"},{"line_number":294,"context_line":"        container_distro_name: ubuntu"},{"line_number":295,"context_line":"        container_distro_version: bionic"},{"line_number":296,"context_line":"        feature_gates: apparmor"},{"line_number":297,"context_line":"      gate_scripts:"},{"line_number":298,"context_line":"        - ./tools/deployment/common/000-install-packages.sh"},{"line_number":299,"context_line":"        - ./tools/deployment/common/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_9fff6b00","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":31},"updated":"2020-02-27 05:29:22.000000000","message":"does this need to have app armor?","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"2ae748324856d57fbfbece1377d7d46eb6a681cb","unresolved":false,"context_lines":[{"line_number":293,"context_line":"      osh_params:"},{"line_number":294,"context_line":"        container_distro_name: ubuntu"},{"line_number":295,"context_line":"        container_distro_version: bionic"},{"line_number":296,"context_line":"        feature_gates: apparmor"},{"line_number":297,"context_line":"      gate_scripts:"},{"line_number":298,"context_line":"        - ./tools/deployment/common/000-install-packages.sh"},{"line_number":299,"context_line":"        - ./tools/deployment/common/005-deploy-k8s.sh"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"1fa4df85_14727d12","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":31},"in_reply_to":"1fa4df85_9fff6b00","updated":"2020-02-27 13:34:34.000000000","message":"yes, I guess we need to have it as the /tools/deployment/common/get-values-overrides.sh will get the values from apparmor.yaml under values_overrides from the charts and apparmor profile will be applied on the containers as well.","commit_id":"e73e7cc14d96dc5a6ba7bf1fbb3d07ba2dd5e77d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"f004e8feccd259943ee90e24afbcd5e6a2f3c53a","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        container_distro_version: bionic"},{"line_number":296,"context_line":"        feature_gates: apparmor"},{"line_number":297,"context_line":"      gate_scripts:"},{"line_number":298,"context_line":"        - ./tools/deployment/common/000-install-packages.sh"},{"line_number":299,"context_line":"        - ./tools/deployment/common/005-deploy-k8s.sh"},{"line_number":300,"context_line":"        - ./tools/deployment/common/metacontroller.sh"},{"line_number":301,"context_line":"        - ./tools/deployment/common/daemonjob-controller.sh"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"- job:"},{"line_number":304,"context_line":"    name: openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"1fa4df85_ccf07f94","line":301,"range":{"start_line":298,"start_character":0,"end_line":301,"end_character":59},"updated":"2020-03-04 20:49:28.000000000","message":"Could we add a gate script to exercise this?","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"584898905bdb96e651f3eb3fc132f467e1b5e849","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        container_distro_version: bionic"},{"line_number":296,"context_line":"        feature_gates: apparmor"},{"line_number":297,"context_line":"      gate_scripts:"},{"line_number":298,"context_line":"        - ./tools/deployment/common/000-install-packages.sh"},{"line_number":299,"context_line":"        - ./tools/deployment/common/005-deploy-k8s.sh"},{"line_number":300,"context_line":"        - ./tools/deployment/common/metacontroller.sh"},{"line_number":301,"context_line":"        - ./tools/deployment/common/daemonjob-controller.sh"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"- job:"},{"line_number":304,"context_line":"    name: openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"1fa4df85_2c5ef343","line":301,"range":{"start_line":298,"start_character":0,"end_line":301,"end_character":59},"in_reply_to":"1fa4df85_ccf07f94","updated":"2020-03-04 21:00:46.000000000","message":"https://review.opendev.org/#/c/705692/68/tools/deployment/common/daemonjob-controller.sh script has proper checkings with a demo daemonjob deployed.and metacontroller logs also says the same .","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"}],"zuul.d/project.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"f004e8feccd259943ee90e24afbcd5e6a2f3c53a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            voting: false"},{"line_number":45,"context_line":"        - openstack-helm-infra-local-storage:"},{"line_number":46,"context_line":"            voting: false"},{"line_number":47,"context_line":"        - openstack-helm-infra-metacontroller"},{"line_number":48,"context_line":"    gate:"},{"line_number":49,"context_line":"      jobs:"},{"line_number":50,"context_line":"        - openstack-helm-lint"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"1fa4df85_6c370b4f","line":47,"range":{"start_line":47,"start_character":10,"end_line":47,"end_character":45},"updated":"2020-03-04 20:49:28.000000000","message":"Make this non-voting for now, once we can confirm that it\u0027s being properly exercised in the gate, then we can look to make it a voting check.","commit_id":"759b2e7b84fd3779fd6fcc8d58ed1f9ca76e5bf4"}]}
