)]}'
{"nagios/templates/deployment.yaml":[{"author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"change_message_id":"322b910ce686ce1b39a1dc7e035848ebbdd82837","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                  name: {{ $nagiosUserSecret }}"},{"line_number":192,"context_line":"                  key: NAGIOSADMIN_PASS"},{"line_number":193,"context_line":"            {{- if not (empty .Values.pod.node_domain)}}"},{"line_number":194,"context_line":"            - name: NODE_DOMAIN "},{"line_number":195,"context_line":"              value: {{ .Values.pod.node_domain }}"},{"line_number":196,"context_line":"            {{- end}}"},{"line_number":197,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_e9d61ff2","line":194,"range":{"start_line":194,"start_character":31,"end_line":194,"end_character":32},"updated":"2020-02-24 20:38:31.000000000","message":"extra space","commit_id":"65e21cee86ee6a8464d4b887be27e19513a9b45a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5e56101d2be3ff39264dc72038595a64bf64645d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $nagiosUserSecret :\u003d .Values.secrets.nagios.admin }}"},{"line_number":21,"context_line":"{{- $nodeDomain :\u003d .Values.pod.env.NODE_DOMAIN}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"nagios\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll \"nagios\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_ecaf1a29","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":48},"updated":"2020-03-11 15:01:24.000000000","message":"This can be removed","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"change_message_id":"3076f624345ee8aee5c29ccf333ed93710277bed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $nagiosUserSecret :\u003d .Values.secrets.nagios.admin }}"},{"line_number":21,"context_line":"{{- $nodeDomain :\u003d .Values.pod.env.NODE_DOMAIN}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"nagios\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll \"nagios\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_51127f0b","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":48},"in_reply_to":"1fa4df85_ecaf1a29","updated":"2020-03-11 18:47:52.000000000","message":"Done","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5e56101d2be3ff39264dc72038595a64bf64645d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            - name: nagios-confd"},{"line_number":111,"context_line":"              mountPath: /opt/nagios/etc/conf.d"},{"line_number":112,"context_line":"          env:"},{"line_number":113,"context_line":"{{- if .Values.pod.domain }}"},{"line_number":114,"context_line":"{{ include \"helm-toolkit.utils.to_k8s_env_vars\" .Values.pod.env | indent 12 }}"},{"line_number":115,"context_line":"{{- end }}"},{"line_number":116,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_cca6de54","line":113,"range":{"start_line":113,"start_character":19,"end_line":113,"end_character":25},"updated":"2020-03-11 15:01:24.000000000","message":"this should be env instead of domain","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"change_message_id":"3076f624345ee8aee5c29ccf333ed93710277bed","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            - name: nagios-confd"},{"line_number":111,"context_line":"              mountPath: /opt/nagios/etc/conf.d"},{"line_number":112,"context_line":"          env:"},{"line_number":113,"context_line":"{{- if .Values.pod.domain }}"},{"line_number":114,"context_line":"{{ include \"helm-toolkit.utils.to_k8s_env_vars\" .Values.pod.env | indent 12 }}"},{"line_number":115,"context_line":"{{- end }}"},{"line_number":116,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_b10093ad","line":113,"range":{"start_line":113,"start_character":19,"end_line":113,"end_character":25},"in_reply_to":"1fa4df85_cca6de54","updated":"2020-03-11 18:47:52.000000000","message":"Done","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5e56101d2be3ff39264dc72038595a64bf64645d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            initialDelaySeconds: 60"},{"line_number":166,"context_line":"            periodSeconds: 30"},{"line_number":167,"context_line":"          env:"},{"line_number":168,"context_line":"{{- if .Values.pod.domain }}"},{"line_number":169,"context_line":"{{ include \"helm-toolkit.utils.to_k8s_env_vars\" .Values.pod.env | indent 12 }}"},{"line_number":170,"context_line":"{{- end }}"},{"line_number":171,"context_line":"            - name: SNMP_NOTIF_PRIMARY_TARGET_WITH_PORT"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_8c66a629","line":168,"range":{"start_line":168,"start_character":19,"end_line":168,"end_character":25},"updated":"2020-03-11 15:01:24.000000000","message":"ditto","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"change_message_id":"3076f624345ee8aee5c29ccf333ed93710277bed","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            initialDelaySeconds: 60"},{"line_number":166,"context_line":"            periodSeconds: 30"},{"line_number":167,"context_line":"          env:"},{"line_number":168,"context_line":"{{- if .Values.pod.domain }}"},{"line_number":169,"context_line":"{{ include \"helm-toolkit.utils.to_k8s_env_vars\" .Values.pod.env | indent 12 }}"},{"line_number":170,"context_line":"{{- end }}"},{"line_number":171,"context_line":"            - name: SNMP_NOTIF_PRIMARY_TARGET_WITH_PORT"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_d1fd0fb2","line":168,"range":{"start_line":168,"start_character":19,"end_line":168,"end_character":25},"in_reply_to":"1fa4df85_8c66a629","updated":"2020-03-11 18:47:52.000000000","message":"Done","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"de161e1b5bd6be297bdaa191411a7a20118a9890","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $nagiosUserSecret :\u003d .Values.secrets.nagios.admin }}"},{"line_number":21,"context_line":"#{{- $nodeDomain :\u003d .Values.pod.env.NODE_DOMAIN }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"nagios\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll \"nagios\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1fa4df85_5f5c7cec","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"updated":"2020-03-17 13:22:13.000000000","message":"where is this used?","commit_id":"8abbd0d6e54c9d7759ac43ffa72fcb4e6e971b90"}],"nagios/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ba3ba4d1467aaa76bb56f8071f1d854c370c6bbd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          endpoint: internal"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"dns:"},{"line_number":65,"context_line":"  node_domain: "},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"secrets:"},{"line_number":68,"context_line":"  nagios:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_30356adb","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":15},"updated":"2020-02-25 14:25:30.000000000","message":"ws","commit_id":"61e19bbf818a14323781f6a571352233d01f9e10"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"6d8188bd83a2d6e432ca1db916bc3a81d6cd8188","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        - service: nagios"},{"line_number":62,"context_line":"          endpoint: internal"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"dns: {}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"secrets:"},{"line_number":67,"context_line":"  nagios:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1fa4df85_fa483fb3","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":7},"updated":"2020-03-10 15:35:02.000000000","message":"I think it would be better to add an env key under the pod: section and define this under that. Then you could use this HTK in the deployment.yaml\n\nThis would be more in line with other charts in OSH and make introducing variables easier in the future.\n\nhttps://opendev.org/openstack/openstack-helm-infra/src/branch/master/helm-toolkit/templates/utils/_to_k8s_env_vars.tpl","commit_id":"03142ca94c2a74867ab8dcf3307761d1776ae353"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"72730e8f2f3d91db52e4768e77d0bff1c9ced88f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        - service: nagios"},{"line_number":62,"context_line":"          endpoint: internal"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"dns: {}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"secrets:"},{"line_number":67,"context_line":"  nagios:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1fa4df85_cb46d7c0","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":7},"in_reply_to":"1fa4df85_fa483fb3","updated":"2020-03-10 17:41:08.000000000","message":"I think that\u0027s a good idea. I\u0027d say we should make the default value empty, along with a comment that explains the purpose of that environment variable with a link to the corresponding logic in the nagios image that shows how it\u0027s consumed. This will help provide visibility into the purpose behind the environment variable instead of it just seeming like an arbitrary entry under the pod.env values tree","commit_id":"03142ca94c2a74867ab8dcf3307761d1776ae353"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5e56101d2be3ff39264dc72038595a64bf64645d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"  # the domain name. Functionality has been added in"},{"line_number":243,"context_line":"  # plugins to append the domain to the host name in"},{"line_number":244,"context_line":"  # the nagios dashboard"},{"line_number":245,"context_line":"  env:"},{"line_number":246,"context_line":"    NODE_DOMAIN: test.domain.web"},{"line_number":247,"context_line":"  replicas:"},{"line_number":248,"context_line":"    nagios: 1"},{"line_number":249,"context_line":"  resources:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_cc29fe9b","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":32},"updated":"2020-03-11 15:01:24.000000000","message":"we should comment both these out for reference, as we don\u0027t want this enabled by default. However, we can pass these overrides in as part of the nagios deployment scripts to validate this functionality works as intended","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"},{"author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"change_message_id":"3076f624345ee8aee5c29ccf333ed93710277bed","unresolved":false,"context_lines":[{"line_number":242,"context_line":"  # the domain name. Functionality has been added in"},{"line_number":243,"context_line":"  # plugins to append the domain to the host name in"},{"line_number":244,"context_line":"  # the nagios dashboard"},{"line_number":245,"context_line":"  env:"},{"line_number":246,"context_line":"    NODE_DOMAIN: test.domain.web"},{"line_number":247,"context_line":"  replicas:"},{"line_number":248,"context_line":"    nagios: 1"},{"line_number":249,"context_line":"  resources:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_111de70e","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":32},"in_reply_to":"1fa4df85_cc29fe9b","updated":"2020-03-11 18:47:52.000000000","message":"sounds good, left them in initially to make sure it didn\u0027t cause an error when something was added","commit_id":"c2f70fc2f03f160f85a7552be1f5e778f3a5c65d"}]}