)]}'
{"id":"openstack%2Fopenstack-helm-infra~709114","triplet_id":"openstack%2Fopenstack-helm-infra~master~I2404d698bcf6c1d63333b7e301e41c4e7a1a9f02","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"I2404d698bcf6c1d63333b7e301e41c4e7a1a9f02","subject":"Bring in apache wsgi/security configs","status":"ABANDONED","created":"2020-02-21 11:43:38.000000000","updated":"2021-04-15 18:53:11.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a62cc864a6c9c588985141826967ee36e2a58f71","_number":709114,"virtual_id_number":709114,"owner":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"date":"2020-03-18 07:28:01.000000000","_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-02-21 12:42:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":-1,"date":"2020-03-17 15:24:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2020-02-27 12:58:18.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"date":"2020-02-21 15:25:29.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"date":"2020-02-21 11:47:44.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"date":"2020-03-18 15:54:16.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"date":"2020-02-27 12:58:31.000000000","_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"date":"2020-02-27 12:57:45.000000000","_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"date":"2020-02-21 15:26:00.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-02-21 11:48:09.000000000","_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-21 11:47:44.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2020-02-21 11:48:09.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2020-02-21 12:42:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-02-21 15:25:29.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-02-21 15:26:00.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-02-27 12:57:45.000000000","updated_by":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"reviewer":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"state":"REVIEWER"},{"updated":"2020-02-27 12:58:18.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2020-02-27 12:58:31.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2020-03-17 15:24:19.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2020-03-18 15:54:16.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"}],"messages":[{"id":"7fb8c828d5050bebd1b7e28258566d51174270ae","author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"date":"2020-02-21 11:43:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4b443fc28d27da8c9c92e6eba3df6e9f64b50cc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-21 12:42:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c42f1dcaf3a414a9e46ee6212021e7d : SUCCESS in 4m 46s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e208045dd6be4e0381021a8ca7a3fe89 : SUCCESS in 2m 55s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/852f4279de324ec7a6cc028ea4f1faee : SUCCESS in 50m 22s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/c7f5cbd815844e02a42f40d6da76e913 : SUCCESS in 36m 32s\n- openstack-helm-infra-federated-monitoring https://zuul.opendev.org/t/openstack/build/ac1668f32c324293b1f3740f773232c0 : FAILURE in 34m 47s (non-voting)\n- openstack-helm-infra-kafka https://zuul.opendev.org/t/openstack/build/ece70e7a91a84e6db8f727c0ad77774d : SUCCESS in 35m 38s (non-voting)\n- openstack-helm-infra-aio-network-policy https://zuul.opendev.org/t/openstack/build/443efdaff3ff4baf8c2e6c03fd7425db : FAILURE in 41m 48s (non-voting)\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/a852bfacc6944d4291ba571045b1e8ce : SUCCESS in 53m 04s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/baa27da4bb4c4a188bee54d23928b59c : SUCCESS in 15m 30s (non-voting)\n- openstack-helm-infra-aio-podsecuritypolicy https://zuul.opendev.org/t/openstack/build/9249f9c2336c474ba453440e0f8e8a9d : FAILURE in 16m 05s (non-voting)\n- openstack-helm-infra-apparmor https://zuul.opendev.org/t/openstack/build/4bb1ea8cb3a04be8834a2769559872fb : FAILURE in 54m 39s (non-voting)\n- openstack-helm-infra-local-storage https://zuul.opendev.org/t/openstack/build/1304b38b7ce74e1d9338c1090b6c5f9f : SUCCESS in 28m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"772ff697688a542b2678e32c34cdc96d413a3196","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-02-21 15:25:29.000000000","message":"Patch Set 1:\n\nHow are these being used? Also, what if someone wants to override it (e.g. they need some new security header) do they need to build a new HTK?","accounts_in_message":[],"_revision_number":1},{"id":"4c12e4f9890ad018ea6a5ceb57f32743eaa1bbe3","author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"date":"2020-02-26 09:08:46.000000000","message":"Patch Set 1:\n\n\u003e How are these being used? Also, what if someone wants to override\n \u003e it (e.g. they need some new security header) do they need to build\n \u003e a new HTK?\n\nThe example of usage could be taken from https://review.opendev.org/709988\nOverriding will be as usual (template in values).","accounts_in_message":[],"_revision_number":1},{"id":"26d3c5e2176f7373f5a08217168aee7893c1bfa2","author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"date":"2020-03-06 08:10:41.000000000","message":"Patch Set 1:\n\nready to get merged","accounts_in_message":[],"_revision_number":1},{"id":"053f3cebbb58ca0dbf1ee39f180c706ff94a0543","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2020-03-17 15:24:19.000000000","message":"Patch Set 1: Code-Review-1\n\nis there a reason this cannot be done via similar methods for what has been done for keystone etc? I\u0027m somewhat concerned re the opinionation that this introduces to apache config.","accounts_in_message":[],"_revision_number":1},{"id":"d3bc6c6965e2b9c24a1e70fadf6c2ddcee7cb891","author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"date":"2020-03-18 07:28:01.000000000","message":"Patch Set 1:\n\n\u003e is there a reason this cannot be done via similar methods for what\n \u003e has been done for keystone etc? I\u0027m somewhat concerned re the\n \u003e opinionation that this introduces to apache config.\n\nIt\u0027s just intended to re-use common code in other services since this configs will be the same most of the time.","accounts_in_message":[],"_revision_number":1},{"id":"a63992a05ec08c2418776c47bac971715555b0fe","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-03-18 15:54:16.000000000","message":"Patch Set 1:\n\nIt seems like the OSH Keystone and Cinder charts handle their httpd configuration a bit differently than how I\u0027m used to seeing it done in OSH-Infra, but I think there are advantages to defining this directly in the values.yaml file for now.\n\nDo we expect many new charts to be added to OSH which could take advantage of this htk snippet, or would this mainly be backported to existing charts?\n\nThe configuration will be more explicit, and easier to override, if it is defined directly in values.yaml rather than by htk. I like that you provided some parameters to make it configurable, but the usage of the template is a bit hard to read - The only way to interpret ( tuple \"Prod\" \"Off\" \"Off\" ) is to first read the htk file. Do these parameters provide all the configuration needed for this snippet to be dropped in to existing charts?\n\nOne last observation: The bulk of the text in this configuration is comments. If brevity is desired these could be trimmed in my opinion.","accounts_in_message":[],"_revision_number":1},{"id":"a62cc864a6c9c588985141826967ee36e2a58f71","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-04-15 18:53:11.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"78c212d8c9255d895d8d15cf57e32016ef13e346","revisions":{"78c212d8c9255d895d8d15cf57e32016ef13e346":{"kind":"REWORK","_number":1,"created":"2020-02-21 11:43:38.000000000","uploader":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"ref":"refs/changes/14/709114/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/14/709114/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/709114/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/709114/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/709114/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/14/709114/1"}}},"commit":{"parents":[{"commit":"e1b6de921887e644981078e78a1e04350e0c3ccf","subject":"Merge \"[ceph-client] Enable Nautilus PG autoscaler module\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/e1b6de921887e644981078e78a1e04350e0c3ccf"}]}],"author":{"name":"Michael Polenchuk","email":"mpolenchuk@mirantis.com","date":"2020-02-21 11:29:43.000000000","tz":240},"committer":{"name":"Michael Polenchuk","email":"mpolenchuk@mirantis.com","date":"2020-02-21 11:43:00.000000000","tz":240},"subject":"Bring in apache wsgi/security configs","message":"Bring in apache wsgi/security configs\n\nChange-Id: I2404d698bcf6c1d63333b7e301e41c4e7a1a9f02\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/78c212d8c9255d895d8d15cf57e32016ef13e346"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/78c212d8c9255d895d8d15cf57e32016ef13e346"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}