)]}'
{"memcached/templates/service.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"36f81a4fd276a3755e8a238078ef9cd7bf8b38cc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: {{ tuple \"oslo_cache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  clusterIP: None"},{"line_number":26,"context_line":"  sessionAffinity: ClientIP"},{"line_number":27,"context_line":"  ports:"},{"line_number":28,"context_line":"    - port: {{ tuple \"oslo_cache\" \"internal\" \"memcache\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_95822252","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":17},"updated":"2020-03-11 19:29:43.000000000","message":"should this be driven off the values.yaml - what if someone doesn\u0027t want this to be headless?","commit_id":"60eb4bfe0c09a2f23fcbbbdafcba530bf039fb09"}],"memcached/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7b7a6e86fdc446f6863a3e63895ada0cdb0b8725","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    port:"},{"line_number":69,"context_line":"      memcache:"},{"line_number":70,"context_line":"        default: 11211"},{"line_number":71,"context_line":"    ip:"},{"line_number":72,"context_line":"      ingress: None"},{"line_number":73,"context_line":"  prometheus_memcached_exporter:"},{"line_number":74,"context_line":"    namespace: null"},{"line_number":75,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_ae293b37","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":19},"updated":"2020-03-09 19:01:07.000000000","message":"what uses this ip: key? I rendered the template with and without this change and diff the rendered the template and they are same.","commit_id":"b6531f66bb123188e19a71b5f50252fd99543f52"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"687b81dbd57f017361bfca35f60fdef1a86e1b6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fa4df85_b47bc089","updated":"2020-03-10 13:27:42.000000000","message":"I do not think you intended to delete this whole file.","commit_id":"cf37b8adf4af62874bfb25cf47e85c0ed6a18684"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"77f62eb6f888ce9392c0a3d673e36c0072512897","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    port:"},{"line_number":69,"context_line":"      memcache:"},{"line_number":70,"context_line":"        default: 11211"},{"line_number":71,"context_line":"    ip:"},{"line_number":72,"context_line":"      # To set headless service, set ingress to None"},{"line_number":73,"context_line":"      # To set service ClusetrIP to a specific IP, set ingress to the IP"},{"line_number":74,"context_line":"      # To allocate service ClusetrIP automatically, remove ingress field."},{"line_number":75,"context_line":"      ingress: None"},{"line_number":76,"context_line":"  prometheus_memcached_exporter:"},{"line_number":77,"context_line":"    namespace: null"},{"line_number":78,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_f58d96d3","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":19},"updated":"2020-03-11 20:00:23.000000000","message":"This is a global comments... so now that we have add \"ingress: None\" to the values.yaml, how is anyone suppose to \"remove\" this field via override?  Also we are changing the default behavior to headless, is the community ok with this change?","commit_id":"60eb4bfe0c09a2f23fcbbbdafcba530bf039fb09"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"140a5930dd0a7d97422f79bf3ba540a860711e3a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        default: 11211"},{"line_number":71,"context_line":"    ip:"},{"line_number":72,"context_line":"      # To set headless service, set ingress to None"},{"line_number":73,"context_line":"      # To set service ClusetrIP to a specific IP, set ingress to the IP"},{"line_number":74,"context_line":"      ingress: None"},{"line_number":75,"context_line":"  prometheus_memcached_exporter:"},{"line_number":76,"context_line":"    namespace: null"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_2e77dda2","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":32},"updated":"2020-03-20 04:10:28.000000000","message":"ClusterIP","commit_id":"00e0261280c1ff3c4f2690fa33b6caac20f70433"}]}