)]}'
{"ceph-client/templates/bin/pool/_init.sh.tpl":[{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"68a4265c61b2146cb7f3cb66acedea66fe251939","unresolved":false,"context_lines":[{"line_number":283,"context_line":"{{- end }}"},{"line_number":284,"context_line":"{{- end }}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"if [[ -z \"$(ceph osd versions | grep ceph\\ version | grep -v nautilus)\" ]]; then"},{"line_number":287,"context_line":"  enable_or_disable_autoscaling"},{"line_number":288,"context_line":"fi"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":12,"id":"3f65232a_7c84115f","line":286,"updated":"2020-10-26 14:56:25.000000000","message":"I would suggest to change the version check by adding the following function:\n\nfunction version_check {\nfor v in $(ceph versions | awk \u0027BEGIN { FS \u003d \"[ \\t\\n.]+\" } /version/ {print $4}\u0027); do\n    if [[ $v -lt 14 ]]; then\n    false; return\n  fi\ndone\ntrue\n}\n\nand then (line 286):\nif [[ version_check ]]; then\n\nThis function gives us a possibility to reuse this code for future ceph releases (14+) and it also checks all major releases of all daemons which looks more reliable. In theory we could have different versions of OSDs and/or different versions of other daemons.","commit_id":"78e63c9bc40c78cc79425fdc72a5ba60709458db"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1d44047a895d1053bfa130883df3239442692bfa","unresolved":true,"context_lines":[{"line_number":125,"context_line":"function version_check {"},{"line_number":126,"context_line":"  for v in $(ceph versions | awk \u0027BEGIN { FS \u003d \"[ \\t\\n.]+\" } /version/ {print $4}\u0027); do"},{"line_number":127,"context_line":"    if [[ $v -lt 14 ]]; then"},{"line_number":128,"context_line":"      false; return"},{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":"  done"},{"line_number":131,"context_line":"  true"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"1a6b7d27_22f8b529","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":19},"updated":"2020-11-24 00:09:18.000000000","message":"what does this do? return false?","commit_id":"82044322a823e13772f28cd02cc18269ede8ed14"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"0ca1e88ed17e4b069e96dd921d8d7c680f38dcd7","unresolved":true,"context_lines":[{"line_number":125,"context_line":"function version_check {"},{"line_number":126,"context_line":"  for v in $(ceph versions | awk \u0027BEGIN { FS \u003d \"[ \\t\\n.]+\" } /version/ {print $4}\u0027); do"},{"line_number":127,"context_line":"    if [[ $v -lt 14 ]]; then"},{"line_number":128,"context_line":"      false; return"},{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":"  done"},{"line_number":131,"context_line":"  true"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"97f0bd6c_8680fa1a","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":19},"in_reply_to":"1a6b7d27_22f8b529","updated":"2020-11-30 16:32:22.000000000","message":"Yes, it returns false if at least one of ceph\u0027s daemons is pre-Nautilus (major release \u003c 14). Otherwise it returns true.","commit_id":"82044322a823e13772f28cd02cc18269ede8ed14"}]}