)]}'
{"ceph-client/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"75ae08a580d9230dc8abf87246365875a5fd78b4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_b96b0183","line":161,"range":{"start_line":161,"start_character":36,"end_line":161,"end_character":42},"updated":"2020-03-30 16:31:35.000000000","message":"I believe this can just be true, or you can just say\nif [[ \"${ENABLE_AUTOSCALER}\" ]]","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8966ca6adb14563bcb63c422787865536752fa5f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_b9e4a13d","line":161,"range":{"start_line":161,"start_character":7,"end_line":161,"end_character":9},"updated":"2020-03-30 16:24:43.000000000","message":"why is this block using [[ ]] and []? should they be not consistent?","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d758bfcd77bcb149c554ae2903e0b9107bdc066e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_2878388e","line":161,"range":{"start_line":161,"start_character":36,"end_line":161,"end_character":42},"in_reply_to":"df33271e_b96b0183","updated":"2020-03-30 18:00:30.000000000","message":"I was incorrect, either drop the quotes and brackets, or keep it as is.","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8966ca6adb14563bcb63c422787865536752fa5f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"},{"line_number":165,"context_line":"      fi"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_39f1b102","line":162,"range":{"start_line":162,"start_character":43,"end_line":162,"end_character":45},"updated":"2020-03-30 16:24:43.000000000","message":"space","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8966ca6adb14563bcb63c422787865536752fa5f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"},{"line_number":165,"context_line":"      fi"},{"line_number":166,"context_line":"    fi"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_d9d8857c","line":163,"range":{"start_line":163,"start_character":6,"end_line":163,"end_character":7},"updated":"2020-03-30 16:24:43.000000000","message":"should this be 2 space indent like elsewhere in the file?","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"75ae08a580d9230dc8abf87246365875a5fd78b4","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [ \"${pg_autoscale_mode}\" !\u003d \"on\" ];then"},{"line_number":163,"context_line":"       echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"       exit 1"},{"line_number":165,"context_line":"      fi"},{"line_number":166,"context_line":"    fi"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"df33271e_f92f493c","line":163,"range":{"start_line":163,"start_character":6,"end_line":163,"end_character":7},"in_reply_to":"df33271e_d9d8857c","updated":"2020-03-30 16:31:35.000000000","message":"yes","commit_id":"7ff76671f895c8e3f96e636c33093054ed0dff33"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"bc9d60e1660a78dab5a695c83823955c29452e0f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" ]]; then"},{"line_number":162,"context_line":"      if [[ \"${pg_autoscale_mode}\" !\u003d \"on\" ]]; then"},{"line_number":163,"context_line":"        echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"        exit 1"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df33271e_740fc036","line":161,"range":{"start_line":161,"start_character":10,"end_line":161,"end_character":32},"updated":"2020-03-30 17:57:05.000000000","message":"No quotes here for a boolean check. If this is in fact a string, then \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" is required.","commit_id":"a64a39bbd6392fab2f5bc6ece0c65261c37e0316"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d758bfcd77bcb149c554ae2903e0b9107bdc066e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" ]]; then"},{"line_number":162,"context_line":"      if [[ \"${pg_autoscale_mode}\" !\u003d \"on\" ]]; then"},{"line_number":163,"context_line":"        echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"        exit 1"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df33271e_4873fcb1","line":161,"range":{"start_line":161,"start_character":10,"end_line":161,"end_character":32},"in_reply_to":"df33271e_740fc036","updated":"2020-03-30 18:00:30.000000000","message":"Revert it back to \u003d\u003d \"true\" as it was before, that should work fine.","commit_id":"a64a39bbd6392fab2f5bc6ece0c65261c37e0316"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"3d0c2e179e0f12428baed883390350a0bae739cc","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    crush_rule\u003d$(echo ${pool_obj} | jq -r .crush_rule)"},{"line_number":159,"context_line":"    name\u003d$(echo ${pool_obj} | jq -r .pool_name)"},{"line_number":160,"context_line":"    pg_autoscale_mode\u003d$(echo ${pool_obj} | jq -r .pg_autoscale_mode)"},{"line_number":161,"context_line":"    if [[ \"${ENABLE_AUTOSCALER}\" \u003d\u003d \"true\" ]]; then"},{"line_number":162,"context_line":"      if [[ \"${pg_autoscale_mode}\" !\u003d \"on\" ]]; then"},{"line_number":163,"context_line":"        echo \"pg autoscaler not enabled on ${name} pool\""},{"line_number":164,"context_line":"        exit 1"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"df33271e_3ea872d9","line":161,"range":{"start_line":161,"start_character":10,"end_line":161,"end_character":42},"updated":"2020-03-30 19:56:18.000000000","message":"Boolean strings! :-)","commit_id":"1a0ca47b510955c9d9b8fa1c68582851bff52cfe"}],"ceph-client/templates/bin/pool/_init.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"bc9d60e1660a78dab5a695c83823955c29452e0f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function enable_autoscaling () {"},{"line_number":80,"context_line":"  if [[ \"${ENABLE_AUTOSCALER}\" ]]; then"},{"line_number":81,"context_line":"    ceph mgr module enable pg_autoscaler"},{"line_number":82,"context_line":"    ceph config set global osd_pool_default_pg_autoscale_mode on"},{"line_number":83,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df33271e_9402440a","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":30},"updated":"2020-03-30 17:57:05.000000000","message":"Yes, like Tin said. No quotes here for a boolean check.","commit_id":"a64a39bbd6392fab2f5bc6ece0c65261c37e0316"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b382153361d69f0bd18601c031e81a1ae1308add","unresolved":false,"context_lines":[{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function enable_autoscaling () {"},{"line_number":80,"context_line":"  if [[ \"${ENABLE_AUTOSCALER}\" ]]; then"},{"line_number":81,"context_line":"    ceph mgr module enable pg_autoscaler"},{"line_number":82,"context_line":"    ceph config set global osd_pool_default_pg_autoscale_mode on"},{"line_number":83,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df33271e_94f88449","line":80,"range":{"start_line":80,"start_character":9,"end_line":80,"end_character":31},"updated":"2020-03-30 17:42:45.000000000","message":"this now is misleading it turns into a -z check. You can set ENABLE_AUTOSCALER to false, and it still execute this block.\n\nSee http://paste.openstack.org/show/791353/","commit_id":"a64a39bbd6392fab2f5bc6ece0c65261c37e0316"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d758bfcd77bcb149c554ae2903e0b9107bdc066e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function enable_autoscaling () {"},{"line_number":80,"context_line":"  if [[ \"${ENABLE_AUTOSCALER}\" ]]; then"},{"line_number":81,"context_line":"    ceph mgr module enable pg_autoscaler"},{"line_number":82,"context_line":"    ceph config set global osd_pool_default_pg_autoscale_mode on"},{"line_number":83,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df33271e_e86130d5","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":30},"in_reply_to":"df33271e_9402440a","updated":"2020-03-30 18:00:30.000000000","message":"Revert this back to \u003d\u003d \"true\"","commit_id":"a64a39bbd6392fab2f5bc6ece0c65261c37e0316"}]}