)]}'
{"mariadb/values.yaml":[{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"f19c90cf17c95bea4ebdf3591abaa63dfbdb0382","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      pod:"},{"line_number":82,"context_line":"        runAsUser: 65534"},{"line_number":83,"context_line":"      container:"},{"line_number":84,"context_line":"        haproxy:"},{"line_number":85,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":86,"context_line":"    prometheus_mysql_exporter:"},{"line_number":87,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_5e709f08","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":16},"updated":"2020-04-29 21:44:49.000000000","message":"Do we need to set \"runAsUser: 0\" here?","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"f01a90a148dab80ef4663d1cd3068c9d7ad66788","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      pod:"},{"line_number":82,"context_line":"        runAsUser: 65534"},{"line_number":83,"context_line":"      container:"},{"line_number":84,"context_line":"        haproxy:"},{"line_number":85,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":86,"context_line":"    prometheus_mysql_exporter:"},{"line_number":87,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_64498e5e","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":16},"in_reply_to":"1f493fa4_5e709f08","updated":"2020-04-29 23:10:29.000000000","message":"no","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"b132485d0334b94b584846d48652925c731c0435","unresolved":false,"context_lines":[{"line_number":259,"context_line":"conf:"},{"line_number":260,"context_line":"  tests:"},{"line_number":261,"context_line":"    # This may either be:"},{"line_number":262,"context_line":"    # * internal: which will hit the endpoint exposed by the ingress controller"},{"line_number":263,"context_line":"    # * direct: which will hit the backends directly via a k8s service ip"},{"line_number":264,"context_line":"    # Note, deadlocks and failure are to be expected with concurrency if"},{"line_number":265,"context_line":"    # hitting the `direct` endpoint."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_a9d40f49","line":262,"range":{"start_line":262,"start_character":0,"end_line":262,"end_character":79},"updated":"2020-04-29 22:18:17.000000000","message":"This will have to change. Do we need to make any changes to this test section?","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"f01a90a148dab80ef4663d1cd3068c9d7ad66788","unresolved":false,"context_lines":[{"line_number":259,"context_line":"conf:"},{"line_number":260,"context_line":"  tests:"},{"line_number":261,"context_line":"    # This may either be:"},{"line_number":262,"context_line":"    # * internal: which will hit the endpoint exposed by the ingress controller"},{"line_number":263,"context_line":"    # * direct: which will hit the backends directly via a k8s service ip"},{"line_number":264,"context_line":"    # Note, deadlocks and failure are to be expected with concurrency if"},{"line_number":265,"context_line":"    # hitting the `direct` endpoint."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_249ae6b7","line":262,"range":{"start_line":262,"start_character":0,"end_line":262,"end_character":79},"in_reply_to":"1f493fa4_a9d40f49","updated":"2020-04-29 23:10:29.000000000","message":"I think we need update this line and replace \"ingress controller\" by \"HAProxy\".","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"b132485d0334b94b584846d48652925c731c0435","unresolved":false,"context_lines":[{"line_number":500,"context_line":"      default: mariadb"},{"line_number":501,"context_line":"      direct: mariadb-server"},{"line_number":502,"context_line":"      discovery: mariadb-discovery"},{"line_number":503,"context_line":"      error_pages: mariadb-ingress-error-pages"},{"line_number":504,"context_line":"    host_fqdn_override:"},{"line_number":505,"context_line":"      default: null"},{"line_number":506,"context_line":"    path: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_e9ca979e","line":503,"updated":"2020-04-29 22:18:17.000000000","message":"This is not needed anymore.","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"f01a90a148dab80ef4663d1cd3068c9d7ad66788","unresolved":false,"context_lines":[{"line_number":500,"context_line":"      default: mariadb"},{"line_number":501,"context_line":"      direct: mariadb-server"},{"line_number":502,"context_line":"      discovery: mariadb-discovery"},{"line_number":503,"context_line":"      error_pages: mariadb-ingress-error-pages"},{"line_number":504,"context_line":"    host_fqdn_override:"},{"line_number":505,"context_line":"      default: null"},{"line_number":506,"context_line":"    path: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_a4eb9610","line":503,"in_reply_to":"1f493fa4_e9ca979e","updated":"2020-04-29 23:10:29.000000000","message":"correct. I\u0027ll remove.","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"86e2076d076d7b5fbed3df8404832de2bf108600","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    frontend mariadb-fe"},{"line_number":409,"context_line":"      mode tcp"},{"line_number":410,"context_line":"      bind *:{{ tuple \"oslo_db\" \"direct\" \"mysql\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":411,"context_line":"      default_backend mariadb-be"},{"line_number":412,"context_line":"    backend mariadb-be"},{"line_number":413,"context_line":"      mode tcp"},{"line_number":414,"context_line":"      option tcp-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_3f6c4407","line":411,"updated":"2020-05-06 07:23:00.000000000","message":"it seems default config gives the same balancing abilities as kubernetes service. Why not just point openstack services directly to kubernetes service?","commit_id":"069d30f6e7c81a9fa9ee0bdb319524d145b03b71"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"b79e91440628cc2c7d4d391308d3ac64e3839fd9","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    frontend mariadb-fe"},{"line_number":409,"context_line":"      mode tcp"},{"line_number":410,"context_line":"      bind *:{{ tuple \"oslo_db\" \"direct\" \"mysql\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":411,"context_line":"      default_backend mariadb-be"},{"line_number":412,"context_line":"    backend mariadb-be"},{"line_number":413,"context_line":"      mode tcp"},{"line_number":414,"context_line":"      option tcp-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_ffd65253","line":411,"in_reply_to":"1f493fa4_3f6c4407","updated":"2020-05-06 15:29:11.000000000","message":"In fact we are using only the first server in a list (#425). Please take a look at the lines #420-426.","commit_id":"069d30f6e7c81a9fa9ee0bdb319524d145b03b71"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"18367605e0d28f693864a4860262c4a27acc662e","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    frontend mariadb-fe"},{"line_number":409,"context_line":"      mode tcp"},{"line_number":410,"context_line":"      bind *:{{ tuple \"oslo_db\" \"direct\" \"mysql\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":411,"context_line":"      default_backend mariadb-be"},{"line_number":412,"context_line":"    backend mariadb-be"},{"line_number":413,"context_line":"      mode tcp"},{"line_number":414,"context_line":"      option tcp-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_c7357fdd","line":411,"in_reply_to":"1f493fa4_ffd65253","updated":"2020-05-07 11:14:12.000000000","message":"the same behaviour might be achived by labeling first pod with specific label and targeting k8s service to it? Do you really need this overhead with haproxy?","commit_id":"069d30f6e7c81a9fa9ee0bdb319524d145b03b71"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"738dea263f996c003bb8ff769c274c944db1a739","unresolved":false,"context_lines":[{"line_number":411,"context_line":"      default_backend mariadb-be"},{"line_number":412,"context_line":"    backend mariadb-be"},{"line_number":413,"context_line":"      mode tcp"},{"line_number":414,"context_line":"      option tcp-check"},{"line_number":415,"context_line":"      default-server resolvers cluster-dns init-addr none"},{"line_number":416,"context_line":"      {{- $server_name :\u003d tuple \"oslo_db\" \"direct\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":417,"context_line":"      {{- $endpoint_name :\u003d tuple \"oslo_db\" \"discovery\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f493fa4_6f227003","line":414,"range":{"start_line":414,"start_character":6,"end_line":414,"end_character":22},"updated":"2020-05-08 07:24:55.000000000","message":"This check will not allow to exclude backend when the mariadb is not ready yet but port 3306 is opened, please check current readiness probe.\n\nhttps://github.com/openstack/openstack-helm-infra/blob/master/mariadb/templates/bin/_readiness.sh.tpl#L36","commit_id":"21f46149d8a17925b723f0f1a30fe30c189ca851"}],"mariadb/values_overrides/apparmor.yaml":[{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"f19c90cf17c95bea4ebdf3591abaa63dfbdb0382","unresolved":false,"context_lines":[{"line_number":1,"context_line":"pod:"},{"line_number":2,"context_line":"  mandatory_access_control:"},{"line_number":3,"context_line":"    type: apparmor"},{"line_number":4,"context_line":"    mariadb-ingress-error-pages:"},{"line_number":5,"context_line":"      ingress-error-pages: runtime/default"},{"line_number":6,"context_line":"    mariadb-ingress:"},{"line_number":7,"context_line":"      ingress: runtime/default"},{"line_number":8,"context_line":"    mariadb-haproxy:"},{"line_number":9,"context_line":"      haproxy: runtime/default"},{"line_number":10,"context_line":"    mariadb-server:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_fe97eb38","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":30},"updated":"2020-04-29 21:44:49.000000000","message":"Shall we remove these lines","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"f01a90a148dab80ef4663d1cd3068c9d7ad66788","unresolved":false,"context_lines":[{"line_number":1,"context_line":"pod:"},{"line_number":2,"context_line":"  mandatory_access_control:"},{"line_number":3,"context_line":"    type: apparmor"},{"line_number":4,"context_line":"    mariadb-ingress-error-pages:"},{"line_number":5,"context_line":"      ingress-error-pages: runtime/default"},{"line_number":6,"context_line":"    mariadb-ingress:"},{"line_number":7,"context_line":"      ingress: runtime/default"},{"line_number":8,"context_line":"    mariadb-haproxy:"},{"line_number":9,"context_line":"      haproxy: runtime/default"},{"line_number":10,"context_line":"    mariadb-server:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_c4f4e2f3","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"1f493fa4_fe97eb38","updated":"2020-04-29 23:10:29.000000000","message":"yes. I\u0027ll remove","commit_id":"0be2a4d6ebf41012a54ce61639b5c30a6f1c01fb"}]}