)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"46715ad3e21ec2ee0d92d85b454da47f6560ad6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Process Exporter: Parameter fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Helm is treating \u0027true\u0027 as boolean, changing in to string."},{"line_number":10,"context_line":"`"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cbe420a47e5361fd685d84c956d2521b6c6f44f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4c43b2_5bb94378","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":58},"updated":"2020-04-16 23:11:34.000000000","message":"we should be fine with boolean using \u0027hasKey\u0027","commit_id":"61db471f23ee3f92e8dd7f0bbe4afe22db2ca633"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"33b4faf9801ca6a4cceca0401135aee48334c3dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Lawrence \u003cjl401j@us.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-16 23:14:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Process Exporter: Parameter fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing the conditional check"},{"line_number":10,"context_line":"`"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cbe420a47e5361fd685d84c956d2521b6c6f44f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4c43b2_deca616b","line":9,"range":{"start_line":7,"start_character":1,"end_line":9,"end_character":28},"updated":"2020-04-16 23:59:32.000000000","message":"means?","commit_id":"c32617abd95d36b2bd7f0a679b28e534e22f631a"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"33b4faf9801ca6a4cceca0401135aee48334c3dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Process Exporter: Parameter fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing the conditional check"},{"line_number":10,"context_line":"`"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cbe420a47e5361fd685d84c956d2521b6c6f44f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4c43b2_7ecb4d71","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2020-04-16 23:59:32.000000000","message":"?","commit_id":"c32617abd95d36b2bd7f0a679b28e534e22f631a"}],"prometheus-process-exporter/templates/daemonset.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"578174bf6eca4ee030cc6404535d08081f25b338","unresolved":false,"context_lines":[{"line_number":72,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.process_exporter | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":73,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"metrics\" \"container\" \"process_exporter\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":74,"context_line":"          args:"},{"line_number":75,"context_line":"{{- if .Values.conf.children.enabled }}"},{"line_number":76,"context_line":"            - -children\u003d{{ toString .Values.conf.children }}"},{"line_number":77,"context_line":"{{- end }}"},{"line_number":78,"context_line":"            - -procnames"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_7b6fdf91","line":75,"range":{"start_line":75,"start_character":28,"end_line":75,"end_character":36},"updated":"2020-04-16 22:20:42.000000000","message":"i think enabled here is a valid key\nshould not we use something like\n {{- if hasKey .Values.conf \"children\" }}","commit_id":"9987089b9c9f6f0441ec2c1ecadb42565f883880"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"578174bf6eca4ee030cc6404535d08081f25b338","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"metrics\" \"container\" \"process_exporter\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":74,"context_line":"          args:"},{"line_number":75,"context_line":"{{- if .Values.conf.children.enabled }}"},{"line_number":76,"context_line":"            - -children\u003d{{ toString .Values.conf.children }}"},{"line_number":77,"context_line":"{{- end }}"},{"line_number":78,"context_line":"            - -procnames"},{"line_number":79,"context_line":"            - {{ .Values.conf.processes }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_1b069bcf","line":76,"range":{"start_line":76,"start_character":27,"end_line":76,"end_character":57},"updated":"2020-04-16 22:20:42.000000000","message":"do you see a sense to use string?","commit_id":"9987089b9c9f6f0441ec2c1ecadb42565f883880"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"6361ae6447ade856d141287b8509b9599547f187","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"metrics\" \"container\" \"process_exporter\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":74,"context_line":"          args:"},{"line_number":75,"context_line":"{{- if .Values.conf.children.enabled }}"},{"line_number":76,"context_line":"            - -children\u003d{{ toString .Values.conf.children }}"},{"line_number":77,"context_line":"{{- end }}"},{"line_number":78,"context_line":"            - -procnames"},{"line_number":79,"context_line":"            - {{ .Values.conf.processes }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_5b366354","line":76,"range":{"start_line":76,"start_character":27,"end_line":76,"end_character":57},"in_reply_to":"3f4c43b2_1b069bcf","updated":"2020-04-16 22:49:50.000000000","message":"The boolean true and false should be rendered as strings correctly without calling toString here","commit_id":"9987089b9c9f6f0441ec2c1ecadb42565f883880"}],"prometheus-process-exporter/values.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"54378570759faf1b7680d3a64cb7fca99f197132","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  processes: dockerd,kubelet,kube-proxy,bgsagent,bgscollect,bgssd"},{"line_number":162,"context_line":"  children:"},{"line_number":163,"context_line":"    enabled: true"},{"line_number":164,"context_line":"    value: \"true\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_5b102302","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":17},"updated":"2020-04-16 22:21:26.000000000","message":"i think we should keep boolean here","commit_id":"9987089b9c9f6f0441ec2c1ecadb42565f883880"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"6361ae6447ade856d141287b8509b9599547f187","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  processes: dockerd,kubelet,kube-proxy,bgsagent,bgscollect,bgssd"},{"line_number":162,"context_line":"  children:"},{"line_number":163,"context_line":"    enabled: true"},{"line_number":164,"context_line":"    value: \"true\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_1b2cdb00","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":17},"in_reply_to":"3f4c43b2_5b102302","updated":"2020-04-16 22:49:50.000000000","message":"I agree, we can leave this file alone and switch to the \u0027hasKey\u0027 method in the condition.","commit_id":"9987089b9c9f6f0441ec2c1ecadb42565f883880"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"46715ad3e21ec2ee0d92d85b454da47f6560ad6c","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"conf:"},{"line_number":161,"context_line":"  processes: dockerd,kubelet,kube-proxy,bgsagent,bgscollect,bgssd"},{"line_number":162,"context_line":"  children: \"true\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_fbc12fe6","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":18},"updated":"2020-04-16 23:11:34.000000000","message":"i think boolean will be fine here","commit_id":"61db471f23ee3f92e8dd7f0bbe4afe22db2ca633"},{"author":{"_account_id":18295,"name":"John Lawrence","email":"jl401j@us.att.com","username":"jl401j"},"change_message_id":"f049a26fb50fb98b26a5cfd855c391303a8e240c","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"conf:"},{"line_number":161,"context_line":"  processes: dockerd,kubelet,kube-proxy,bgsagent,bgscollect,bgssd"},{"line_number":162,"context_line":"  children: \"true\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_1b321b11","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":18},"in_reply_to":"3f4c43b2_fbc12fe6","updated":"2020-04-16 23:20:41.000000000","message":"Thanks Andrill","commit_id":"61db471f23ee3f92e8dd7f0bbe4afe22db2ca633"}]}