)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"bfad84d68c5ffd7c0fa18b3f2556244dc21aa23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ff570b3c_eb6224ad","updated":"2020-06-10 14:07:29.000000000","message":"Can you put a Depends-On: https://review.opendev.org/#/c/732520/\n\nfor this ps since this change relies on the new htk functions.","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"95bf257f7083c0d41d8da11d878b243900102ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ff570b3c_cb9c806c","in_reply_to":"ff570b3c_eb6224ad","updated":"2020-06-10 14:13:14.000000000","message":"Disregard","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"}],"mariadb/templates/bin/_backup_mariadb.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9d24ceeb98b9a002ef29eced7ee8d5573f9de278","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  done"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  #Dumping the database"},{"line_number":69,"context_line":"  #DATE\u003d$(date +\"%Y_%m_%d_%H_%M_%S\")"},{"line_number":70,"context_line":"  DATE\u003d$(date +\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"ff570b3c_c8cec92b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":36},"updated":"2020-05-19 02:13:43.000000000","message":"can remove","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  done"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  #Dumping the database"},{"line_number":69,"context_line":"  #DATE\u003d$(date +\"%Y_%m_%d_%H_%M_%S\")"},{"line_number":70,"context_line":"  DATE\u003d$(date +\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"ff570b3c_72768072","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":36},"in_reply_to":"ff570b3c_c8cec92b","updated":"2020-05-19 16:27:54.000000000","message":"removed","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"19cf46f9c6c7a493868e7936bd08c5a4d8272894","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  MYSQLDUMP\u003d\"mysqldump \\"},{"line_number":37,"context_line":"     --defaults-file\u003d/etc/mysql/admin_user.cnf\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  DBNAME\u003d( $($MYSQL --silent --skip-column-names -e \\"},{"line_number":40,"context_line":"     \"show databases;\" | \\"},{"line_number":41,"context_line":"     egrep -vi \u0027information_schema|performance_schema\u0027) )"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":19,"id":"ff570b3c_9738103e","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":53},"updated":"2020-05-22 20:05:54.000000000","message":"DBNAME and DB_NAME are quite similar but 2 different constants. Renaming would be nice.","commit_id":"803ab998590632b9c3191caa897e62889b6c3f44"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"212274d538ae60f193abc3e1a8286e779e6c2cb2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  MYSQLDUMP\u003d\"mysqldump \\"},{"line_number":37,"context_line":"     --defaults-file\u003d/etc/mysql/admin_user.cnf\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  DBNAME\u003d( $($MYSQL --silent --skip-column-names -e \\"},{"line_number":40,"context_line":"     \"show databases;\" | \\"},{"line_number":41,"context_line":"     egrep -vi \u0027information_schema|performance_schema\u0027) )"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":19,"id":"ff570b3c_9da831dc","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":53},"in_reply_to":"ff570b3c_9738103e","updated":"2020-05-22 22:13:59.000000000","message":"renamed to MYSQL_DBNAMES","commit_id":"803ab998590632b9c3191caa897e62889b6c3f44"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Export the variables required by the framework"},{"line_number":19,"context_line":"# Note: REMOTE_BACKUP_ENABLED, STORAGE_POLICY  and CONTAINER_NAME are already"},{"line_number":20,"context_line":"#       exported."},{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_aecea1b1","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":24},"updated":"2020-06-08 22:09:31.000000000","message":"this vars are used single time. I can understand a convenience to define constant for the second one. But do you really need to define a first one?","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Export the variables required by the framework"},{"line_number":19,"context_line":"# Note: REMOTE_BACKUP_ENABLED, STORAGE_POLICY  and CONTAINER_NAME are already"},{"line_number":20,"context_line":"#       exported."},{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_113ed0b8","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":24},"in_reply_to":"ff570b3c_aecea1b1","updated":"2020-06-08 23:10:51.000000000","message":"These are needed by helm-toolkit.scripts.db-backup-restore.backup_main","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#       exported."},{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_8ecf5db2","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":60},"updated":"2020-06-08 22:09:31.000000000","message":"Too long to be w/o curved brackets, use them please","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#       exported."},{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_518fa874","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":60},"in_reply_to":"ff570b3c_8ecf5db2","updated":"2020-06-08 23:10:51.000000000","message":"added","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Dump all the database files to existing $TMP_DIR and save logs to $LOG_FILE"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_6ed48948","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":62},"updated":"2020-06-08 22:09:31.000000000","message":"ditto","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"export DB_NAMESPACE\u003d${MARIADB_POD_NAMESPACE}"},{"line_number":22,"context_line":"export DB_NAME\u003d\"mariadb\""},{"line_number":23,"context_line":"export LOCAL_DAYS_TO_KEEP\u003d$MARIADB_LOCAL_BACKUP_DAYS_TO_KEEP"},{"line_number":24,"context_line":"export REMOTE_DAYS_TO_KEEP\u003d$MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":25,"context_line":"export ARCHIVE_DIR\u003d${MARIADB_BACKUP_BASE_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Dump all the database files to existing $TMP_DIR and save logs to $LOG_FILE"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_91e6604a","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":62},"in_reply_to":"ff570b3c_6ed48948","updated":"2020-06-08 23:10:51.000000000","message":"added","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Call main program to start the database backup"},{"line_number":87,"context_line":"backup_databases"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_6e3009a0","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":16},"updated":"2020-06-08 22:09:31.000000000","message":"I don\u0027t find function with this name and no executable as well. Could you explain please.","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Call main program to start the database backup"},{"line_number":87,"context_line":"backup_databases"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"ff570b3c_51e4c83c","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":16},"in_reply_to":"ff570b3c_6e3009a0","updated":"2020-06-08 23:10:51.000000000","message":"The main function is here: helm-toolkit.scripts.db-backup-restore.backup_main","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"set -x"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"source /tmp/backup_main.sh"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Export the variables required by the framework"},{"line_number":19,"context_line":"# Note: REMOTE_BACKUP_ENABLED, STORAGE_POLICY  and CONTAINER_NAME are already"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_eea97c90","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"updated":"2020-06-11 15:05:10.000000000","message":"Should this generate an error and exit if the file cannot be found?","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  MYSQL_DBNAMES\u003d( $($MYSQL --silent --skip-column-names -e \\"},{"line_number":40,"context_line":"     \"show databases;\" | \\"},{"line_number":41,"context_line":"     egrep -vi \u0027information_schema|performance_schema\u0027) )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #check if there is a database to backup, otherwise exit"},{"line_number":44,"context_line":"  if [[ -z \"${MYSQL_DBNAMES// }\" ]]"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_0e77903d","line":41,"updated":"2020-06-11 15:05:10.000000000","message":"egrep is deprecated, use grep -E instead:\n--extended-regexp\n    Interpret patterns as extended regular expressions (EREs)","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  fi"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  #Create a list of Databases"},{"line_number":51,"context_line":"  printf \"%s\\n\" \"${MYSQL_DBNAMES[@]}\" \u003e $TMP_DIR/db.list"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  #Retrieve and create the GRANT files per DB"},{"line_number":54,"context_line":"  for db in \"${MYSQL_DBNAMES[@]}\""}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_ee97bc39","line":51,"range":{"start_line":51,"start_character":40,"end_line":51,"end_character":48},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  #Retrieve and create the GRANT files per DB"},{"line_number":54,"context_line":"  for db in \"${MYSQL_DBNAMES[@]}\""},{"line_number":55,"context_line":"  do"},{"line_number":56,"context_line":"    echo $($MYSQL --skip-column-names -e \"select concat(\u0027show grants for \u0027,user,\u0027;\u0027) \\"},{"line_number":57,"context_line":"          from mysql.db where ucase(db)\u003ducase(\u0027$db\u0027);\") | \\"},{"line_number":58,"context_line":"          sed -r \"s/show grants for ([a-zA-Z0-9_-]*)/show grants for \u0027\\1\u0027/\" | \\"},{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_ceb3d8e8","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":17},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    echo $($MYSQL --skip-column-names -e \"select concat(\u0027show grants for \u0027,user,\u0027;\u0027) \\"},{"line_number":57,"context_line":"          from mysql.db where ucase(db)\u003ducase(\u0027$db\u0027);\") | \\"},{"line_number":58,"context_line":"          sed -r \"s/show grants for ([a-zA-Z0-9_-]*)/show grants for \u0027\\1\u0027/\" | \\"},{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"},{"line_number":60,"context_line":"    if [ \"$?\" -eq 0 ]"},{"line_number":61,"context_line":"    then"},{"line_number":62,"context_line":"      sed -i \u0027s/$/;/\u0027 $TMP_DIR/${db}_grant.sql"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_0ec5d03d","line":59,"range":{"start_line":59,"start_character":61,"end_line":59,"end_character":69},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    echo $($MYSQL --skip-column-names -e \"select concat(\u0027show grants for \u0027,user,\u0027;\u0027) \\"},{"line_number":57,"context_line":"          from mysql.db where ucase(db)\u003ducase(\u0027$db\u0027);\") | \\"},{"line_number":58,"context_line":"          sed -r \"s/show grants for ([a-zA-Z0-9_-]*)/show grants for \u0027\\1\u0027/\" | \\"},{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"},{"line_number":60,"context_line":"    if [ \"$?\" -eq 0 ]"},{"line_number":61,"context_line":"    then"},{"line_number":62,"context_line":"      sed -i \u0027s/$/;/\u0027 $TMP_DIR/${db}_grant.sql"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_2eca544e","line":59,"range":{"start_line":59,"start_character":49,"end_line":59,"end_character":58},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    echo $($MYSQL --skip-column-names -e \"select concat(\u0027show grants for \u0027,user,\u0027;\u0027) \\"},{"line_number":57,"context_line":"          from mysql.db where ucase(db)\u003ducase(\u0027$db\u0027);\") | \\"},{"line_number":58,"context_line":"          sed -r \"s/show grants for ([a-zA-Z0-9_-]*)/show grants for \u0027\\1\u0027/\" | \\"},{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"},{"line_number":60,"context_line":"    if [ \"$?\" -eq 0 ]"},{"line_number":61,"context_line":"    then"},{"line_number":62,"context_line":"      sed -i \u0027s/$/;/\u0027 $TMP_DIR/${db}_grant.sql"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_4e4228ad","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":16},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"},{"line_number":60,"context_line":"    if [ \"$?\" -eq 0 ]"},{"line_number":61,"context_line":"    then"},{"line_number":62,"context_line":"      sed -i \u0027s/$/;/\u0027 $TMP_DIR/${db}_grant.sql"},{"line_number":63,"context_line":"    else"},{"line_number":64,"context_line":"      log ERROR \"Failed to create GRANT files for ${db}\""},{"line_number":65,"context_line":"    fi"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_4e1b48c9","line":62,"range":{"start_line":62,"start_character":31,"end_line":62,"end_character":36},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          $MYSQL --silent --skip-column-names 2\u003e\u003e$LOG_FILE \u003e $TMP_DIR/${db}_grant.sql"},{"line_number":60,"context_line":"    if [ \"$?\" -eq 0 ]"},{"line_number":61,"context_line":"    then"},{"line_number":62,"context_line":"      sed -i \u0027s/$/;/\u0027 $TMP_DIR/${db}_grant.sql"},{"line_number":63,"context_line":"    else"},{"line_number":64,"context_line":"      log ERROR \"Failed to create GRANT files for ${db}\""},{"line_number":65,"context_line":"    fi"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_6e20ccf8","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":30},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  #Dumping the database"},{"line_number":69,"context_line":"  DATE\u003d$(date +\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all"},{"line_number":72,"context_line":"  TARBALL_FILE\u003d${SQL_FILE}.${DATE}.tar.gz"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $MYSQLDUMP $MYSQL_BACKUP_MYSQLDUMP_OPTIONS \"${MYSQL_DBNAMES[@]}\"  \\"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_30eab20d","line":71,"range":{"start_line":71,"start_character":19,"end_line":71,"end_character":41},"updated":"2020-06-11 15:05:10.000000000","message":"This should use the braces and double quote.","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  DATE\u003d$(date +\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all"},{"line_number":72,"context_line":"  TARBALL_FILE\u003d${SQL_FILE}.${DATE}.tar.gz"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $MYSQLDUMP $MYSQL_BACKUP_MYSQLDUMP_OPTIONS \"${MYSQL_DBNAMES[@]}\"  \\"},{"line_number":75,"context_line":"            \u003e $TMP_DIR/${SQL_FILE}.sql 2\u003e\u003e$LOG_FILE"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_ce15984b","line":72,"range":{"start_line":72,"start_character":2,"end_line":72,"end_character":14},"updated":"2020-06-11 15:05:10.000000000","message":"Doesn\u0027t look like this is used. Otherwise it should be:\nexport TARBALL_FILE\u003d\"${SQL_FILE}\".\"${DATE}\".tar.gz","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all"},{"line_number":72,"context_line":"  TARBALL_FILE\u003d${SQL_FILE}.${DATE}.tar.gz"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $MYSQLDUMP $MYSQL_BACKUP_MYSQLDUMP_OPTIONS \"${MYSQL_DBNAMES[@]}\"  \\"},{"line_number":75,"context_line":"            \u003e $TMP_DIR/${SQL_FILE}.sql 2\u003e\u003e$LOG_FILE"},{"line_number":76,"context_line":"  if [[ $? -eq 0 \u0026\u0026 -s $TMP_DIR/${SQL_FILE}.sql ]]"},{"line_number":77,"context_line":"  then"}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_1034cedd","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":44},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"4b677830ba08b64c73bd125815f13617ede185c1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  TARBALL_FILE\u003d${SQL_FILE}.${DATE}.tar.gz"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $MYSQLDUMP $MYSQL_BACKUP_MYSQLDUMP_OPTIONS \"${MYSQL_DBNAMES[@]}\"  \\"},{"line_number":75,"context_line":"            \u003e $TMP_DIR/${SQL_FILE}.sql 2\u003e\u003e$LOG_FILE"},{"line_number":76,"context_line":"  if [[ $? -eq 0 \u0026\u0026 -s $TMP_DIR/${SQL_FILE}.sql ]]"},{"line_number":77,"context_line":"  then"},{"line_number":78,"context_line":"    log INFO \"Databases dumped successfully.\""}],"source_content_type":"text/x-smarty","patch_set":32,"id":"ff570b3c_30291289","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":22},"updated":"2020-06-11 15:05:10.000000000","message":"Double quote","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"}],"mariadb/templates/bin/_restore_mariadb.sh.tpl":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e5f9577cadaad4e34c7f12593fea30df6213d3ee","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":72,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":73,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p | grep \"^CREATE TABLE\" | awk -F \u0027`\u0027 \u0027{print $2}\u0027 \u003e $TABLE_FILE"},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"    # Error, cannot report the tables"},{"line_number":76,"context_line":"    echo \"No SQL file found - cannot extract the tables\""}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_9c7749d5","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":29},"updated":"2020-06-18 18:44:16.000000000","message":"you may want to pass filename to sed directly saving couple symbols that makes sense given the length of line. Also it makes sense to make it multiline for readability","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"2b8cd217f059a53c3974f9e40d132e2baf6c3de9","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":72,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":73,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p | grep \"^CREATE TABLE\" | awk -F \u0027`\u0027 \u0027{print $2}\u0027 \u003e $TABLE_FILE"},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"    # Error, cannot report the tables"},{"line_number":76,"context_line":"    echo \"No SQL file found - cannot extract the tables\""}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_6fb36399","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":29},"in_reply_to":"bf51134e_9c7749d5","updated":"2020-06-22 20:04:01.000000000","message":"updated","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e5f9577cadaad4e34c7f12593fea30df6213d3ee","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":90,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":91,"context_line":"    DB_FILE\u003d$(mktemp -p /tmp)"},{"line_number":92,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \u003e ${DB_FILE}"},{"line_number":93,"context_line":"    cat ${DB_FILE} | grep \"INSERT INTO \\`${TABLE}\\` VALUES\" \u003e $ROW_FILE"},{"line_number":94,"context_line":"    rm -f ${DB_FILE}"},{"line_number":95,"context_line":"  else"},{"line_number":96,"context_line":"    # Error, cannot report the rows"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_dc81c191","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":71},"updated":"2020-06-18 18:44:16.000000000","message":"ditto","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"2b8cd217f059a53c3974f9e40d132e2baf6c3de9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":90,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":91,"context_line":"    DB_FILE\u003d$(mktemp -p /tmp)"},{"line_number":92,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \u003e ${DB_FILE}"},{"line_number":93,"context_line":"    cat ${DB_FILE} | grep \"INSERT INTO \\`${TABLE}\\` VALUES\" \u003e $ROW_FILE"},{"line_number":94,"context_line":"    rm -f ${DB_FILE}"},{"line_number":95,"context_line":"  else"},{"line_number":96,"context_line":"    # Error, cannot report the rows"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_afa9fb24","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":71},"in_reply_to":"bf51134e_dc81c191","updated":"2020-06-22 20:04:01.000000000","message":"updated","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e5f9577cadaad4e34c7f12593fea30df6213d3ee","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":111,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":112,"context_line":"    DB_FILE\u003d$(mktemp -p /tmp)"},{"line_number":113,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \u003e ${DB_FILE}"},{"line_number":114,"context_line":"    cat ${DB_FILE} | sed -n /\u0027CREATE TABLE `\u0027$TABLE\u0027`\u0027/,/\u0027--\u0027/p \u003e ${SCHEMA_FILE}"},{"line_number":115,"context_line":"    if [[ ! (-s ${SCHEMA_FILE}) ]]; then"},{"line_number":116,"context_line":"      cat ${DB_FILE} | sed -n /\u0027CREATE TABLE IF NOT EXISTS `\u0027$TABLE\u0027`\u0027/,/\u0027--\u0027/p \u003e ${SCHEMA_FILE}"},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"    rm -f ${DB_FILE}"},{"line_number":119,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_1c4df999","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":96},"updated":"2020-06-18 18:44:16.000000000","message":"ditto","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"2b8cd217f059a53c3974f9e40d132e2baf6c3de9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":111,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":112,"context_line":"    DB_FILE\u003d$(mktemp -p /tmp)"},{"line_number":113,"context_line":"    cat $TMP_DIR/$SQL_FILE | sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \u003e ${DB_FILE}"},{"line_number":114,"context_line":"    cat ${DB_FILE} | sed -n /\u0027CREATE TABLE `\u0027$TABLE\u0027`\u0027/,/\u0027--\u0027/p \u003e ${SCHEMA_FILE}"},{"line_number":115,"context_line":"    if [[ ! (-s ${SCHEMA_FILE}) ]]; then"},{"line_number":116,"context_line":"      cat ${DB_FILE} | sed -n /\u0027CREATE TABLE IF NOT EXISTS `\u0027$TABLE\u0027`\u0027/,/\u0027--\u0027/p \u003e ${SCHEMA_FILE}"},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"    rm -f ${DB_FILE}"},{"line_number":119,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_8fa6b752","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":96},"in_reply_to":"bf51134e_1c4df999","updated":"2020-06-22 20:04:01.000000000","message":"updated","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e5f9577cadaad4e34c7f12593fea30df6213d3ee","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  # script if that\u0027s the case."},{"line_number":133,"context_line":"  delete_restore_user \"dont_exit_on_error\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  $MYSQL --execute\u003d\"GRANT SELECT ON *.* TO ${RESTORE_USER}@\u0027%\u0027 IDENTIFIED BY \u0027${RESTORE_PW}\u0027;\" 2\u003e\u003e$RESTORE_LOG"},{"line_number":136,"context_line":"  if [[ \"$?\" -eq 0 ]]"},{"line_number":137,"context_line":"  then"},{"line_number":138,"context_line":"    $MYSQL --execute\u003d\"GRANT ALL ON ${restore_db}.* TO ${RESTORE_USER}@\u0027%\u0027 IDENTIFIED BY \u0027${RESTORE_PW}\u0027;\" 2\u003e\u003e$RESTORE_LOG"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_dc5a614d","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":110},"updated":"2020-06-18 18:44:16.000000000","message":"do you only plan to write stderr to restore log? otherwise you need to do \u00272\u003e\u00261 \u003e\u003e $RESTORE_LOG\u0027","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"2b8cd217f059a53c3974f9e40d132e2baf6c3de9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  # script if that\u0027s the case."},{"line_number":133,"context_line":"  delete_restore_user \"dont_exit_on_error\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  $MYSQL --execute\u003d\"GRANT SELECT ON *.* TO ${RESTORE_USER}@\u0027%\u0027 IDENTIFIED BY \u0027${RESTORE_PW}\u0027;\" 2\u003e\u003e$RESTORE_LOG"},{"line_number":136,"context_line":"  if [[ \"$?\" -eq 0 ]]"},{"line_number":137,"context_line":"  then"},{"line_number":138,"context_line":"    $MYSQL --execute\u003d\"GRANT ALL ON ${restore_db}.* TO ${RESTORE_USER}@\u0027%\u0027 IDENTIFIED BY \u0027${RESTORE_PW}\u0027;\" 2\u003e\u003e$RESTORE_LOG"}],"source_content_type":"text/x-smarty","patch_set":40,"id":"bf51134e_ef1bf37d","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":110},"in_reply_to":"bf51134e_dc5a614d","updated":"2020-06-22 20:04:01.000000000","message":"Yes, I only wanted to dump the error to this log. there are a lot of false positives in this error log for restoring a single db","commit_id":"c6bb27b5bf61b5d6daeeb8feb3bda469bccf8d08"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"aae9a685cc2dd09e5521cb2c44ebbe9d04e227c8","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RESTORE_USER\u003d\u0027restoreuser\u0027"},{"line_number":31,"context_line":"RESTORE_PW\u003d$(pwgen 16 1)"},{"line_number":32,"context_line":"RESTORE_LOG\u003d\u0027/tmp/restore_error.log\u0027"},{"line_number":33,"context_line":"rm -f $RESTORE_LOG"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# This is for commands which require admin access"}],"source_content_type":"text/x-smarty","patch_set":42,"id":"bf51134e_6f0fe336","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":36},"updated":"2020-06-22 20:04:17.000000000","message":"Please use LOG_FILE variable for logging to consistent logfile path (consistent with other dbs).","commit_id":"a5b7776b841a58ebe8c8e397e306725d98994492"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"cb1a4d40eae10c01093511f7f34447bc9f1361f3","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":72,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":73,"context_line":"    sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \\"},{"line_number":74,"context_line":"        $TMP_DIR/$SQL_FILE | grep \"^CREATE TABLE\" | awk -F \u0027`\u0027 \u0027{print $2}\u0027 \\"},{"line_number":75,"context_line":"        \u003e $TABLE_FILE"},{"line_number":76,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf51134e_1c75a764","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":75},"updated":"2020-06-24 01:28:26.000000000","message":"Bit better, should do the same:\n\nPATTERN\u003d\"-- Current Database:\"\nsed -n \"/${PATTERN} \\`${DATABASE}\\`/,/${PATTERN}/p\"\n\nAlso since we repeat it 3 times in this file - lets pretend \"bash programmers\" and incapsulate it in a separate function:\n\ncurrent_db_desc() {\n  PATTERN\u003d\"-- Current Database:\"\n  sed -n \"/${PATTERN} \\`$1\\`/,/${PATTERN}/p\" $2\n}\n\nand invocation:\ncurrent_db_desc ${DATABASE} ${TMP_DIR}/${SQL_FILE} | ...\n\nI\u0027m not insisting on function name here","commit_id":"56d7496f18147d7252d3b926e9851ad92fd5ca09"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"492280d57b7ceb757766228af8e4d97f1995f30b","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  SQL_FILE\u003dmariadb.$MARIADB_POD_NAMESPACE.all.sql"},{"line_number":72,"context_line":"  if [[ -e $TMP_DIR/$SQL_FILE ]]; then"},{"line_number":73,"context_line":"    sed -n /\u0027-- Current Database: `\u0027$DATABASE\u0027`\u0027/,/\u0027-- Current Database:\u0027/p \\"},{"line_number":74,"context_line":"        $TMP_DIR/$SQL_FILE | grep \"^CREATE TABLE\" | awk -F \u0027`\u0027 \u0027{print $2}\u0027 \\"},{"line_number":75,"context_line":"        \u003e $TABLE_FILE"},{"line_number":76,"context_line":"  else"}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf51134e_ac6d62cd","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":75},"in_reply_to":"bf51134e_1c75a764","updated":"2020-06-24 14:47:09.000000000","message":"updated","commit_id":"56d7496f18147d7252d3b926e9851ad92fd5ca09"}],"mariadb/templates/configmap-bin.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9d24ceeb98b9a002ef29eced7ee8d5573f9de278","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  restore_mariadb.sh: |"},{"line_number":46,"context_line":"{{ tuple \"bin/_restore_mariadb.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":47,"context_line":"  backup_main.sh: |"},{"line_number":48,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.backup_main\" . | indent 4 }}"},{"line_number":49,"context_line":"  restore_main.sh: |"},{"line_number":50,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.restore_main\" . | indent 4 }}"},{"line_number":51,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_88c85122","line":48,"range":{"start_line":48,"start_character":1,"end_line":48,"end_character":3},"updated":"2020-05-19 02:13:43.000000000","message":"this would chomp the newline and possibly not render correctly.","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  restore_mariadb.sh: |"},{"line_number":46,"context_line":"{{ tuple \"bin/_restore_mariadb.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":47,"context_line":"  backup_main.sh: |"},{"line_number":48,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.backup_main\" . | indent 4 }}"},{"line_number":49,"context_line":"  restore_main.sh: |"},{"line_number":50,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.restore_main\" . | indent 4 }}"},{"line_number":51,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_521ffc06","line":48,"range":{"start_line":48,"start_character":1,"end_line":48,"end_character":3},"in_reply_to":"ff570b3c_88c85122","updated":"2020-05-19 16:27:54.000000000","message":"removed","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9d24ceeb98b9a002ef29eced7ee8d5573f9de278","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  backup_main.sh: |"},{"line_number":48,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.backup_main\" . | indent 4 }}"},{"line_number":49,"context_line":"  restore_main.sh: |"},{"line_number":50,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.restore_main\" . | indent 4 }}"},{"line_number":51,"context_line":"{{- end }}"},{"line_number":52,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":53,"context_line":"  ks-user.sh: |"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_68cdfd2f","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":3},"updated":"2020-05-19 02:13:43.000000000","message":"ditto","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  backup_main.sh: |"},{"line_number":48,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.backup_main\" . | indent 4 }}"},{"line_number":49,"context_line":"  restore_main.sh: |"},{"line_number":50,"context_line":"{{- include \"helm-toolkit.scripts.db-backup-restore.restore_main\" . | indent 4 }}"},{"line_number":51,"context_line":"{{- end }}"},{"line_number":52,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":53,"context_line":"  ks-user.sh: |"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_f2d5701d","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":3},"in_reply_to":"ff570b3c_68cdfd2f","updated":"2020-05-19 16:27:54.000000000","message":"removed","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"}],"mariadb/templates/cron-job-backup-mariadb.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"77a131d38a07d674dfa36bad14d9b035236d0513","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                - name: MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":92,"context_line":"                  value: {{ .Values.conf.backup.remote_backup.days_to_keep | quote }}"},{"line_number":93,"context_line":"                - name: CONTAINER_NAME"},{"line_number":94,"context_line":"                  value: \"{{ .Values.conf.backup.remote_backup.container_name }}\""},{"line_number":95,"context_line":"                - name: STORAGE_POLICY"},{"line_number":96,"context_line":"                  value: \"{{ .Values.conf.backup.remote_backup.storage_policy }}\""},{"line_number":97,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" $envAll.Values.secrets.identity.remote_rgw_user }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff570b3c_4fb84675","line":94,"range":{"start_line":94,"start_character":25,"end_line":94,"end_character":81},"updated":"2020-05-28 17:21:21.000000000","message":"why not just do | quote like it was done with the number","commit_id":"c8dd9e4fc3e102c06dd19bf1c28b63f4a2c9bb16"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"68496731dea4def39805f669ea2b7e360dbc0601","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                - name: MARIADB_REMOTE_BACKUP_DAYS_TO_KEEP"},{"line_number":92,"context_line":"                  value: {{ .Values.conf.backup.remote_backup.days_to_keep | quote }}"},{"line_number":93,"context_line":"                - name: CONTAINER_NAME"},{"line_number":94,"context_line":"                  value: \"{{ .Values.conf.backup.remote_backup.container_name }}\""},{"line_number":95,"context_line":"                - name: STORAGE_POLICY"},{"line_number":96,"context_line":"                  value: \"{{ .Values.conf.backup.remote_backup.storage_policy }}\""},{"line_number":97,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" $envAll.Values.secrets.identity.remote_rgw_user }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff570b3c_6ca2759c","line":94,"range":{"start_line":94,"start_character":25,"end_line":94,"end_character":81},"in_reply_to":"ff570b3c_4fb84675","updated":"2020-05-28 18:49:13.000000000","message":"updated","commit_id":"c8dd9e4fc3e102c06dd19bf1c28b63f4a2c9bb16"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"77a131d38a07d674dfa36bad14d9b035236d0513","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            - name: mariadb-secrets"},{"line_number":128,"context_line":"              secret:"},{"line_number":129,"context_line":"                secretName: mariadb-secrets"},{"line_number":130,"context_line":"                defaultMode: 0644"},{"line_number":131,"context_line":"            - configMap:"},{"line_number":132,"context_line":"                defaultMode: 0555"},{"line_number":133,"context_line":"                name: mariadb-bin"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff570b3c_af8da2d4","line":130,"range":{"start_line":130,"start_character":29,"end_line":130,"end_character":31},"updated":"2020-05-28 17:21:21.000000000","message":"why does this secret need u+w access?","commit_id":"c8dd9e4fc3e102c06dd19bf1c28b63f4a2c9bb16"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"68496731dea4def39805f669ea2b7e360dbc0601","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            - name: mariadb-secrets"},{"line_number":128,"context_line":"              secret:"},{"line_number":129,"context_line":"                secretName: mariadb-secrets"},{"line_number":130,"context_line":"                defaultMode: 0644"},{"line_number":131,"context_line":"            - configMap:"},{"line_number":132,"context_line":"                defaultMode: 0555"},{"line_number":133,"context_line":"                name: mariadb-bin"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff570b3c_4c9df155","line":130,"range":{"start_line":130,"start_character":29,"end_line":130,"end_character":31},"in_reply_to":"ff570b3c_af8da2d4","updated":"2020-05-28 18:49:13.000000000","message":"updated","commit_id":"c8dd9e4fc3e102c06dd19bf1c28b63f4a2c9bb16"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            - name: mariadb-secrets"},{"line_number":130,"context_line":"              secret:"},{"line_number":131,"context_line":"                secretName: mariadb-secrets"},{"line_number":132,"context_line":"                defaultMode: 0444"},{"line_number":133,"context_line":"            - configMap:"},{"line_number":134,"context_line":"                defaultMode: 0555"},{"line_number":135,"context_line":"                name: mariadb-bin"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_ee38993c","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":33},"updated":"2020-06-08 22:09:31.000000000","message":"as I understand this should be failing after rebase on yamllint check that restricts octal notations. Could you please use decimal one.","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            - name: mariadb-secrets"},{"line_number":130,"context_line":"              secret:"},{"line_number":131,"context_line":"                secretName: mariadb-secrets"},{"line_number":132,"context_line":"                defaultMode: 0444"},{"line_number":133,"context_line":"            - configMap:"},{"line_number":134,"context_line":"                defaultMode: 0555"},{"line_number":135,"context_line":"                name: mariadb-bin"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_314af4ab","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":33},"in_reply_to":"ff570b3c_ee38993c","updated":"2020-06-08 23:10:51.000000000","message":"updated","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"c6098d45377c20baec67af6da22404cd32c7dea2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                secretName: mariadb-secrets"},{"line_number":132,"context_line":"                defaultMode: 0444"},{"line_number":133,"context_line":"            - configMap:"},{"line_number":134,"context_line":"                defaultMode: 0555"},{"line_number":135,"context_line":"                name: mariadb-bin"},{"line_number":136,"context_line":"              name: mariadb-bin"},{"line_number":137,"context_line":"            {{- if and .Values.volume.backup.enabled  .Values.manifests.pvc_backup }}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_6e7be9f3","line":134,"range":{"start_line":134,"start_character":29,"end_line":134,"end_character":33},"updated":"2020-06-08 22:09:31.000000000","message":"ditto","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4700e2630b7a4f2f0cca726d526cf8c40f0732b5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                secretName: mariadb-secrets"},{"line_number":132,"context_line":"                defaultMode: 0444"},{"line_number":133,"context_line":"            - configMap:"},{"line_number":134,"context_line":"                defaultMode: 0555"},{"line_number":135,"context_line":"                name: mariadb-bin"},{"line_number":136,"context_line":"              name: mariadb-bin"},{"line_number":137,"context_line":"            {{- if and .Values.volume.backup.enabled  .Values.manifests.pvc_backup }}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_91c4a010","line":134,"range":{"start_line":134,"start_character":29,"end_line":134,"end_character":33},"in_reply_to":"ff570b3c_6e7be9f3","updated":"2020-06-08 23:10:51.000000000","message":"updated","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"39ea2372c00f372f3115e035b22d03bcc3df1f77","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                - chown"},{"line_number":64,"context_line":"                - -R"},{"line_number":65,"context_line":"                - \"65534:65534\""},{"line_number":66,"context_line":"                - $(MARIADB_BACKUP_BASE_DIR)"},{"line_number":67,"context_line":"              env:"},{"line_number":68,"context_line":"                - name: MARIADB_BACKUP_BASE_DIR"},{"line_number":69,"context_line":"                  value: {{ .Values.conf.backup.base_path | quote }}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"bf51134e_7459f358","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":44},"updated":"2020-06-15 23:24:37.000000000","message":"need to use brackets, rather than parenthesis","commit_id":"433f0f47ee13d468dce96800bc10631424a84ab4"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"4276bc41476856576eab657aafdd199989244d0f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                - chown"},{"line_number":64,"context_line":"                - -R"},{"line_number":65,"context_line":"                - \"65534:65534\""},{"line_number":66,"context_line":"                - $(MARIADB_BACKUP_BASE_DIR)"},{"line_number":67,"context_line":"              env:"},{"line_number":68,"context_line":"                - name: MARIADB_BACKUP_BASE_DIR"},{"line_number":69,"context_line":"                  value: {{ .Values.conf.backup.base_path | quote }}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"bf51134e_2f69d624","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":44},"in_reply_to":"bf51134e_7459f358","updated":"2020-06-16 20:22:13.000000000","message":"I have to do it this way. This is inside yaml chat.","commit_id":"433f0f47ee13d468dce96800bc10631424a84ab4"}],"mariadb/templates/job-ks-user.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1d50651e172ed82019e6f4c323387ff32871ed3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2020 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_28df85d6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"updated":"2020-05-19 02:15:13.000000000","message":"also not sure if we need these, Gage took all these copyrights out so do we want to add them now back in against these non-copyrightable entities.","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2020 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_52cd3c83","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":42},"in_reply_to":"ff570b3c_28df85d6","updated":"2020-05-19 16:27:54.000000000","message":"removed","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"}],"mariadb/templates/secret-rgw.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9d24ceeb98b9a002ef29eced7ee8d5573f9de278","unresolved":false,"context_lines":[{"line_number":22,"context_line":"     keystone account mentioned above. This may not be needed if the"},{"line_number":23,"context_line":"     account is in a remote cluster (auth_url is non-null in that case)."},{"line_number":24,"context_line":"*/}}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{- if .Values.conf.backup.remote_backup.enabled }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":29,"context_line":"{{- $userClass :\u003d \"mariadb\" }}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_e853cd69","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":51},"updated":"2020-05-19 02:13:43.000000000","message":"shouldn\u0027t this be jointed with the manifest job boolean in some way? Do we need these secrets if we don\u0027t actually do anything with the ks_user job?","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"     keystone account mentioned above. This may not be needed if the"},{"line_number":23,"context_line":"     account is in a remote cluster (auth_url is non-null in that case)."},{"line_number":24,"context_line":"*/}}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{- if .Values.conf.backup.remote_backup.enabled }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":29,"context_line":"{{- $userClass :\u003d \"mariadb\" }}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_92ed14b9","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":51},"in_reply_to":"ff570b3c_e853cd69","updated":"2020-05-19 16:27:54.000000000","message":"added","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"f082c4b7d9a31d842f48590bd35102227b3c13e6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"     in that case)."},{"line_number":23,"context_line":"*/}}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{- if and .Values.conf.backup.remote_backup.enabled .Values.manifests.job_ks_user }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":28,"context_line":"{{- $userClass :\u003d \"remote_rgw_user\" }}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ff570b3c_b0e5333b","line":25,"range":{"start_line":25,"start_character":54,"end_line":25,"end_character":82},"updated":"2020-05-26 19:26:40.000000000","message":"The job_ks_user part should be removed.  This file produces 2 secrets, one for the keystone admin user, and one for the mariadb backup user.  There is already a check for job_ks_user on line 52.","commit_id":"74158d3dc2bbc18e18555b1eed9fd49e25b53f9e"}],"mariadb/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f6b89e619ad506a12bc321cec9be16a232e38f84","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    error_pages: gcr.io/google_containers/defaultbackend:1.0"},{"line_number":26,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.2.31"},{"line_number":27,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":28,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton-ubuntu_xenial"},{"line_number":29,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:v1.0.0"},{"line_number":30,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":31,"context_line":"    mariadb_backup: quay.io/airshipit/porthole-mysqlclient-utility:latest-ubuntu_bionic"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_68f69d65","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":91},"updated":"2020-05-19 02:16:46.000000000","message":"may be for a follow on patch - should/can this be updated too.","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"89886f8a5122c49107eb7fd9c1167237581527cf","unresolved":false,"context_lines":[{"line_number":551,"context_line":"      mariadb:"},{"line_number":552,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":553,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":554,"context_line":"        auth_url: null"},{"line_number":555,"context_line":"        role: admin"},{"line_number":556,"context_line":"        region_name: RegionOne"},{"line_number":557,"context_line":"        username: mariadb-backup-user"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_3119ad21","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":22},"updated":"2020-05-19 09:55:48.000000000","message":"would this url be ever different from the admin account?","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":551,"context_line":"      mariadb:"},{"line_number":552,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":553,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":554,"context_line":"        auth_url: null"},{"line_number":555,"context_line":"        role: admin"},{"line_number":556,"context_line":"        region_name: RegionOne"},{"line_number":557,"context_line":"        username: mariadb-backup-user"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_b51be270","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":22},"in_reply_to":"ff570b3c_3119ad21","updated":"2020-05-19 16:27:54.000000000","message":"should be the same most of the time","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"89886f8a5122c49107eb7fd9c1167237581527cf","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    port:"},{"line_number":572,"context_line":"      api:"},{"line_number":573,"context_line":"        default: 80"},{"line_number":574,"context_line":"        internal: 5000"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"network_policy:"},{"line_number":577,"context_line":"  mariadb:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_51342193","line":574,"range":{"start_line":574,"start_character":8,"end_line":574,"end_character":22},"updated":"2020-05-19 09:55:48.000000000","message":"would mariaDB need to interact with both the external and internal keystone endpoints?","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"3cd1fbe99c4e58fe020fe47a01056a48850c3da3","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    port:"},{"line_number":572,"context_line":"      api:"},{"line_number":573,"context_line":"        default: 80"},{"line_number":574,"context_line":"        internal: 5000"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"network_policy:"},{"line_number":577,"context_line":"  mariadb:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff570b3c_d5893675","line":574,"range":{"start_line":574,"start_character":8,"end_line":574,"end_character":22},"in_reply_to":"ff570b3c_51342193","updated":"2020-05-19 16:27:54.000000000","message":"Yes, in case we send the backups to the local openstack swift container.","commit_id":"923be62ce5fb0c7af55636f581bc026cbe9aaf61"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"255bc2824bcaaf74b06421269e40edc3fbf91ec7","unresolved":false,"context_lines":[{"line_number":441,"context_line":"secrets:"},{"line_number":442,"context_line":"  identity:"},{"line_number":443,"context_line":"    admin: keystone-admin-user"},{"line_number":444,"context_line":"    mariadb: mariadb-backup-user"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"# typically overridden by environmental"},{"line_number":447,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_9038213e","line":444,"range":{"start_line":444,"start_character":0,"end_line":444,"end_character":32},"updated":"2020-05-22 14:17:41.000000000","message":"I suggest we name this key differently.  Instead of \"mariadb\", which is a bit confusing, I suggest we call it \"rgw_user\" or \"remote_rgw\" or something that indicates what it\u0027s really used for.  I should have done this also for postgresql (I may go back and correct it later).","commit_id":"421f6de75f493262af27f81c941eef3b4f752860"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"f1dfefe5848b7a6357b0592ccede88b246cceca1","unresolved":false,"context_lines":[{"line_number":441,"context_line":"secrets:"},{"line_number":442,"context_line":"  identity:"},{"line_number":443,"context_line":"    admin: keystone-admin-user"},{"line_number":444,"context_line":"    mariadb: mariadb-backup-user"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"# typically overridden by environmental"},{"line_number":447,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_4b09ba93","line":444,"range":{"start_line":444,"start_character":0,"end_line":444,"end_character":32},"in_reply_to":"ff570b3c_9038213e","updated":"2020-05-22 14:49:18.000000000","message":"changed to remote_ks_admin and remote_rgw_user","commit_id":"421f6de75f493262af27f81c941eef3b4f752860"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"b347a76d3ba29f60b4462a2b5aafd2dd956f05c9","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    name: backup-storage-auth"},{"line_number":539,"context_line":"    namespace: openstack"},{"line_number":540,"context_line":"    auth:"},{"line_number":541,"context_line":"      admin:"},{"line_number":542,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":543,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":544,"context_line":"        auth_url: null"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_aeed018d","line":541,"range":{"start_line":541,"start_character":6,"end_line":541,"end_character":11},"updated":"2020-05-22 17:24:56.000000000","message":"I think this key should also change to match the key name on line 443.","commit_id":"70d572f4af4583024820d555575a0ccc92c1e34b"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"55e2d888eabd778a11878e67f307a03920f217ad","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    name: backup-storage-auth"},{"line_number":539,"context_line":"    namespace: openstack"},{"line_number":540,"context_line":"    auth:"},{"line_number":541,"context_line":"      admin:"},{"line_number":542,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":543,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":544,"context_line":"        auth_url: null"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_51904896","line":541,"range":{"start_line":541,"start_character":6,"end_line":541,"end_character":11},"in_reply_to":"ff570b3c_aeed018d","updated":"2020-05-22 17:39:31.000000000","message":"updated","commit_id":"70d572f4af4583024820d555575a0ccc92c1e34b"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"b347a76d3ba29f60b4462a2b5aafd2dd956f05c9","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        project_name: admin"},{"line_number":549,"context_line":"        user_domain_name: default"},{"line_number":550,"context_line":"        project_domain_name: default"},{"line_number":551,"context_line":"      mariadb:"},{"line_number":552,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":553,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":554,"context_line":"        auth_url: null"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_4ee385a5","line":551,"range":{"start_line":551,"start_character":6,"end_line":551,"end_character":13},"updated":"2020-05-22 17:24:56.000000000","message":"I think this key should also change to match the key name on line 444.","commit_id":"70d572f4af4583024820d555575a0ccc92c1e34b"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"55e2d888eabd778a11878e67f307a03920f217ad","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        project_name: admin"},{"line_number":549,"context_line":"        user_domain_name: default"},{"line_number":550,"context_line":"        project_domain_name: default"},{"line_number":551,"context_line":"      mariadb:"},{"line_number":552,"context_line":"        # Auth URL of null indicates local authentication"},{"line_number":553,"context_line":"        # HTK will form the URL unless specified here"},{"line_number":554,"context_line":"        auth_url: null"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_91e78047","line":551,"range":{"start_line":551,"start_character":6,"end_line":551,"end_character":13},"in_reply_to":"ff570b3c_4ee385a5","updated":"2020-05-22 17:39:31.000000000","message":"updated","commit_id":"70d572f4af4583024820d555575a0ccc92c1e34b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"fcca6394303be160a87e63ddaa8430e1d7348f2c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        username: mariadb-backup-user"},{"line_number":559,"context_line":"        password: password"},{"line_number":560,"context_line":"        project_name: service"},{"line_number":561,"context_line":"        user_domain_name: service"},{"line_number":562,"context_line":"        project_domain_name: service"},{"line_number":563,"context_line":"    hosts:"},{"line_number":564,"context_line":"      default: keystone"},{"line_number":565,"context_line":"      internal: keystone-api"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_8ed0fd2d","line":562,"range":{"start_line":561,"start_character":0,"end_line":562,"end_character":36},"updated":"2020-06-08 21:52:30.000000000","message":"Where is this service domain being created at?","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"d94eda9a09bf40f2093c3419fb0e015cfc5dfb5c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        username: mariadb-backup-user"},{"line_number":559,"context_line":"        password: password"},{"line_number":560,"context_line":"        project_name: service"},{"line_number":561,"context_line":"        user_domain_name: service"},{"line_number":562,"context_line":"        project_domain_name: service"},{"line_number":563,"context_line":"    hosts:"},{"line_number":564,"context_line":"      default: keystone"},{"line_number":565,"context_line":"      internal: keystone-api"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ff570b3c_2e72914a","line":562,"range":{"start_line":561,"start_character":0,"end_line":562,"end_character":36},"in_reply_to":"ff570b3c_8ed0fd2d","updated":"2020-06-08 21:59:05.000000000","message":"At the remote site that has the rgw running","commit_id":"3cf4a7e6d41d7c8038cebb800fdb657d628bdc10"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"bb9d255850dccf0ec6200a1c6c9dd42bd7ee3953","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        runAsUser: 65534"},{"line_number":116,"context_line":"      container:"},{"line_number":117,"context_line":"        backup_perms:"},{"line_number":118,"context_line":"          runAsUser: 0"},{"line_number":119,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":120,"context_line":"        mariadb_backup:"},{"line_number":121,"context_line":"          runAsUser: 65534"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"ff570b3c_0b183882","line":118,"range":{"start_line":118,"start_character":10,"end_line":118,"end_character":22},"updated":"2020-06-10 14:26:43.000000000","message":"Does this need to be root if its readonlyfilesystem?","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"d89b560413d8e07e967663081f2753c0f0bf4523","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        runAsUser: 65534"},{"line_number":116,"context_line":"      container:"},{"line_number":117,"context_line":"        backup_perms:"},{"line_number":118,"context_line":"          runAsUser: 0"},{"line_number":119,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":120,"context_line":"        mariadb_backup:"},{"line_number":121,"context_line":"          runAsUser: 65534"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"ff570b3c_6ee3aca5","line":118,"range":{"start_line":118,"start_character":10,"end_line":118,"end_character":22},"in_reply_to":"ff570b3c_0b183882","updated":"2020-06-11 14:53:25.000000000","message":"This backup_perms init container needs to run the chown command.","commit_id":"df2bc1ac4250443b2f7cbbf1ee353cfdcae42056"}]}