)]}'
{"mariadb/values.yaml":[{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"7ab3ab014461ea6aa290dc1c0e7f42b17e649875","unresolved":false,"context_lines":[{"line_number":521,"context_line":"  deployment_error: true"},{"line_number":522,"context_line":"  deployment_ingress: true"},{"line_number":523,"context_line":"  job_image_repo_sync: true"},{"line_number":524,"context_line":"  cron_job_mariadb_backup: true"},{"line_number":525,"context_line":"  pvc_backup: false"},{"line_number":526,"context_line":"  monitoring:"},{"line_number":527,"context_line":"    prometheus:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_70f09f68","line":524,"updated":"2020-05-13 20:51:09.000000000","message":"Could you Please add in values_overrides.yaml instead of values.yam same as for example:\nhttps://review.opendev.org/#/c/718300/14/ceph-mon/values_overrides/apparmor.yaml","commit_id":"f2e3d1d2869c0e4122d861c881021ec43bd090e2"}],"mariadb/values_overrides/apparmor.yaml":[{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"9b1478ce75adc28f24d9283dc97d97fc896e0333","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"monitoring:"},{"line_number":28,"context_line":"  prometheus:"},{"line_number":29,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_7776d9a6","line":29,"updated":"2020-05-13 17:43:02.000000000","message":"Can you  add override for mariadb-backup here\nhttps://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dmariadb/values.yaml;h\u003d58dc8f35118892374dc851f5cbed730e47eb47d3;hb\u003drefs/heads/master#l522","commit_id":"f292877513fbbcb77544e0f79663cc07506f462c"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"ac1236de3b241b2f4a7039686a121fd9b6a0dfa9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  prometheus:"},{"line_number":29,"context_line":"    enabled: true"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"backup:"},{"line_number":32,"context_line":"  enabled: true"},{"line_number":33,"context_line":"manifests:"},{"line_number":34,"context_line":"  cron_job_mariadb_backup: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_abb2c8e4","line":31,"updated":"2020-05-13 21:38:32.000000000","message":"What is this backup enabling?\nI already see volume.backup enabled (https://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dmariadb/values.yaml;h\u003d58dc8f35118892374dc851f5cbed730e47eb47d3;hb\u003drefs/heads/master#l252) and  also conf.backup enabled (https://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dmariadb/values.yaml;h\u003d58dc8f35118892374dc851f5cbed730e47eb47d3;hb\u003drefs/heads/master#l285)","commit_id":"0f3a101a73a6eee754d67de44622b21c59fd660e"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"372307944855e86a5ac4e78ebde8c9d5bb5204f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  prometheus:"},{"line_number":29,"context_line":"    enabled: true"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"backup:"},{"line_number":32,"context_line":"  enabled: true"},{"line_number":33,"context_line":"manifests:"},{"line_number":34,"context_line":"  cron_job_mariadb_backup: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_867379b1","line":31,"in_reply_to":"ff570b3c_ab46487b","updated":"2020-05-13 22:13:31.000000000","message":"Gage,I see conf.backup is also enabled (https://review.opendev.org/gitweb?p\u003dopenstack/openstack-helm-infra.git;a\u003dblob;f\u003dmariadb/values.yaml;h\u003d58dc8f35118892374dc851f5cbed730e47eb47d3;hb\u003drefs/heads/master#l285)","commit_id":"0f3a101a73a6eee754d67de44622b21c59fd660e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"b5134bb0ca527b0441e100e5e95b14e232adde79","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  prometheus:"},{"line_number":29,"context_line":"    enabled: true"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"backup:"},{"line_number":32,"context_line":"  enabled: true"},{"line_number":33,"context_line":"manifests:"},{"line_number":34,"context_line":"  cron_job_mariadb_backup: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_ab46487b","line":31,"in_reply_to":"ff570b3c_abb2c8e4","updated":"2020-05-13 22:02:58.000000000","message":"This needs to be under conf.backup I believe.","commit_id":"0f3a101a73a6eee754d67de44622b21c59fd660e"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"02fdc78b60c4c9f0b7f2a054d502af197f6a01b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    mariadb-test:"},{"line_number":18,"context_line":"      init: runtime/default"},{"line_number":19,"context_line":"      mariadb-mariadb-test: runtime/default"},{"line_number":20,"context_line":"    prometheus-mysql-exporter:"},{"line_number":21,"context_line":"      init: runtime/default"},{"line_number":22,"context_line":"      mysql-exporter: runtime/default"},{"line_number":23,"context_line":"    create-sql-user:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_94af15e2","line":20,"updated":"2020-05-14 15:06:12.000000000","message":"Seems you missed pod name\nhttps://review.opendev.org/#/c/727270/7/mariadb/templates/monitoring/prometheus/exporter-job-create-user.yaml","commit_id":"845385de38aae79928429366f1633c893bfc1638"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"99f1ec11e98fc9b2b5e5813edf486d58449d351f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    mariadb-test:"},{"line_number":18,"context_line":"      init: runtime/default"},{"line_number":19,"context_line":"      mariadb-mariadb-test: runtime/default"},{"line_number":20,"context_line":"    prometheus-mysql-exporter:"},{"line_number":21,"context_line":"      init: runtime/default"},{"line_number":22,"context_line":"      mysql-exporter: runtime/default"},{"line_number":23,"context_line":"    create-sql-user:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_3404497b","line":20,"in_reply_to":"ff570b3c_94af15e2","updated":"2020-05-14 15:13:51.000000000","message":"oh! I see we have both, thanks for pointing Rahul. Sorry missed it\nhttps://review.opendev.org/#/c/727270/7/mariadb/templates/monitoring/prometheus/exporter-deployment.yaml","commit_id":"845385de38aae79928429366f1633c893bfc1638"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"34b5c85ecf8908f1ca8141fb291f0109284179f7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    mariadb-test:"},{"line_number":18,"context_line":"      init: runtime/default"},{"line_number":19,"context_line":"      mariadb-mariadb-test: runtime/default"},{"line_number":20,"context_line":"    prometheus-mysql-exporter:"},{"line_number":21,"context_line":"      init: runtime/default"},{"line_number":22,"context_line":"      mysql-exporter: runtime/default"},{"line_number":23,"context_line":"    create-sql-user:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_14eae50d","line":20,"in_reply_to":"ff570b3c_94af15e2","updated":"2020-05-14 15:08:33.000000000","message":"please check line #23","commit_id":"845385de38aae79928429366f1633c893bfc1638"}]}