)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"e146330559b5fa66dd87773cbef866ef0af82476","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rahul Khiyani \u003crahul.khiyani@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-10 21:33:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"using print statement to add apparmor profile to non existent container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tried using concat template, but current helm version"},{"line_number":10,"context_line":"does not support concat"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_e8905f99","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":71},"updated":"2020-06-10 21:37:39.000000000","message":"I think your initial subject was fine. no reason to add implementation details here","commit_id":"ebf4918e824cb41a5c817cf986305903ddbd8d05"}],"ingress/templates/deployment-ingress.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"868ac4036fbeb5f2f71b2a1dfc251c1f594ac070","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_c4a90d25","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"updated":"2020-06-10 16:32:36.000000000","message":"pls reuse $containers here\n{{- $containers \u003d append $containers \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\" }}","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"35f2ba0666822d0efaad2003258048fd09a3f075","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_7010bb50","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_1544d11a","updated":"2020-06-10 18:55:27.000000000","message":"Yes this is a problem. it\u0027s not available in v14.1. I don\u0027t find anything except for work arounds for that like:\n{{- $containers \u003d printf \"%s ingress-vip-kernel-modules ingress-vip-init ingress-vip\" (join \" \" $containers) | list }}\nor a bit cleaner:\n{{- $containers :\u003d \"init ingress\" }}\n{{- if and .Values.network.host_namespace .Values.network.vip.manage }}\n{{- $containers \u003d printf \"%s ingress-vip-kernel-modules ingress-vip-init ingress-vip\" $containers }}\n{{- end }}\n{{- $containers \u003d list $containers }}","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"227898073c1b82d20db7b82fa05e8d23a62c64a5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_d5eb790f","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_556489e5","updated":"2020-06-10 18:09:39.000000000","message":"I tried concat also it was throwing error saying \"concat\" not found.","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"c7ad7995b8c0083613b6758ba45dd8f3eb774cff","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_10385f3b","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_7010bb50","updated":"2020-06-10 19:35:52.000000000","message":"Did you try \":\" before \"\u003d\" same as line 181","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"151242a957f5457cb2a5f1018d9008b488376a38","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_f0920bfc","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_7010bb50","updated":"2020-06-10 19:45:51.000000000","message":"pls use {{- $containers \u003d splitList \" \" $containers }} instead for the last line","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"b8bea764f5b88e3ee122d81d6b8e4bc75b3f4a44","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_556489e5","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_9adf70d5","updated":"2020-06-10 18:03:23.000000000","message":"right. sorry, this should work\n{{- $containers \u003d concat $containers (list \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"b00e375ee4cc9c9de56744ba4f1038b69ba9e21d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_9adf70d5","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_c4a90d25","updated":"2020-06-10 17:53:37.000000000","message":"I tried to keep as you suggested and did a dry run, but it\u0027s failing with the below error \n\"Error: render error in \"ingress/templates/deployment-ingress.yaml\": template: ingress/templates/deployment-ingress.yaml:170:18: executing \"ingress/templates/deployment-ingress.yaml\" at \u003cappend\u003e: wrong number of args for append: want 2 got 4\"","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"7b4324beb9a552f332287ab99d916eb1e65f03a6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_1544d11a","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_d5eb790f","updated":"2020-06-10 18:13:21.000000000","message":"Error: parse error in \"ingress/templates/deployment-ingress.yaml\": template: ingress/templates/deployment-ingress.yaml:170: function \"concat\" not defined","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"8079ca42ac2aa4a18cea93aa486a1e6c7a1dd7a4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-conf.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":181,"context_line":"{{- $containers :\u003d (list \"init\" \"ingress\") }}"},{"line_number":182,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.manage }}"},{"line_number":183,"context_line":"{{- $containers \u003d (list \"init\" \"ingress\" \"ingress-vip-kernel-modules\" \"ingress-vip-init\" \"ingress-vip\") }}"},{"line_number":184,"context_line":"{{- end }}"},{"line_number":185,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ingress-server\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":186,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_82db821f","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":40},"in_reply_to":"ff570b3c_f0920bfc","updated":"2020-06-10 20:33:28.000000000","message":"Yes Andrii, Thanks this seems like working as expected.\ncontainer.apparmor.security.beta.kubernetes.io/ingress-vip-kernel-modules: runtime/default\n        container.apparmor.security.beta.kubernetes.io/ingress-vip-init: runtime/default\n        container.apparmor.security.beta.kubernetes.io/ingress-vip: runtime/default","commit_id":"cccca8d98be499534449e96cfb6bb224e9c81c7c"}]}
