)]}'
{"kibana/templates/deployment.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"371213c81a66a7970d215b8906dfffaaceeea3e1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          ports:"},{"line_number":123,"context_line":"            - name: kibana"},{"line_number":124,"context_line":"              containerPort: {{ tuple \"kibana\" \"internal\" \"kibana\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":125,"context_line":"{{ dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"liveness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":126,"context_line":"{{/* dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"readiness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 */}}"},{"line_number":127,"context_line":"          readinessProbe:"},{"line_number":128,"context_line":"            exec:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_77929cfe","line":125,"range":{"start_line":125,"start_character":63,"end_line":125,"end_character":77},"updated":"2020-06-09 01:05:22.000000000","message":"what happens to the liveness probe?","commit_id":"341b0e93f2944a2d15b769c04aa285759bcf2f97"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"f0297f63669d9f73737f3d8112752ed8c7a96e87","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          ports:"},{"line_number":123,"context_line":"            - name: kibana"},{"line_number":124,"context_line":"              containerPort: {{ tuple \"kibana\" \"internal\" \"kibana\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":125,"context_line":"{{ dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"liveness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":126,"context_line":"{{/* dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"readiness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 */}}"},{"line_number":127,"context_line":"          readinessProbe:"},{"line_number":128,"context_line":"            exec:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_fd94cd8e","line":125,"range":{"start_line":125,"start_character":63,"end_line":125,"end_character":77},"in_reply_to":"ff570b3c_77929cfe","updated":"2020-06-09 03:28:54.000000000","message":"Great point","commit_id":"341b0e93f2944a2d15b769c04aa285759bcf2f97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"371213c81a66a7970d215b8906dfffaaceeea3e1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"          readinessProbe:"},{"line_number":128,"context_line":"            exec:"},{"line_number":129,"context_line":"              command:"},{"line_number":130,"context_line":"                - \"cat\""},{"line_number":131,"context_line":"                - \"/tmp/started\""},{"line_number":132,"context_line":"            initialDelaySeconds: 20"},{"line_number":133,"context_line":"            periodSeconds: 30"},{"line_number":134,"context_line":"          env:"},{"line_number":135,"context_line":"            - name: ELASTICSEARCH_HOSTS"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_37fb0448","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":34},"updated":"2020-06-09 01:05:22.000000000","message":"If the start() method executes and touched this file, the readinessProbe would immediately succeed, and as nothing will ever remove that file, this will continue to be READY and never file - in essence removing the readinessProbe all together.\n\nIf there is an issue with long wait with ES update, perhaps we can make this more robust by using a bash/py script to better handle readiness.","commit_id":"341b0e93f2944a2d15b769c04aa285759bcf2f97"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"f0297f63669d9f73737f3d8112752ed8c7a96e87","unresolved":false,"context_lines":[{"line_number":127,"context_line":"          readinessProbe:"},{"line_number":128,"context_line":"            exec:"},{"line_number":129,"context_line":"              command:"},{"line_number":130,"context_line":"                - \"cat\""},{"line_number":131,"context_line":"                - \"/tmp/started\""},{"line_number":132,"context_line":"            initialDelaySeconds: 20"},{"line_number":133,"context_line":"            periodSeconds: 30"},{"line_number":134,"context_line":"          env:"},{"line_number":135,"context_line":"            - name: ELASTICSEARCH_HOSTS"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_bdc9b5ad","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":34},"in_reply_to":"ff570b3c_37fb0448","updated":"2020-06-09 03:28:54.000000000","message":"You\u0027re right -  I updated this change to make the probes toggle-able. In situations where the readiness check is interrupting deployment pipelines, we can disable it. Now that 733489 is merged, I hope those situations become quite rare in the future.","commit_id":"341b0e93f2944a2d15b769c04aa285759bcf2f97"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7967f8555aea3a0c65129884df595590a3120ec6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          ports:"},{"line_number":123,"context_line":"            - name: kibana"},{"line_number":124,"context_line":"              containerPort: {{ tuple \"kibana\" \"internal\" \"kibana\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":125,"context_line":"{{- if .Values.pod.probes.kibana.enabled }}"},{"line_number":126,"context_line":"{{ dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"liveness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":127,"context_line":"{{ dict \"envAll\" . \"component\" \"kibana\" \"container\" \"kibana\" \"type\" \"readiness\" \"probeTemplate\" (include \"kibanaProbeTemplate\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":128,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_3d3914d8","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":43},"updated":"2020-06-09 17:15:09.000000000","message":"does this make more sense if moved to L20?","commit_id":"9d49e2d01fe441897f7672e4d5622ae2fdb2079f"}],"kibana/values.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"b7e2ac90bdb227d484e5d921bde88c7afa78ca02","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      enabled: true"},{"line_number":124,"context_line":"      kibana:"},{"line_number":125,"context_line":"        liveness:"},{"line_number":126,"context_line":"          enabled: true"},{"line_number":127,"context_line":"          params:"},{"line_number":128,"context_line":"            initialDelaySeconds: 180"},{"line_number":129,"context_line":"            periodSeconds: 60"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_dd59f835","line":126,"range":{"start_line":126,"start_character":10,"end_line":126,"end_character":23},"updated":"2020-06-09 17:16:10.000000000","message":"this is already overridable","commit_id":"9d49e2d01fe441897f7672e4d5622ae2fdb2079f"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"b7e2ac90bdb227d484e5d921bde88c7afa78ca02","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            initialDelaySeconds: 180"},{"line_number":129,"context_line":"            periodSeconds: 60"},{"line_number":130,"context_line":"        readiness:"},{"line_number":131,"context_line":"          enabled: true"},{"line_number":132,"context_line":"          params:"},{"line_number":133,"context_line":"            initialDelaySeconds: 20"},{"line_number":134,"context_line":"            periodSeconds: 30"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_9d4f8069","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":23},"updated":"2020-06-09 17:16:10.000000000","message":"ditto","commit_id":"9d49e2d01fe441897f7672e4d5622ae2fdb2079f"}]}