)]}'
{"id":"openstack%2Fopenstack-helm-infra~734140","triplet_id":"openstack%2Fopenstack-helm-infra~master~I2818cad57ada671b307c2ba92729d56e210d8b44","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"I2818cad57ada671b307c2ba92729d56e210d8b44","subject":"Kibana Make Probes Toggleable","status":"ABANDONED","created":"2020-06-08 16:26:59.000000000","updated":"2020-06-09 17:22:24.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f36f5235ff3a6c7ed43bdf60126bfd5c8b63a6e3","_number":734140,"virtual_id_number":734140,"owner":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-09 04:02:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"date":"2020-06-09 17:17:52.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"date":"2020-06-09 17:15:09.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-06-09 17:16:10.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":1,"date":"2020-06-09 15:08:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-09 04:02:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-09 15:08:06.000000000","updated_by":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"reviewer":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"state":"REVIEWER"},{"updated":"2020-06-09 17:15:09.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-06-09 17:16:10.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"REVIEWER"}],"messages":[{"id":"065ed5c93fc7b673626b3ab26d15d5f6d0538ad9","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-08 16:26:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2fcb7ab629fbc71d1f1a55744d3bef2f7ad0affc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 17:34:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77a05283eafa409a96bc922c95ffd37e : SUCCESS in 3m 24s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/333e677079634a10807e758961072b3f : SUCCESS in 1m 58s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/fea29336e8aa4fd2b08eb789b3098982 : SUCCESS in 39m 10s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/2bd3366031594bf7b8f04902dddc1415 : SUCCESS in 42m 13s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/06220217cd874fd29a0ce5aea1370353 : SUCCESS in 1h 02m 16s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/d626e5ab04864ea28fb47fa8f3f82586 : SUCCESS in 13m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a640315bd5d77842e1a9db21cac6e4700b3d82ea","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-08 20:30:56.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d1a3b1b0f06dcc8bbd790f5dcc03b5be92713d1e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 22:12:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8233e29daf5e4e29a986285a022afde0 : SUCCESS in 11m 58s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/beaa1355c33d4ce9a2e9b29300e333b9 : SUCCESS in 3m 38s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/64b2ea6d50764fccbb09f307309946ef : SUCCESS in 40m 51s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/51a7e4825e0448fcb9344d5aa40e1fb1 : SUCCESS in 43m 04s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/14d36e21f33a4779a5f0e2a2cc82545b : SUCCESS in 1h 05m 12s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/b2534bf60b2e4743b3bcbb28e2e1567e : SUCCESS in 15m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"371213c81a66a7970d215b8906dfffaaceeea3e1","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-06-09 01:05:22.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1918d18e7cc5b52a68243106c8c197d464e5c4da","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-09 03:08:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f0297f63669d9f73737f3d8112752ed8c7a96e87","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-09 03:28:54.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6ef077793e9149fca4c179d0ab8da0b2ea4c80d6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 04:02:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9aa1481c94c14836bfabc4cc1d9e31f7 : SUCCESS in 3m 20s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/3974b7809759404ca7e65135d04a30db : SUCCESS in 1m 38s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/c2cac7010db4453ea577c11f093b781d : SUCCESS in 43m 32s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/84d4b5c22aeb4ddcb08eb32cfa2d7313 : SUCCESS in 42m 09s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/3d6f656adff549e298601f5e6bb8daaa : SUCCESS in 53m 28s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/2f150aeffd104ae083c2220108e69d63 : SUCCESS in 14m 11s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e0c70a6f25dac0616ea94f86496b8065a6390a34","author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"date":"2020-06-09 15:08:06.000000000","message":"Patch Set 3: Code-Review+1\n\ngood idea Steven","accounts_in_message":[],"_revision_number":3},{"id":"7967f8555aea3a0c65129884df595590a3120ec6","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-06-09 17:15:09.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b7e2ac90bdb227d484e5d921bde88c7afa78ca02","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2020-06-09 17:16:10.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)\n\nWhy is this required, instead of using the existing configuration parameters?","accounts_in_message":[],"_revision_number":3},{"id":"53a134e00281ee800f8127897b26c181a7492f49","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-09 17:16:32.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n\nI\u0027m not sure. Do you mean wrapping the probe template section with this if statement as well?","accounts_in_message":[],"_revision_number":3},{"id":"e6605f67bcb9d5d7294aa9e2f4e5335429087122","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-09 17:17:52.000000000","message":"Patch Set 3:\n\n\u003e (2 comments)\n \u003e \n \u003e Why is this required, instead of using the existing configuration\n \u003e parameters?\n\nThank you Phil, makes sense. I will update this","accounts_in_message":[],"_revision_number":3},{"id":"f36f5235ff3a6c7ed43bdf60126bfd5c8b63a6e3","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-06-09 17:22:24.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9d49e2d01fe441897f7672e4d5622ae2fdb2079f","revisions":{"982eae296ae95b9644029fe5a9935a052d7e59e4":{"kind":"REWORK","_number":1,"created":"2020-06-08 16:26:59.000000000","uploader":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"ref":"refs/changes/40/734140/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/40/734140/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/1"}}},"commit":{"parents":[{"commit":"309278389e6362202f97b24ac67d9732fd79a522","subject":"Elasticsearch: Update Rolling Restart Procedure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/309278389e6362202f97b24ac67d9732fd79a522"}]}],"author":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-08 16:25:39.000000000","tz":-300},"committer":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-08 16:25:39.000000000","tz":-300},"subject":"[test] Change Kibana Readiness Probe to File","message":"[test] Change Kibana Readiness Probe to File\n\nThis is to get around an akward situation where kibana does not\nbecome ready until all ES data pods of a previous version have\nleft the cluster.\n\nChange-Id: I2818cad57ada671b307c2ba92729d56e210d8b44\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/982eae296ae95b9644029fe5a9935a052d7e59e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/982eae296ae95b9644029fe5a9935a052d7e59e4"}]},"branch":"refs/heads/master"},"341b0e93f2944a2d15b769c04aa285759bcf2f97":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-06-08 20:30:56.000000000","uploader":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"ref":"refs/changes/40/734140/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/40/734140/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/2"}}},"commit":{"parents":[{"commit":"309278389e6362202f97b24ac67d9732fd79a522","subject":"Elasticsearch: Update Rolling Restart Procedure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/309278389e6362202f97b24ac67d9732fd79a522"}]}],"author":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-08 16:25:39.000000000","tz":-300},"committer":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-08 20:30:46.000000000","tz":-300},"subject":"Change Kibana Readiness Probe to File","message":"Change Kibana Readiness Probe to File\n\nThis is to get around an akward situation where kibana does not\nbecome ready until all ES data pods of a previous version have\nleft the cluster.\n\nChange-Id: I2818cad57ada671b307c2ba92729d56e210d8b44\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/341b0e93f2944a2d15b769c04aa285759bcf2f97"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/341b0e93f2944a2d15b769c04aa285759bcf2f97"}]},"branch":"refs/heads/master"},"9d49e2d01fe441897f7672e4d5622ae2fdb2079f":{"kind":"REWORK","_number":3,"created":"2020-06-09 03:08:14.000000000","uploader":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"ref":"refs/changes/40/734140/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/40/734140/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/40/734140/3"}}},"commit":{"parents":[{"commit":"309278389e6362202f97b24ac67d9732fd79a522","subject":"Elasticsearch: Update Rolling Restart Procedure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/309278389e6362202f97b24ac67d9732fd79a522"}]}],"author":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-08 16:25:39.000000000","tz":-300},"committer":{"name":"Steven Fitzpatrick","email":"steven.fitzpatrick@att.com","date":"2020-06-09 03:07:36.000000000","tz":-300},"subject":"Kibana Make Probes Toggleable","message":"Kibana Make Probes Toggleable\n\nThis is to get around an akward situation where kibana does not\nbecome ready until all ES data pods of a previous version have\nleft the cluster.\n\nChange-Id: I2818cad57ada671b307c2ba92729d56e210d8b44\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9d49e2d01fe441897f7672e4d5622ae2fdb2079f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9d49e2d01fe441897f7672e4d5622ae2fdb2079f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
