)]}'
{"ceph-osd/templates/bin/osd/ceph-volume/_init-with-ceph-volume.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"6eeadd19dd5ee17066935f1fb875a7942f0e3adf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  local device_type\u003d$3"},{"line_number":45,"context_line":"  local device_string VG DEVICE_OSD_ID logical_devices logical_volume"},{"line_number":46,"context_line":"  device_string\u003d$(echo \"${BLOCK_DEVICE#/}\" | tr \u0027/\u0027 \u0027-\u0027)"},{"line_number":47,"context_line":"  VG\u003d$(vgs | grep \"${device_string}\" | awk \u0027{print $1}\u0027)"},{"line_number":48,"context_line":"  if [[ $VG ]]; then"},{"line_number":49,"context_line":"    DEVICE_OSD_ID\u003d$(get_osd_id_from_volume \"/dev/ceph-vg-${device_string}/ceph-${device_type}-${osd_dev_string}\")"},{"line_number":50,"context_line":"    CEPH_LVM_PREPARE\u003d1"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_244dfb99","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":10},"updated":"2020-06-23 18:33:31.000000000","message":"https://review.opendev.org/711991 added a sync lock here to avoid a race condition that was causing OSD init errors. Why has it been removed?","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"43592a7cb8c81feaae6735a86cba16abcea4f128","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  local device_type\u003d$3"},{"line_number":45,"context_line":"  local device_string VG DEVICE_OSD_ID logical_devices logical_volume"},{"line_number":46,"context_line":"  device_string\u003d$(echo \"${BLOCK_DEVICE#/}\" | tr \u0027/\u0027 \u0027-\u0027)"},{"line_number":47,"context_line":"  VG\u003d$(vgs | grep \"${device_string}\" | awk \u0027{print $1}\u0027)"},{"line_number":48,"context_line":"  if [[ $VG ]]; then"},{"line_number":49,"context_line":"    DEVICE_OSD_ID\u003d$(get_osd_id_from_volume \"/dev/ceph-vg-${device_string}/ceph-${device_type}-${osd_dev_string}\")"},{"line_number":50,"context_line":"    CEPH_LVM_PREPARE\u003d1"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_3a4d129a","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":10},"in_reply_to":"bf51134e_244dfb99","updated":"2020-06-23 20:14:04.000000000","message":"I know about that. And I made a set of tests on the same environment:\n1. before the PS which you mentioned. And obviously I was hitting the issue. \n2. with your PS. The issue was not present at that time (was fixed)\n3. And, obviously, with the current PS. It\u0027s working correctly with shared disk.\n(not able to see the issue as well)\n\nPlease keep in mind that you updated several lines(#405-#419).\nAnd added \"locked\" in many places like below:\nlocked vgcreate ...\nlocked lvcreate ... \nlocked ceph-volume lvm -v prepare ${CLI_OPTS}\n\nBut I don\u0027t think that we need \"locked\" for vgs/pvs/lvs. It\u0027s redundant. And as I mentioned it was verified locally. I\u0027ll do another round of verification  in a target environment when I have access to it.","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"6eeadd19dd5ee17066935f1fb875a7942f0e3adf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"  else"},{"line_number":59,"context_line":"    options\u003d\"--noheadings -o+lv_dm_path -o-pv_fmt,pv_name,vg_name,pv_attr,pv_size,pv_free\""},{"line_number":60,"context_line":"    logical_devices\u003d$(pvs ${options} -S \"pv_name\u003d~${BLOCK_DEVICE},lv_name\u003d~ceph--vg--dev--${osd_dev_split}\")"},{"line_number":61,"context_line":"    if [[ -n \"$logical_devices\" ]]; then"},{"line_number":62,"context_line":"      dmsetup remove $logical_devices"},{"line_number":63,"context_line":"      disk_zap \"${OSD_DEVICE}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_4448ef85","line":60,"range":{"start_line":60,"start_character":22,"end_line":60,"end_character":25},"updated":"2020-06-23 18:33:31.000000000","message":"Same as above.","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"43592a7cb8c81feaae6735a86cba16abcea4f128","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"  else"},{"line_number":59,"context_line":"    options\u003d\"--noheadings -o+lv_dm_path -o-pv_fmt,pv_name,vg_name,pv_attr,pv_size,pv_free\""},{"line_number":60,"context_line":"    logical_devices\u003d$(pvs ${options} -S \"pv_name\u003d~${BLOCK_DEVICE},lv_name\u003d~ceph--vg--dev--${osd_dev_split}\")"},{"line_number":61,"context_line":"    if [[ -n \"$logical_devices\" ]]; then"},{"line_number":62,"context_line":"      dmsetup remove $logical_devices"},{"line_number":63,"context_line":"      disk_zap \"${OSD_DEVICE}\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_7a430a6d","line":60,"range":{"start_line":60,"start_character":22,"end_line":60,"end_character":25},"in_reply_to":"bf51134e_4448ef85","updated":"2020-06-23 20:14:04.000000000","message":"same","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"6eeadd19dd5ee17066935f1fb875a7942f0e3adf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    VG\u003dceph-vg-${device_string}"},{"line_number":67,"context_line":"    locked vgcreate \"$VG\" \"${BLOCK_DEVICE}\""},{"line_number":68,"context_line":"  fi"},{"line_number":69,"context_line":"  logical_volume\u003d$(lvs | grep \"ceph-${device_type}-${osd_dev_string}\" | awk \u0027{print $1}\u0027)"},{"line_number":70,"context_line":"  if [[ $logical_volume !\u003d \"ceph-${device_type}-${osd_dev_string}\" ]]; then"},{"line_number":71,"context_line":"    locked lvcreate -L \"${BLOCK_DEVICE_SIZE}\" -n \"ceph-${device_type}-${osd_dev_string}\" \"${VG}\""},{"line_number":72,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_845de748","line":69,"range":{"start_line":69,"start_character":19,"end_line":69,"end_character":22},"updated":"2020-06-23 18:33:31.000000000","message":"Same as above.","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"43592a7cb8c81feaae6735a86cba16abcea4f128","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    VG\u003dceph-vg-${device_string}"},{"line_number":67,"context_line":"    locked vgcreate \"$VG\" \"${BLOCK_DEVICE}\""},{"line_number":68,"context_line":"  fi"},{"line_number":69,"context_line":"  logical_volume\u003d$(lvs | grep \"ceph-${device_type}-${osd_dev_string}\" | awk \u0027{print $1}\u0027)"},{"line_number":70,"context_line":"  if [[ $logical_volume !\u003d \"ceph-${device_type}-${osd_dev_string}\" ]]; then"},{"line_number":71,"context_line":"    locked lvcreate -L \"${BLOCK_DEVICE_SIZE}\" -n \"ceph-${device_type}-${osd_dev_string}\" \"${VG}\""},{"line_number":72,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_5a48c685","line":69,"range":{"start_line":69,"start_character":19,"end_line":69,"end_character":22},"in_reply_to":"bf51134e_845de748","updated":"2020-06-23 20:14:04.000000000","message":"same","commit_id":"7273379cc25a4b79b371b69eaca3cf1981a73493"}]}