)]}'
{"id":"openstack%2Fopenstack-helm-infra~738489","triplet_id":"openstack%2Fopenstack-helm-infra~master~I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06","subject":"Fix drop databases issue in Postgresql restore","status":"MERGED","created":"2020-06-29 18:44:09.000000000","updated":"2020-07-01 23:08:14.000000000","submitted":"2020-07-01 23:06:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"738489-1593644785303-8c5a5b72","meta_rev_id":"8a42cbc15ee6cc7ef16f4bb612e8f7ca310b2e12","_number":738489,"virtual_id_number":738489,"owner":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-01 23:06:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":0,"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"recommended":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-07-01 15:25:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},{"value":2,"date":"2020-07-01 20:53:24.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2020-07-01 21:34:05.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":1,"date":"2020-07-01 15:54:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":1,"date":"2020-07-01 20:56:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2020-07-01 21:26:54.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":0,"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":1,"date":"2020-07-01 21:26:54.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-29 20:35:12.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2020-07-01 15:25:48.000000000","updated_by":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"reviewer":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"state":"REVIEWER"},{"updated":"2020-07-01 15:54:26.000000000","updated_by":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"reviewer":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"state":"REVIEWER"},{"updated":"2020-07-01 20:53:24.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-07-01 20:56:34.000000000","updated_by":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"reviewer":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"state":"REVIEWER"},{"updated":"2020-07-01 21:26:54.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-07-01 21:34:05.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2020-07-01 23:06:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"26abdd8f94f8b6d5b16d5712d348b3c6695cf432","author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"date":"2020-06-29 18:44:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ef057e9559bc88334025f3e6a7425227e5a7380","author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"date":"2020-06-29 18:46:27.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f007aebdb3dfdacf5d253c8ffff74aeafe845401","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-29 19:47:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b2573925601e424788458cb034d7f72e : SUCCESS in 4m 14s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/26ac834c1ea04e799bd64a5cb1778b83 : SUCCESS in 2m 34s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/ae65d5b2739a46f08daf172b9a979ce1 : SUCCESS in 38m 54s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/a6b520d3f6004a81b3b6124994baf532 : SUCCESS in 43m 24s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/83ba617273354e35972b04b308e46ead : SUCCESS in 56m 12s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/be3cc0e2b4ba426a9d3739a029de251b : SUCCESS in 13m 50s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/199a785118604c358b94cb5630e95abd : SUCCESS in 16m 54s","accounts_in_message":[],"_revision_number":2},{"id":"97e8ca96f3206ec1f19f2185defb1930637210a4","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2020-06-29 20:35:12.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ad88cea93997819428af6968c2002dfaa40bfe63","author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"date":"2020-06-30 19:08:38.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"1271c4a0d2d90fa08ff12a80b7c0282b198cfa37","author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"date":"2020-06-30 19:39:09.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"21363781cc26c0e86c92784a2cfd3b010f8357e6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 20:45:52.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96cd751aaacb4b0ca032933e1b0099d7 : SUCCESS in 4m 38s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/0841c8fcaf1d44698091e9781fab14e0 : SUCCESS in 4m 01s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/604d3fd719d9440490cb1fbfca03a994 : SUCCESS in 51m 46s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/d38c722613b442d9bf2f019c36ae5a17 : SUCCESS in 54m 53s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/2ff08160b9c842ae8872911728c9b737 : SUCCESS in 1h 05m 13s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/85cc4106a3ec40e88e1cac5c02efbefe : SUCCESS in 17m 45s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/2c0fa75dfda54c559cbc7a04b637dfdb : SUCCESS in 23m 24s","accounts_in_message":[],"_revision_number":4},{"id":"cacab1ce2d2f3af14b93df124643436233816ea9","author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"date":"2020-07-01 15:25:48.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e693d1f99201d863c2ecca86ad936da26fc1dd6c","author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"date":"2020-07-01 15:54:26.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"fa20bd4564022695876c5b47ce8ebd5a92c5cfb7","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-07-01 20:53:24.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"1780cc9f1a00ae3b5e766bcdc576fa0ec3395cdb","author":{"_account_id":28849,"name":"Meghan Heisler","email":"mkheisler93@gmail.com","username":"mh783g"},"date":"2020-07-01 20:56:34.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"2ad0923b06a3eed8b4bc5e1a1e14c92066f6be97","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-07-01 21:26:54.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"887d168468b4209822dc2f3e30d0c5e1a68f7c71","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 21:27:07.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"2049cb77c23f98da14bd42f5aa6afba2d2101900","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-07-01 21:34:05.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"3b7c210f24b992251a2ec7000386d5f8578c7d64","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 23:06:25.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b77594e864946738221d3274026a9cf : SUCCESS in 4m 36s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/82e625237d204431b64047c578a8a2d7 : SUCCESS in 3m 07s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/dd9707241c714ad69f96d7b13c5bca75 : SUCCESS in 40m 23s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/5c9fd4ddfc444ac1a9eef2d90a95261b : SUCCESS in 47m 32s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/2c409dc69e72427ebb6125e23fd24d53 : SUCCESS in 1h 05m 46s","accounts_in_message":[],"_revision_number":4},{"id":"a88914e4f15a18273391e41e7a55d63a06b354b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 23:06:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"8a42cbc15ee6cc7ef16f4bb612e8f7ca310b2e12","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 23:08:14.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e93122cee22740b484d4b5770adf425c : SUCCESS in 1m 31s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4964ea2a762bba5fcbae5941fbbfc13e62cdb95f","revisions":{"eed9ee54e7b0963a4e66900261489b7f4a7b9920":{"kind":"REWORK","_number":1,"created":"2020-06-29 18:44:09.000000000","uploader":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"ref":"refs/changes/89/738489/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/89/738489/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/1"}}},"commit":{"parents":[{"commit":"7cb3ef69ae479358f7b07852de645a19e3907203","subject":"feat(tls): add tls support to helm-toolkit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7cb3ef69ae479358f7b07852de645a19e3907203"}]}],"author":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:16:41.000000000","tz":0},"committer":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:44:01.000000000","tz":0},"subject":"Fix drop databases issue in Postgresql restore","message":"Fix drop databases issue in Postgresql restore\n\nRecently, the Postgresql backups were modified to generate drop database\ncommands (--clean pgdumpall option). Also for single database restore,\na DROP DATABASE command was added before the restore so that the\ndatabase could be restored without duplicate rows. However, if there are\nexisting database connections (by the applications or other users), then\nthe drop database commands will fail. So for the duration of the restore\ndatabase operation, the databases being restored need to have their\nexisting connections dropped and new connections prevented until the\ndatabase(s) restored, then connections should be re-allowed.\n\nAlso found a problem with psql returning 0 (success code) even though\nthere were errors during its execution. The solution is to check the\noutput for errors and if there are any, dump out the log file for the\nuser to see and let the user know there are errors.\n\nChange-Id: I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/eed9ee54e7b0963a4e66900261489b7f4a7b9920"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/eed9ee54e7b0963a4e66900261489b7f4a7b9920"}]},"branch":"refs/heads/master"},"ab7f6c6713df72970ed501a87cdf6685ca0ef0c9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-06-29 18:46:27.000000000","uploader":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"ref":"refs/changes/89/738489/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/89/738489/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/2"}}},"commit":{"parents":[{"commit":"7cb3ef69ae479358f7b07852de645a19e3907203","subject":"feat(tls): add tls support to helm-toolkit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7cb3ef69ae479358f7b07852de645a19e3907203"}]}],"author":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:16:41.000000000","tz":0},"committer":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:44:38.000000000","tz":0},"subject":"Fix drop databases issue in Postgresql restore","message":"Fix drop databases issue in Postgresql restore\n\nRecently, the Postgresql backups were modified to generate drop database\ncommands (--clean pgdumpall option). Also for single database restore,\na DROP DATABASE command was added before the restore so that the\ndatabase could be restored without duplicate rows. However, if there are\nexisting database connections (by the applications or other users), then\nthe drop database commands will fail. So for the duration of the restore\ndatabase operation, the databases being restored need to have their\nexisting connections dropped and new connections prevented until the\ndatabase(s) restored, then connections should be re-allowed.\n\nAlso found a problem with psql returning 0 (success code) even though\nthere were errors during its execution. The solution is to check the\noutput for errors and if there are any, dump out the log file for the\nuser to see and let the user know there are errors.\n\nLastly, a problem was found with the single database restortion, where\nthe database dump for a single database was being incorrectly extracted\nfrom the psql dump file, resulting in the database not being restored\ncorrectly (most of the db being wiped out!). This patchset fixes that\nissue as well.\n\nChange-Id: I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ab7f6c6713df72970ed501a87cdf6685ca0ef0c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ab7f6c6713df72970ed501a87cdf6685ca0ef0c9"}]},"branch":"refs/heads/master"},"b6adbec277ece7d9a9378a896d0413065cc0375a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-06-30 19:08:38.000000000","uploader":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"ref":"refs/changes/89/738489/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/89/738489/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/3"}}},"commit":{"parents":[{"commit":"1508324ce7f683da93c5344343e3da031fac816d","subject":"Fix return code when backup to remote rgw fails","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/1508324ce7f683da93c5344343e3da031fac816d"}]}],"author":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:16:41.000000000","tz":0},"committer":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-30 19:08:38.000000000","tz":0},"subject":"Fix drop databases issue in Postgresql restore","message":"Fix drop databases issue in Postgresql restore\n\nRecently, the Postgresql backups were modified to generate drop database\ncommands (--clean pgdumpall option). Also for single database restore,\na DROP DATABASE command was added before the restore so that the\ndatabase could be restored without duplicate rows. However, if there are\nexisting database connections (by the applications or other users), then\nthe drop database commands will fail. So for the duration of the restore\ndatabase operation, the databases being restored need to have their\nexisting connections dropped and new connections prevented until the\ndatabase(s) restored, then connections should be re-allowed.\n\nAlso found a problem with psql returning 0 (success code) even though\nthere were errors during its execution. The solution is to check the\noutput for errors and if there are any, dump out the log file for the\nuser to see and let the user know there are errors.\n\nLastly, a problem was found with the single database restortion, where\nthe database dump for a single database was being incorrectly extracted\nfrom the psql dump file, resulting in the database not being restored\ncorrectly (most of the db being wiped out!). This patchset fixes that\nissue as well.\n\nChange-Id: I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b6adbec277ece7d9a9378a896d0413065cc0375a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b6adbec277ece7d9a9378a896d0413065cc0375a"}]},"branch":"refs/heads/master"},"4964ea2a762bba5fcbae5941fbbfc13e62cdb95f":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2020-06-30 19:39:09.000000000","uploader":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"ref":"refs/changes/89/738489/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/89/738489/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/89/738489/4"}}},"commit":{"parents":[{"commit":"1508324ce7f683da93c5344343e3da031fac816d","subject":"Fix return code when backup to remote rgw fails","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/1508324ce7f683da93c5344343e3da031fac816d"}]}],"author":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-29 18:16:41.000000000","tz":0},"committer":{"name":"Cliff Parsons","email":"cliff.parsons@att.com","date":"2020-06-30 19:39:00.000000000","tz":0},"subject":"Fix drop databases issue in Postgresql restore","message":"Fix drop databases issue in Postgresql restore\n\nRecently, the Postgresql backups were modified to generate drop database\ncommands (--clean pgdumpall option). Also for single database restore,\na DROP DATABASE command was added before the restore so that the\ndatabase could be restored without duplicate rows. However, if there are\nexisting database connections (by the applications or other users), then\nthe drop database commands will fail. So for the duration of the restore\ndatabase operation, the databases being restored need to have their\nexisting connections dropped and new connections prevented until the\ndatabase(s) restored, then connections should be re-allowed.\n\nAlso found a problem with psql returning 0 (success code) even though\nthere were errors during its execution. The solution is to check the\noutput for errors and if there are any, dump out the log file for the\nuser to see and let the user know there are errors.\n\nLastly, a problem was found with the single database restortion, where\nthe database dump for a single database was being incorrectly extracted\nfrom the psql dump file, resulting in the database not being restored\ncorrectly (most of the db being wiped out). This patchset fixes that\nissue as well.\n\nChange-Id: I4db3f6ac7e9fe7cce6a432dfba056e17ad1e3f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/4964ea2a762bba5fcbae5941fbbfc13e62cdb95f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/4964ea2a762bba5fcbae5941fbbfc13e62cdb95f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}