)]}'
{"helm-toolkit/templates/manifests/_job-db-init-mysql.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"6fc1bee287a5c2f41e657dea2721a9781a8565e2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                secretKeyRef:"},{"line_number":74,"context_line":"                  name: {{ $dbToInit.adminSecret | quote }}"},{"line_number":75,"context_line":"                  key: DB_CONNECTION"},{"line_number":76,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":77,"context_line":"            - name: DB_USER_HOST"},{"line_number":78,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":79,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"bf51134e_f58e7230","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":39},"updated":"2020-07-05 17:42:10.000000000","message":"mysql runs in cni space\n\nif this is an IP we have no way of setting this cleanly do we?\n\nmight it not still be almost as good to not have the host restriction ?","commit_id":"d7700151c757774952df1972864d2487e3443f56"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"427383ef7947b3f27f921a67e91f099f44cc68e7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                secretKeyRef:"},{"line_number":74,"context_line":"                  name: {{ $dbToInit.adminSecret | quote }}"},{"line_number":75,"context_line":"                  key: DB_CONNECTION"},{"line_number":76,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":77,"context_line":"            - name: DB_USER_HOST"},{"line_number":78,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":79,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"bf51134e_35c6f94a","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":39},"in_reply_to":"bf51134e_f58e7230","updated":"2020-07-08 11:08:23.000000000","message":"Yes, these is no way to cleanly get the cni ip/cidr to set this.\n\nBut, setting wildcards to hostnames seems to be not recommended security wise. This will at least enable users to  override to avoid the wildcards.","commit_id":"d7700151c757774952df1972864d2487e3443f56"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75abc1e2fbb20db760bed239fec02cc1259a4aa3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                secretKeyRef:"},{"line_number":74,"context_line":"                  name: {{ $dbToInit.adminSecret | quote }}"},{"line_number":75,"context_line":"                  key: DB_CONNECTION"},{"line_number":76,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":77,"context_line":"            - name: DB_USER_HOST"},{"line_number":78,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":79,"context_line":"{{- end }}"},{"line_number":80,"context_line":"{{- if eq $dbToInitType \"oslo\" }}"},{"line_number":81,"context_line":"            - name: OPENSTACK_CONFIG_FILE"},{"line_number":82,"context_line":"              value: {{ $dbToInit.configFile | quote }}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"bf51134e_2e222a02","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":10},"updated":"2020-07-08 13:28:03.000000000","message":"I agree with Chris - how does one specify this IP in practice? Can you update values.yaml at the gate to demonstrate how a user can take use of this?","commit_id":"c469d3990e0cc99830918fa0eebeeb37d49d982d"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"56e63e713fdd240c78e584069b294180e0e5aa73","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                secretKeyRef:"},{"line_number":74,"context_line":"                  name: {{ $dbToInit.adminSecret | quote }}"},{"line_number":75,"context_line":"                  key: DB_CONNECTION"},{"line_number":76,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":77,"context_line":"            - name: DB_USER_HOST"},{"line_number":78,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":79,"context_line":"{{- end }}"},{"line_number":80,"context_line":"{{- if eq $dbToInitType \"oslo\" }}"},{"line_number":81,"context_line":"            - name: OPENSTACK_CONFIG_FILE"},{"line_number":82,"context_line":"              value: {{ $dbToInit.configFile | quote }}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"bf51134e_f0abb2d2","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":10},"in_reply_to":"bf51134e_2e222a02","updated":"2020-07-13 07:59:43.000000000","message":"Done","commit_id":"c469d3990e0cc99830918fa0eebeeb37d49d982d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c1a31da478ef829c65511d7f76bf8edc50ced6c4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                  key: DB_CONNECTION"},{"line_number":77,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":78,"context_line":"            - name: DB_USER_HOST"},{"line_number":79,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if eq $dbToInitType \"oslo\" }}"},{"line_number":82,"context_line":"            - name: OPENSTACK_CONFIG_FILE"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"bf51134e_2c2aab7d","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":57},"updated":"2020-07-17 05:41:10.000000000","message":"| quote","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"dcd095634b7d10489e53fda4307dced865e99741","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                  key: DB_CONNECTION"},{"line_number":77,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":78,"context_line":"            - name: DB_USER_HOST"},{"line_number":79,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if eq $dbToInitType \"oslo\" }}"},{"line_number":82,"context_line":"            - name: OPENSTACK_CONFIG_FILE"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"bf51134e_f2288898","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":57},"in_reply_to":"bf51134e_2c2aab7d","updated":"2020-07-17 09:59:09.000000000","message":"Done","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"acb5bc3cad4658940883a9147fdae58cd60784b8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                secretKeyRef:"},{"line_number":75,"context_line":"                  name: {{ $dbToInit.adminSecret | quote }}"},{"line_number":76,"context_line":"                  key: DB_CONNECTION"},{"line_number":77,"context_line":"{{- if $envAll.Values.conf.db_user_host }}"},{"line_number":78,"context_line":"            - name: DB_USER_HOST"},{"line_number":79,"context_line":"              value: {{ $envAll.Values.conf.db_user_host }}"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if eq $dbToInitType \"oslo\" }}"},{"line_number":82,"context_line":"            - name: OPENSTACK_CONFIG_FILE"},{"line_number":83,"context_line":"              value: {{ $dbToInit.configFile | quote }}"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"bf51134e_2f1ac1c4","line":80,"range":{"start_line":77,"start_character":1,"end_line":80,"end_character":10},"updated":"2020-07-15 13:17:07.000000000","message":"Just a suggestion, you can set the default value of this env variable to %% then you do not need if checks here.","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"}],"mariadb/templates/bin/_start.py.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c1a31da478ef829c65511d7f76bf8edc50ced6c4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"The dbadmin username should not match the sst user username\")"},{"line_number":112,"context_line":"    sys.exit(1)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"mysql_dbuser_host \u003d os.environ.get(\u0027DB_USER_HOST\u0027, \u0027%\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# Set some variables for tuneables"},{"line_number":117,"context_line":"cluster_leader_ttl \u003d 120"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"bf51134e_6c24a3b0","line":114,"range":{"start_line":114,"start_character":50,"end_line":114,"end_character":54},"updated":"2020-07-17 05:41:10.000000000","message":"should this be also %%?","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"ad24f804457cb7b51e11ef177cf6422e2938b637","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"The dbadmin username should not match the sst user username\")"},{"line_number":112,"context_line":"    sys.exit(1)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"mysql_dbuser_host \u003d os.environ.get(\u0027DB_USER_HOST\u0027, \u0027%\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# Set some variables for tuneables"},{"line_number":117,"context_line":"cluster_leader_ttl \u003d 120"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"bf51134e_8c113761","line":114,"range":{"start_line":114,"start_character":50,"end_line":114,"end_character":54},"in_reply_to":"bf51134e_6c24a3b0","updated":"2020-07-17 07:35:01.000000000","message":"This can be \u0027%\u0027.","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"}],"mariadb/templates/statefulset.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c1a31da478ef829c65511d7f76bf8edc50ced6c4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            {{- end }}"},{"line_number":178,"context_line":"            {{- if .Values.conf.db_user_host }}"},{"line_number":179,"context_line":"            - name: DB_USER_HOST"},{"line_number":180,"context_line":"              value: {{ .Values.conf.db_user_host }}"},{"line_number":181,"context_line":"            {{- end }}"},{"line_number":182,"context_line":"          ports:"},{"line_number":183,"context_line":"            - name: mysql"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bf51134e_cc384fd6","line":180,"range":{"start_line":180,"start_character":48,"end_line":180,"end_character":50},"updated":"2020-07-17 05:41:10.000000000","message":"| quote","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"dcd095634b7d10489e53fda4307dced865e99741","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            {{- end }}"},{"line_number":178,"context_line":"            {{- if .Values.conf.db_user_host }}"},{"line_number":179,"context_line":"            - name: DB_USER_HOST"},{"line_number":180,"context_line":"              value: {{ .Values.conf.db_user_host }}"},{"line_number":181,"context_line":"            {{- end }}"},{"line_number":182,"context_line":"          ports:"},{"line_number":183,"context_line":"            - name: mysql"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bf51134e_321cc076","line":180,"range":{"start_line":180,"start_character":48,"end_line":180,"end_character":50},"in_reply_to":"bf51134e_cc384fd6","updated":"2020-07-17 09:59:09.000000000","message":"Done","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"}],"mariadb/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"6fc1bee287a5c2f41e657dea2721a9781a8565e2","unresolved":false,"context_lines":[{"line_number":371,"context_line":"      max_connections\u003d8192"},{"line_number":372,"context_line":"      max-connect-errors\u003d1000000"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"      secure-file-priv\u003d/var/lib/mysql"},{"line_number":375,"context_line":"      local-infile\u003d0"},{"line_number":376,"context_line":"      symbolic-links\u003d0"},{"line_number":377,"context_line":"      sql-mode\u003d\"STRICT_ALL_TABLES,STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION\""},{"line_number":378,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_35990a79","line":375,"range":{"start_line":374,"start_character":6,"end_line":375,"end_character":20},"updated":"2020-07-05 17:42:10.000000000","message":"does this really make things better?\n\ndo we have untrusted mounts?","commit_id":"d7700151c757774952df1972864d2487e3443f56"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"427383ef7947b3f27f921a67e91f099f44cc68e7","unresolved":false,"context_lines":[{"line_number":371,"context_line":"      max_connections\u003d8192"},{"line_number":372,"context_line":"      max-connect-errors\u003d1000000"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"      secure-file-priv\u003d/var/lib/mysql"},{"line_number":375,"context_line":"      local-infile\u003d0"},{"line_number":376,"context_line":"      symbolic-links\u003d0"},{"line_number":377,"context_line":"      sql-mode\u003d\"STRICT_ALL_TABLES,STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION\""},{"line_number":378,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_f55c81ee","line":375,"range":{"start_line":374,"start_character":6,"end_line":375,"end_character":20},"in_reply_to":"bf51134e_35990a79","updated":"2020-07-08 11:08:23.000000000","message":"There seem to be no untrusted mounts.\n\nAccording to mysql security considerations, it would be better to restrict/disable these than leaving them enabled.","commit_id":"d7700151c757774952df1972864d2487e3443f56"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c1a31da478ef829c65511d7f76bf8edc50ced6c4","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"- job:"},{"line_number":412,"context_line":"    name: openstack-helm-infra-openstack-support-dbhost"},{"line_number":413,"context_line":"    parent: openstack-helm-infra-functional"},{"line_number":414,"context_line":"    timeout: 7200"},{"line_number":415,"context_line":"    pre-run: playbooks/osh-infra-upgrade-host.yaml"},{"line_number":416,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bf51134e_0c3367f8","line":413,"range":{"start_line":413,"start_character":11,"end_line":413,"end_character":43},"updated":"2020-07-17 05:41:10.000000000","message":"do we just change the parent so we don\u0027t need to redeclare all the gate_scripts?","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":29397,"name":"Kudaka Poorna Rajesh","email":"rajesh.kudaka@imaginea.com","username":"rajesh.kudaka"},"change_message_id":"dcd095634b7d10489e53fda4307dced865e99741","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"- job:"},{"line_number":412,"context_line":"    name: openstack-helm-infra-openstack-support-dbhost"},{"line_number":413,"context_line":"    parent: openstack-helm-infra-functional"},{"line_number":414,"context_line":"    timeout: 7200"},{"line_number":415,"context_line":"    pre-run: playbooks/osh-infra-upgrade-host.yaml"},{"line_number":416,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bf51134e_72163858","line":413,"range":{"start_line":413,"start_character":11,"end_line":413,"end_character":43},"in_reply_to":"bf51134e_0c3367f8","updated":"2020-07-17 09:59:09.000000000","message":"Done","commit_id":"22f0f897eb61fcde203c0c0fd433cc2d414bc318"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"82efc985e5f72f1555fa47e0743ecd89e457fcfc","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"- job:"},{"line_number":412,"context_line":"    name: openstack-helm-infra-openstack-support-dbhost"},{"line_number":413,"context_line":"    parent: openstack-helm-infra-support"},{"line_number":414,"context_line":"    timeout: 7200"},{"line_number":415,"context_line":"    pre-run: playbooks/osh-infra-upgrade-host.yaml"},{"line_number":416,"context_line":"    run: playbooks/osh-infra-gate-runner.yaml"},{"line_number":417,"context_line":"    required-projects:"},{"line_number":418,"context_line":"      - openstack/openstack-helm"},{"line_number":419,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":420,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":421,"context_line":"    vars:"},{"line_number":422,"context_line":"      osh_params:"},{"line_number":423,"context_line":"        container_distro_name: ubuntu"},{"line_number":424,"context_line":"        container_distro_version: bionic"},{"line_number":425,"context_line":"        feature_gates: dbhost"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"- job:"},{"line_number":428,"context_line":"    name: openstack-helm-infra-five-ubuntu"},{"line_number":429,"context_line":"    parent: openstack-helm-infra"},{"line_number":430,"context_line":"    nodeset: openstack-helm-five-node-ubuntu"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_8c43f76c","line":428,"range":{"start_line":413,"start_character":2,"end_line":428,"end_character":0},"updated":"2020-07-17 07:20:19.000000000","message":"Job openstack-helm-infra-support not defined","commit_id":"acea0589cd72954d516be428d8abd2e181d054c4"}]}