)]}'
{"id":"openstack%2Fopenstack-helm-infra~739137","triplet_id":"openstack%2Fopenstack-helm-infra~master~Ie42af89551bd8804b87fe936c676e85130564187","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"Ie42af89551bd8804b87fe936c676e85130564187","subject":"allocate_data_node function improvement","status":"MERGED","created":"2020-07-02 19:25:03.000000000","updated":"2020-07-08 21:43:24.000000000","submitted":"2020-07-08 21:41:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"739137-1594244508682-326f21e0","meta_rev_id":"21c01244364cb05081a3d89646bb009eb403a271","_number":739137,"virtual_id_number":739137,"owner":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-08 21:41:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-08 13:44:09.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":1,"date":"2020-07-08 14:43:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},{"value":2,"date":"2020-07-08 20:22:36.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2020-07-08 20:22:45.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},{"value":1,"date":"2020-07-08 20:22:36.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-02 19:25:24.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2020-07-02 19:26:59.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2020-07-08 13:44:09.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2020-07-08 14:43:55.000000000","updated_by":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"reviewer":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"state":"REVIEWER"},{"updated":"2020-07-08 20:22:36.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2020-07-08 20:22:45.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-07-08 21:41:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e1fceb4aa42722ddd815bb946735ac688294c3d0","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-02 19:25:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"802bcd851b7ed74a82b848d71e53001849d54f5e","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2020-07-02 19:25:24.000000000","message":"Patch Set 1:\n\nCongratulations, you\u0027ve proposed your first change in OpenDev.\n\nYour submission will now be tested automatically by Zuul, our gatekeeper,\nand reviewed by other friendly developers. They will give you feedback and\nmay require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches often take days (and sometimes weeks) to get reviewed, so be\npatient. Don\u0027t hesitate to ask for help, and answer questions about your\nwork promptly if you can. The more you get to know reviewers and get to be\nknown by them, the smoother the review and approval process will become. The\nfastest way to accomplish this is by reviewing other proposed changes\nyourself: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for participating in OpenDev, we look forward to seeing you\naround.\n\nWorkflow Guide: https://docs.openstack.org/infra/manual/developers.html","accounts_in_message":[],"_revision_number":1},{"id":"3660f7e6da0f72c36a98f033ee5ed88b1c12ea11","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2020-07-02 19:26:59.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6b1509645c950e83da7ddb8b3db96d1ace432a05","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-02 19:42:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8a1802ceff09fbce290b12c71f53bb9ca18d03d3","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2020-07-02 20:21:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f3ec83e052b8b4a2b7af058fcdc3cda44847ac21","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2020-07-02 20:24:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8a8f0e5bf7434da41dd26ad7833f8ca61ae1e5f0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-02 20:32:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7cbf171be5f47fe9458a67ef4661184 : SUCCESS in 7m 43s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/461781b974b641e1810e6f20db6f83bb : SUCCESS in 4m 15s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/9dcf445db0bb4dedb240059cf68274be : SUCCESS in 42m 36s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/67acfdbd836d4c6aad52b9701a980397 : SUCCESS in 49m 07s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/0b7f742dda8b4676bd9b3b3fa3fc9783 : SUCCESS in 1h 00m 18s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/decedbf30ca74a40ab69d598bd839980 : SUCCESS in 15m 29s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/fc9328c1e77c409abe8b88deb2862b86 : SUCCESS in 22m 45s","accounts_in_message":[],"_revision_number":1},{"id":"234d727a92dcc25a5baa8f21c3a3aa8116cdd3f9","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-02 21:18:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d03ea74f96f584e788aef4ab50a6fc6ae3004d8e","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-02 21:22:13.000000000","message":"Patch Set 2:\n\nI\u0027m not saying we should remove the trap. I\u0027m just saying allocate_data_node() would be better run after start_data_node() is complete. I update the code a little bit and we can sync again Monday. I have great long weekend.","accounts_in_message":[],"_revision_number":2},{"id":"ec537e35fc07ddd54d989f835d0d4aad53786545","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-02 22:44:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8ad85073aefe45919c01a9edb0c66afd : SUCCESS in 4m 32s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/c7637eb04770453bb6999457d10d84bc : SUCCESS in 3m 45s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/696d8d64b080465994e9730819e0ce5b : SUCCESS in 42m 04s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/1b135c1e6e3d48e780d626675ce30a5a : SUCCESS in 39m 54s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/c2c1c52217054de5be782455a2f67269 : SUCCESS in 1h 03m 04s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/99edb7850c4d4e22841f9ec706a8fe6d : SUCCESS in 14m 08s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/093ad4cdd0a843c09538544b32e0bba3 : SUCCESS in 16m 01s","accounts_in_message":[],"_revision_number":2},{"id":"436f77c99f1b30d12f8951a6aa5996a582bb877c","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2020-07-05 17:36:45.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"fbb6b4c209c8eeef5046b33d30ca986b0f150ab2","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-06 14:13:42.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"115b398732fa0601809f4c46115f3cbf1b97693b","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-06 14:15:19.000000000","message":"Patch Set 3:\n\nCould you please review the updated codes?\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"ccf4e3cfeba7b44b5fb572962cc1435a7fd256c5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-06 15:23:33.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c1ca25f13814f6387f292ab4167812d : SUCCESS in 4m 46s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/744658a4ed444e1493153c43cde34457 : SUCCESS in 4m 10s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/d72c449b4a1a41dd86bcadf3c7583ece : FAILURE in 48m 43s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/ca116cc154534a958ed8597ee3250ca2 : SUCCESS in 43m 18s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/d5e462ad66d248e49f99ea057bbbf64f : SUCCESS in 1h 02m 00s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/20d5bcb7c99c40b983b280e9bcce0fdb : SUCCESS in 13m 58s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/e0d78b22e0dd4ec590ad5aee47bb34f2 : SUCCESS in 20m 37s","accounts_in_message":[],"_revision_number":3},{"id":"5e0e7125a8a4b80b432eaf6f62ccb5f97902933f","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-07-06 21:17:33.000000000","message":"Patch Set 3:\n\n(1 comment)\n\n\u003e (1 comment)\n\nIn https://review.opendev.org/733489 I changed the functionality of the drain function according to: https://www.elastic.co/guide/en/elasticsearch/reference/7.x/restart-cluster.html#restart-cluster-rolling\n\nSince we know that the node will be coming back online soon, we tell the cluster to not create new replica shards while the node is down. Once the node comes back online, we change that setting back to its default. Once all nodes have restarted we should have a green cluster again while avoiding a lot of I/O caused by re-allocating shards.\n\nI\u0027m not sure exactly what the sequence of events is which leaves us with cluster.routing.allocation.enable set to primaries only.","accounts_in_message":[],"_revision_number":3},{"id":"5d3adef9d874c138ced26b51379d3eb2ac521745","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-07 16:02:47.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ae0e0718c8a3f49e258a4116bd6bbfa0a2d68b2f","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-07 16:07:51.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"cd5f93a6de1ea2024737494e8616817a947c0a78","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-07-07 16:16:12.000000000","message":"Patch Set 5: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":5},{"id":"8f579fb68eb4f705c7a2fbe3a4259b65ea34a23a","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-07 16:20:06.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ce4470cc1fc500ba6aced33b36cd5be6dcde8303","author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"date":"2020-07-07 16:31:39.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"be911b84ab5209d8529d927f803e9f8650fc9805","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-07 17:46:40.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48ee924a15d94021a8a0700c64df4a8a : SUCCESS in 9m 02s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/6dc7cddff86c48e8872d0b316ba756c1 : SUCCESS in 3m 12s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/6da264c4a8c04321b9270f859d78a103 : SUCCESS in 42m 29s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/eb926e1d932345c8bf17b21dc464244a : SUCCESS in 44m 20s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/0e1bfa1402974fb1a92af0375dc0bd7e : SUCCESS in 58m 15s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/03fd4a291a3f459f8da6b2e332fe4670 : SUCCESS in 14m 40s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/b3f490da81154e9d9b356056528eebcc : SUCCESS in 20m 59s","accounts_in_message":[],"_revision_number":7},{"id":"cfd298d8d124bd7c477901ab3113e60638c5d2e9","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-07-08 13:44:09.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"0bf8de79ee8bca21e045d318d1018b10eb78b6f2","author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"date":"2020-07-08 14:43:55.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"efccc94189138b3866fe602bc3e46974a3d86f34","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2020-07-08 20:22:36.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"b6b266913304db5ee16642afc4dbd22c44c66535","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-07-08 20:22:45.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"e189652a8069538217e7951935ef0cf4ab65a340","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 20:22:52.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"067a9ef1c9556234b8cf308812bc3bbfba85c8b4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 21:41:48.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/109ba29b34e6430c9e3799197ab9f1c7 : SUCCESS in 4m 19s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/1aa04e801745488f90621ae9807d5bdd : SUCCESS in 3m 30s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/29bdb0bafd0f46dd9e74cb941faed14c : SUCCESS in 49m 43s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/b91c38e665c04c8d8454c935341fc6c9 : SUCCESS in 49m 12s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/fdb22ca1bd66483e9c811c82bfb992b5 : SUCCESS in 1h 17m 00s","accounts_in_message":[],"_revision_number":7},{"id":"7c2786bf92d2709dd9a71773e31c3fc509061b06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 21:41:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"21c01244364cb05081a3d89646bb009eb403a271","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 21:43:24.000000000","message":"Patch Set 7:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/94d93af1efa84f3895bdd6049c715707 : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"e89c1c3c06c75ae84b61f384aba5e8a458ad4c57","revisions":{"73222528a338c066a7de89beed6fa8078edb0cd1":{"kind":"REWORK","_number":1,"created":"2020-07-02 19:25:03.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/1"}}},"commit":{"parents":[{"commit":"bfe7a99a61e49ccd9ef9d73f181862646f92e6b8","subject":"[CEPH] Make ceph-volume as default deployment tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/bfe7a99a61e49ccd9ef9d73f181862646f92e6b8"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:25:02.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\nallocate_data_node() should execute after drain_data_node()\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/73222528a338c066a7de89beed6fa8078edb0cd1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/73222528a338c066a7de89beed6fa8078edb0cd1"}]},"branch":"refs/heads/master"},"5087b16d240fc2bd69dde11e8472b6f5155b2b91":{"kind":"REWORK","_number":2,"created":"2020-07-02 21:18:25.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/2"}}},"commit":{"parents":[{"commit":"bfe7a99a61e49ccd9ef9d73f181862646f92e6b8","subject":"[CEPH] Make ceph-volume as default deployment tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/bfe7a99a61e49ccd9ef9d73f181862646f92e6b8"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 21:14:47.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\n- allocate_data_node() should execute after drain_data_node()\n- enable alloation moved outside the wait_to_join check loop\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5087b16d240fc2bd69dde11e8472b6f5155b2b91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/5087b16d240fc2bd69dde11e8472b6f5155b2b91"}]},"branch":"refs/heads/master"},"63786eab6b8e78a0de690acbb970ec7d5eb75896":{"kind":"REWORK","_number":3,"created":"2020-07-06 14:13:42.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/3"}}},"commit":{"parents":[{"commit":"2b4cf6a2d95a668416b7d4fdfe49918bf64d2197","subject":"Completely switch to python3 for developers installation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2b4cf6a2d95a668416b7d4fdfe49918bf64d2197"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-06 14:11:21.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\n- allocate_data_node() should execute after drain_data_node()\n- enable alloation moved outside the wait_to_join check loop\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/63786eab6b8e78a0de690acbb970ec7d5eb75896"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/63786eab6b8e78a0de690acbb970ec7d5eb75896"}]},"branch":"refs/heads/master"},"9116b059bdcc648d6f1c6b2b8f65adc834aafb95":{"kind":"REWORK","_number":4,"created":"2020-07-07 16:02:47.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/4"}}},"commit":{"parents":[{"commit":"88b79920db193ccef5527f38ad5f9f3ffd603541","subject":"Merge \"[rabbitmq] Upgrade to 3.7.26\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/88b79920db193ccef5527f38ad5f9f3ffd603541"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-07 15:56:17.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\nremove \"if\" condition of allocate_data_node\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9116b059bdcc648d6f1c6b2b8f65adc834aafb95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/9116b059bdcc648d6f1c6b2b8f65adc834aafb95"}]},"branch":"refs/heads/master"},"995c5323d76058bad42204ad67ee45d6965b228e":{"kind":"REWORK","_number":5,"created":"2020-07-07 16:07:51.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/5"}}},"commit":{"parents":[{"commit":"88b79920db193ccef5527f38ad5f9f3ffd603541","subject":"Merge \"[rabbitmq] Upgrade to 3.7.26\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/88b79920db193ccef5527f38ad5f9f3ffd603541"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-07 16:07:03.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\nremove \"if\" condition of allocate_data_node\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/995c5323d76058bad42204ad67ee45d6965b228e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/995c5323d76058bad42204ad67ee45d6965b228e"}]},"branch":"refs/heads/master"},"b856291329074271f3a0cc891f3c91ba95be17dc":{"kind":"REWORK","_number":6,"created":"2020-07-07 16:20:06.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/6"}}},"commit":{"parents":[{"commit":"88b79920db193ccef5527f38ad5f9f3ffd603541","subject":"Merge \"[rabbitmq] Upgrade to 3.7.26\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/88b79920db193ccef5527f38ad5f9f3ffd603541"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-07 16:19:44.000000000","tz":-240},"subject":"allocate_data_node","message":"allocate_data_node\n\nremove \"if\" condition of allocate_data_node\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b856291329074271f3a0cc891f3c91ba95be17dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/b856291329074271f3a0cc891f3c91ba95be17dc"}]},"branch":"refs/heads/master"},"e89c1c3c06c75ae84b61f384aba5e8a458ad4c57":{"kind":"REWORK","_number":7,"created":"2020-07-07 16:31:39.000000000","uploader":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"ref":"refs/changes/37/739137/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/37/739137/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/37/739137/7"}}},"commit":{"parents":[{"commit":"88b79920db193ccef5527f38ad5f9f3ffd603541","subject":"Merge \"[rabbitmq] Upgrade to 3.7.26\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/88b79920db193ccef5527f38ad5f9f3ffd603541"}]}],"author":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-02 19:16:37.000000000","tz":-240},"committer":{"name":"willxz","email":"xz8905@att.com","date":"2020-07-07 16:28:21.000000000","tz":-240},"subject":"allocate_data_node function improvement","message":"allocate_data_node function improvement\n\n- Remove \"if\" condition of allocate_data_node\n- Dealy 5 seconds for wait_to_join initial check to start\n- Set 60 minutes timeout for wait_to_join function\n\nChange-Id: Ie42af89551bd8804b87fe936c676e85130564187\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/e89c1c3c06c75ae84b61f384aba5e8a458ad4c57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/e89c1c3c06c75ae84b61f384aba5e8a458ad4c57"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}