)]}'
{"ceph-client/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":14029,"name":"Alexander Vlasov","email":"vlasov.alexandr89@gmail.com","username":"avlasov"},"change_message_id":"2dd841d72665daab95d5f52746079c2a2c1f9190","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  if [ ${num_osd} -eq 1 ]; then"},{"line_number":38,"context_line":"    MIN_OSDS\u003d${num_osd}"},{"line_number":39,"context_line":"  else"},{"line_number":40,"context_line":"    MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":41,"context_line":"  fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ \"${num_osd}\" -eq 0 ]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bf51134e_7771a3de","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":58},"updated":"2020-07-07 18:32:06.000000000","message":"is this correct? as shell doesn\u0027t do floating point arithmetics","commit_id":"94e9f4198ae3c6df1d0087e43d6ec4e68a379c8d"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"bcd1fdee773c30b19f8484fed4577da773fbb935","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  if [ ${num_osd} -eq 1 ]; then"},{"line_number":38,"context_line":"    MIN_OSDS\u003d${num_osd}"},{"line_number":39,"context_line":"  else"},{"line_number":40,"context_line":"    MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":41,"context_line":"  fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ \"${num_osd}\" -eq 0 ]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bf51134e_12a155aa","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":58},"in_reply_to":"bf51134e_7771a3de","updated":"2020-07-07 19:10:41.000000000","message":"yes. it\u0027s correct.","commit_id":"94e9f4198ae3c6df1d0087e43d6ec4e68a379c8d"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"b9138783df16ffd8177529d21aeafa09f5915c66","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  num_in_osds\u003d$(ceph osd stat | tr \u0027 \u0027 \u0027\\n\u0027 | grep -x -E \u0027[0-9]+\u0027 | tail -n1)"},{"line_number":35,"context_line":"  num_up_osds\u003d$(ceph osd stat | tr \u0027 \u0027 \u0027\\n\u0027 | grep -x -E \u0027[0-9]+\u0027 | head -n2 | tail -n1)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if [ ${num_osd} -eq 1 ]; then"},{"line_number":38,"context_line":"    MIN_OSDS\u003d${num_osd}"},{"line_number":39,"context_line":"  else"},{"line_number":40,"context_line":"    MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":41,"context_line":"  fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ \"${num_osd}\" -eq 0 ]; then"},{"line_number":44,"context_line":"    echo \"There are no osds in the cluster\""}],"source_content_type":"text/x-smarty","patch_set":4,"id":"bf51134e_65443148","line":41,"range":{"start_line":37,"start_character":0,"end_line":41,"end_character":4},"updated":"2020-07-09 05:30:39.000000000","message":"i feel some inconsistency in this logic.\nwe\u0027re limiting to 1 for 1 osd disregarding percentage, though not limiting to 1 for N osd with \n\nN*percentage/100 \u003c 1\n\nI understand you don\u0027t introduce this logic here, though this may be a flaw and you expect it to be \u003e1","commit_id":"49bcb02bee1ac8723d87e9b45ee8b660ebb13b39"}]}