)]}'
{"prometheus-alertmanager/templates/bin/_alertmanager.sh.tpl":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  final_pod_suffix\u003d$(( {{ .Values.pod.replicas.alertmanager }}-1 ))"},{"line_number":30,"context_line":"  for pod_suffix in `seq 0 \"$final_pod_suffix\"`"},{"line_number":31,"context_line":"  do"},{"line_number":32,"context_line":"    echo --cluster.peer\u003d{{ .Values.Release.Name }}-$pod_suffix.$DISCOVERY_SVC:$MESH_PORT"},{"line_number":33,"context_line":"  done"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_77cd5185","line":32,"range":{"start_line":32,"start_character":50,"end_line":32,"end_character":51},"updated":"2020-07-21 20:17:27.000000000","message":"There is a missing \"-alertmanager-\" here, right?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  final_pod_suffix\u003d$(( {{ .Values.pod.replicas.alertmanager }}-1 ))"},{"line_number":30,"context_line":"  for pod_suffix in `seq 0 \"$final_pod_suffix\"`"},{"line_number":31,"context_line":"  do"},{"line_number":32,"context_line":"    echo --cluster.peer\u003d{{ .Values.Release.Name }}-$pod_suffix.$DISCOVERY_SVC:$MESH_PORT"},{"line_number":33,"context_line":"  done"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_97e1052e","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":35},"updated":"2020-07-21 20:17:27.000000000","message":"We don\u0027t need to reference .Values here, since .Release.Name is a built-in object\n\nhttps://helm.sh/docs/chart_template_guide/builtin_objects/","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  final_pod_suffix\u003d$(( {{ .Values.pod.replicas.alertmanager }}-1 ))"},{"line_number":30,"context_line":"  for pod_suffix in `seq 0 \"$final_pod_suffix\"`"},{"line_number":31,"context_line":"  do"},{"line_number":32,"context_line":"    echo --cluster.peer\u003d{{ .Values.Release.Name }}-$pod_suffix.$DISCOVERY_SVC:$MESH_PORT"},{"line_number":33,"context_line":"  done"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"bf51134e_72bc236c","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":35},"in_reply_to":"bf51134e_97e1052e","updated":"2020-07-22 21:40:35.000000000","message":"removed release.name and changed with hardcoded string for now.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/templates/clusterrolebinding.yaml":[{"author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"change_message_id":"ef690f10b062a9623c10751939095d464c2d038e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.clusterrolebinding }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"prometheus-alertmanager\" }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":20,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_61675353","line":17,"updated":"2020-07-21 19:10:36.000000000","message":"shouldnt this be .Values.Release.Name ?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.clusterrolebinding }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"prometheus-alertmanager\" }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":20,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_f79e8167","line":17,"in_reply_to":"bf51134e_61675353","updated":"2020-07-21 20:17:27.000000000","message":"This should match the serviceAccountName we set in the statefulset I think?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.clusterrolebinding }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"prometheus-alertmanager\" }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":20,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_4dea240e","line":17,"in_reply_to":"bf51134e_61675353","updated":"2020-07-22 21:40:35.000000000","message":"updated","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.clusterrolebinding }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"prometheus-alertmanager\" }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":20,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8df43cf3","line":17,"in_reply_to":"bf51134e_f79e8167","updated":"2020-07-22 21:40:35.000000000","message":"updated.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/templates/job-image-repo-sync.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.job_image_repo_sync .Values.images.local_registry.active }}"},{"line_number":16,"context_line":"{{- $imageRepoSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"prometheus-alertmanager\" -}}"},{"line_number":17,"context_line":"{{ $imageRepoSyncJob | include \"helm-toolkit.manifests.job_image_repo_sync\" }}"},{"line_number":18,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_5745ad14","line":16,"range":{"start_line":16,"start_character":55,"end_line":16,"end_character":67},"updated":"2020-07-21 20:17:27.000000000","message":"Probably unnecessary to change this job name","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.job_image_repo_sync .Values.images.local_registry.active }}"},{"line_number":16,"context_line":"{{- $imageRepoSyncJob :\u003d dict \"envAll\" . \"serviceName\" \"prometheus-alertmanager\" -}}"},{"line_number":17,"context_line":"{{ $imageRepoSyncJob | include \"helm-toolkit.manifests.job_image_repo_sync\" }}"},{"line_number":18,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_0de02c26","line":16,"range":{"start_line":16,"start_character":55,"end_line":16,"end_character":67},"in_reply_to":"bf51134e_5745ad14","updated":"2020-07-22 21:40:35.000000000","message":"reversed.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/templates/network_policy.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License. */}}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{- if .Values.manifests.network_policy -}}"},{"line_number":15,"context_line":"{{- $netpol_opts :\u003d dict \"envAll\" . \"name\" \"application\" \"label\" \"prometheus-alertmanager\" -}}"},{"line_number":16,"context_line":"{{ $netpol_opts | include \"helm-toolkit.manifests.kubernetes_network_policy\" }}"},{"line_number":17,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_7792715a","line":15,"range":{"start_line":15,"start_character":66,"end_line":15,"end_character":89},"updated":"2020-07-21 20:17:27.000000000","message":"Since this is used to look up a yaml key in values.yaml, I don\u0027t think \u0027-\u0027 is an allowed character","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License. */}}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{- if .Values.manifests.network_policy -}}"},{"line_number":15,"context_line":"{{- $netpol_opts :\u003d dict \"envAll\" . \"name\" \"application\" \"label\" \"prometheus-alertmanager\" -}}"},{"line_number":16,"context_line":"{{ $netpol_opts | include \"helm-toolkit.manifests.kubernetes_network_policy\" }}"},{"line_number":17,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_adcae09d","line":15,"range":{"start_line":15,"start_character":66,"end_line":15,"end_character":89},"in_reply_to":"bf51134e_7792715a","updated":"2020-07-22 21:40:35.000000000","message":"reversed.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/templates/secret-ingress-tls.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.secret_ingress_tls }}"},{"line_number":16,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendServiceType\" \"alerts\" \"backendService\" \"prometheus-alertmanager\") }}"},{"line_number":17,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_578f6d2d","line":16,"range":{"start_line":16,"start_character":121,"end_line":16,"end_character":134},"updated":"2020-07-21 20:17:27.000000000","message":"Same thing about the \u0027-\u0027","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.secret_ingress_tls }}"},{"line_number":16,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendServiceType\" \"alerts\" \"backendService\" \"prometheus-alertmanager\") }}"},{"line_number":17,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_cdbe34ff","line":16,"range":{"start_line":16,"start_character":121,"end_line":16,"end_character":134},"in_reply_to":"bf51134e_578f6d2d","updated":"2020-07-22 21:40:35.000000000","message":"reversed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/templates/statefulset.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $mounts_alertmanager :\u003d .Values.pod.mounts.alertmanager.alertmanager }}"},{"line_number":19,"context_line":"{{- $mounts_alertmanager_init :\u003d .Values.pod.mounts.alertmanager.init_container }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $serviceAccountName :\u003d \"prometheus-alertmanager\" }}"},{"line_number":22,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: apps/v1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_97c46561","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":55},"updated":"2020-07-21 20:17:27.000000000","message":"This should match what we have in the ClusterRoleBinding template, right?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $mounts_alertmanager :\u003d .Values.pod.mounts.alertmanager.alertmanager }}"},{"line_number":19,"context_line":"{{- $mounts_alertmanager_init :\u003d .Values.pod.mounts.alertmanager.init_container }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $serviceAccountName :\u003d \"prometheus-alertmanager\" }}"},{"line_number":22,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: apps/v1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_ed48582f","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":55},"in_reply_to":"bf51134e_97c46561","updated":"2020-07-22 21:40:35.000000000","message":"yes. and it\u0027s matches now.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: apps/v1"},{"line_number":25,"context_line":"kind: StatefulSet"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: prometheus-alertmanager"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":30,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_1c123c0a","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":19},"updated":"2020-07-21 20:17:27.000000000","message":"We should change this to .Release.Name to stay consistent with what we have in that alertmanager.sh script. Otherwise we could end up with broken DNS looksups, since the pods of this statefulset will take after this name.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: apps/v1"},{"line_number":25,"context_line":"kind: StatefulSet"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: prometheus-alertmanager"},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":30,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_6d5e08ea","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":19},"in_reply_to":"bf51134e_1c123c0a","updated":"2020-07-22 21:40:35.000000000","message":"removed the usage of release.name","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"prometheus-alertmanager\" \"containerNames\" (list \"prometheus-alertmanager\" \"prometheus-alertmanager-perms\" \"init\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":48,"context_line":"    spec:"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":50,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_771f1109","line":47,"range":{"start_line":47,"start_character":85,"end_line":47,"end_character":140},"updated":"2020-07-21 20:17:27.000000000","message":"Same thing about the hyphens. These need to match what\u0027s in values.yaml too. (See the HTK MAC template code for more details","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"prometheus-alertmanager\" \"containerNames\" (list \"prometheus-alertmanager\" \"prometheus-alertmanager-perms\" \"init\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":48,"context_line":"    spec:"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":50,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_3726396a","line":47,"range":{"start_line":47,"start_character":36,"end_line":47,"end_character":59},"updated":"2020-07-21 20:17:27.000000000","message":"This is used to lookup a yaml key in values.yaml, and I don\u0027t think \u0027-\u0027 is an allowed character for yaml keys","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"prometheus-alertmanager\" \"containerNames\" (list \"prometheus-alertmanager\" \"prometheus-alertmanager-perms\" \"init\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":48,"context_line":"    spec:"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":50,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_12a5e747","line":47,"range":{"start_line":47,"start_character":36,"end_line":47,"end_character":59},"in_reply_to":"bf51134e_3726396a","updated":"2020-07-22 21:40:35.000000000","message":"I don\u0027t see any issues or errror with hyphen in statefulset. but anyhow, I changed them.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"prometheus-alertmanager\" \"containerNames\" (list \"prometheus-alertmanager\" \"prometheus-alertmanager-perms\" \"init\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":48,"context_line":"    spec:"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":50,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8d5b9cf4","line":47,"range":{"start_line":47,"start_character":85,"end_line":47,"end_character":140},"in_reply_to":"bf51134e_771f1109","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"ee49fe67d5db4270a569bedfab8156d58fffb2b6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" | indent 8 }}"},{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"prometheus-alertmanager\" \"containerNames\" (list \"prometheus-alertmanager\" \"prometheus-alertmanager-perms\" \"init\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":48,"context_line":"    spec:"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":50,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_adb66089","line":47,"range":{"start_line":47,"start_character":85,"end_line":47,"end_character":140},"in_reply_to":"bf51134e_8d5b9cf4","updated":"2020-07-22 22:16:16.000000000","message":"Oh, I might have been mistaken about this then","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        {{ .Values.labels.alertmanager.node_selector_key }}: {{ .Values.labels.alertmanager.node_selector_value | quote }}"},{"line_number":55,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.alertmanager.timeout | default \"30\" }}"},{"line_number":56,"context_line":"      initContainers:"},{"line_number":57,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_f7d0412e","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":41},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027 char","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        {{ .Values.labels.alertmanager.node_selector_key }}: {{ .Values.labels.alertmanager.node_selector_value | quote }}"},{"line_number":55,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.alertmanager.timeout | default \"30\" }}"},{"line_number":56,"context_line":"      initContainers:"},{"line_number":57,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_6d03a8bf","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":41},"in_reply_to":"bf51134e_f7d0412e","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager_perms\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":62,"context_line":"          command:"},{"line_number":63,"context_line":"            - chown"},{"line_number":64,"context_line":"            - -R"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_57e12dfc","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":46},"updated":"2020-07-21 20:17:27.000000000","message":"Here\u0027s another personal nit where I would rename this to \u0027alertmanager\u0027 and change the corresponding entry in values.yaml - but it\u0027s just a name and works I guess.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager_perms\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":62,"context_line":"          command:"},{"line_number":63,"context_line":"            - chown"},{"line_number":64,"context_line":"            - -R"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_17e055fa","line":61,"range":{"start_line":61,"start_character":61,"end_line":61,"end_character":90},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027 and matching whats in values.yaml","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager_perms\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":62,"context_line":"          command:"},{"line_number":63,"context_line":"            - chown"},{"line_number":64,"context_line":"            - -R"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_4d06a4cf","line":61,"range":{"start_line":61,"start_character":61,"end_line":61,"end_character":90},"in_reply_to":"bf51134e_17e055fa","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: prometheus-alertmanager-perms"},{"line_number":59,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager_perms\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":62,"context_line":"          command:"},{"line_number":63,"context_line":"            - chown"},{"line_number":64,"context_line":"            - -R"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8d10bc02","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":46},"in_reply_to":"bf51134e_57e12dfc","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        - name: prometheus-alertmanager"},{"line_number":74,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":75,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":76,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":77,"context_line":"          command:"},{"line_number":78,"context_line":"            - /tmp/alertmanager.sh"},{"line_number":79,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_97ebc5da","line":76,"range":{"start_line":76,"start_character":61,"end_line":76,"end_character":84},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        - name: prometheus-alertmanager"},{"line_number":74,"context_line":"{{ tuple $envAll \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":75,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.alertmanager | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":76,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"server\" \"container\" \"prometheus-alertmanager\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":77,"context_line":"          command:"},{"line_number":78,"context_line":"            - /tmp/alertmanager.sh"},{"line_number":79,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8d427c0e","line":76,"range":{"start_line":76,"start_character":61,"end_line":76,"end_character":84},"in_reply_to":"bf51134e_97ebc5da","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus-alertmanager/values.yaml":[{"author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"change_message_id":"9d9cdd05d6ad826318e580353d4a8c310a4f22ff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# name: value"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_9c712c10","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2020-07-21 19:11:58.000000000","message":"shouldnt these variables be in lowercase?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# name: value"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_724a6383","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"bf51134e_9c712c10","updated":"2020-07-22 21:40:35.000000000","message":"removed this section.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"change_message_id":"9d9cdd05d6ad826318e580353d4a8c310a4f22ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_fc5f8872","line":20,"updated":"2020-07-21 19:11:58.000000000","message":"same as above","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_92473778","line":20,"in_reply_to":"bf51134e_d7d41d4a","updated":"2020-07-22 21:40:35.000000000","message":"you are right. this is built-in variable for Helm. no need for that so removed.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_d7d41d4a","line":20,"in_reply_to":"bf51134e_fc5f8872","updated":"2020-07-21 20:17:27.000000000","message":"We actually don\u0027t need to define these, they are automatically defined when we install a helm chart (You give the release name with \u0027helm install my-chart /path/to/my-chart` or via manifest property)\n\nhttps://helm.sh/docs/chart_template_guide/builtin_objects/","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"Release:"},{"line_number":20,"context_line":"  Name: prometheus-alertmanager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"images:"},{"line_number":23,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_b244fb75","line":20,"in_reply_to":"bf51134e_fc5f8872","updated":"2020-07-22 21:40:35.000000000","message":"removed.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      pod:"},{"line_number":46,"context_line":"        runAsUser: 65534"},{"line_number":47,"context_line":"      container:"},{"line_number":48,"context_line":"        prometheus-alertmanager_perms:"},{"line_number":49,"context_line":"          runAsUser: 0"},{"line_number":50,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":51,"context_line":"        prometheus-alertmanager:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_37cab9a0","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":37},"updated":"2020-07-21 20:17:27.000000000","message":"iirc Hyphens \u0027-\u0027 are not allowed in yaml keys. So in values.yaml and the helm-toolkit template arguments we should switch to all \u0027_\u0027 characters","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      pod:"},{"line_number":46,"context_line":"        runAsUser: 65534"},{"line_number":47,"context_line":"      container:"},{"line_number":48,"context_line":"        prometheus-alertmanager_perms:"},{"line_number":49,"context_line":"          runAsUser: 0"},{"line_number":50,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":51,"context_line":"        prometheus-alertmanager:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_5232bf10","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":37},"in_reply_to":"bf51134e_37cab9a0","updated":"2020-07-22 21:40:35.000000000","message":"the strange part is I didn\u0027t see error or issues with that. but anyhow, I changed them.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        prometheus-alertmanager_perms:"},{"line_number":49,"context_line":"          runAsUser: 0"},{"line_number":50,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":51,"context_line":"        prometheus-alertmanager:"},{"line_number":52,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":53,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":54,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_17cfb5b0","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":19},"updated":"2020-07-21 20:17:27.000000000","message":"Same","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        prometheus-alertmanager_perms:"},{"line_number":49,"context_line":"          runAsUser: 0"},{"line_number":50,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":51,"context_line":"        prometheus-alertmanager:"},{"line_number":52,"context_line":"          allowPrivilegeEscalation: false"},{"line_number":53,"context_line":"          readOnlyRootFilesystem: true"},{"line_number":54,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_b2399bf3","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":19},"in_reply_to":"bf51134e_17cfb5b0","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    port:"},{"line_number":105,"context_line":"      registry:"},{"line_number":106,"context_line":"        node: 5000"},{"line_number":107,"context_line":"  alerts:"},{"line_number":108,"context_line":"    name: prometheus-alertmanager"},{"line_number":109,"context_line":"    namespace: null"},{"line_number":110,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_77f6f1da","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":8},"updated":"2020-07-21 20:17:27.000000000","message":"Personal nit: I think it would be more clear to change this to \"alertmanager\" instead of \"alerts\", which would require changing the helm-toolkit endpoint lookups throughout the chart.\n\nI guess we can leave it as-is since it\u0027s just a name","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    port:"},{"line_number":105,"context_line":"      registry:"},{"line_number":106,"context_line":"        node: 5000"},{"line_number":107,"context_line":"  alerts:"},{"line_number":108,"context_line":"    name: prometheus-alertmanager"},{"line_number":109,"context_line":"    namespace: null"},{"line_number":110,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_f222f3b9","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":8},"in_reply_to":"bf51134e_77f6f1da","updated":"2020-07-22 21:40:35.000000000","message":"Changed and updated in other places.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    common:"},{"line_number":137,"context_line":"      local_image_registry:"},{"line_number":138,"context_line":"        jobs:"},{"line_number":139,"context_line":"          - prometheus-alertmanager-image-repo-sync"},{"line_number":140,"context_line":"        services:"},{"line_number":141,"context_line":"          - endpoint: node"},{"line_number":142,"context_line":"            service: local_image_registry"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_f75de1ec","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":51},"updated":"2020-07-21 20:17:27.000000000","message":"Probably unnecessary to change this job name","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    common:"},{"line_number":137,"context_line":"      local_image_registry:"},{"line_number":138,"context_line":"        jobs:"},{"line_number":139,"context_line":"          - prometheus-alertmanager-image-repo-sync"},{"line_number":140,"context_line":"        services:"},{"line_number":141,"context_line":"          - endpoint: node"},{"line_number":142,"context_line":"            service: local_image_registry"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_2d1b7073","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":51},"in_reply_to":"bf51134e_f75de1ec","updated":"2020-07-22 21:40:35.000000000","message":"reversed.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"          - endpoint: node"},{"line_number":142,"context_line":"            service: local_image_registry"},{"line_number":143,"context_line":"  static:"},{"line_number":144,"context_line":"    prometheus-alertmanager:"},{"line_number":145,"context_line":"      services: null"},{"line_number":146,"context_line":"    image_repo_sync:"},{"line_number":147,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_77c3918b","line":144,"range":{"start_line":144,"start_character":4,"end_line":144,"end_character":15},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027 char","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"          - endpoint: node"},{"line_number":142,"context_line":"            service: local_image_registry"},{"line_number":143,"context_line":"  static:"},{"line_number":144,"context_line":"    prometheus-alertmanager:"},{"line_number":145,"context_line":"      services: null"},{"line_number":146,"context_line":"    image_repo_sync:"},{"line_number":147,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_6d99e8ce","line":144,"range":{"start_line":144,"start_character":4,"end_line":144,"end_character":15},"in_reply_to":"bf51134e_77c3918b","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      annotations:"},{"line_number":159,"context_line":"        nginx.ingress.kubernetes.io/rewrite-target: /"},{"line_number":160,"context_line":"    node_port:"},{"line_number":161,"context_line":"      enabled: true"},{"line_number":162,"context_line":"      port: 30903"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_d739bda3","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":19},"updated":"2020-07-21 20:17:27.000000000","message":"Is this required to be enabled by default?","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      annotations:"},{"line_number":159,"context_line":"        nginx.ingress.kubernetes.io/rewrite-target: /"},{"line_number":160,"context_line":"    node_port:"},{"line_number":161,"context_line":"      enabled: true"},{"line_number":162,"context_line":"      port: 30903"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_0db2ec49","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":19},"in_reply_to":"bf51134e_d739bda3","updated":"2020-07-22 21:40:35.000000000","message":"reversed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"secrets:"},{"line_number":165,"context_line":"  tls:"},{"line_number":166,"context_line":"    alerts:"},{"line_number":167,"context_line":"      prometheus-alertmanager:"},{"line_number":168,"context_line":"        public: alerts-tls-public"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"storage:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_57c00d7d","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":29},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027 char","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"secrets:"},{"line_number":165,"context_line":"  tls:"},{"line_number":166,"context_line":"    alerts:"},{"line_number":167,"context_line":"      prometheus-alertmanager:"},{"line_number":168,"context_line":"        public: alerts-tls-public"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"storage:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_6d828854","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":29},"in_reply_to":"bf51134e_57c00d7d","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  statefulset: true"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_policy:"},{"line_number":192,"context_line":"  prometheus-alertmanager:"},{"line_number":193,"context_line":"    ingress:"},{"line_number":194,"context_line":"      - {}"},{"line_number":195,"context_line":"    egress:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_b7bd2904","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":25},"updated":"2020-07-21 20:17:27.000000000","message":"Same comment about the \u0027-\u0027 char","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  statefulset: true"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_policy:"},{"line_number":192,"context_line":"  prometheus-alertmanager:"},{"line_number":193,"context_line":"    ingress:"},{"line_number":194,"context_line":"      - {}"},{"line_number":195,"context_line":"    egress:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_4d850459","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":25},"in_reply_to":"bf51134e_b7bd2904","updated":"2020-07-22 21:40:35.000000000","message":"changed","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}],"prometheus/values.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"1b6fa3914771ca6b6f11a2b6baedf1c931da772d","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"              regex: peer-mesh"},{"line_number":1071,"context_line":"              action: drop"},{"line_number":1072,"context_line":"    rules:"},{"line_number":1073,"context_line":"      test:"},{"line_number":1074,"context_line":"        groups:"},{"line_number":1075,"context_line":"        - name: test.rules"},{"line_number":1076,"context_line":"          rules:"},{"line_number":1077,"context_line":"          - alert: etcd_Object_Counts"},{"line_number":1078,"context_line":"            expr: etcd_object_counts{resource\u003d\"endpoints\"} \u003e 0"},{"line_number":1079,"context_line":"            for: 3m"},{"line_number":1080,"context_line":"            labels:"},{"line_number":1081,"context_line":"              severity: page"},{"line_number":1082,"context_line":"            annotations:"},{"line_number":1083,"context_line":"              description: This is a test alert for Prometheus"},{"line_number":1084,"context_line":"              summary: Test Alert"},{"line_number":1085,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_d72a5d7c","line":1084,"range":{"start_line":1073,"start_character":0,"end_line":1084,"end_character":33},"updated":"2020-07-21 20:17:27.000000000","message":"Openstack Helm is trying to remove this sort of \u0027testing\u0027 configuration from the chart values.yaml in favor of using this \u0027feature gate\u0027 functionality we have in Zuul. If you look at prometheus/values_overrides/alertmanager.yaml you will find a similar configuration there.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"},{"author":{"_account_id":31713,"name":"William Zhang","email":"xz8905@att.com","username":"willxz"},"change_message_id":"2b49f8f282ee894185785b72cf3ddafe9b2ba1c8","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"              regex: peer-mesh"},{"line_number":1071,"context_line":"              action: drop"},{"line_number":1072,"context_line":"    rules:"},{"line_number":1073,"context_line":"      test:"},{"line_number":1074,"context_line":"        groups:"},{"line_number":1075,"context_line":"        - name: test.rules"},{"line_number":1076,"context_line":"          rules:"},{"line_number":1077,"context_line":"          - alert: etcd_Object_Counts"},{"line_number":1078,"context_line":"            expr: etcd_object_counts{resource\u003d\"endpoints\"} \u003e 0"},{"line_number":1079,"context_line":"            for: 3m"},{"line_number":1080,"context_line":"            labels:"},{"line_number":1081,"context_line":"              severity: page"},{"line_number":1082,"context_line":"            annotations:"},{"line_number":1083,"context_line":"              description: This is a test alert for Prometheus"},{"line_number":1084,"context_line":"              summary: Test Alert"},{"line_number":1085,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_127a07b9","line":1084,"range":{"start_line":1073,"start_character":0,"end_line":1084,"end_character":33},"in_reply_to":"bf51134e_d72a5d7c","updated":"2020-07-22 21:40:35.000000000","message":"Removed this section.","commit_id":"65d8d25c2705f06773204c244ace30f0644cbfee"}]}