)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"5c4a8ea3f453c4d11fb471b18b47baab98f37157","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move MariaDB backup-restore function into a Deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patchset moves the MariaDB backup-restore functionality"},{"line_number":10,"context_line":"out of the CronJob into a Deployment. By doing this, both"},{"line_number":11,"context_line":"the automatic backup (implemented using the CronJob) and"},{"line_number":12,"context_line":"manual backup or retore (managed through the airship/porthole"},{"line_number":13,"context_line":"utility pod) will accessing the same persistent pod deployed"},{"line_number":14,"context_line":"by the Deployment for operations. The PVC, if used, will be"},{"line_number":15,"context_line":"always mounted on the persistently running pod and no on-demand"},{"line_number":16,"context_line":"pod is needed for any operations."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibdba1b8623bbf00ea7baf745cf7ddfa69c84c25a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_f40dd635","line":16,"range":{"start_line":10,"start_character":38,"end_line":16,"end_character":33},"updated":"2020-07-29 15:06:02.000000000","message":"Can you please reword this to explain why the change is advantageous or required?","commit_id":"db23fd95cea569c6b8526c2a8370276031138188"}],"mariadb/templates/deployment-backup-restore.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"673bb1063f51a06d45b8392d929cf7cc37a1e97c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 12 }}"},{"line_number":98,"context_line":"{{- end }}"},{"line_number":99,"context_line":"{{- end }}"},{"line_number":100,"context_line":"          restartPolicy: OnFailure"},{"line_number":101,"context_line":"          serviceAccount: {{ $serviceAccountName }}"},{"line_number":102,"context_line":"          serviceAccountName: {{ $serviceAccountName }}"},{"line_number":103,"context_line":"          volumeMounts:"},{"line_number":104,"context_line":"            - name: pod-tmp"},{"line_number":105,"context_line":"              mountPath: /tmp"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_0e8a081a","line":102,"range":{"start_line":100,"start_character":0,"end_line":102,"end_character":55},"updated":"2020-07-28 22:39:43.000000000","message":"these lines are not needed.  They are above already (lines 43-45)","commit_id":"2fc64d4a4e37d5ed8e53abbc505ef4e60b43cdfc"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b763ca2fed0a1478abe6f88c66b5306739bf7a48","unresolved":false,"context_lines":[{"line_number":70,"context_line":"{{ tuple $envAll .Values.pod.resources.deployments.mariadb_backup_restore | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":71,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"mariadb_backup_restore\" \"container\" \"mariadb_backup_restore\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":72,"context_line":"          command:"},{"line_number":73,"context_line":"            - tail"},{"line_number":74,"context_line":"            - -f"},{"line_number":75,"context_line":"            - /dev/null"},{"line_number":76,"context_line":"          env:"},{"line_number":77,"context_line":"            - name: MARIADB_BACKUP_BASE_DIR"},{"line_number":78,"context_line":"              value: {{ .Values.conf.backup.base_path | quote }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_a4e17d9d","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":23},"updated":"2020-07-29 03:08:50.000000000","message":"why would we want a pod/container that just freeze? and have all the scripts mounted so people exec into this deployment to just run the scripts? This looks like an anti-pattern.","commit_id":"db23fd95cea569c6b8526c2a8370276031138188"}]}