)]}'
{"helm-toolkit/templates/manifests/_job-ks-endpoints.tpl":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"005f487fd5a98f1134a6dfea5033c58b269d6161","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default \"OnFailure\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"9f560f44_81656748","line":34,"updated":"2020-08-13 07:26:49.000000000","message":"I suggest to make value order precedence the same as it is used on L24 for nodeSelector:\n\n1. restartPolicy variable when passed to template with context\n2. restartPolicy that configured in Values.jobs.\u003cjob_name\u003e.restartPolicy\n3. default OnFailure","commit_id":"921102ce25031570d74abc1ef21e066ddf6885ed"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"1b07508f376deae6133808626a743ac4f22e06c1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default \"OnFailure\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"9f560f44_97dbe51f","line":34,"in_reply_to":"9f560f44_81656748","updated":"2020-08-13 09:52:16.000000000","message":"Agree, I\u0027ve reworked the patch.","commit_id":"921102ce25031570d74abc1ef21e066ddf6885ed"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"8ae38cb8f0b04a0fe661b29662f1ab010a8e150b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{{- $backoffLimit :\u003d index . \"backoffLimit\" | default \"1000\" -}}"},{"line_number":29,"context_line":"{{- $activeDeadlineSeconds :\u003d index . \"activeDeadlineSeconds\" -}}"},{"line_number":30,"context_line":"{{- $serviceNamePretty :\u003d $serviceName | replace \"_\" \"-\" -}}"},{"line_number":31,"context_line":"{{- $restartPolicy_ :\u003d \"\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_2491c99a","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":25},"updated":"2020-08-18 16:03:13.000000000","message":"\"OnFailure\"","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"8ae38cb8f0b04a0fe661b29662f1ab010a8e150b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy_ :\u003d \"\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_e4db517a","line":34,"range":{"start_line":34,"start_character":79,"end_line":34,"end_character":91},"updated":"2020-08-18 16:03:13.000000000","message":"$restartPolicy_","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d95171578f02f14a744eea4e217a7f7d4ded1473","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy_ :\u003d \"\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_57478dbd","line":34,"range":{"start_line":34,"start_character":69,"end_line":34,"end_character":90},"updated":"2020-08-13 09:57:53.000000000","message":"I think this default is not needed, because in any case you have default on line 37","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"e7baecc20c2aee65161c21552291be913dab9a96","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy_ :\u003d \"\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_f767c150","line":34,"range":{"start_line":34,"start_character":69,"end_line":34,"end_character":90},"in_reply_to":"9f560f44_57478dbd","updated":"2020-08-13 10:00:23.000000000","message":"a the key restartPolicy maybe absent... ok","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"3862fb860d7a244d0f5b1a1b49174bfec8829ed8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{- $restartPolicy_ :\u003d \"\" -}}"},{"line_number":32,"context_line":"{{- if hasKey $envAll.Values \"jobs\" -}}"},{"line_number":33,"context_line":"{{- if hasKey $envAll.Values.jobs \"ks_endpoints\" -}}"},{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_371db9bd","line":34,"range":{"start_line":34,"start_character":69,"end_line":34,"end_character":90},"in_reply_to":"9f560f44_57478dbd","updated":"2020-08-13 09:59:24.000000000","message":"agree, it could be ommited","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"8ae38cb8f0b04a0fe661b29662f1ab010a8e150b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceNamePretty \"ks-endpoints\" }}"},{"line_number":40,"context_line":"{{ tuple $envAll \"ks_endpoints\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_642d8145","line":37,"range":{"start_line":37,"start_character":72,"end_line":37,"end_character":94},"updated":"2020-08-18 16:03:13.000000000","message":"not needed if above applied","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"},{"author":{"_account_id":29954,"name":"Oleh Hryhorov","email":"golantster@gmail.com","username":"ohryhorov"},"change_message_id":"f53984a65f351ab5772bfed0a523369bc448c0d6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"{{- $restartPolicy_ \u003d $envAll.Values.jobs.ks_endpoints.restartPolicy | default \"OnFailure\" }}"},{"line_number":35,"context_line":"{{- end }}"},{"line_number":36,"context_line":"{{- end }}"},{"line_number":37,"context_line":"{{- $restartPolicy :\u003d index . \"restartPolicy\" | default $restartPolicy_  | default \"OnFailure\" -}}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceNamePretty \"ks-endpoints\" }}"},{"line_number":40,"context_line":"{{ tuple $envAll \"ks_endpoints\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f560f44_8721ad50","line":37,"range":{"start_line":37,"start_character":72,"end_line":37,"end_character":94},"in_reply_to":"9f560f44_642d8145","updated":"2020-08-19 08:13:42.000000000","message":"Good catch, thanks!","commit_id":"2bf08eeee9b60ee3bd29fa004ceb0a3743f1a802"}]}