)]}'
{"id":"openstack%2Fopenstack-helm-infra~746209","triplet_id":"openstack%2Fopenstack-helm-infra~master~I29387a597a21180bb7fba974b4daeadf6ffc182d","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"I29387a597a21180bb7fba974b4daeadf6ffc182d","subject":"[ceph-client] Fix crush weight comparison in reweight_osds()","status":"MERGED","created":"2020-08-13 18:03:03.000000000","updated":"2020-08-13 20:43:02.000000000","submitted":"2020-08-13 20:40:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"746209-1597351246384-88ec3396","meta_rev_id":"611b1fa7e0076c86e731ae2036139da1029aa964","_number":746209,"virtual_id_number":746209,"owner":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-13 20:40:46.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":0,"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"recommended":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-13 18:05:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":1,"date":"2020-08-13 18:09:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":1,"date":"2020-08-13 19:09:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"value":2,"date":"2020-08-13 18:51:08.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":1,"date":"2020-08-13 18:57:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":1,"date":"2020-08-13 18:06:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},{"value":2,"date":"2020-08-13 19:51:58.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"value":0,"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},{"value":1,"date":"2020-08-13 19:51:58.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-13 18:05:51.000000000","updated_by":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"reviewer":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"state":"REVIEWER"},{"updated":"2020-08-13 18:06:50.000000000","updated_by":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"reviewer":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"state":"REVIEWER"},{"updated":"2020-08-13 18:09:37.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"REVIEWER"},{"updated":"2020-08-13 18:51:08.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2020-08-13 18:57:40.000000000","updated_by":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"reviewer":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"state":"REVIEWER"},{"updated":"2020-08-13 19:09:46.000000000","updated_by":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"reviewer":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"state":"REVIEWER"},{"updated":"2020-08-13 19:51:58.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2020-08-13 20:40:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"de3e6254141a741d52f39f3d8ee68279ae9575c1","author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"date":"2020-08-13 18:03:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"47d2b12b5d4a6cbb4b09955bf09334e559de40ea","author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"date":"2020-08-13 18:05:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"53a81eb54233058a62afe934a617f1858941ebcf","author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"date":"2020-08-13 18:06:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c543772fb6c34da2124d7662f8d9d24ac25ed0e5","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2020-08-13 18:09:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a7e33787806b5a55b7fd9afdb468959153a5a8ff","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 18:48:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b9eafd1e55e5403f8caf51d306f698bf : SUCCESS in 4m 47s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e0ef894585324deb94ac42ca19589dfe : SUCCESS in 3m 07s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/451e765d5d2540b787cd7694313441e3 : SUCCESS in 40m 09s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/c1bac012b9ab498d8c1d0f4b5cd6e1fc : SUCCESS in 27m 21s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/0fd6a6f056ed47af8028c003be5134c4 : SUCCESS in 43m 47s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/977859ffae4a4d77b73b554e36c11328 : SUCCESS in 21m 15s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/730899b09a424f10b3e325bc0f828cd9 : SUCCESS in 12m 57s","accounts_in_message":[],"_revision_number":1},{"id":"7951bac5af12ce8be3c2a1dcd13f74bce958dd2a","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-08-13 18:51:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4db1e4c1ac35d58c27431d2a931d5e32bfbdc99e","author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"date":"2020-08-13 18:57:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1a0084115daed3e048b7a9b3138fd61c6c997138","author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"date":"2020-08-13 19:09:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b638197c3913cea88a9aeec55ad05d78babdb3e5","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2020-08-13 19:51:58.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9f30f5fcfd69475f8470a58439bd7904785ce7f6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 19:52:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5212e21097871effe4abe093df5d1ed346bc4128","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 20:40:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7526ab619d7271deef96f04cb679a2b2898001e8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 20:40:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/00fc853ca7b84307ac8e62201a14a100 : SUCCESS in 3m 05s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/d278eb6b427b4f658aa5f387f46b2b83 : SUCCESS in 2m 25s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/d04d00c08d004f079c10e228bd85baf6 : SUCCESS in 34m 16s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/b453aa0e4d0c4f419ed9568ea65fade1 : SUCCESS in 31m 08s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/9cbf153628ff4c298cbcd5b37ec257be : SUCCESS in 43m 31s","accounts_in_message":[],"_revision_number":1},{"id":"611b1fa7e0076c86e731ae2036139da1029aa964","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 20:43:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae7b7d2c82554345babdbee16731c848 : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f66f9fe560d1a6057e82ec7cf1f01e33284be2bd","revisions":{"f66f9fe560d1a6057e82ec7cf1f01e33284be2bd":{"kind":"REWORK","_number":1,"created":"2020-08-13 18:03:03.000000000","uploader":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"ref":"refs/changes/09/746209/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/09/746209/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/09/746209/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/09/746209/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/09/746209/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/09/746209/1"}}},"commit":{"parents":[{"commit":"8631c795484a28d34ac95e880b4bd9108d889997","subject":"Merge \"Add security context template for keystone-webhook container\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/8631c795484a28d34ac95e880b4bd9108d889997"}]}],"author":{"name":"Taylor, Stephen (st053q)","email":"st053q@att.com","date":"2020-08-13 18:00:32.000000000","tz":-360},"committer":{"name":"Taylor, Stephen (st053q)","email":"st053q@att.com","date":"2020-08-13 18:00:32.000000000","tz":-360},"subject":"[ceph-client] Fix crush weight comparison in reweight_osds()","message":"[ceph-client] Fix crush weight comparison in reweight_osds()\n\nThe recently-added crush weight comparison in reweight_osds() that\nchecks weights for zero isn\u0027t working correctly because the\nexpected weight is being calculated to two decimal places and then\ncompared against \"0\" as a string. This updates the comparison\nstring to \"0.00\" to match the calculation.\n\nChange-Id: I29387a597a21180bb7fba974b4daeadf6ffc182d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/f66f9fe560d1a6057e82ec7cf1f01e33284be2bd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/f66f9fe560d1a6057e82ec7cf1f01e33284be2bd"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8631c795484a28d34ac95e880b4bd9108d889997","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}