)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"658f653806c1a041be3d1a90b44bae8c1322c3ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f560f44_f96ff8c0","updated":"2020-09-10 23:55:11.000000000","message":"Can you add a short summary of what this change is doing?\n\nSee: https://wiki.openstack.org/wiki/GitCommitMessages#Examples_of_good_practice_2","commit_id":"5ae2829959785e6adcab762b271b7cb6e9d10a39"}],"postgresql/Chart.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"39e86f0bbca9606bbf8996bc046dab969a055cfa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"apiVersion: v1"},{"line_number":15,"context_line":"description: OpenStack-Helm PostgreSQL"},{"line_number":16,"context_line":"name: postgresql"},{"line_number":17,"context_line":"version: 0.1.1"},{"line_number":18,"context_line":"home: https://www.postgresql.org"},{"line_number":19,"context_line":"sources:"},{"line_number":20,"context_line":"  - https://github.com/postgres/postgres"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_a659c55b","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":14},"updated":"2020-09-28 06:35:36.000000000","message":"Need to bump to 0.1.2 and rebase to include https://review.opendev.org/#/c/754200/","commit_id":"3d6836937d372a31d8260c2b8c0eff309fea9cd6"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"fb7a988b6efe0c4e54d6fa8cd6c1640000a552f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"appVersion: v9.6"},{"line_number":16,"context_line":"description: OpenStack-Helm PostgreSQL"},{"line_number":17,"context_line":"name: postgresql"},{"line_number":18,"context_line":"version: 0.1.3"},{"line_number":19,"context_line":"home: https://www.postgresql.org"},{"line_number":20,"context_line":"sources:"},{"line_number":21,"context_line":"  - https://github.com/postgres/postgres"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f560f44_71d501b7","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":14},"updated":"2020-10-08 15:56:14.000000000","message":"why did you increment by 2?","commit_id":"d6fe9416e38cf17662c26e36fa692a3cc32eb89d"}],"postgresql/templates/bin/_start.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0f017b55d075d498d9454a708a3a3112d5dea646","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"set -x"},{"line_number":37,"context_line":"exec /docker-entrypoint.sh postgres -c config_file\u003d/tmp/postgresql.conf"}],"source_content_type":"text/x-smarty","patch_set":33,"id":"9f560f44_6307f618","line":37,"range":{"start_line":36,"start_character":2,"end_line":37,"end_character":5},"updated":"2020-10-08 18:02:27.000000000","message":"also why?","commit_id":"dcf385f36c8262c671f0d0b998f9f731ca319c79"}],"postgresql/templates/configmap-etc.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d7780802108f5d82fac99fd914e93aa65958174a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  pg_hba.conf: |"},{"line_number":29,"context_line":"{{ .Values.conf.pg_hba | indent 4 }}"},{"line_number":30,"context_line":"{{- end }}"},{"line_number":31,"context_line":"  recovery.conf: |"},{"line_number":32,"context_line":"{{- range $key, $value :\u003d default dict .Values.conf.recovery }}"},{"line_number":33,"context_line":"    {{ $key | snakecase }} \u003d \u0027{{ $value }}\u0027"},{"line_number":34,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_36d1ad58","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":10},"updated":"2020-09-09 05:13:24.000000000","message":"this is outside the if-block started on L15. (That blocks ends on Line 30).","commit_id":"ad162698f0cde1b78dd6b51d5f9ddd9287926a56"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"98158985d441728f9abbdd09a0d18285b525b947","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{- end }}"},{"line_number":28,"context_line":"  pg_hba.conf: |"},{"line_number":29,"context_line":"{{ .Values.conf.pg_hba | indent 4 }}"},{"line_number":30,"context_line":"{{- end}}"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"9f560f44_c701af09","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"updated":"2020-10-08 18:01:28.000000000","message":"why?","commit_id":"dcf385f36c8262c671f0d0b998f9f731ca319c79"}],"postgresql/templates/statefulset.yaml":[{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"41a58ee58ae60be3f49d5d37a199f4cfa54df8fe","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        accessModes: [\"ReadWriteOnce\"]"},{"line_number":265,"context_line":"        resources:"},{"line_number":266,"context_line":"          requests:"},{"line_number":267,"context_line":"            storage: {{ .Values.storage.pvc.size }}"},{"line_number":268,"context_line":"{{- end }}"},{"line_number":269,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_4ada91e8","line":267,"range":{"start_line":267,"start_character":24,"end_line":267,"end_character":48},"updated":"2020-09-24 20:48:46.000000000","message":"Would it make sense to use a different size for the recovery volume?","commit_id":"9e604c12c23bea565676f79398de48319857ba70"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"39e86f0bbca9606bbf8996bc046dab969a055cfa","unresolved":false,"context_lines":[{"line_number":221,"context_line":"              subPath: {{ .Values.storage.mount.subpath }}"},{"line_number":222,"context_line":"            - name: postgresql-archive"},{"line_number":223,"context_line":"              mountPath: {{ .Values.storage.archive.mount_path }}"},{"line_number":224,"context_line":"              subPath: {{ .Values.storage.mount.subpath }}"},{"line_number":225,"context_line":"      volumes:"},{"line_number":226,"context_line":"        - name: pod-tmp"},{"line_number":227,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_86364101","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":58},"updated":"2020-09-28 06:35:36.000000000","message":"Is there any reason we are using a subPath mount here?\n\nIf it is necessary, it seems like it should be a distinct parameter from the subPath used by the postgresql-data mount.","commit_id":"3d6836937d372a31d8260c2b8c0eff309fea9cd6"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"c430f0f338c3dc8137137ccd7db5deb691a4e3bd","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        - name: postgresql-data"},{"line_number":243,"context_line":"          hostPath:"},{"line_number":244,"context_line":"            path: {{ .Values.storage.host.host_path }}"},{"line_number":245,"context_line":"        - name: postgresql-archive"},{"line_number":246,"context_line":"          hostPath:"},{"line_number":247,"context_line":"            path: {{ .Values.storage.archive.host_path }}"},{"line_number":248,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_ba454d19","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":34},"updated":"2020-09-28 14:52:08.000000000","message":"Add a knob to read off of \"archive is enabled\"?","commit_id":"b56d52493ddf7804d54d1f19aa2d391732a6d612"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"c430f0f338c3dc8137137ccd7db5deb691a4e3bd","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        resources:"},{"line_number":257,"context_line":"          requests:"},{"line_number":258,"context_line":"            storage: {{ .Values.storage.pvc.size }}"},{"line_number":259,"context_line":"    - metadata:"},{"line_number":260,"context_line":"        name: postgresql-archive"},{"line_number":261,"context_line":"        annotations:"},{"line_number":262,"context_line":"          {{ .Values.storage.archive_pvc.class_path }}: {{ .Values.storage.archive_pvc.class_name }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_da4c8141","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":15},"updated":"2020-09-28 14:52:08.000000000","message":"Add a knob to read off of \"archive is enabled\"?","commit_id":"b56d52493ddf7804d54d1f19aa2d391732a6d612"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"8e66d1ca777ef917cd610af91b10867cf9e714f2","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            - name: postgresql-data"},{"line_number":220,"context_line":"              mountPath: {{ .Values.storage.mount.path }}"},{"line_number":221,"context_line":"              subPath: {{ .Values.storage.mount.subpath }}"},{"line_number":222,"context_line":"            - name: postgresql-archive"},{"line_number":223,"context_line":"              mountPath: {{ .Values.storage.archive.mount_path }}"},{"line_number":224,"context_line":"              subPath: {{ .Values.storage.mount.subpath }}"},{"line_number":225,"context_line":"      volumes:"},{"line_number":226,"context_line":"        - name: pod-tmp"},{"line_number":227,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_dfd1d3cc","line":224,"range":{"start_line":222,"start_character":0,"end_line":224,"end_character":58},"updated":"2020-10-01 20:27:25.000000000","message":"This should not exist if archive_mode is \"off\".  Also, what does the volume look like if archive_mode is \"on\"?  there would be no volume entry below.","commit_id":"298a3df528b6cde90571f234f63c4a08197096e7"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2acd5b648577550434c07e272c2804ac1464ed98","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              mountPath: /tmp/pg_hba.conf"},{"line_number":213,"context_line":"              subPath: pg_hba.conf"},{"line_number":214,"context_line":"              readOnly: true"},{"line_number":215,"context_line":"            - name: postgresql-etc"},{"line_number":216,"context_line":"              mountPath: /tmp/recovery.conf"},{"line_number":217,"context_line":"              subpath: recovery.conf"},{"line_number":218,"context_line":"              readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_b07a2a22","line":215,"range":{"start_line":215,"start_character":20,"end_line":215,"end_character":34},"updated":"2020-10-05 18:48:37.000000000","message":"duplicate name (see line 211)","commit_id":"9d8be496fc1b984aff71191ed980899e4a086d80"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2acd5b648577550434c07e272c2804ac1464ed98","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            storage: {{ .Values.storage.archive_pvc.size }}"},{"line_number":270,"context_line":"{{- end }}"},{"line_number":271,"context_line":"{{- if and (eq .Values.conf.postgresql.archive_mode \"off\" )  (eq .Values.storage.pvc.enabled false) }}"},{"line_number":272,"context_line":"  []"},{"line_number":273,"context_line":"{{- end }}"},{"line_number":274,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_108f9622","line":272,"range":{"start_line":272,"start_character":2,"end_line":272,"end_character":4},"updated":"2020-10-05 18:48:37.000000000","message":"?","commit_id":"9d8be496fc1b984aff71191ed980899e4a086d80"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"c636d95720ba67fb42b6de9d5c7132e9e87fcf89","unresolved":false,"context_lines":[{"line_number":268,"context_line":"          requests:"},{"line_number":269,"context_line":"            storage: {{ .Values.storage.archive_pvc.size }}"},{"line_number":270,"context_line":"{{- end }}"},{"line_number":271,"context_line":"{{- if and (eq .Values.conf.postgresql.archive_mode \"off\" )  (eq .Values.storage.pvc.enabled false) }}"},{"line_number":272,"context_line":"    []"},{"line_number":273,"context_line":"{{- end }}"},{"line_number":274,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9f560f44_8142303a","line":271,"range":{"start_line":271,"start_character":0,"end_line":271,"end_character":102},"updated":"2020-10-06 13:20:46.000000000","message":"why don\u0027t you reverse the this check and put it on line 247. That is if archive_mode in on or pvc is enabled then only put volumeClaimTemplates:. It will be cleaner that way.","commit_id":"d891e928acc0125f349de154b9bedf8206fac220"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"f1ad3657bc08ac2d7fdda1332dc5de524db6d130","unresolved":false,"context_lines":[{"line_number":213,"context_line":"              subPath: pg_hba.conf"},{"line_number":214,"context_line":"              readOnly: true"},{"line_number":215,"context_line":"            - name: postgresql-etc"},{"line_number":216,"context_line":"              mountPath: /tmp/recovery"},{"line_number":217,"context_line":"              subpath: recovery.conf"},{"line_number":218,"context_line":"              readOnly: true"},{"line_number":219,"context_line":"            - name: postgresql-data"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9f560f44_6146eaa9","line":216,"range":{"start_line":216,"start_character":30,"end_line":216,"end_character":38},"updated":"2020-10-07 13:59:55.000000000","message":"shouldn\u0027t this be recovery.conf?","commit_id":"a5163b538956046c40177614c54e59be98dd7cd8"}],"postgresql/values.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"39e86f0bbca9606bbf8996bc046dab969a055cfa","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    class_name: general"},{"line_number":166,"context_line":"    class_path: volume.beta.kubernetes.io/storage-class"},{"line_number":167,"context_line":"  archive_pvc:"},{"line_number":168,"context_line":"    enabled: true"},{"line_number":169,"context_line":"    size: 5Gi"},{"line_number":170,"context_line":"    class_name: general"},{"line_number":171,"context_line":"    class_path: volume.beta.kubernetes.io/storage-class"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_29862666","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":17},"updated":"2020-09-28 06:35:36.000000000","message":"This option doesn\u0027t seem to have an effect - the way the chart renders, either PVCs are used for both data and archive, or neither.","commit_id":"3d6836937d372a31d8260c2b8c0eff309fea9cd6"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"39e86f0bbca9606bbf8996bc046dab969a055cfa","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    local all all trust"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  postgresql:"},{"line_number":271,"context_line":"    archive_mode: \u0027on\u0027"},{"line_number":272,"context_line":"    archive_command: \u0027test ! -f /var/lib/archive/%f \u0026\u0026 gzip \u003c %p \u003e /var/lib/archive/%f\u0027"},{"line_number":273,"context_line":"    cluster_name: \u0027postgresql\u0027"},{"line_number":274,"context_line":"    datestyle: \u0027iso, mdy\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_c9720a7c","line":271,"range":{"start_line":271,"start_character":4,"end_line":271,"end_character":22},"updated":"2020-09-28 06:35:36.000000000","message":"Should the archive volume only be mounted if archive_mode is on?","commit_id":"3d6836937d372a31d8260c2b8c0eff309fea9cd6"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"c430f0f338c3dc8137137ccd7db5deb691a4e3bd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    class_name: general"},{"line_number":166,"context_line":"    class_path: volume.beta.kubernetes.io/storage-class"},{"line_number":167,"context_line":"  archive_pvc:"},{"line_number":168,"context_line":"    enabled: true"},{"line_number":169,"context_line":"    size: 5Gi"},{"line_number":170,"context_line":"    class_name: general"},{"line_number":171,"context_line":"    class_path: volume.beta.kubernetes.io/storage-class"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_ba926d9f","line":168,"range":{"start_line":168,"start_character":13,"end_line":168,"end_character":17},"updated":"2020-09-28 14:52:08.000000000","message":"should we consider disabled this by default since this would require a separate pvc (additional space req).","commit_id":"b56d52493ddf7804d54d1f19aa2d391732a6d612"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"c430f0f338c3dc8137137ccd7db5deb691a4e3bd","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    host all all 0.0.0.0/0 reject"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"  postgresql:"},{"line_number":274,"context_line":"    archive_mode: \u0027on\u0027"},{"line_number":275,"context_line":"    archive_command: \u0027test ! -f /var/lib/archive/%f \u0026\u0026 gzip \u003c %p \u003e /var/lib/archive/%f\u0027"},{"line_number":276,"context_line":"    cluster_name: \u0027postgresql\u0027"},{"line_number":277,"context_line":"    datestyle: \u0027iso, mdy\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_3acdbdba","line":274,"range":{"start_line":274,"start_character":19,"end_line":274,"end_character":21},"updated":"2020-09-28 14:52:08.000000000","message":"maybe just add extra \"knob\" to control both the archive_mode and archive_pvc enabled above?  Unless there is scenario where we may want 1 enabled but not the other?","commit_id":"b56d52493ddf7804d54d1f19aa2d391732a6d612"}]}