)]}'
{"ceph-provisioners/templates/bin/provisioner/rbd/_namespace-client-key-manager.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"93133018abf0f476031900e502ad0f3d03a8bd81","unresolved":false,"context_lines":[{"line_number":38,"context_line":"type: \"${secret_type}\""},{"line_number":39,"context_line":"data:"},{"line_number":40,"context_line":"  key: $( echo ${ceph_key} )"},{"line_number":41,"context_line":"#{{ if .Values.deployment.csi }}"},{"line_number":42,"context_line":"#  userID:  $( echo ${ceph_id} )"},{"line_number":43,"context_line":"#  userKey: $( echo ${ceph_key} )"},{"line_number":44,"context_line":"#{{ end }}"},{"line_number":45,"context_line":"EOF"},{"line_number":46,"context_line":"  } | kubectl apply --namespace ${kube_namespace} -f -"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":33,"id":"9f560f44_6046687e","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":9},"updated":"2020-09-28 16:24:31.000000000","message":"what\u0027s this for?","commit_id":"e3ef02d431891160ea1c9af2a5202968a2113da4"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2505caac2e69bd5fa67754e6cee4d0087a6acc62","unresolved":false,"context_lines":[{"line_number":38,"context_line":"type: \"${secret_type}\""},{"line_number":39,"context_line":"data:"},{"line_number":40,"context_line":"  key: $( echo ${ceph_key} )"},{"line_number":41,"context_line":"#{{ if .Values.deployment.csi }}"},{"line_number":42,"context_line":"#  userID:  $( echo ${ceph_id} )"},{"line_number":43,"context_line":"#  userKey: $( echo ${ceph_key} )"},{"line_number":44,"context_line":"#{{ end }}"},{"line_number":45,"context_line":"EOF"},{"line_number":46,"context_line":"  } | kubectl apply --namespace ${kube_namespace} -f -"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":33,"id":"9f560f44_118edcd0","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":9},"in_reply_to":"9f560f44_6046687e","updated":"2020-09-28 18:53:46.000000000","message":"Done","commit_id":"e3ef02d431891160ea1c9af2a5202968a2113da4"}],"ceph-provisioners/templates/deamonset-csi-rbd-plugin.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"bb1979e1e321e83b6438be293e975d257aecc675","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  labels:"},{"line_number":50,"context_line":"{{ tuple $envAll \"rbd\" \"plugin\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":51,"context_line":"spec:"},{"line_number":52,"context_line":"  replicas: {{ .Values.pod.replicas.rbd_plugin }}"},{"line_number":53,"context_line":"  selector:"},{"line_number":54,"context_line":"    matchLabels:"},{"line_number":55,"context_line":"{{ tuple $envAll \"rbd\" \"plugin\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"20f040e7_74cfc2a9","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":5},"updated":"2021-02-18 18:49:45.000000000","message":"Doesn\u0027t make sense to have replicas in a daemonset.","commit_id":"ee647d11155c011cf0736ee024aa8b373e627959"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"ca2c35664ec20703f691946397e66483b1fc5045","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  labels:"},{"line_number":50,"context_line":"{{ tuple $envAll \"rbd\" \"plugin\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":51,"context_line":"spec:"},{"line_number":52,"context_line":"  replicas: {{ .Values.pod.replicas.rbd_plugin }}"},{"line_number":53,"context_line":"  selector:"},{"line_number":54,"context_line":"    matchLabels:"},{"line_number":55,"context_line":"{{ tuple $envAll \"rbd\" \"plugin\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"7d4ef0e3_78429cb6","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":5},"in_reply_to":"20f040e7_74cfc2a9","updated":"2021-02-18 19:38:52.000000000","message":"Done","commit_id":"ee647d11155c011cf0736ee024aa8b373e627959"}],"ceph-provisioners/values.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"cf1fc8283b60fd179a65c3a86741d5e56b9ca518","unresolved":true,"context_lines":[{"line_number":298,"context_line":"    provisioner: ceph.com/rbd"},{"line_number":299,"context_line":"    ceph_configmap_name: ceph-etc"},{"line_number":300,"context_line":"    metadata:"},{"line_number":301,"context_line":"      name: general-backup"},{"line_number":302,"context_line":"    parameters:"},{"line_number":303,"context_line":"      pool: rbd"},{"line_number":304,"context_line":"      adminId: admin"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"65b37039_52a2384a","line":301,"range":{"start_line":301,"start_character":12,"end_line":301,"end_character":26},"updated":"2021-01-25 17:43:13.000000000","message":"I think we have to keep this named \"general\" for upgrade purposes. The operator may not want to change all of their PVCs to use the csi_rbd driver.","commit_id":"97e0522ad12add7807be6948a49da424269792d1"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"cf1fc8283b60fd179a65c3a86741d5e56b9ca518","unresolved":true,"context_lines":[{"line_number":313,"context_line":"    provisioner: ceph.rbd.csi.ceph.com"},{"line_number":314,"context_line":"    metadata:"},{"line_number":315,"context_line":"      default_storage_class: true"},{"line_number":316,"context_line":"      name: general"},{"line_number":317,"context_line":"    parameters:"},{"line_number":318,"context_line":"      clusterID: ceph"},{"line_number":319,"context_line":"      csi.storage.k8s.io/controller-expand-secret-name: pvc-ceph-conf-combined-storageclass"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"29212d0b_a5c38a90","line":316,"range":{"start_line":316,"start_character":12,"end_line":316,"end_character":19},"updated":"2021-01-25 17:43:13.000000000","message":"I suggest we name this differently. How about \"general-csi\"?","commit_id":"97e0522ad12add7807be6948a49da424269792d1"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"459a6639271ae95eebaa306a0c0da319056bb24f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"          capabilities:"},{"line_number":97,"context_line":"            add: [\"SYS_ADMIN\"]"},{"line_number":98,"context_line":"          # FIX ME"},{"line_number":99,"context_line":"          allowPrivilegeEscalation: true"},{"line_number":100,"context_line":"    bootstrap:"},{"line_number":101,"context_line":"      pod:"},{"line_number":102,"context_line":"        runAsUser: 99"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"fbd56e11_d3e001c8","line":99,"range":{"start_line":99,"start_character":10,"end_line":99,"end_character":40},"updated":"2021-02-04 18:02:06.000000000","message":"Why do we need this? My guess would be to access the Ceph client key, but if that\u0027s the case, can we change permissions on the key and get rid of this?","commit_id":"a15bf03353a6e7cc51ba7b3dc01f387be54e8919"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"e763e22f12542816ba991c28bb4628b6e2a5a508","unresolved":false,"context_lines":[{"line_number":96,"context_line":"          capabilities:"},{"line_number":97,"context_line":"            add: [\"SYS_ADMIN\"]"},{"line_number":98,"context_line":"          # FIX ME"},{"line_number":99,"context_line":"          allowPrivilegeEscalation: true"},{"line_number":100,"context_line":"    bootstrap:"},{"line_number":101,"context_line":"      pod:"},{"line_number":102,"context_line":"        runAsUser: 99"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"32b3fe18_31f070a7","line":99,"range":{"start_line":99,"start_character":10,"end_line":99,"end_character":40},"in_reply_to":"7c1e7d7e_ab1e9f9b","updated":"2021-02-04 19:14:56.000000000","message":"Thanks for pointing this out. I need to talk to Dmitrii about why the FIX ME comment is there.","commit_id":"a15bf03353a6e7cc51ba7b3dc01f387be54e8919"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"92790366e99bc398bc2470bc63d5209578256296","unresolved":false,"context_lines":[{"line_number":96,"context_line":"          capabilities:"},{"line_number":97,"context_line":"            add: [\"SYS_ADMIN\"]"},{"line_number":98,"context_line":"          # FIX ME"},{"line_number":99,"context_line":"          allowPrivilegeEscalation: true"},{"line_number":100,"context_line":"    bootstrap:"},{"line_number":101,"context_line":"      pod:"},{"line_number":102,"context_line":"        runAsUser: 99"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"7c1e7d7e_ab1e9f9b","line":99,"range":{"start_line":99,"start_character":10,"end_line":99,"end_character":40},"in_reply_to":"fbd56e11_d3e001c8","updated":"2021-02-04 18:05:22.000000000","message":"Wait, this has to map RBDs too. That requires root.","commit_id":"a15bf03353a6e7cc51ba7b3dc01f387be54e8919"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"4e1683ec2c33c89c1d2eef5f1b6d2ddb6777821b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"pod:"},{"line_number":64,"context_line":"  test_pod:"},{"line_number":65,"context_line":"    wait_timeout: 600"},{"line_number":66,"context_line":"    rbd:"},{"line_number":67,"context_line":"      name: rbd-prov-test-pod"},{"line_number":68,"context_line":"      pvc_name: rbd-prov-test-pvc"},{"line_number":69,"context_line":"    cephfs:"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"05a95237_cb1719c2","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":2},"updated":"2021-02-18 20:44:07.000000000","message":"Let\u0027s also add helm test for the new provisioner/storage class.","commit_id":"9d2a9f73c944fa994e96ad904273340627740322"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"f9e043f18ae83e472b4d242a34d6d83494d11698","unresolved":false,"context_lines":[{"line_number":63,"context_line":"pod:"},{"line_number":64,"context_line":"  test_pod:"},{"line_number":65,"context_line":"    wait_timeout: 600"},{"line_number":66,"context_line":"    rbd:"},{"line_number":67,"context_line":"      name: rbd-prov-test-pod"},{"line_number":68,"context_line":"      pvc_name: rbd-prov-test-pvc"},{"line_number":69,"context_line":"    cephfs:"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"c4054db8_bd007021","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":2},"in_reply_to":"05a95237_cb1719c2","updated":"2021-02-19 00:18:04.000000000","message":"Done","commit_id":"9d2a9f73c944fa994e96ad904273340627740322"}]}