)]}'
{"ingress/templates/configmap-conf.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fb7fa7d16fceb7d98015422ea0cac18d7e07fdbb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"metadata:"},{"line_number":35,"context_line":"  name: ingress-conf"},{"line_number":36,"context_line":"data:"},{"line_number":37,"context_line":"{{- if .Values.manifests.ingress_dhparam -}}"},{"line_number":38,"context_line":"{{- $_ :\u003d set .Values.conf.ingress \"ssl-dhparam\" \"openstack/ingress-dhparam\" -}}"},{"line_number":39,"context_line":"{{- end }}"},{"line_number":40,"context_line":"{{ toYaml .Values.conf.ingress | indent 2 }}"},{"line_number":41,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_3d19257a","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":10},"updated":"2020-09-14 22:44:55.000000000","message":"can\u0027t this not be just part of the .conf.ingress values override?","commit_id":"bafb97b29538c795101020a3857cf26e881baa68"}],"ingress/templates/secret-dhparam.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bfc942d15dc560397a1687061be6fcb37d2c4136","unresolved":false,"context_lines":[{"line_number":18,"context_line":"apiVersion: v1"},{"line_number":19,"context_line":"kind: Secret"},{"line_number":20,"context_line":"metadata:"},{"line_number":21,"context_line":"  name: ingress-dhparam"},{"line_number":22,"context_line":"type: Opaque"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  dhparam.pem: {{ .Values.secrets.dhparam.ingress_dhparam | b64enc }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_a7d7d6ee","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":23},"updated":"2020-09-15 18:09:22.000000000","message":"should this be named secret and not an ingress?","commit_id":"3d12b1e84e0d1494f7afde9cb48267c45fcf1a2a"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"46843d09cecf428ea85f99cc645795cfe36d37b4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"apiVersion: v1"},{"line_number":19,"context_line":"kind: Secret"},{"line_number":20,"context_line":"metadata:"},{"line_number":21,"context_line":"  name: ingress-dhparam"},{"line_number":22,"context_line":"type: Opaque"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  dhparam.pem: {{ .Values.secrets.dhparam.ingress_dhparam | b64enc }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_6d3d9dbb","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":23},"in_reply_to":"9f560f44_a7d7d6ee","updated":"2020-09-15 19:24:54.000000000","message":"Done","commit_id":"3d12b1e84e0d1494f7afde9cb48267c45fcf1a2a"}],"ingress/values.yaml":[{"author":{"_account_id":18213,"name":"Matthew Neafie","email":"matthewneafie@gmail.com","username":"mn9209"},"change_message_id":"192e7b90bced313f364ebc5cd7b0711e2ecd3497","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # NOTE: The contents of the secret are from .endpoints.ingress.host_fqdn_override.public.tls"},{"line_number":268,"context_line":"        public: default-tls-public"},{"line_number":269,"context_line":"  dhparam:"},{"line_number":270,"context_line":"    ingress_dhparam: |"},{"line_number":271,"context_line":"conf:"},{"line_number":272,"context_line":"  controller:"},{"line_number":273,"context_line":"    # NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_72d3cc60","line":270,"updated":"2020-09-15 17:01:58.000000000","message":"default setting","commit_id":"3ac249178b2de5b1a323b59188d01d03a0a441ac"},{"author":{"_account_id":18213,"name":"Matthew Neafie","email":"matthewneafie@gmail.com","username":"mn9209"},"change_message_id":"192e7b90bced313f364ebc5cd7b0711e2ecd3497","unresolved":false,"context_lines":[{"line_number":314,"context_line":"  endpoints_ingress: true"},{"line_number":315,"context_line":"  ingress: true"},{"line_number":316,"context_line":"  secret_ingress_tls: false"},{"line_number":317,"context_line":"  ingress_dhparam: true"},{"line_number":318,"context_line":"  service_error: true"},{"line_number":319,"context_line":"  service_ingress: true"},{"line_number":320,"context_line":"  job_image_repo_sync: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_92ce60b5","line":317,"updated":"2020-09-15 17:01:58.000000000","message":"default, false. Override in manifest","commit_id":"3ac249178b2de5b1a323b59188d01d03a0a441ac"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fb7fa7d16fceb7d98015422ea0cac18d7e07fdbb","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        public: default-tls-public"},{"line_number":269,"context_line":"  dhparam:"},{"line_number":270,"context_line":"    ingress_dhparam: |"},{"line_number":271,"context_line":"      MIIBCAKCAQEAq1TfL5qAQ2lmDyk1ZqjG1hFCjSObh/Stn3vENvNCc02jsCe6rbBY"},{"line_number":272,"context_line":"      BuBi1+0/IcqIbyraGuXT1gLj9tY/VSqjyD837T+fFz+tJdQYRZicYab/ZQy51Caz"},{"line_number":273,"context_line":"      TU4mUyyHe09u7/aTWdtdDDicT3tD9ze8Kj5OndJtUwpIb9AMHrJHL9Qk7KGhY+tM"},{"line_number":274,"context_line":"      eZTxyxZIlBcnLKKQZ5JA1tkWLcR4CXZKpPsmdj3WY/YSQFjAEBWEtvD3lrU0C/Z3"},{"line_number":275,"context_line":"      VmR6wsNmo9WKWdXTT0pyHWonQdsfPzvflLHQMF2+EcR909CSeRSfskz5Uit386qG"},{"line_number":276,"context_line":"      +4TeDbeZ1yONIBx7JBogVYhtsQ8SBTsdkwIBAg\u003d\u003d"},{"line_number":277,"context_line":"conf:"},{"line_number":278,"context_line":"  controller:"},{"line_number":279,"context_line":"    # NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f206bc21","line":276,"range":{"start_line":271,"start_character":0,"end_line":276,"end_character":46},"updated":"2020-09-14 22:44:55.000000000","message":"? probably don\u0027t want this statically coded here","commit_id":"bafb97b29538c795101020a3857cf26e881baa68"},{"author":{"_account_id":18213,"name":"Matthew Neafie","email":"matthewneafie@gmail.com","username":"mn9209"},"change_message_id":"192e7b90bced313f364ebc5cd7b0711e2ecd3497","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        public: default-tls-public"},{"line_number":269,"context_line":"  dhparam:"},{"line_number":270,"context_line":"    ingress_dhparam: |"},{"line_number":271,"context_line":"      MIIBCAKCAQEAq1TfL5qAQ2lmDyk1ZqjG1hFCjSObh/Stn3vENvNCc02jsCe6rbBY"},{"line_number":272,"context_line":"      BuBi1+0/IcqIbyraGuXT1gLj9tY/VSqjyD837T+fFz+tJdQYRZicYab/ZQy51Caz"},{"line_number":273,"context_line":"      TU4mUyyHe09u7/aTWdtdDDicT3tD9ze8Kj5OndJtUwpIb9AMHrJHL9Qk7KGhY+tM"},{"line_number":274,"context_line":"      eZTxyxZIlBcnLKKQZ5JA1tkWLcR4CXZKpPsmdj3WY/YSQFjAEBWEtvD3lrU0C/Z3"},{"line_number":275,"context_line":"      VmR6wsNmo9WKWdXTT0pyHWonQdsfPzvflLHQMF2+EcR909CSeRSfskz5Uit386qG"},{"line_number":276,"context_line":"      +4TeDbeZ1yONIBx7JBogVYhtsQ8SBTsdkwIBAg\u003d\u003d"},{"line_number":277,"context_line":"conf:"},{"line_number":278,"context_line":"  controller:"},{"line_number":279,"context_line":"    # NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_7dd9dd26","line":276,"range":{"start_line":271,"start_character":0,"end_line":276,"end_character":46},"in_reply_to":"9f560f44_f206bc21","updated":"2020-09-15 17:01:58.000000000","message":"Correct, we want this in security manifest.","commit_id":"bafb97b29538c795101020a3857cf26e881baa68"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"1a22651f26577dfd999dd87dd02a306e6071763a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        public: default-tls-public"},{"line_number":269,"context_line":"  dhparam:"},{"line_number":270,"context_line":"    ingress_dhparam: |"},{"line_number":271,"context_line":"      MIIBCAKCAQEAq1TfL5qAQ2lmDyk1ZqjG1hFCjSObh/Stn3vENvNCc02jsCe6rbBY"},{"line_number":272,"context_line":"      BuBi1+0/IcqIbyraGuXT1gLj9tY/VSqjyD837T+fFz+tJdQYRZicYab/ZQy51Caz"},{"line_number":273,"context_line":"      TU4mUyyHe09u7/aTWdtdDDicT3tD9ze8Kj5OndJtUwpIb9AMHrJHL9Qk7KGhY+tM"},{"line_number":274,"context_line":"      eZTxyxZIlBcnLKKQZ5JA1tkWLcR4CXZKpPsmdj3WY/YSQFjAEBWEtvD3lrU0C/Z3"},{"line_number":275,"context_line":"      VmR6wsNmo9WKWdXTT0pyHWonQdsfPzvflLHQMF2+EcR909CSeRSfskz5Uit386qG"},{"line_number":276,"context_line":"      +4TeDbeZ1yONIBx7JBogVYhtsQ8SBTsdkwIBAg\u003d\u003d"},{"line_number":277,"context_line":"conf:"},{"line_number":278,"context_line":"  controller:"},{"line_number":279,"context_line":"    # NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d3b8d0e9","line":276,"range":{"start_line":271,"start_character":0,"end_line":276,"end_character":46},"in_reply_to":"9f560f44_f206bc21","updated":"2020-09-15 14:48:25.000000000","message":"I am testing the changes currently, I will make changes once I am done, Thank you much for reviewing","commit_id":"bafb97b29538c795101020a3857cf26e881baa68"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bfc942d15dc560397a1687061be6fcb37d2c4136","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    bind-address: null"},{"line_number":284,"context_line":"    enable-vts-status: \"true\""},{"line_number":285,"context_line":"    server-tokens: \"false\""},{"line_number":286,"context_line":"    ssl-dh-param: openstack/ingress-dhparam"},{"line_number":287,"context_line":"  # This block sets the --default-ssl-certificate option"},{"line_number":288,"context_line":"  # https://kubernetes.github.io/ingress-nginx/user-guide/tls/#default-ssl-certificate"},{"line_number":289,"context_line":"  default_ssl_certificate:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_27fd866e","line":286,"range":{"start_line":286,"start_character":17,"end_line":286,"end_character":43},"updated":"2020-09-15 18:09:22.000000000","message":"how is this mounted? now it is specifying a file that doesn\u0027t exist.","commit_id":"3d12b1e84e0d1494f7afde9cb48267c45fcf1a2a"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"46843d09cecf428ea85f99cc645795cfe36d37b4","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    bind-address: null"},{"line_number":284,"context_line":"    enable-vts-status: \"true\""},{"line_number":285,"context_line":"    server-tokens: \"false\""},{"line_number":286,"context_line":"    ssl-dh-param: openstack/ingress-dhparam"},{"line_number":287,"context_line":"  # This block sets the --default-ssl-certificate option"},{"line_number":288,"context_line":"  # https://kubernetes.github.io/ingress-nginx/user-guide/tls/#default-ssl-certificate"},{"line_number":289,"context_line":"  default_ssl_certificate:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_cd9ca9c1","line":286,"range":{"start_line":286,"start_character":17,"end_line":286,"end_character":43},"in_reply_to":"9f560f44_27fd866e","updated":"2020-09-15 19:24:54.000000000","message":"we don\u0027t have to mount anything, it\u0027s already being mounted\n\naiab@ubuntu:~/openstack-helm-infra/ingress$ kubectl exec -it ingress-788d58fc4c-pjprv -n openstack cat nginx.conf | grep dh\n        # allow custom DH file http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_dhparam\n        ssl_dhparam /etc/ingress-controller/ssl/openstack-secret-dhparam.pem;\n        ssl_ecdh_curve auto;\naiab@ubuntu:~/openstack-helm-infra/ingress$","commit_id":"3d12b1e84e0d1494f7afde9cb48267c45fcf1a2a"}]}