)]}'
{"libvirt/templates/secret-ca-cert.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fad81cae3ad9b59a424044520b8d18706698a6fa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"type: Opaque"},{"line_number":15,"context_line":"stringData:"},{"line_number":16,"context_line":"  cacert.pem: |"},{"line_number":17,"context_line":"    -----BEGIN CERTIFICATE-----"},{"line_number":18,"context_line":"    MIID9TCCAl2gAwIBAgIMX2ExnQ//mYG6bVAaMA0GCSqGSIb3DQEBCwUAMBYxFDAS"},{"line_number":19,"context_line":"    BgNVBAMTC2xpYnZpcnQub3JnMB4XDTIwMDkxNTIxMjY1M1oXDTIxMDkxNTIxMjY1"},{"line_number":20,"context_line":"    M1owFjEUMBIGA1UEAxMLbGlidmlydC5vcmcwggGiMA0GCSqGSIb3DQEBAQUAA4IB"},{"line_number":21,"context_line":"    jwAwggGKAoIBgQDaRyGiqmztvL3NHeYGzgwx1Dpg1194Qk1Ak79lowQz9aIARLDG"},{"line_number":22,"context_line":"    yTjj14ToPLC392eWyosCsEQ1dDXx5rKOiEtSJgN18vdAPywsej1wb+f3H3EAslZu"},{"line_number":23,"context_line":"    uOXAiXTBp0ex/EoWqmVmG/JpwP74Rf16WVnTAc1xGABnDwsSIs8gigKI8ha+TdiT"},{"line_number":24,"context_line":"    uFqLNLpJuRXKnI0srBpUrkfhjJmikx9aP99wik+Y6I/iDiUKuDPvjtI4wqlwBqWc"},{"line_number":25,"context_line":"    +WDh2Zx/ot3UGwHS7jUAiZaodAjO40OniQCevwYlbCppj3e7C+3fYSGJ4L/RBUVS"},{"line_number":26,"context_line":"    +HaTyyos/Mz+2gIyNY9y2qi7YCMC1Q0h31o5Cr1G+B9BtQonOGXWq2FuCvCj4KOY"},{"line_number":27,"context_line":"    vpdvnHt6RCvtUkW4rinvqzx9GIiu3E8cFPrMTXH9hgkRvRsKz+X8dGXBstPMNcmT"},{"line_number":28,"context_line":"    N/DQ3Udtg75OlKixNhzxhYn845AhQ0HIZp4SZSsLZRP/KUYtIUhmgIwR84o6Jhb5"},{"line_number":29,"context_line":"    Rlf/zhVTauAD+6kCAwEAAaNDMEEwDwYDVR0TAQH/BAUwAwEB/zAPBgNVHQ8BAf8E"},{"line_number":30,"context_line":"    BQMDBwQAMB0GA1UdDgQWBBRqB1vUFPzNJVgSrh2R2WnIvO+T6zANBgkqhkiG9w0B"},{"line_number":31,"context_line":"    AQsFAAOCAYEAl4FDGkogq8eRwBE4QIwSlcjeUFTKc142PN3ZiVsx/QHwaZQwo+N4"},{"line_number":32,"context_line":"    JNflN15+GPasm/yNs7hYlowNcb6GC93k2NRaZ66jXQ3Yp1T2fSIvs2vKMj362eXK"},{"line_number":33,"context_line":"    hcfjG//t4HUrNqivTcpwg+klDXV/w0K0/cFVnwWaGjvfRU6lx8/fBGmag30t0UQq"},{"line_number":34,"context_line":"    UgCuPclV53JCArdGhoRZcxvAgql+uWxdyvsdmdFvaCe0D3n15nRMuFhFkrDIxyjI"},{"line_number":35,"context_line":"    JHBu+Z32yn6zTTkZPoPpPvSFQiXCzppdKLvGs/vbMi6qKty6wMZcpZtzTaKNHxUr"},{"line_number":36,"context_line":"    n0+/BeMDuQT7IYGl29Ds6LzFnnYhN4Ckh+R8nCml9+JicQPQNL1TC0u1ZlrQdSIc"},{"line_number":37,"context_line":"    kqpLCxb4OGp2u5eYxMaXKHWpl5LJoJbe9Rvyr5yV+zx46FH0o0qz8Rvka32hSiDG"},{"line_number":38,"context_line":"    FpNX6DoAEk3zVSYdFB5xTQ6h0BK1dMMbHPVzuXaYa0N2yjEWvBfjcVygn2164Rkj"},{"line_number":39,"context_line":"    6ZwFOKGDbhUL"},{"line_number":40,"context_line":"    -----END CERTIFICATE-----"},{"line_number":41,"context_line":"..."},{"line_number":42,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_15386339","line":40,"range":{"start_line":17,"start_character":0,"end_line":40,"end_character":29},"updated":"2020-09-16 03:41:12.000000000","message":"this makes all the certs uncustomizable with CN\u003dlibvirt.org as the issuer.","commit_id":"4aa81c4cb93546d242e401a404db40ffa2f37af3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"fd64a149812fb8189e385098d014a51a38c06b15","unresolved":false,"context_lines":[{"line_number":14,"context_line":"type: Opaque"},{"line_number":15,"context_line":"stringData:"},{"line_number":16,"context_line":"  cacert.pem: |"},{"line_number":17,"context_line":"    -----BEGIN CERTIFICATE-----"},{"line_number":18,"context_line":"    MIID9TCCAl2gAwIBAgIMX2ExnQ//mYG6bVAaMA0GCSqGSIb3DQEBCwUAMBYxFDAS"},{"line_number":19,"context_line":"    BgNVBAMTC2xpYnZpcnQub3JnMB4XDTIwMDkxNTIxMjY1M1oXDTIxMDkxNTIxMjY1"},{"line_number":20,"context_line":"    M1owFjEUMBIGA1UEAxMLbGlidmlydC5vcmcwggGiMA0GCSqGSIb3DQEBAQUAA4IB"},{"line_number":21,"context_line":"    jwAwggGKAoIBgQDaRyGiqmztvL3NHeYGzgwx1Dpg1194Qk1Ak79lowQz9aIARLDG"},{"line_number":22,"context_line":"    yTjj14ToPLC392eWyosCsEQ1dDXx5rKOiEtSJgN18vdAPywsej1wb+f3H3EAslZu"},{"line_number":23,"context_line":"    uOXAiXTBp0ex/EoWqmVmG/JpwP74Rf16WVnTAc1xGABnDwsSIs8gigKI8ha+TdiT"},{"line_number":24,"context_line":"    uFqLNLpJuRXKnI0srBpUrkfhjJmikx9aP99wik+Y6I/iDiUKuDPvjtI4wqlwBqWc"},{"line_number":25,"context_line":"    +WDh2Zx/ot3UGwHS7jUAiZaodAjO40OniQCevwYlbCppj3e7C+3fYSGJ4L/RBUVS"},{"line_number":26,"context_line":"    +HaTyyos/Mz+2gIyNY9y2qi7YCMC1Q0h31o5Cr1G+B9BtQonOGXWq2FuCvCj4KOY"},{"line_number":27,"context_line":"    vpdvnHt6RCvtUkW4rinvqzx9GIiu3E8cFPrMTXH9hgkRvRsKz+X8dGXBstPMNcmT"},{"line_number":28,"context_line":"    N/DQ3Udtg75OlKixNhzxhYn845AhQ0HIZp4SZSsLZRP/KUYtIUhmgIwR84o6Jhb5"},{"line_number":29,"context_line":"    Rlf/zhVTauAD+6kCAwEAAaNDMEEwDwYDVR0TAQH/BAUwAwEB/zAPBgNVHQ8BAf8E"},{"line_number":30,"context_line":"    BQMDBwQAMB0GA1UdDgQWBBRqB1vUFPzNJVgSrh2R2WnIvO+T6zANBgkqhkiG9w0B"},{"line_number":31,"context_line":"    AQsFAAOCAYEAl4FDGkogq8eRwBE4QIwSlcjeUFTKc142PN3ZiVsx/QHwaZQwo+N4"},{"line_number":32,"context_line":"    JNflN15+GPasm/yNs7hYlowNcb6GC93k2NRaZ66jXQ3Yp1T2fSIvs2vKMj362eXK"},{"line_number":33,"context_line":"    hcfjG//t4HUrNqivTcpwg+klDXV/w0K0/cFVnwWaGjvfRU6lx8/fBGmag30t0UQq"},{"line_number":34,"context_line":"    UgCuPclV53JCArdGhoRZcxvAgql+uWxdyvsdmdFvaCe0D3n15nRMuFhFkrDIxyjI"},{"line_number":35,"context_line":"    JHBu+Z32yn6zTTkZPoPpPvSFQiXCzppdKLvGs/vbMi6qKty6wMZcpZtzTaKNHxUr"},{"line_number":36,"context_line":"    n0+/BeMDuQT7IYGl29Ds6LzFnnYhN4Ckh+R8nCml9+JicQPQNL1TC0u1ZlrQdSIc"},{"line_number":37,"context_line":"    kqpLCxb4OGp2u5eYxMaXKHWpl5LJoJbe9Rvyr5yV+zx46FH0o0qz8Rvka32hSiDG"},{"line_number":38,"context_line":"    FpNX6DoAEk3zVSYdFB5xTQ6h0BK1dMMbHPVzuXaYa0N2yjEWvBfjcVygn2164Rkj"},{"line_number":39,"context_line":"    6ZwFOKGDbhUL"},{"line_number":40,"context_line":"    -----END CERTIFICATE-----"},{"line_number":41,"context_line":"..."},{"line_number":42,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_4ee7e0ad","line":40,"range":{"start_line":17,"start_character":0,"end_line":40,"end_character":29},"updated":"2020-09-16 15:53:59.000000000","message":"agree that we should not hard code this","commit_id":"55b9cc99ff2d58b5887bc292b679cc40a8b299c7"}],"libvirt/values.yaml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9b0e438ca81f40feddd3e5f8e58eba45d9fc68ee","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  daemonset_libvirt: true"},{"line_number":190,"context_line":"  job_image_repo_sync: true"},{"line_number":191,"context_line":"  network_policy: false"},{"line_number":192,"context_line":"secrets:"},{"line_number":193,"context_line":"  tls:"},{"line_number":194,"context_line":"    server: libvirt-tls-server"},{"line_number":195,"context_line":"    client: libvirt-tls-client"},{"line_number":196,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_cfa4614e","line":195,"range":{"start_line":192,"start_character":0,"end_line":195,"end_character":30},"updated":"2020-09-18 13:58:07.000000000","message":"can you add one new line above this to space it out from the manifests section above?","commit_id":"422240bfa8c4f6c71706bad71911cea71624ad82"}],"libvirt/values_overrides/ssl.yaml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9b0e438ca81f40feddd3e5f8e58eba45d9fc68ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    listen_tcp: \"0\""},{"line_number":5,"context_line":"    listen_tls: \"1\""},{"line_number":6,"context_line":"    auth_tcp: \"none\""},{"line_number":7,"context_line":"    key_file: \"/etc/pki/libvirt/private/serverkey.pem\""},{"line_number":8,"context_line":"    cert_file: \"/etc/pki/libvirt/servercert.pem\""},{"line_number":9,"context_line":"    ca_file: \"/etc/pki/CA/cacert.pem\""},{"line_number":10,"context_line":"    listen_addr: 0.0.0.0"},{"line_number":11,"context_line":"    log_level: \"3\""},{"line_number":12,"context_line":"    log_outputs: \"1:file:/var/log/libvirt/libvirtd.log\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_8f81c9a3","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":37},"updated":"2020-09-18 13:58:07.000000000","message":"could we technically move this to default?","commit_id":"422240bfa8c4f6c71706bad71911cea71624ad82"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9b0e438ca81f40feddd3e5f8e58eba45d9fc68ee","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    cert_file: \"/etc/pki/libvirt/servercert.pem\""},{"line_number":9,"context_line":"    ca_file: \"/etc/pki/CA/cacert.pem\""},{"line_number":10,"context_line":"    listen_addr: 0.0.0.0"},{"line_number":11,"context_line":"    log_level: \"3\""},{"line_number":12,"context_line":"    log_outputs: \"1:file:/var/log/libvirt/libvirtd.log\""},{"line_number":13,"context_line":"    log_filters: \"3:remote 4:event 3:util.json 3:rpc 1:*\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"secrets:"},{"line_number":16,"context_line":"  tls:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_cf8bc1bd","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":57},"updated":"2020-09-18 13:58:07.000000000","message":"and remove this?","commit_id":"422240bfa8c4f6c71706bad71911cea71624ad82"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9b0e438ca81f40feddd3e5f8e58eba45d9fc68ee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    log_outputs: \"1:file:/var/log/libvirt/libvirtd.log\""},{"line_number":13,"context_line":"    log_filters: \"3:remote 4:event 3:util.json 3:rpc 1:*\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"secrets:"},{"line_number":16,"context_line":"  tls:"},{"line_number":17,"context_line":"    server: libvirt-tls-server"},{"line_number":18,"context_line":"    client: libvirt-tls-client"},{"line_number":19,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_4fb97177","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":30},"updated":"2020-09-18 13:58:07.000000000","message":"this already exists in values.yaml so we can remove it from the override i guess?","commit_id":"422240bfa8c4f6c71706bad71911cea71624ad82"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"27462c09ceb45cbbbe7a51e6974fa276522978fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"conf:"},{"line_number":3,"context_line":"  libvirt:"},{"line_number":4,"context_line":"    listen_tcp: \"0\""},{"line_number":5,"context_line":"    listen_tls: \"1\""},{"line_number":6,"context_line":"    listen_addr: 0.0.0.0"},{"line_number":7,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_a159effd","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"updated":"2020-09-23 19:44:36.000000000","message":"is this needed for something else later?  I don\u0027t think this is needed for TLS.\nmaybe show tls_port instead?","commit_id":"70a16045903782e7d11fc6058602c7fba3574fc5"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"00044aa191bca0601bd7464a0426de0b472bb938","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"conf:"},{"line_number":3,"context_line":"  libvirt:"},{"line_number":4,"context_line":"    listen_tcp: \"0\""},{"line_number":5,"context_line":"    listen_tls: \"1\""},{"line_number":6,"context_line":"    listen_addr: 0.0.0.0"},{"line_number":7,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_d4f3ffe5","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"in_reply_to":"9f560f44_a159effd","updated":"2020-09-23 20:30:05.000000000","message":"listen_tcp is only for unencrypted tcp/ip socket and it is disabled as default.\nBut in the default value file, it is enabled explicitly.\nSo we need to disable it in ssl mode.","commit_id":"70a16045903782e7d11fc6058602c7fba3574fc5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"01bfd15e83cbf09b130fba8cef9d5aa14d3c680d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"conf:"},{"line_number":3,"context_line":"  libvirt:"},{"line_number":4,"context_line":"    listen_tcp: \"0\""},{"line_number":5,"context_line":"    listen_tls: \"1\""},{"line_number":6,"context_line":"    listen_addr: 0.0.0.0"},{"line_number":7,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_37c4fd5f","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"in_reply_to":"9f560f44_d4f3ffe5","updated":"2020-09-23 21:31:07.000000000","message":"I can see where perhaps listen_tcp and listen_tls is mutually exclusive, I wish the documentation would state as much, but unfortunately it does not, so I am ok with this here.","commit_id":"70a16045903782e7d11fc6058602c7fba3574fc5"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"27462c09ceb45cbbbe7a51e6974fa276522978fe","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        - - ./tools/deployment/openstack-support/100-ceph-radosgateway.sh"},{"line_number":654,"context_line":"          - ./tools/deployment/openstack-support/110-openstack-exporter.sh"},{"line_number":655,"context_line":"          - ./tools/deployment/openstack-support/120-powerdns.sh"},{"line_number":656,"context_line":"          - ./tools/deployment/openstack-support/130-cinder.sh"},{"line_number":657,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f560f44_815e6be6","line":656,"range":{"start_line":656,"start_character":25,"end_line":656,"end_character":56},"updated":"2020-09-23 19:44:36.000000000","message":"I am conflicted on whether we should add testing with apparmor as part of the gate, in case the profile blocks access to something we don\u0027t expect.","commit_id":"70a16045903782e7d11fc6058602c7fba3574fc5"}]}