)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ac74c270f02e9e1e0329d68466abfd8f359ffa7f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph] Fixed a bug in custom storage classes definition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The original code overrides the list of monitors with ceph monitors defined"},{"line_number":10,"context_line":"in [global] section of ceph.conf even if monitors are explicitly enlisted"},{"line_number":11,"context_line":"in storage class parameters. This allows to use the only one ceph cluster with"},{"line_number":12,"context_line":"all storage classes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Patch set fixes this issue by using the monitors from [global] section of"},{"line_number":15,"context_line":"ceph.conf as a \u0027default\u0027 value, only if the \u0027monitors:\u0027 parameter is not explicitly"},{"line_number":16,"context_line":"set in the storage class definition."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Ex."},{"line_number":19,"context_line":"      storageclass:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_008e8cd0","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":16},"updated":"2020-09-28 16:22:20.000000000","message":"reflow if you revisit this","commit_id":"f667841fe75ee7eb0f8800bcd1302bf4bc562602"}],"helm-toolkit/templates/manifests/_ceph-storageclass.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ac74c270f02e9e1e0329d68466abfd8f359ffa7f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            name: general"},{"line_number":29,"context_line":"          parameters:"},{"line_number":30,"context_line":"            #We will grab the monitors value based on helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup"},{"line_number":31,"context_line":"            #if they are not defined in storage class explicitly"},{"line_number":32,"context_line":"            pool: rbd"},{"line_number":33,"context_line":"            admin_id: admin"},{"line_number":34,"context_line":"            ceph_configmap_name: \"ceph-etc\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9f560f44_c0ac9438","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":14},"updated":"2020-09-28 16:22:20.000000000","message":"# comments with a space prefix preferred in yaml\n#not like this","commit_id":"f667841fe75ee7eb0f8800bcd1302bf4bc562602"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"de99c9ea3ebc81178814df7f5fd90169077c1933","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            name: general"},{"line_number":29,"context_line":"          parameters:"},{"line_number":30,"context_line":"            #We will grab the monitors value based on helm-toolkit.endpoints.host_and_port_endpoint_uri_lookup"},{"line_number":31,"context_line":"            #if they are not defined in storage class explicitly"},{"line_number":32,"context_line":"            pool: rbd"},{"line_number":33,"context_line":"            admin_id: admin"},{"line_number":34,"context_line":"            ceph_configmap_name: \"ceph-etc\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9f560f44_fe9203a0","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":14},"in_reply_to":"9f560f44_c0ac9438","updated":"2020-09-29 16:17:56.000000000","message":"Could you also add space after # to the previous line","commit_id":"f667841fe75ee7eb0f8800bcd1302bf4bc562602"}]}
