)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"b34b70c7e2fb027c22cc12ad220e402c2416a5f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c02326ec_6087c729","updated":"2021-12-20 22:26:32.000000000","message":"Looks like a nice addition to me and everything seems fine","commit_id":"e6e661772d767e908658daf5d1a6ac4eb091a004"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"59c3f8332bf5431d98fc70cd4d9f6bdc8a74f6e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4663a5d9_7c240e6a","updated":"2021-12-20 22:27:00.000000000","message":"Maybe rebase so it can actually be merged","commit_id":"e6e661772d767e908658daf5d1a6ac4eb091a004"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"8160c2aa2b4c980f84f7d89f192ef66bda51800d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"095e4ef8_7764b842","updated":"2022-05-10 16:29:25.000000000","message":"Oleks could you rebase this again so we can land this 😞","commit_id":"0729b645bddc7fe36177ec1d22c29008965655d5"}],"libvirt/templates/daemonset-libvirt.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"08574720be7a1d2d1347c132ee5afb622f613de2","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            - name: metrics"},{"line_number":221,"context_line":"              protocol: TCP"},{"line_number":222,"context_line":"              containerPort: {{ tuple \"libvirt_exporter\" \"direct\" \"metrics\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":223,"context_line":"          livenessProbe:"},{"line_number":224,"context_line":"            httpGet:"},{"line_number":225,"context_line":"              path: /"},{"line_number":226,"context_line":"              port: metrics"},{"line_number":227,"context_line":"          readinessProbe:"},{"line_number":228,"context_line":"            httpGet:"},{"line_number":229,"context_line":"              path: /"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_3a0f7d8c","line":226,"range":{"start_line":223,"start_character":8,"end_line":226,"end_character":27},"updated":"2020-09-28 15:09:11.000000000","message":"I am not against all these probes in general, but just thinking if one is needed for this exporter.\n\nAlso would it make sense to make this exporter \"optional\", maybe add a knob to allow user to enable it if needed?","commit_id":"cc9038743bf99667c81e88601c633c69dc754a06"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"16a6ca498d257e2b364fac9a947d7b95d826b3f6","unresolved":true,"context_lines":[{"line_number":220,"context_line":"              readOnly: true"},{"line_number":221,"context_line":"            {{- end }}"},{"line_number":222,"context_line":"            {{- end }}"},{"line_number":223,"context_line":"{{ if $mounts_libvirt.volumeMounts }}{{ toYaml $mounts_libvirt.volumeMounts | indent 12 }}{{ end }}"},{"line_number":224,"context_line":"      volumes:"},{"line_number":225,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.client \"name\" \"ssl-client\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"clientcert.pem\" \"clientkey.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":226,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.server \"name\" \"ssl-server-cert\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"servercert.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8f7a285d_1f03180f","side":"PARENT","line":223,"updated":"2020-12-09 14:02:43.000000000","message":"Why do we not need to mount these volumes anymore?","commit_id":"970ec5128a5d836914c68b3a99155e0c1e3840df"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"0c9852c738f28fcccabf48dd6b7677e34a150802","unresolved":false,"context_lines":[{"line_number":220,"context_line":"              readOnly: true"},{"line_number":221,"context_line":"            {{- end }}"},{"line_number":222,"context_line":"            {{- end }}"},{"line_number":223,"context_line":"{{ if $mounts_libvirt.volumeMounts }}{{ toYaml $mounts_libvirt.volumeMounts | indent 12 }}{{ end }}"},{"line_number":224,"context_line":"      volumes:"},{"line_number":225,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.client \"name\" \"ssl-client\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"clientcert.pem\" \"clientkey.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":226,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.server \"name\" \"ssl-server-cert\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"servercert.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"77894002_c19bcfc5","side":"PARENT","line":223,"in_reply_to":"2738b7c8_aed49ed1","updated":"2022-03-09 04:53:11.000000000","message":"Done","commit_id":"970ec5128a5d836914c68b3a99155e0c1e3840df"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"610e10d706f34a6ce3950071fb7ffc552f3c6a91","unresolved":true,"context_lines":[{"line_number":220,"context_line":"              readOnly: true"},{"line_number":221,"context_line":"            {{- end }}"},{"line_number":222,"context_line":"            {{- end }}"},{"line_number":223,"context_line":"{{ if $mounts_libvirt.volumeMounts }}{{ toYaml $mounts_libvirt.volumeMounts | indent 12 }}{{ end }}"},{"line_number":224,"context_line":"      volumes:"},{"line_number":225,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.client \"name\" \"ssl-client\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"clientcert.pem\" \"clientkey.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":226,"context_line":"        {{ dict \"enabled\" $ssl_enabled \"secretName\" $envAll.Values.secrets.tls.server \"name\" \"ssl-server-cert\" \"path\" \"/etc/pki/libvirt\" \"certs\" (tuple \"servercert.pem\" ) | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2738b7c8_aed49ed1","side":"PARENT","line":223,"in_reply_to":"8f7a285d_1f03180f","updated":"2020-12-10 11:13:32.000000000","message":"good catch","commit_id":"970ec5128a5d836914c68b3a99155e0c1e3840df"}],"libvirt/values.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"16a6ca498d257e2b364fac9a947d7b95d826b3f6","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        cpu: \"100m\""},{"line_number":168,"context_line":"      limits:"},{"line_number":169,"context_line":"        memory: \"256Mi\""},{"line_number":170,"context_line":"        cpu: \"500m\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"dependencies:"},{"line_number":173,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fe220f96_86e54f6c","line":170,"range":{"start_line":170,"start_character":14,"end_line":170,"end_character":18},"updated":"2020-12-09 14:02:43.000000000","message":"Does sidecar need more CPU the main container?","commit_id":"11e7604408f2b40e0e7ca535c4bf2600f211dff2"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"0c9852c738f28fcccabf48dd6b7677e34a150802","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        cpu: \"100m\""},{"line_number":168,"context_line":"      limits:"},{"line_number":169,"context_line":"        memory: \"256Mi\""},{"line_number":170,"context_line":"        cpu: \"500m\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"dependencies:"},{"line_number":173,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"641383da_c1247e1c","line":170,"range":{"start_line":170,"start_character":14,"end_line":170,"end_character":18},"in_reply_to":"0c0b5c5d_344c27d5","updated":"2022-03-09 04:53:11.000000000","message":"Done","commit_id":"11e7604408f2b40e0e7ca535c4bf2600f211dff2"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"610e10d706f34a6ce3950071fb7ffc552f3c6a91","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        cpu: \"100m\""},{"line_number":168,"context_line":"      limits:"},{"line_number":169,"context_line":"        memory: \"256Mi\""},{"line_number":170,"context_line":"        cpu: \"500m\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"dependencies:"},{"line_number":173,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0c0b5c5d_344c27d5","line":170,"range":{"start_line":170,"start_character":14,"end_line":170,"end_character":18},"in_reply_to":"fe220f96_86e54f6c","updated":"2020-12-10 11:13:32.000000000","message":"I dont think so. so used smaller vaule","commit_id":"11e7604408f2b40e0e7ca535c4bf2600f211dff2"}]}