)]}'
{"id":"openstack%2Fopenstack-helm-infra~761028","triplet_id":"openstack%2Fopenstack-helm-infra~master~I133e07f759111cd8f568c49fd78ed0f7ed8435e5","project":"openstack/openstack-helm-infra","branch":"master","topic":"mstr_overr","hashtags":[],"change_id":"I133e07f759111cd8f568c49fd78ed0f7ed8435e5","subject":"[helm-toolkit] add daemonset_overrides_root function","status":"ABANDONED","created":"2020-11-02 22:08:27.000000000","updated":"2021-09-30 16:07:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7a806081919ed6b59f36c554f2681e70d2ed8fa0","_number":761028,"virtual_id_number":761028,"owner":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-11-05 15:09:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-11-06 17:48:22.000000000","_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":1,"date":"2020-11-06 15:52:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-05 15:09:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-06 15:52:23.000000000","updated_by":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"reviewer":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"state":"REVIEWER"}],"messages":[{"id":"67c799690f186e19d0c9deec9ceaecf52cccf5dc","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2020-11-02 22:08:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c433dac4ec6eb3c6721879c0fe58824bb924b23","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-02 23:03:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8605c4444e8c4b1d8f3763de45f7025e : SUCCESS in 2m 53s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/626d4fe0f3dd43ed9dc2f6e5a9e198d8 : SUCCESS in 3m 47s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/90857dd8f6654e6692762fe064248adb : SUCCESS in 34m 20s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/c65383714b6d4b06a257b2e07764c29d : SUCCESS in 31m 31s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/40b95b3c41c54cf58a591cd9977a0d67 : SUCCESS in 46m 46s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/f16577b0cdab49ebb825907b8ca31e38 : SUCCESS in 48m 02s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/945bffe399f44e43bc74b61ccf28672d : SUCCESS in 10m 13s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/cf8bc3b71b2e468a9536f102e64b663d : SUCCESS in 13m 53s","accounts_in_message":[],"_revision_number":1},{"id":"97798a2f3e92e72be1801c415c879d2f23daab27","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2020-11-03 08:12:27.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"28cafe0d8c35a6170ddd855558ce242529455df4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 09:12:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b95ee571d98e468e891894476f1a1023 : SUCCESS in 3m 59s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/13d5f283c9f647819076537d833ddeb1 : SUCCESS in 3m 49s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/7cab045c99ed4624b1de6dfffe46d618 : SUCCESS in 37m 54s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/5a1d1a59158a42aabae9dbb5a33f042d : SUCCESS in 30m 29s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/16842bfdebf344ad935b3a46046af422 : SUCCESS in 46m 37s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/5471fa7c09ef42d598bd94b99a2b553b : SUCCESS in 46m 00s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/c75530d9d4884ea697a6854a8478510d : SUCCESS in 9m 59s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/72fe72837c904ebe91c750f92a2ae901 : SUCCESS in 13m 22s","accounts_in_message":[],"_revision_number":2},{"id":"3b7456e38cf270e63bbd2332bdc39b2ce795e1f4","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2020-11-05 14:15:20.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"7398ebfe995fb46d8c0024277344db80aef621ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-05 15:09:55.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/785e79c509f249f8a3f41a7bf6612c74 : SUCCESS in 3m 05s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e6d69639bc9b40d2bed3ce0faf868c5b : SUCCESS in 3m 38s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/787e280030834f06985f3a2f072b9791 : SUCCESS in 34m 14s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/6852b4f88173496a83528bcf1c3bed36 : SUCCESS in 30m 55s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/6bcd5e2e690948bca76d25d9dd922c54 : SUCCESS in 47m 59s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/579674ceffe04378853afd02f1949d60 : SUCCESS in 44m 18s\n- openstack-helm-infra-airship-divingbell https://zuul.opendev.org/t/openstack/build/2f951872f51b4ad59cfa746327f9b1b3 : SUCCESS in 10m 22s (non-voting)\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/92a1bb62bfca495bb0a7ab6bcf5a6520 : SUCCESS in 13m 43s","accounts_in_message":[],"_revision_number":3},{"id":"4f3a23bf658566e5ab7e27da80659501f50ce88e","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2020-11-06 15:52:23.000000000","message":"Patch Set 3: Code-Review+1\n\nwe would benefit from seeing it tested by being invoked. maybe in a follow up change where some example usage is implemented","accounts_in_message":[],"_revision_number":3},{"id":"02de54840abdf10dc7819a6a3418f53b66b3d4c2","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2020-11-06 17:48:22.000000000","message":"Patch Set 3:\n\nthere is patch to nova that depends on this one:\nhttps://review.opendev.org/#/c/761774/","accounts_in_message":[],"_revision_number":3},{"id":"7a806081919ed6b59f36c554f2681e70d2ed8fa0","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-09-30 16:07:18.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e8646a5690d80c36c8f2d0178f92f0d1610a2d5d","revisions":{"35948976a44d71c69de955f4ca1d9993c9db9261":{"kind":"REWORK","_number":1,"created":"2020-11-02 22:08:27.000000000","uploader":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"ref":"refs/changes/28/761028/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/28/761028/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/1"}}},"commit":{"parents":[{"commit":"7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b","subject":"[ceph-provisioners] Validate each storageclass created","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b"}]}],"author":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-02 22:07:48.000000000","tz":120},"committer":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-02 22:08:16.000000000","tz":120},"subject":"[helm-toolkit] add daemonset_overrides_root function","message":"[helm-toolkit] add daemonset_overrides_root function\n\nThe helm-toolkit.utils.daemonset_overrides function have some limitations:\n\n * it allows to override only conf values specifid in configmap-etc\n * it doesn\u0027t allow to override values for daemonsets passed via env variables\n   or via damoenset definition. As result it is impossible to have mixed\n   deployment when one compute is configured with dpdk while other not.\n * it is impossible to override interface names/other information stored in\n   \u003cservice\u003e-bin configmap\n * It allows to schedule on both hosts and labels, which adds some\n   uncertainty\n\nThis implementation is intended to handle those limitations:\n\n * it allows to schedule only based on labels\n * it creates \u003cservice\u003e-bin per daemonset override\n * it allows to override values when rendering daemonsets\n\n It picks data from the following structure:\n\n .Values:\n   mychart_mydaemonset:\n     labels:\n       override::me:\n         root:\n           override_root_option: override_root_value\n           conf:\n             ovs_dpdk:\n               enabled: true\n             neutron:\n               DEFAULT:\n                 foo: bar\n\nChange-Id: I133e07f759111cd8f568c49fd78ed0f7ed8435e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/35948976a44d71c69de955f4ca1d9993c9db9261"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/35948976a44d71c69de955f4ca1d9993c9db9261"}]},"branch":"refs/heads/master"},"8a270f17115fae3ccd576a6f00892e9a32281a21":{"kind":"REWORK","_number":2,"created":"2020-11-03 08:12:27.000000000","uploader":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"ref":"refs/changes/28/761028/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/28/761028/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/2"}}},"commit":{"parents":[{"commit":"7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b","subject":"[ceph-provisioners] Validate each storageclass created","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b"}]}],"author":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-02 22:07:48.000000000","tz":120},"committer":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-03 08:12:25.000000000","tz":0},"subject":"[helm-toolkit] add daemonset_overrides_root function","message":"[helm-toolkit] add daemonset_overrides_root function\n\nThe helm-toolkit.utils.daemonset_overrides function have some limitations:\n\n * it allows to override only conf values specifid in configmap-etc\n * it doesn\u0027t allow to override values for daemonsets passed via env variables\n   or via damoenset definition. As result it is impossible to have mixed\n   deployment when one compute is configured with dpdk while other not.\n * it is impossible to override interface names/other information stored in\n   \u003cservice\u003e-bin configmap\n * It allows to schedule on both hosts and labels, which adds some\n   uncertainty\n\nThis implementation is intended to handle those limitations:\n\n * it allows to schedule only based on labels\n * it creates \u003cservice\u003e-bin per daemonset override\n * it allows to override values when rendering daemonsets\n\n It picks data from the following structure:\n\n .Values:\n   overrides:\n     mychart_mydaemonset:\n       labels:\n         override::me:\n           root:\n             override_root_option: override_root_value\n             conf:\n               ovs_dpdk:\n                 enabled: true\n               neutron:\n                 DEFAULT:\n                   foo: bar\n\nChange-Id: I133e07f759111cd8f568c49fd78ed0f7ed8435e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/8a270f17115fae3ccd576a6f00892e9a32281a21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/8a270f17115fae3ccd576a6f00892e9a32281a21"}]},"branch":"refs/heads/master"},"e8646a5690d80c36c8f2d0178f92f0d1610a2d5d":{"kind":"REWORK","_number":3,"created":"2020-11-05 14:15:20.000000000","uploader":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"ref":"refs/changes/28/761028/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/28/761028/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/28/761028/3"}}},"commit":{"parents":[{"commit":"7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b","subject":"[ceph-provisioners] Validate each storageclass created","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7c8ca55ac08123c32fa7183bf9c3b94c4fa4fa5b"}]}],"author":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-02 22:07:48.000000000","tz":120},"committer":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2020-11-05 14:14:59.000000000","tz":0},"subject":"[helm-toolkit] add daemonset_overrides_root function","message":"[helm-toolkit] add daemonset_overrides_root function\n\nThe helm-toolkit.utils.daemonset_overrides function have some limitations:\n\n * it allows to override only conf values specifid in configmap-etc\n * it doesn\u0027t allow to override values for daemonsets passed via env variables\n   or via damoenset definition. As result it is impossible to have mixed\n   deployment when one compute is configured with dpdk while other not.\n * it is impossible to override interface names/other information stored in\n   \u003cservice\u003e-bin configmap\n * It allows to schedule on both hosts and labels, which adds some\n   uncertainty\n\nThis implementation is intended to handle those limitations:\n\n * it allows to schedule only based on labels\n * it creates \u003cservice\u003e-bin per daemonset override\n * it allows to override values when rendering daemonsets\n\n It picks data from the following structure:\n\n .Values:\n   overrides:\n     mychart_mydaemonset:\n       labels:\n         override::me:\n           root:\n             override_root_option: override_root_value\n             conf:\n               ovs_dpdk:\n                 enabled: true\n               neutron:\n                 DEFAULT:\n                   foo: bar\n\nChange-Id: I133e07f759111cd8f568c49fd78ed0f7ed8435e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/e8646a5690d80c36c8f2d0178f92f0d1610a2d5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/e8646a5690d80c36c8f2d0178f92f0d1610a2d5d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}