)]}'
{"tools/deployment/common/setup-ceph-loopback-device.sh":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"6c602b2a56eb35488582ee8714028d872bf1aa68","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  sudo mkdir -p /var/lib/openstack-helm/$namespace"},{"line_number":7,"context_line":"  sudo truncate -s 10G /var/lib/openstack-helm/$namespace/ceph-osd-data-loopbackfile.img"},{"line_number":8,"context_line":"  sudo truncate -s 8G /var/lib/openstack-helm/$namespace/ceph-osd-db-wal-loopbackfile.img"},{"line_number":9,"context_line":"  cat \u003c\u003cEOF \u003e /etc/systemd/system/loops-setup.service"},{"line_number":10,"context_line":"[Unit]"},{"line_number":11,"context_line":"Description\u003dSetup loop devices"},{"line_number":12,"context_line":"DefaultDependencies\u003dno"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_0190ed42","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":53},"updated":"2020-11-04 23:54:36.000000000","message":"i think you\u0027ll need sudo here. as well as in further systemctl manipulation","commit_id":"79b19d5ae50f841bd9469284c1fcc82b29594589"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"6389aa0f0a810a1c069b6dcbc123612f0c8dd75e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  sudo mkdir -p /var/lib/openstack-helm/$namespace"},{"line_number":10,"context_line":"  sudo truncate -s 10G /var/lib/openstack-helm/$namespace/ceph-osd-data-loopbackfile.img"},{"line_number":11,"context_line":"  sudo truncate -s 8G /var/lib/openstack-helm/$namespace/ceph-osd-db-wal-loopbackfile.img"},{"line_number":12,"context_line":"  sudo bash -c \u0027cat \u003c\u003cEOF \u003e /etc/systemd/system/loops-setup.service"},{"line_number":13,"context_line":"[Unit]"},{"line_number":14,"context_line":"Description\u003dSetup loop devices"},{"line_number":15,"context_line":"DefaultDependencies\u003dno"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1f621f24_266ed200","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":16},"updated":"2020-11-05 18:43:11.000000000","message":"double quotes","commit_id":"76c291e38a073cc40a7cfcce9e1984e7f28e6a8b"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"6389aa0f0a810a1c069b6dcbc123612f0c8dd75e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  sudo systemctl status loops-setup"},{"line_number":37,"context_line":"  sudo systemctl enable loops-setup"},{"line_number":38,"context_line":"  #lets verify the devices"},{"line_number":39,"context_line":"  sudo losetup -a"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"while [[ \"$#\" \u003e 0 ]]; do case $1 in"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1f621f24_4672eee4","line":39,"updated":"2020-11-05 18:43:11.000000000","message":"makes sense to be safe and wait for device ready somewhere here to avoid possible race condition","commit_id":"76c291e38a073cc40a7cfcce9e1984e7f28e6a8b"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"691a7fb8b26862a5fcb62d6f2314d30efeb6b515","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  sudo systemctl start loops-setup"},{"line_number":37,"context_line":"  sudo systemctl status loops-setup"},{"line_number":38,"context_line":"  sudo systemctl enable loops-setup"},{"line_number":39,"context_line":"  #lets verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_0c200b48","line":39,"updated":"2020-11-06 15:35:45.000000000","message":"nit - need space after # sign and also lets changed to let\u0027s or i\u0027d just change it to verify the devices.","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4bfa73464aee41f32936e0edfb77e366a26017a8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  sudo systemctl start loops-setup"},{"line_number":37,"context_line":"  sudo systemctl status loops-setup"},{"line_number":38,"context_line":"  sudo systemctl enable loops-setup"},{"line_number":39,"context_line":"  #lets verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_7dc7a765","line":39,"in_reply_to":"1f621f24_0c200b48","updated":"2020-11-06 19:52:33.000000000","message":"Done","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"691a7fb8b26862a5fcb62d6f2314d30efeb6b515","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  #lets verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"couldnt find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_8cd9bb58","line":42,"range":{"start_line":42,"start_character":41,"end_line":42,"end_character":52},"updated":"2020-11-06 15:35:45.000000000","message":"nit - needs to be successfully","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4bfa73464aee41f32936e0edfb77e366a26017a8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  #lets verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"couldnt find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_5dc46b5f","line":42,"range":{"start_line":42,"start_character":41,"end_line":42,"end_character":52},"in_reply_to":"1f621f24_8cd9bb58","updated":"2020-11-06 19:52:33.000000000","message":"Done","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"691a7fb8b26862a5fcb62d6f2314d30efeb6b515","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"couldnt find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_ecdaef48","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":17},"updated":"2020-11-06 15:35:45.000000000","message":"nit - change to couldn\u0027t or could not","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4bfa73464aee41f32936e0edfb77e366a26017a8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created scuessfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"couldnt find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_bda2dfac","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":17},"in_reply_to":"1f621f24_ecdaef48","updated":"2020-11-06 19:52:33.000000000","message":"Done","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"691a7fb8b26862a5fcb62d6f2314d30efeb6b515","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created scuessfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"couldnt find ceph osd wal/db  disk so exiting\""},{"line_number":51,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_0ce5ab09","line":48,"range":{"start_line":48,"start_character":42,"end_line":48,"end_character":43},"updated":"2020-11-06 15:35:45.000000000","message":"Nit - needs to be successfully","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4bfa73464aee41f32936e0edfb77e366a26017a8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created scuessfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"couldnt find ceph osd wal/db  disk so exiting\""},{"line_number":51,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_9da723be","line":48,"range":{"start_line":48,"start_character":42,"end_line":48,"end_character":43},"in_reply_to":"1f621f24_0ce5ab09","updated":"2020-11-06 19:52:33.000000000","message":"Done","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"691a7fb8b26862a5fcb62d6f2314d30efeb6b515","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created scuessfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"couldnt find ceph osd wal/db  disk so exiting\""},{"line_number":51,"context_line":"    exit 1"},{"line_number":52,"context_line":"  fi"},{"line_number":53,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_6ceedfed","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":17},"updated":"2020-11-06 15:35:45.000000000","message":"nit - change to couldn\u0027t or could not","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4bfa73464aee41f32936e0edfb77e366a26017a8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created scuessfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"couldnt find ceph osd wal/db  disk so exiting\""},{"line_number":51,"context_line":"    exit 1"},{"line_number":52,"context_line":"  fi"},{"line_number":53,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1f621f24_fda8d78c","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":17},"in_reply_to":"1f621f24_6ceedfed","updated":"2020-11-06 19:52:33.000000000","message":"Done","commit_id":"c96e4108b5315cfa043bd30fa6d5e543c2d4ed29"}]}