)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"f86e7a7aca9fa267a2c2d4a28704a2cfb6b0a48c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Correct naming convention for logical volumes in disk_zap()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OSD logical volume names used to be based on the logical disk path,"},{"line_number":10,"context_line":"i.e. /dev/sdb, but that has changed. The lvremove logic in disk_zap()"},{"line_number":11,"context_line":"is still using the old naming convention. This change fixes that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If32ab354670166a3c844991de1744de63a508303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"69a022ff_05ee8e1c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"updated":"2020-12-17 17:16:26.000000000","message":"could you elaborate when it changed and do we break any compatibility with old behavior here","commit_id":"213596d71cc3cb3fca7a78e6fef12479f36b89a0"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"f77d3485239496b739bb46edeb8c793ed5d122a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ceph-osd] Correct naming convention for logical volumes in disk_zap()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OSD logical volume names used to be based on the logical disk path,"},{"line_number":10,"context_line":"i.e. /dev/sdb, but that has changed. The lvremove logic in disk_zap()"},{"line_number":11,"context_line":"is still using the old naming convention. This change fixes that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If32ab354670166a3c844991de1744de63a508303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4e792975_c105bc0d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"in_reply_to":"69a022ff_05ee8e1c","updated":"2020-12-17 17:27:24.000000000","message":"This changed back in September with https://review.opendev.org/c/openstack/openstack-helm-infra/+/745166\n\nThat change included logic to rename volumes that used the old naming convention, so this change isn\u0027t expected to break anything with regard to the previous behavior. This was just missed when that change happened.","commit_id":"213596d71cc3cb3fca7a78e6fef12479f36b89a0"}],"ceph-osd/templates/bin/osd/ceph-volume/_common.sh.tpl":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"dfcd91ddb38e2604ad3d207127adb4121df2c89a","unresolved":true,"context_lines":[{"line_number":305,"context_line":"  # Run all the commands that ceph-disk zap uses to clear a disk"},{"line_number":306,"context_line":"  local device\u003d${1}"},{"line_number":307,"context_line":"  local device_filter\u003d$(basename \"${device}\")"},{"line_number":308,"context_line":"  local lv_name\u003d$(get_lv_name_from_device \"${device}\")"},{"line_number":309,"context_line":"  local dm_devices\u003d$(get_lvm_path_from_device \"pv_name\u003d~${device_filter},lv_name\u003d~ceph\")"},{"line_number":310,"context_line":"  for dm_device in ${dm_devices}; do"},{"line_number":311,"context_line":"    if [[ ! -z ${dm_device} ]] \u0026\u0026 [[ ! -z $(dmsetup ls | grep ${dm_device}) ]]; then"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"0b8ae5b8_0aef95d7","line":308,"range":{"start_line":308,"start_character":18,"end_line":308,"end_character":53},"updated":"2020-12-17 16:28:59.000000000","message":"we lack device_type here","commit_id":"7dae5f148e0b58439aafe4e2f3d010710830e4a9"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"4c759648d4293dfd128f9c88a0d449e79fefe197","unresolved":false,"context_lines":[{"line_number":305,"context_line":"  # Run all the commands that ceph-disk zap uses to clear a disk"},{"line_number":306,"context_line":"  local device\u003d${1}"},{"line_number":307,"context_line":"  local device_filter\u003d$(basename \"${device}\")"},{"line_number":308,"context_line":"  local lv_name\u003d$(get_lv_name_from_device \"${device}\")"},{"line_number":309,"context_line":"  local dm_devices\u003d$(get_lvm_path_from_device \"pv_name\u003d~${device_filter},lv_name\u003d~ceph\")"},{"line_number":310,"context_line":"  for dm_device in ${dm_devices}; do"},{"line_number":311,"context_line":"    if [[ ! -z ${dm_device} ]] \u0026\u0026 [[ ! -z $(dmsetup ls | grep ${dm_device}) ]]; then"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"175873ef_f32d7a66","line":308,"range":{"start_line":308,"start_character":18,"end_line":308,"end_character":53},"in_reply_to":"0b8ae5b8_0aef95d7","updated":"2020-12-17 16:32:14.000000000","message":"Done","commit_id":"7dae5f148e0b58439aafe4e2f3d010710830e4a9"}]}