)]}'
{"ceph-client/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a484b0fb746f7877725bd1248926bc4ce5757e93","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if [[ $(ceph tell mon.* version | egrep \"octopus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":49,"context_line":"    num_osd\u003d$(jq \u0027.num_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":50,"context_line":"    num_in_osds\u003d$(jq \u0027.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":51,"context_line":"    num_up_osds\u003d$(jq \u0027.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"8eb34233_9a4c2e6a","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":93},"updated":"2021-02-02 16:43:04.000000000","message":"What about something that looks for a major version greater than or equal to 15 instead of \"octopus\" here? Then it will work for future releases assuming the json schema doesn\u0027t change again.\n\nif [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 15 ]]; then\n\nAlternatively, removing jq and using \u0027-f json-pretty\u0027 and awk will allow the same set of commands to work for all Ceph versions (no if statement required):\n\nosd_stat\u003d$(ceph osd stat -f json-pretty)\nnum_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)\n(Repeated for num_in_osds and num_up_osds)\n\nThe same change could be made in other files in this patch set.","commit_id":"e187522c7655591ef172b6566bcd005a073e4980"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"9c4c8ce84d1890768db769bdfdcc4ead1f97b421","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if [[ $(ceph tell mon.* version | egrep \"octopus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":49,"context_line":"    num_osd\u003d$(jq \u0027.num_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":50,"context_line":"    num_in_osds\u003d$(jq \u0027.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":51,"context_line":"    num_up_osds\u003d$(jq \u0027.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"913118a6_d7a88cdb","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":93},"in_reply_to":"8eb34233_9a4c2e6a","updated":"2021-02-02 22:47:31.000000000","message":"Done","commit_id":"e187522c7655591ef172b6566bcd005a073e4980"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a484b0fb746f7877725bd1248926bc4ce5757e93","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        exit 1"},{"line_number":196,"context_line":"      fi"},{"line_number":197,"context_line":"    fi"},{"line_number":198,"context_line":"    if [[ $(ceph tell mon.* version | egrep \"octopus|nautilus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":199,"context_line":"      if [ \"x${size}\" !\u003d \"x${RBD}\" ] || [ \"x${min_size}\" !\u003d \"x${EXPECTED_POOLMINSIZE}\" ] \\"},{"line_number":200,"context_line":"        || [ \"x${crush_rule}\" !\u003d \"x${expectedCrushRuleId}\" ]; then"},{"line_number":201,"context_line":"        echo \"Pool ${name} has incorrect parameters!!! Size\u003d${size}, Min_Size\u003d${min_size}, Rule\u003d${crush_rule}, PG_Autoscale_Mode\u003d${pg_autoscale_mode}\""}],"source_content_type":"text/x-smarty","patch_set":22,"id":"b8debb58_e3e19d8f","line":198,"range":{"start_line":198,"start_character":4,"end_line":198,"end_character":104},"updated":"2021-02-02 16:43:04.000000000","message":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 14 ]]; then\n\nSame for several other files in this patch set.","commit_id":"e187522c7655591ef172b6566bcd005a073e4980"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"9c4c8ce84d1890768db769bdfdcc4ead1f97b421","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        exit 1"},{"line_number":196,"context_line":"      fi"},{"line_number":197,"context_line":"    fi"},{"line_number":198,"context_line":"    if [[ $(ceph tell mon.* version | egrep \"octopus|nautilus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":199,"context_line":"      if [ \"x${size}\" !\u003d \"x${RBD}\" ] || [ \"x${min_size}\" !\u003d \"x${EXPECTED_POOLMINSIZE}\" ] \\"},{"line_number":200,"context_line":"        || [ \"x${crush_rule}\" !\u003d \"x${expectedCrushRuleId}\" ]; then"},{"line_number":201,"context_line":"        echo \"Pool ${name} has incorrect parameters!!! Size\u003d${size}, Min_Size\u003d${min_size}, Rule\u003d${crush_rule}, PG_Autoscale_Mode\u003d${pg_autoscale_mode}\""}],"source_content_type":"text/x-smarty","patch_set":22,"id":"6aa65ff0_a14d4e55","line":198,"range":{"start_line":198,"start_character":4,"end_line":198,"end_character":104},"in_reply_to":"b8debb58_e3e19d8f","updated":"2021-02-02 22:47:31.000000000","message":"Done","commit_id":"e187522c7655591ef172b6566bcd005a073e4980"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"7e29fce1850e734cf824be59eaac8e843c07648c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":48,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":49,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"7e7024e9_5ee8d168","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":7},"updated":"2021-02-03 17:13:59.000000000","message":"These three lines (47, 48 49) did not work for nautilus (in wnv2c).\nSame comment for all the other places where this method of getting the OSD statuses is used.","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"ca91e594436b432af0021ce1d32b59b3cc96f371","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":48,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":49,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"771213ec_05230992","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":7},"in_reply_to":"7e7024e9_5ee8d168","updated":"2021-02-03 17:50:11.000000000","message":"yes added json-pretty, will fix the issue now .\ngood catch cliff, thank you .","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ec8576a9d1ed8d0e49876f50af14160ffa26e63","unresolved":true,"context_lines":[{"line_number":43,"context_line":"function check_osd_count() {"},{"line_number":44,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":48,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":49,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"2b353b71_b0c84dab","line":46,"range":{"start_line":46,"start_character":30,"end_line":46,"end_character":34},"updated":"2021-02-03 17:23:22.000000000","message":"json-pretty","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4fee56697fcf4a969f5e06b83837747e80e0682d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"function check_osd_count() {"},{"line_number":44,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":45,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":46,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":47,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":48,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":49,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"42405cdc_33e9132f","line":46,"range":{"start_line":46,"start_character":30,"end_line":46,"end_character":34},"in_reply_to":"2b353b71_b0c84dab","updated":"2021-02-03 17:48:22.000000000","message":"Done","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"}],"ceph-client/templates/bin/pool/_init.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    num_in_osds\u003d$(jq \u0027.osdmap.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":82,"context_line":"    num_up_osds\u003d$(jq \u0027.osdmap.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":83,"context_line":"  fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  EXPECTED_OSDS\u003d{{.Values.conf.pool.target.osd}}"},{"line_number":86,"context_line":"  REQUIRED_PERCENT_OF_OSDS\u003d{{.Values.conf.pool.target.required_percent_of_osds}}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"1fa3ca70_c6303812","line":84,"updated":"2021-02-03 14:23:12.000000000","message":"num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)\nnum_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)\nnum_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    num_in_osds\u003d$(jq \u0027.osdmap.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":82,"context_line":"    num_up_osds\u003d$(jq \u0027.osdmap.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":83,"context_line":"  fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  EXPECTED_OSDS\u003d{{.Values.conf.pool.target.osd}}"},{"line_number":86,"context_line":"  REQUIRED_PERCENT_OF_OSDS\u003d{{.Values.conf.pool.target.required_percent_of_osds}}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"ecf02a9a_89645c62","line":84,"in_reply_to":"1fa3ca70_c6303812","updated":"2021-02-03 16:55:06.000000000","message":"Done","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":270,"context_line":"{{ $targetQuota :\u003d .Values.conf.pool.target.quota | default 100 }}"},{"line_number":271,"context_line":"{{ $targetProtection :\u003d .Values.conf.pool.target.protected | default \"false\" | quote | lower }}"},{"line_number":272,"context_line":"cluster_capacity\u003d0"},{"line_number":273,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 14 ]]; then"},{"line_number":274,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | grep \"TOTAL\" | awk \u0027{print $2 substr($3, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":275,"context_line":"  if [[ $(ceph tell mon.* version | egrep \"octopus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":276,"context_line":"    echo \"We cant disable autoscaler module from Octopus release,so ignoring\""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"8f395356_80cae40a","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":84},"updated":"2021-02-03 14:23:12.000000000","message":"Why not just use \u0027-eq 14\u0027 here and remove the if statement on line 275 since Nautilus is the only release that supports a disabled autoscaler module?","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":270,"context_line":"{{ $targetQuota :\u003d .Values.conf.pool.target.quota | default 100 }}"},{"line_number":271,"context_line":"{{ $targetProtection :\u003d .Values.conf.pool.target.protected | default \"false\" | quote | lower }}"},{"line_number":272,"context_line":"cluster_capacity\u003d0"},{"line_number":273,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 14 ]]; then"},{"line_number":274,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | grep \"TOTAL\" | awk \u0027{print $2 substr($3, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":275,"context_line":"  if [[ $(ceph tell mon.* version | egrep \"octopus\" \u003e /dev/null 2\u003e\u00261; echo $?) -eq 0 ]]; then"},{"line_number":276,"context_line":"    echo \"We cant disable autoscaler module from Octopus release,so ignoring\""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"814ad946_26020626","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":84},"in_reply_to":"8f395356_80cae40a","updated":"2021-02-03 16:55:06.000000000","message":"somehow this was implemented  in wrong place so I moved this to a separate if statement.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"2a81f2708b7f2db7d5b7ebdd5e6c16d237caec05","unresolved":true,"context_lines":[{"line_number":263,"context_line":"{{ $targetQuota :\u003d .Values.conf.pool.target.quota | default 100 }}"},{"line_number":264,"context_line":"{{ $targetProtection :\u003d .Values.conf.pool.target.protected | default \"false\" | quote | lower }}"},{"line_number":265,"context_line":"cluster_capacity\u003d0"},{"line_number":266,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 14 ]]; then"},{"line_number":267,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | grep \"TOTAL\" | awk \u0027{print $2 substr($3, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":268,"context_line":"else"},{"line_number":269,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | head -n3 | tail -n1 | awk \u0027{print $1 substr($2, 1, 1)}\u0027 | numfmt --from\u003diec)"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"22db6e4d_78cca037","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":25},"updated":"2021-02-03 17:07:27.000000000","message":"It is the Ceph client version that will determine the format of this command output, so \u0027ceph -v\u0027 would be more appropriate than \u0027ceph mon versions\u0027 here, although in theory they should be the same.","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5e86fca0a7d297166d36c5c19c9e70640d1c9ac0","unresolved":false,"context_lines":[{"line_number":263,"context_line":"{{ $targetQuota :\u003d .Values.conf.pool.target.quota | default 100 }}"},{"line_number":264,"context_line":"{{ $targetProtection :\u003d .Values.conf.pool.target.protected | default \"false\" | quote | lower }}"},{"line_number":265,"context_line":"cluster_capacity\u003d0"},{"line_number":266,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 14 ]]; then"},{"line_number":267,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | grep \"TOTAL\" | awk \u0027{print $2 substr($3, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":268,"context_line":"else"},{"line_number":269,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | head -n3 | tail -n1 | awk \u0027{print $1 substr($2, 1, 1)}\u0027 | numfmt --from\u003diec)"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"3033446e_4c8dea24","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":25},"in_reply_to":"22db6e4d_78cca037","updated":"2021-02-03 17:14:12.000000000","message":"makes sense, thank you .","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"2a81f2708b7f2db7d5b7ebdd5e6c16d237caec05","unresolved":true,"context_lines":[{"line_number":269,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | head -n3 | tail -n1 | awk \u0027{print $1 substr($2, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":270,"context_line":"fi"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"if [[ $(ceph osd versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -eq 14 ]]; then"},{"line_number":273,"context_line":"  enable_or_disable_autoscaling"},{"line_number":274,"context_line":"fi"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"df93e628_5e32df97","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":25},"updated":"2021-02-03 17:07:27.000000000","message":"The PG autoscaler module is part of the mgr, so \u0027ceph mgr versions\u0027 would be better here.","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5e86fca0a7d297166d36c5c19c9e70640d1c9ac0","unresolved":false,"context_lines":[{"line_number":269,"context_line":"  cluster_capacity\u003d$(ceph --cluster \"${CLUSTER}\" df | head -n3 | tail -n1 | awk \u0027{print $1 substr($2, 1, 1)}\u0027 | numfmt --from\u003diec)"},{"line_number":270,"context_line":"fi"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"if [[ $(ceph osd versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -eq 14 ]]; then"},{"line_number":273,"context_line":"  enable_or_disable_autoscaling"},{"line_number":274,"context_line":"fi"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"020f7f1c_22636f5d","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":25},"in_reply_to":"df93e628_5e32df97","updated":"2021-02-03 17:14:12.000000000","message":"makes sense, thank you .","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ec8576a9d1ed8d0e49876f50af14160ffa26e63","unresolved":true,"context_lines":[{"line_number":70,"context_line":"function check_osd_count() {"},{"line_number":71,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":72,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":73,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":74,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":75,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":76,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"9b4e8dac_6038df08","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":34},"updated":"2021-02-03 17:23:22.000000000","message":"json-pretty","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4fee56697fcf4a969f5e06b83837747e80e0682d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"function check_osd_count() {"},{"line_number":71,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":72,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":73,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":74,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":75,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":76,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"0ba358d5_6200a801","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":34},"in_reply_to":"9b4e8dac_6038df08","updated":"2021-02-03 17:48:22.000000000","message":"Done","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"}],"ceph-client/templates/bin/utils/_checkPGs.py.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepResult \u003d int(subprocess.check_output(\u0027ceph mon versions | egrep \"octopus|nautilus\" | echo $?\u0027, shell\u003dTrue))  # nosec"},{"line_number":111,"context_line":"        return grepResult \u003d\u003d 0"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"b6585e49_d1eb9d34","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":94},"updated":"2021-02-03 14:23:12.000000000","message":"This can check for a major version greater than or equal to 14 instead and will work for future releases as well.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepResult \u003d int(subprocess.check_output(\u0027ceph mon versions | egrep \"octopus|nautilus\" | echo $?\u0027, shell\u003dTrue))  # nosec"},{"line_number":111,"context_line":"        return grepResult \u003d\u003d 0"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"28f2f0d1_52bf2274","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":94},"in_reply_to":"b6585e49_d1eb9d34","updated":"2021-02-03 16:55:06.000000000","message":"thank you for you help  on it steve","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"73165ab1993d268dfb5f5ef9d42b647aad017244","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepVerResult \u003d int(subprocess.check_output(\"ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1\"), shell\u003dTrue))  # nosec "},{"line_number":111,"context_line":"        return grepVerResult \u003e\u003d 14"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"85b0f908_86c89bb6","line":110,"range":{"start_line":110,"start_character":137,"end_line":110,"end_character":138},"updated":"2021-02-03 18:04:07.000000000","message":"Trailing whitespace will fail the lint check","commit_id":"8f7b20c7cac97c65ae7bc1e728b06bd17e57a92c"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"65b54228b90533f8adc43813226a9724321abdbb","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepVerResult \u003d int(subprocess.check_output(\"ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1\"), shell\u003dTrue))  # nosec"},{"line_number":111,"context_line":"        return grepVerResult \u003e\u003d 14"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"4a7eb32c_437a693b","line":110,"range":{"start_line":110,"start_character":126,"end_line":110,"end_character":128},"updated":"2021-02-03 19:24:12.000000000","message":"Only one ) here","commit_id":"a2c5cd22883c39afccbe84f6def7b869e11d8af8"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5a5cd81e8a0284714ee0a572b97ab8de6ae83e1e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepVerResult \u003d int(subprocess.check_output(\"ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1\"), shell\u003dTrue))  # nosec"},{"line_number":111,"context_line":"        return grepVerResult \u003e\u003d 14"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"68e9d659_a04dbc00","line":110,"range":{"start_line":110,"start_character":126,"end_line":110,"end_character":128},"in_reply_to":"0dfbe5b0_ae9c2b7c","updated":"2021-02-03 19:44:56.000000000","message":"Done","commit_id":"a2c5cd22883c39afccbe84f6def7b869e11d8af8"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"bc6dc694a91acc9d83f3b558ce9f83c6e15e8197","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        self.poolSize \u003d 0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def isSupportedRelease(self):"},{"line_number":110,"context_line":"        grepVerResult \u003d int(subprocess.check_output(\"ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1\"), shell\u003dTrue))  # nosec"},{"line_number":111,"context_line":"        return grepVerResult \u003e\u003d 14"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def getPoolSize(self, poolName):"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"0dfbe5b0_ae9c2b7c","line":110,"range":{"start_line":110,"start_character":126,"end_line":110,"end_character":128},"in_reply_to":"4a7eb32c_437a693b","updated":"2021-02-03 19:26:05.000000000","message":"Nope, it\u0027s the earlier ) that\u0027s wrong.","commit_id":"a2c5cd22883c39afccbe84f6def7b869e11d8af8"}],"ceph-client/values.yaml":[{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"9f12e0224cbeea85e8d9b2b1842ee6f00abda97a","unresolved":true,"context_lines":[{"line_number":495,"context_line":"    ceph -s"},{"line_number":496,"context_line":"    function ensure_pool () {"},{"line_number":497,"context_line":"      ceph osd pool stats $1 || ceph osd pool create $1 $2"},{"line_number":498,"context_line":"      local test_version\u003d$(ceph tell osd.* version | egrep -c \"ocotpus|nautilus|mimic|luminous\" | xargs echo)"},{"line_number":499,"context_line":"      if [[ ${test_version} -gt 0 ]]; then"},{"line_number":500,"context_line":"        ceph osd pool application enable $1 $3"},{"line_number":501,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6d019b20_dc180d9e","line":498,"range":{"start_line":498,"start_character":63,"end_line":498,"end_character":70},"updated":"2021-01-08 21:12:58.000000000","message":"misspelled. should be octopus","commit_id":"499945be561c49a6f33f832b8539dcec7b3b9847"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"3d00e635ab0b96dc75e30ac26b7fb7b3f1767ba4","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    ceph -s"},{"line_number":496,"context_line":"    function ensure_pool () {"},{"line_number":497,"context_line":"      ceph osd pool stats $1 || ceph osd pool create $1 $2"},{"line_number":498,"context_line":"      local test_version\u003d$(ceph tell osd.* version | egrep -c \"ocotpus|nautilus|mimic|luminous\" | xargs echo)"},{"line_number":499,"context_line":"      if [[ ${test_version} -gt 0 ]]; then"},{"line_number":500,"context_line":"        ceph osd pool application enable $1 $3"},{"line_number":501,"context_line":"      fi"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"322cb874_06af57a8","line":498,"range":{"start_line":498,"start_character":63,"end_line":498,"end_character":70},"in_reply_to":"6d019b20_dc180d9e","updated":"2021-01-08 21:15:58.000000000","message":"thank you , fixed","commit_id":"499945be561c49a6f33f832b8539dcec7b3b9847"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"a484b0fb746f7877725bd1248926bc4ce5757e93","unresolved":true,"context_lines":[{"line_number":498,"context_line":"    function ensure_pool () {"},{"line_number":499,"context_line":"      ceph osd pool stats $1 || ceph osd pool create $1 $2"},{"line_number":500,"context_line":"      local test_version\u003d$(ceph tell osd.* version | egrep -c \"nautilus|mimic|luminous\" | xargs echo)"},{"line_number":501,"context_line":"      if [[ ${test_version} -gt 0 ]]; then"},{"line_number":502,"context_line":"        ceph osd pool application enable $1 $3"},{"line_number":503,"context_line":"      fi"},{"line_number":504,"context_line":"    }"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"16090005_70eec30d","side":"PARENT","line":501,"updated":"2021-02-02 16:43:04.000000000","message":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then\n\nThe same change can be made in other files in this patch set as well.","commit_id":"1884f2c957a12f8d370c6426b94b6ffd20e034aa"}],"ceph-mon/templates/bin/keys/_bootstrap-keyring-manager.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2fccca3e8c0a16ed93c799d8ad5e5cc3a910a08c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function ceph_gen_key () {"},{"line_number":23,"context_line":"  python3 ${CEPH_GEN_DIR}/keys-bootstrap-keyring-generator.py"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"function kube_ceph_keyring_gen () {"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"fdcddfdf_97f65b29","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":10},"updated":"2021-01-08 21:56:50.000000000","message":"Should we update the python in the image to be python3?","commit_id":"499945be561c49a6f33f832b8539dcec7b3b9847"}],"ceph-osd/templates/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    num_osd\u003d$(jq \u0027.osdmap.num_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":30,"context_line":"    num_in_osds\u003d$(jq \u0027.osdmap.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":31,"context_line":"    num_up_osds\u003d$(jq \u0027.osdmap.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":35,"context_line":"  if [ ${MIN_OSDS} -lt 1 ]; then"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"9c015085_4148b8d5","line":32,"updated":"2021-02-03 14:23:12.000000000","message":"num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)\nnum_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)\nnum_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    num_osd\u003d$(jq \u0027.osdmap.num_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":30,"context_line":"    num_in_osds\u003d$(jq \u0027.osdmap.num_in_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":31,"context_line":"    num_up_osds\u003d$(jq \u0027.osdmap.num_up_osds\u0027 \u003c\u003c\u003c \"$osd_stat\")"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  MIN_OSDS\u003d$((${num_osd}*$REQUIRED_PERCENT_OF_OSDS/100))"},{"line_number":35,"context_line":"  if [ ${MIN_OSDS} -lt 1 ]; then"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"f1a0087c_bd3c6418","line":32,"in_reply_to":"9c015085_4148b8d5","updated":"2021-02-03 16:55:06.000000000","message":"Done","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ec8576a9d1ed8d0e49876f50af14160ffa26e63","unresolved":true,"context_lines":[{"line_number":19,"context_line":"function check_osd_count() {"},{"line_number":20,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":21,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":22,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":23,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":24,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":25,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"a35efdde_037e95aa","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":34},"updated":"2021-02-03 17:23:22.000000000","message":"json-pretty","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4fee56697fcf4a969f5e06b83837747e80e0682d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function check_osd_count() {"},{"line_number":20,"context_line":"  echo \"#### Start: Checking OSD count ####\""},{"line_number":21,"context_line":"  noup_flag\u003d$(ceph osd stat | awk \u0027/noup/ {print $2}\u0027)"},{"line_number":22,"context_line":"  osd_stat\u003d$(ceph osd stat -f json)"},{"line_number":23,"context_line":"  num_osd\u003d$(awk \u0027/\"num_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":24,"context_line":"  num_in_osds\u003d$(awk \u0027/\"num_in_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"},{"line_number":25,"context_line":"  num_up_osds\u003d$(awk \u0027/\"num_up_osds\"/{print $2}\u0027 \u003c\u003c\u003c \"$osd_stat\" | cut -d, -f1)"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"7c4efeea_33b5ad8e","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":34},"in_reply_to":"a35efdde_037e95aa","updated":"2021-02-03 17:48:22.000000000","message":"Done","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"}],"ceph-osd/templates/bin/osd/ceph-disk/_common.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":31,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":32,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ $(ceph -v | egrep \"octopus|nautilus|mimic|luminous\" \u003e /dev/null 2\u003e\u00261; echo $?) -ne 0 ]]; then"},{"line_number":35,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"d1dff11a_46a577e0","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":99},"updated":"2021-02-03 14:23:12.000000000","message":"if [[ $(ceph -v | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":32,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ $(ceph -v | egrep \"octopus|nautilus|mimic|luminous\" \u003e /dev/null 2\u003e\u00261; echo $?) -ne 0 ]]; then"},{"line_number":35,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"83b7da46_cd937622","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":99},"in_reply_to":"d1dff11a_46a577e0","updated":"2021-02-03 16:55:06.000000000","message":"as discussed , not touching this ceph-disk folder.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":32,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ $(ceph -v | egrep \"octopus|nautilus|mimic|luminous\" \u003e /dev/null 2\u003e\u00261; echo $?) -ne 0 ]]; then"},{"line_number":35,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"773763cf_aa1436e4","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":62},"updated":"2021-02-03 14:23:12.000000000","message":"nit: This might be improved by saying something like \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\" or something similar. Then it won\u0027t need to be changed in the future.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ $(ceph -v | egrep \"octopus|nautilus|mimic|luminous\" \u003e /dev/null 2\u003e\u00261; echo $?) -ne 0 ]]; then"},{"line_number":35,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"5e82338f_c78f39cf","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":62},"in_reply_to":"773763cf_aa1436e4","updated":"2021-02-03 16:55:06.000000000","message":"as discussed , not touching this ceph-disk folder.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"}],"ceph-osd/templates/bin/osd/ceph-volume/_common.sh.tpl":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"ac974d82_3cf87eb2","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":25},"updated":"2021-02-03 14:23:12.000000000","message":"This checks the mon version where the previous check was for the client version. In theory they should match, but in the ceph-volume OSD init script it is the client and ceph-osd versions that are relevant. Use \u0027ceph -v\u0027 to check the client version and/or \u0027ceph-osd -v\u0027 to check the ceph-osd package version. A client check like before is probably sufficient since there isn\u0027t currently anything in the script that requires a specific version of ceph-volume.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":24,"id":"b5bb909f_284a4551","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":25},"in_reply_to":"ac974d82_3cf87eb2","updated":"2021-02-03 16:55:06.000000000","message":"Done","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ff97d70088c2b58c3623b0d158adae46bb697e2","unresolved":true,"context_lines":[{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"244314ad_b18b6217","line":126,"range":{"start_line":126,"start_character":4,"end_line":126,"end_character":62},"updated":"2021-02-03 14:23:12.000000000","message":"nit: This might be improved by saying something like \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\" or something similar. Then it won\u0027t need to be changed in the future.","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"51dbcd7a1054b9fe1756d52b1b64331251e7bf1b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph mon versions | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR- need Luminous/Mimic/Nautilus/Octopus release\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":24,"id":"6c4aeb61_8f0e1cf6","line":126,"range":{"start_line":126,"start_character":4,"end_line":126,"end_character":62},"in_reply_to":"244314ad_b18b6217","updated":"2021-02-03 16:55:06.000000000","message":"Done","commit_id":"6111fe54e82fc4597fe36ecd90b04d6d703beadd"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"2a81f2708b7f2db7d5b7ebdd5e6c16d237caec05","unresolved":true,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph -v | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"21b94ed6_cd29951a","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":74},"updated":"2021-02-03 17:07:27.000000000","message":"The error condition is when the Ceph version is less than 12. Greater than or equal to 12 is the success case.","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"5e86fca0a7d297166d36c5c19c9e70640d1c9ac0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph -v | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -ge 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"ffd14476_4fa357e8","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":74},"in_reply_to":"21b94ed6_cd29951a","updated":"2021-02-03 17:14:12.000000000","message":"copy paste error , good catch :)","commit_id":"aa8328a226bd9d7ac418286666867690473cbee5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"5ec8576a9d1ed8d0e49876f50af14160ffa26e63","unresolved":true,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph -v | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -le 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"2e636014_d529a8fb","line":125,"range":{"start_line":125,"start_character":59,"end_line":125,"end_character":62},"updated":"2021-02-03 17:23:22.000000000","message":"-lt","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"4fee56697fcf4a969f5e06b83837747e80e0682d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"eval CRUSH_FAILURE_DOMAIN_FROM_HOSTNAME_MAP\u003d$(cat /etc/ceph/storage.json | jq \u0027.failure_domain_by_hostname_map.\"\u0027$HOSTNAME\u0027\"\u0027)"},{"line_number":123,"context_line":"eval DEVICE_CLASS\u003d$(cat /etc/ceph/storage.json | python3 -c \u0027import sys, json; data \u003d json.load(sys.stdin); print(json.dumps(data[\"device_class\"]))\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [[ $(ceph -v | awk \u0027/version/{print $3}\u0027 | cut -d. -f1) -le 12 ]]; then"},{"line_number":126,"context_line":"    echo \"ERROR - The minimum Ceph version supported is Luminous 12.x.x\""},{"line_number":127,"context_line":"    exit 1"},{"line_number":128,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":26,"id":"40498c0b_1f40be1d","line":125,"range":{"start_line":125,"start_character":59,"end_line":125,"end_character":62},"in_reply_to":"2e636014_d529a8fb","updated":"2021-02-03 17:48:22.000000000","message":"Done","commit_id":"7ef2f3998ed0a083ff5e3d6475dc8457b9a722b2"}]}