)]}'
{"helm-toolkit/templates/manifests/_job-rabbit-init.yaml.tpl":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3cf7d545dc241281231fe664581ada7d1af37242","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{- $serviceUserPretty :\u003d $serviceUser | replace \"_\" \"-\" -}}"},{"line_number":27,"context_line":"{{- $serviceNamePretty :\u003d $serviceName | replace \"_\" \"-\" -}}"},{"line_number":28,"context_line":"{{- $tlsPath :\u003d index . \"tlsPath\" | default (printf \"/etc/%s/certs\" $serviceNamePretty ) -}}"},{"line_number":29,"context_line":"{{- $tlsSecret :\u003d index . \"tlsSecret\" | default \"\" -}}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceUserPretty \"rabbit-init\" }}"},{"line_number":32,"context_line":"{{ tuple $envAll \"rabbit_init\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"8987b82c_d0de4e98","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2021-03-23 12:43:29.000000000","message":"Should we set any default value here? What if the certificate is enabled and user does not pass tlsSecrte name. Nothing will be mounted in that case, is that ok?","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"4a18fa8274d6b4183cff68ff0a6179ccee747903","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{- $serviceUserPretty :\u003d $serviceUser | replace \"_\" \"-\" -}}"},{"line_number":27,"context_line":"{{- $serviceNamePretty :\u003d $serviceName | replace \"_\" \"-\" -}}"},{"line_number":28,"context_line":"{{- $tlsPath :\u003d index . \"tlsPath\" | default (printf \"/etc/%s/certs\" $serviceNamePretty ) -}}"},{"line_number":29,"context_line":"{{- $tlsSecret :\u003d index . \"tlsSecret\" | default \"\" -}}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" $serviceUserPretty \"rabbit-init\" }}"},{"line_number":32,"context_line":"{{ tuple $envAll \"rabbit_init\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-smarty","patch_set":30,"id":"baed3e6a_91430f31","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"8987b82c_d0de4e98","updated":"2021-03-23 16:17:41.000000000","message":"Not updated in my latest PS, still need to resolve.","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"}],"helm-toolkit/templates/scripts/_rabbit-init.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f4d51407159204c2331e381cfd35c781c40cdc7b","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- define \"helm-toolkit.scripts.rabbit_init\" }}"},{"line_number":16,"context_line":"#!/bin/bash"},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":"# Extract connection details"},{"line_number":19,"context_line":"RABBIT_HOSTNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":20,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"2ab6f1b9_8180209b","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":6},"updated":"2021-05-21 06:03:39.000000000","message":"wouldn\u0027t this now print RABBITMQ_ADMIN_PASSWORD to stdout and be harvested by LMA?","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"61262484be637499d82a6600acab4a4c6fbfa0e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- define \"helm-toolkit.scripts.rabbit_init\" }}"},{"line_number":16,"context_line":"#!/bin/bash"},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":"# Extract connection details"},{"line_number":19,"context_line":"RABBIT_HOSTNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":20,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"067d4340_87fe972f","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":6},"in_reply_to":"2ab6f1b9_8180209b","updated":"2021-05-21 12:43:28.000000000","message":"Done","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f4d51407159204c2331e381cfd35c781c40cdc7b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"RABBITMQ_VHOST\u003d\"${RABBITMQ_VHOST:-/}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function rabbitmqadmin_cli () {"},{"line_number":50,"context_line":"  if [ ! -z \"$RABBITMQ_X509\" ]"},{"line_number":51,"context_line":"  then"},{"line_number":52,"context_line":"    rabbitmqadmin \\"},{"line_number":53,"context_line":"      --ssl \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"d28e2cc2_93ad4951","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":12},"updated":"2021-05-21 06:03:39.000000000","message":"-n","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"61262484be637499d82a6600acab4a4c6fbfa0e8","unresolved":true,"context_lines":[{"line_number":47,"context_line":"RABBITMQ_VHOST\u003d\"${RABBITMQ_VHOST:-/}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function rabbitmqadmin_cli () {"},{"line_number":50,"context_line":"  if [ ! -z \"$RABBITMQ_X509\" ]"},{"line_number":51,"context_line":"  then"},{"line_number":52,"context_line":"    rabbitmqadmin \\"},{"line_number":53,"context_line":"      --ssl \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"e2cbea03_734ce81e","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":12},"in_reply_to":"d28e2cc2_93ad4951","updated":"2021-05-21 12:43:28.000000000","message":"They both essentially mean the same things, just a preference. But I made the changed. \n-n\n   string is not null.\n-z\n  string is null, that is, has zero length","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"}],"rabbitmq/templates/bin/_rabbitmq-wait-for-cluster.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f4d51407159204c2331e381cfd35c781c40cdc7b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"set -ex"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function rabbitmqadmin_authed () {"},{"line_number":34,"context_line":"  if [ ! -z \"$RABBITMQ_X509\" ]"},{"line_number":35,"context_line":"  then"},{"line_number":36,"context_line":"    set +x"},{"line_number":37,"context_line":"    rabbitmqadmin \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"903dd43a_15206dea","line":34,"range":{"start_line":34,"start_character":7,"end_line":34,"end_character":11},"updated":"2021-05-21 06:03:39.000000000","message":"-n","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"61262484be637499d82a6600acab4a4c6fbfa0e8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"set -ex"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function rabbitmqadmin_authed () {"},{"line_number":34,"context_line":"  if [ ! -z \"$RABBITMQ_X509\" ]"},{"line_number":35,"context_line":"  then"},{"line_number":36,"context_line":"    set +x"},{"line_number":37,"context_line":"    rabbitmqadmin \\"}],"source_content_type":"text/x-smarty","patch_set":71,"id":"991bf0f7_15413ab3","line":34,"range":{"start_line":34,"start_character":7,"end_line":34,"end_character":11},"in_reply_to":"903dd43a_15206dea","updated":"2021-05-21 12:43:28.000000000","message":"Made the changed as explained in previous comment","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"}],"rabbitmq/templates/certificates.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"56ed6fd3a2e1aabd4ebafeea7992fea4868cf011","unresolved":true,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.certificates -}}"},{"line_number":16,"context_line":"{{ dict \"envAll\" . \"service\" \"oslo_messaging\" \"type\" \"default\" | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":17,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"102ff833_169fe310","line":16,"range":{"start_line":16,"start_character":46,"end_line":16,"end_character":62},"updated":"2021-03-23 12:36:36.000000000","message":"Should this be \"type\" \"internal\"?","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"4a18fa8274d6b4183cff68ff0a6179ccee747903","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.certificates -}}"},{"line_number":16,"context_line":"{{ dict \"envAll\" . \"service\" \"oslo_messaging\" \"type\" \"default\" | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":17,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"e7ac4d22_1cc41c65","line":16,"range":{"start_line":16,"start_character":46,"end_line":16,"end_character":62},"in_reply_to":"102ff833_169fe310","updated":"2021-03-23 16:17:41.000000000","message":"Updated","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"}],"rabbitmq/values.yaml":[{"author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"change_message_id":"4e05b9fba0b9d6da342f1988c3db9515334bc312","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  # this is not in the right place; placeholder"},{"line_number":197,"context_line":"  {{ if .Values.manifests.certificates }}"},{"line_number":198,"context_line":"  # TLS"},{"line_number":199,"context_line":"  ssl_ca\u003d/etc/rabbitmq/certs/ca.crt"},{"line_number":200,"context_line":"  ssl_key\u003d/etc/rabbitmq/certs/tls.key"},{"line_number":201,"context_line":"  ssl_cert\u003d/etc/rabbitmq/certs/tls.crt"},{"line_number":202,"context_line":"  # tls_version \u003d TLSv1.2,TLSv1.3"},{"line_number":203,"context_line":"  ssl-verify-server-cert"},{"line_number":204,"context_line":"  {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a804395_9ec104fe","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":38},"updated":"2021-03-04 00:56:03.000000000","message":"The format should be: \"\"","commit_id":"ca37fae816b10ed96f76349355e07c7574bd184b"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"bc4463531e6367dd9964fb81939cb6198753553a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  # this is not in the right place; placeholder"},{"line_number":197,"context_line":"  {{ if .Values.manifests.certificates }}"},{"line_number":198,"context_line":"  # TLS"},{"line_number":199,"context_line":"  ssl_ca\u003d/etc/rabbitmq/certs/ca.crt"},{"line_number":200,"context_line":"  ssl_key\u003d/etc/rabbitmq/certs/tls.key"},{"line_number":201,"context_line":"  ssl_cert\u003d/etc/rabbitmq/certs/tls.crt"},{"line_number":202,"context_line":"  # tls_version \u003d TLSv1.2,TLSv1.3"},{"line_number":203,"context_line":"  ssl-verify-server-cert"},{"line_number":204,"context_line":"  {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d55709fb_c52d58f2","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":38},"in_reply_to":"7a804395_9ec104fe","updated":"2021-03-19 14:46:40.000000000","message":"moved this to values_overrides/tls.yaml","commit_id":"ca37fae816b10ed96f76349355e07c7574bd184b"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"56ed6fd3a2e1aabd4ebafeea7992fea4868cf011","unresolved":true,"context_lines":[{"line_number":252,"context_line":"  tls:"},{"line_number":253,"context_line":"    oslo_messaging:"},{"line_number":254,"context_line":"      server:"},{"line_number":255,"context_line":"        public: rabbitmq-tls-server"},{"line_number":256,"context_line":"        internal: rabbitmq-tls-direct"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# typically overridden by environmental"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"417be5c4_d9df5bc3","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"updated":"2021-03-23 12:36:36.000000000","message":"What is this for and where is this being created and used?","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"4a18fa8274d6b4183cff68ff0a6179ccee747903","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  tls:"},{"line_number":253,"context_line":"    oslo_messaging:"},{"line_number":254,"context_line":"      server:"},{"line_number":255,"context_line":"        public: rabbitmq-tls-server"},{"line_number":256,"context_line":"        internal: rabbitmq-tls-direct"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# typically overridden by environmental"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8e396f06_2f47e5e4","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"in_reply_to":"417be5c4_d9df5bc3","updated":"2021-03-23 16:17:41.000000000","message":"Removed","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f4d51407159204c2331e381cfd35c781c40cdc7b","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"84bb3bea_dec04e95","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"updated":"2021-05-21 06:03:39.000000000","message":"Isn\u0027t this sort of misleading in that the additional config is triggered by the presence of certificates? Without the comment below, it would be very hard to tell. Can this not be just overwritten by the tls override?","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"476828d636f5de65e75c2fab4378141a9cd87c4b","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"5b368f88_f1671859","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"in_reply_to":"4b7cd9e0_f01ad2a1","updated":"2021-05-21 14:23:57.000000000","message":"Following values in values.yaml\n    management.listener.ip: null\n    management.listener.port: null\n\nFollowing is what is is rendered to (if no values is set in configmap-etc)\n    management.listener.ip \u003d\n    management.listener.port \u003d","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"aaf815067ca6c91a8ffaa3e1acda28c52ea654dc","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"e2078319_6f3ebd3b","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"in_reply_to":"5b368f88_f1671859","updated":"2021-05-24 16:40:59.000000000","message":"I guess what you are saying is simply having them set to \"null\" or \"empty\" does not help, these 2 parameters cannot exist at all if TLS is enabled?  Can you confirm?","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"61262484be637499d82a6600acab4a4c6fbfa0e8","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"97432460_e87304f6","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"in_reply_to":"84bb3bea_dec04e95","updated":"2021-05-21 12:43:28.000000000","message":"In case of TLS, these 2 parameters should not be present at all, hence they can not be overridden. There is no way to override to remove the parameters from values.yaml. In case of TLS, the config should look something like \n\ncluster_formation.k8s.address_type \u003d hostname\ncluster_formation.k8s.host \u003d kubernetes.default.svc.cluster.local\ncluster_formation.node_cleanup.interval \u003d 10\ncluster_formation.node_cleanup.only_log_warning \u003d true\ncluster_formation.peer_discovery_backend \u003d rabbit_peer_discovery_k8s\ncluster_partition_handling \u003d autoheal\nlisteners.ssl.1 \u003d 5672\nlisteners.tcp \u003d none\nloopback_users.guest \u003d false\nmanagement.ssl.cacertfile \u003d /etc/rabbitmq/certs/ca.crt\nmanagement.ssl.certfile \u003d /etc/rabbitmq/certs/tls.crt\nmanagement.ssl.keyfile \u003d /etc/rabbitmq/certs/tls.key\nmanagement.load_definitions \u003d /var/lib/rabbitmq/definitions.json\nmanagement.ssl.port \u003d 15672\nqueue_master_locator \u003d min-masters\nssl_options.cacertfile \u003d /etc/rabbitmq/certs/ca.crt\nssl_options.certfile \u003d /etc/rabbitmq/certs/tls.crt\nssl_options.fail_if_no_peer_cert \u003d false\nssl_options.keyfile \u003d /etc/rabbitmq/certs/tls.key\nssl_options.verify \u003d verify_peer","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8ea0aed32229ff5775fde4e5ab1926e7f5a0add7","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"4b7cd9e0_f01ad2a1","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"in_reply_to":"97432460_e87304f6","updated":"2021-05-21 13:40:36.000000000","message":"Does setting the field to null not remove it from the rendering?","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"55dd19c146b92dd2530041d24d4fb88947611c27","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    queue_master_locator: min-masters"},{"line_number":190,"context_line":"    loopback_users.guest: \"false\""},{"line_number":191,"context_line":"    management.load_definitions: \"/var/lib/rabbitmq/definitions.json\""},{"line_number":192,"context_line":"  rabbit_additonal_conf:"},{"line_number":193,"context_line":"    # This confinguration is used for non TLS deployments"},{"line_number":194,"context_line":"    management.listener.ip: \"::\""},{"line_number":195,"context_line":"    management.listener.port: null"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"45898be4_946e4144","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":24},"in_reply_to":"e2078319_6f3ebd3b","updated":"2021-05-24 21:45:03.000000000","message":"That is correct Roy Tang","commit_id":"434665382165d09c7a6d28a683c50083ad8dc88e"}],"rabbitmq/values_overrides/tls.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c0cd9f26bdfe697d82d7bd4bb1982d80c645ad24","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      cacertfile: \"/etc/rabbitmq/certs/ca.crt\""},{"line_number":9,"context_line":"      certfile: \"/etc/rabbitmq/certs/tls.crt\""},{"line_number":10,"context_line":"      keyfile: \"/etc/rabbitmq/certs/tls.key\""},{"line_number":11,"context_line":"pod:"},{"line_number":12,"context_line":"  security_context:"},{"line_number":13,"context_line":"    server:"},{"line_number":14,"context_line":"      container:"},{"line_number":15,"context_line":"        rabbitmq_password:"},{"line_number":16,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":17,"context_line":"        rabbitmq_cookie:"},{"line_number":18,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":19,"context_line":"        rabbitmq_perms:"},{"line_number":20,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":21,"context_line":"        rabbitmq:"},{"line_number":22,"context_line":"          runAsUser: 0"},{"line_number":23,"context_line":"endpoints:"},{"line_number":24,"context_line":"  oslo_messaging:"},{"line_number":25,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1ebc9145_4d93c3a7","line":22,"range":{"start_line":11,"start_character":0,"end_line":22,"end_character":22},"updated":"2021-03-23 03:33:57.000000000","message":"why are these necessary? I don\u0027t see we are writing anything to disk or doing things that require root access.","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"4a18fa8274d6b4183cff68ff0a6179ccee747903","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      cacertfile: \"/etc/rabbitmq/certs/ca.crt\""},{"line_number":9,"context_line":"      certfile: \"/etc/rabbitmq/certs/tls.crt\""},{"line_number":10,"context_line":"      keyfile: \"/etc/rabbitmq/certs/tls.key\""},{"line_number":11,"context_line":"pod:"},{"line_number":12,"context_line":"  security_context:"},{"line_number":13,"context_line":"    server:"},{"line_number":14,"context_line":"      container:"},{"line_number":15,"context_line":"        rabbitmq_password:"},{"line_number":16,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":17,"context_line":"        rabbitmq_cookie:"},{"line_number":18,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":19,"context_line":"        rabbitmq_perms:"},{"line_number":20,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":21,"context_line":"        rabbitmq:"},{"line_number":22,"context_line":"          runAsUser: 0"},{"line_number":23,"context_line":"endpoints:"},{"line_number":24,"context_line":"  oslo_messaging:"},{"line_number":25,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"fc680b5a_34a69579","line":22,"range":{"start_line":11,"start_character":0,"end_line":22,"end_character":22},"in_reply_to":"1ebc9145_4d93c3a7","updated":"2021-03-23 16:17:41.000000000","message":"Removed","commit_id":"862714c22ec68ef898623546a421aa34b9df2ce5"}]}
