)]}'
{"ca-clusterissuer/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b88d5e26e61dade6d7894ecf52f2ee227d1538d5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"conf:"},{"line_number":14,"context_line":"  ca:"},{"line_number":15,"context_line":"    issuer:"},{"line_number":16,"context_line":"      name: ca-issuer"},{"line_number":17,"context_line":"    secret:"},{"line_number":18,"context_line":"      name: secret-name"},{"line_number":19,"context_line":"      # Namespace where cert-manager is deployed."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"aa1f0660_31a896de","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":21},"updated":"2021-02-18 07:50:27.000000000","message":"should this be ca-clusterissuer?","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"d3a15da2d8f1f904269d2eaa7c4fe22b68580aff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"conf:"},{"line_number":14,"context_line":"  ca:"},{"line_number":15,"context_line":"    issuer:"},{"line_number":16,"context_line":"      name: ca-issuer"},{"line_number":17,"context_line":"    secret:"},{"line_number":18,"context_line":"      name: secret-name"},{"line_number":19,"context_line":"      # Namespace where cert-manager is deployed."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"436e8e0a_d9c70279","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":21},"in_reply_to":"aa1f0660_31a896de","updated":"2021-02-18 17:21:09.000000000","message":"Done","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b88d5e26e61dade6d7894ecf52f2ee227d1538d5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    issuer:"},{"line_number":16,"context_line":"      name: ca-issuer"},{"line_number":17,"context_line":"    secret:"},{"line_number":18,"context_line":"      name: secret-name"},{"line_number":19,"context_line":"      # Namespace where cert-manager is deployed."},{"line_number":20,"context_line":"      namespace: cert-manager"},{"line_number":21,"context_line":"      crt: null"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"6cf66b5b_3c7de59a","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":23},"updated":"2021-02-18 07:50:27.000000000","message":"should this be more descriptive than secret-name?","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"d3a15da2d8f1f904269d2eaa7c4fe22b68580aff","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    issuer:"},{"line_number":16,"context_line":"      name: ca-issuer"},{"line_number":17,"context_line":"    secret:"},{"line_number":18,"context_line":"      name: secret-name"},{"line_number":19,"context_line":"      # Namespace where cert-manager is deployed."},{"line_number":20,"context_line":"      namespace: cert-manager"},{"line_number":21,"context_line":"      crt: null"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa48d2f9_00074397","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":23},"in_reply_to":"6cf66b5b_3c7de59a","updated":"2021-02-18 17:21:09.000000000","message":"this is a config param that can be configured and doesn\u0027t need to change","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"}],"helm-toolkit/templates/manifests/_certificates.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"20b472da07c7db0e3ee8115bdbe64a1a682fa689","unresolved":true,"context_lines":[{"line_number":43,"context_line":"      {{ $opts | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":44,"context_line":"    return: |"},{"line_number":45,"context_line":"      ---"},{"line_number":46,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":47,"context_line":"      kind: Certificate"},{"line_number":48,"context_line":"      metadata:"},{"line_number":49,"context_line":"        name: keystone-tls-api"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"b7bb3134_79daa87d","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":36},"updated":"2021-02-02 06:55:23.000000000","message":"You may want some {{- if (version check) -}} wrapped around these things to avoid accidental breaking because someone is using an old cert manager that doesn\u0027t support /v1. Though we should be moving the default cert-mang to \u003e\u003d v1.x","commit_id":"d0407da42653335b316dae3c1cb00a9974f892bd"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"d35e5ba132621be9c3c83153389a118d0786f966","unresolved":true,"context_lines":[{"line_number":43,"context_line":"      {{ $opts | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":44,"context_line":"    return: |"},{"line_number":45,"context_line":"      ---"},{"line_number":46,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":47,"context_line":"      kind: Certificate"},{"line_number":48,"context_line":"      metadata:"},{"line_number":49,"context_line":"        name: keystone-tls-api"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3cf41d34_43248b6f","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":36},"in_reply_to":"b7bb3134_79daa87d","updated":"2021-02-02 12:04:50.000000000","message":"We can add the if version check but for what all do we put these checks. The code can different for different versions of kubectl, helm, etc and it would not be a good idea to put if checks all these. I think we should make cert-manager default to version \u003ev1.x as you stated and just document it in release notes as already done in this PS.","commit_id":"d0407da42653335b316dae3c1cb00a9974f892bd"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"a9f3166668c5c36d8857f032b30a5a199b0f1bf7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"      {{ $opts | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":44,"context_line":"    return: |"},{"line_number":45,"context_line":"      ---"},{"line_number":46,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":47,"context_line":"      kind: Certificate"},{"line_number":48,"context_line":"      metadata:"},{"line_number":49,"context_line":"        name: keystone-tls-api"}],"source_content_type":"text/x-smarty","patch_set":21,"id":"d40213d8_59e5d36c","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":36},"updated":"2021-02-17 21:34:04.000000000","message":"I thought we talked about adding some version check to determine which apiVersion to use?","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"d3a15da2d8f1f904269d2eaa7c4fe22b68580aff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      {{ $opts | include \"helm-toolkit.manifests.certificates\" }}"},{"line_number":44,"context_line":"    return: |"},{"line_number":45,"context_line":"      ---"},{"line_number":46,"context_line":"      apiVersion: cert-manager.io/v1"},{"line_number":47,"context_line":"      kind: Certificate"},{"line_number":48,"context_line":"      metadata:"},{"line_number":49,"context_line":"        name: keystone-tls-api"}],"source_content_type":"text/x-smarty","patch_set":21,"id":"b0134e46_612a210f","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":36},"in_reply_to":"d40213d8_59e5d36c","updated":"2021-02-18 17:21:09.000000000","message":"You are right, made a PS update","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"a9f3166668c5c36d8857f032b30a5a199b0f1bf7","unresolved":true,"context_lines":[{"line_number":94,"context_line":"{{- $_ :\u003d (list \"server auth\" \"client auth\") | set (index $envAll.Values.endpoints $service \"host_fqdn_override\" \"default\" \"tls\") \"usages\" -}}"},{"line_number":95,"context_line":"{{- end -}}"},{"line_number":96,"context_line":"---"},{"line_number":97,"context_line":"apiVersion: cert-manager.io/v1"},{"line_number":98,"context_line":"kind: Certificate"},{"line_number":99,"context_line":"metadata:"},{"line_number":100,"context_line":"  name: {{ index $envAll.Values.endpoints $service \"host_fqdn_override\" \"default\" \"tls\" \"secretName\" }}"}],"source_content_type":"text/x-smarty","patch_set":21,"id":"96b40df2_4cd833cb","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":30},"updated":"2021-02-17 21:34:04.000000000","message":"I thought we talked about adding some version check to determine which apiVersion to use?","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"d3a15da2d8f1f904269d2eaa7c4fe22b68580aff","unresolved":false,"context_lines":[{"line_number":94,"context_line":"{{- $_ :\u003d (list \"server auth\" \"client auth\") | set (index $envAll.Values.endpoints $service \"host_fqdn_override\" \"default\" \"tls\") \"usages\" -}}"},{"line_number":95,"context_line":"{{- end -}}"},{"line_number":96,"context_line":"---"},{"line_number":97,"context_line":"apiVersion: cert-manager.io/v1"},{"line_number":98,"context_line":"kind: Certificate"},{"line_number":99,"context_line":"metadata:"},{"line_number":100,"context_line":"  name: {{ index $envAll.Values.endpoints $service \"host_fqdn_override\" \"default\" \"tls\" \"secretName\" }}"}],"source_content_type":"text/x-smarty","patch_set":21,"id":"14ee5f7f_7fa1f7a8","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":30},"in_reply_to":"96b40df2_4cd833cb","updated":"2021-02-18 17:21:09.000000000","message":"You are right, made a PS update","commit_id":"4a5820a79b2d1134c6fbcfdbaf79108af993246d"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"96870836bb5b181d01d0d0ff5f9704ba21a0de6c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  Creates a certificate using jetstack"},{"line_number":18,"context_line":"examples:"},{"line_number":19,"context_line":"  - values: |"},{"line_number":20,"context_line":"      cert_manager_version: v0.15.0"},{"line_number":21,"context_line":"      endpoints:"},{"line_number":22,"context_line":"        dashboard:"},{"line_number":23,"context_line":"          host_fqdn_override:"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"d02a505f_fa829b93","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"updated":"2021-02-24 17:38:55.000000000","message":"do we want this line here at all if the template already defaults to \"v1.0.0\"? especially we want the new cert to be the default right, not the older version, so at least update this to \"v1.0.0\"?","commit_id":"fb72ab71c5abc2670085c78f309359c53f20a03e"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"05341098b86dc31316dfbd2aaa3d124fc8ca2dfe","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  Creates a certificate using jetstack"},{"line_number":18,"context_line":"examples:"},{"line_number":19,"context_line":"  - values: |"},{"line_number":20,"context_line":"      cert_manager_version: v0.15.0"},{"line_number":21,"context_line":"      endpoints:"},{"line_number":22,"context_line":"        dashboard:"},{"line_number":23,"context_line":"          host_fqdn_override:"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"99ff1441_6d5f253e","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"d02a505f_fa829b93","updated":"2021-02-24 19:19:00.000000000","message":"This is to show an example how the default value can be overridden if desired. The other example is to show if no cert_manager_version is present in values.yaml","commit_id":"fb72ab71c5abc2670085c78f309359c53f20a03e"}]}