)]}'
{"grafana/templates/deployment.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"108fdd68e930935aa31eae92bb7e1bba90ad8b60","unresolved":true,"context_lines":[{"line_number":118,"context_line":"              mountPath: /etc/grafana/dashboards/{{$key}}.json"},{"line_number":119,"context_line":"              subPath: {{$key}}.json"},{"line_number":120,"context_line":"            {{- end }}"},{"line_number":121,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":122,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db_session.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":123,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.grafana.grafana.internal \"path\" \"/etc/grafana/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":124,"context_line":"{{ if $mounts_grafana.volumeMounts }}{{ toYaml $mounts_grafana.volumeMounts | indent 12 }}{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a167891_1a2949e9","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":1},"updated":"2021-02-10 19:39:56.000000000","message":"Why do you need to mount all 3 certificates. You are basically overwriting them. This will create /etc/mysql/certs/ca.crt, /etc/mysql/certs/tls.crt and /etc/mysql/certs/ca.key","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"880c30864e017f3aeb870d921e828098517b34a4","unresolved":true,"context_lines":[{"line_number":118,"context_line":"              mountPath: /etc/grafana/dashboards/{{$key}}.json"},{"line_number":119,"context_line":"              subPath: {{$key}}.json"},{"line_number":120,"context_line":"            {{- end }}"},{"line_number":121,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":122,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db_session.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":123,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.grafana.grafana.internal \"path\" \"/etc/grafana/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":124,"context_line":"{{ if $mounts_grafana.volumeMounts }}{{ toYaml $mounts_grafana.volumeMounts | indent 12 }}{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"71031221_fdf50c7d","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":1},"in_reply_to":"7a167891_1a2949e9","updated":"2021-02-10 19:50:20.000000000","message":"ok, Line 122 is not needed since it is basically the same as L121 for mariadb.  But L123 is needed for grafana, isn\u0027t it?","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"108fdd68e930935aa31eae92bb7e1bba90ad8b60","unresolved":true,"context_lines":[{"line_number":147,"context_line":"            defaultMode: 0555"},{"line_number":148,"context_line":"        - name: data"},{"line_number":149,"context_line":"          emptyDir: {}"},{"line_number":150,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":151,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db_session.auth.admin.secret.tls.internal | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":152,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.grafana.grafana.internal | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":153,"context_line":"{{ if $mounts_grafana.volumes }}{{ toYaml $mounts_grafana.volumes | indent 8 }}{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"44fe7c90_676991b3","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":1},"updated":"2021-02-10 19:39:56.000000000","message":"NO need to mount all 3 volumes.","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"}],"grafana/templates/job-db-init-session.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8d3722a0fa1762cc807342be5cf8e3d97211d9c4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"              mountPath: /tmp/db-init.py"},{"line_number":71,"context_line":"              subPath: db-init.py"},{"line_number":72,"context_line":"              readOnly: true"},{"line_number":73,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":74,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db_session.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":75,"context_line":"{{- end }}"},{"line_number":76,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4b4cc819_9166e1ce","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":47},"updated":"2021-02-10 19:59:56.000000000","message":"ditto","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8d3722a0fa1762cc807342be5cf8e3d97211d9c4","unresolved":true,"context_lines":[{"line_number":80,"context_line":"          configMap:"},{"line_number":81,"context_line":"            name: grafana-bin"},{"line_number":82,"context_line":"            defaultMode: 0555"},{"line_number":83,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":84,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db_session.auth.admin.secret.tls.internal | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":85,"context_line":"{{- end }}"},{"line_number":86,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2a6432f4_795c0402","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":47},"updated":"2021-02-10 19:59:56.000000000","message":"ditto","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"}],"grafana/templates/job-db-init.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a465ed86bd04b2776799e11d9a1a80465ba1e1e4","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                secretKeyRef:"},{"line_number":58,"context_line":"                  name: {{ .Values.secrets.oslo_db.user }}"},{"line_number":59,"context_line":"                  key: DB_CONNECTION"},{"line_number":60,"context_line":"            {{- if $envAll.Values.manifests.certificates }}"},{"line_number":61,"context_line":"            - name: MARIADB_X509"},{"line_number":62,"context_line":"              value: \"REQUIRE X509\""},{"line_number":63,"context_line":"            {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e5fa095c_f4ffb413","line":60,"range":{"start_line":60,"start_character":16,"end_line":60,"end_character":56},"updated":"2021-02-08 14:58:48.000000000","message":"this is not defined anywhere for this chart","commit_id":"ac0406bc84637a31ea773f57159d16c57ff969b3"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a465ed86bd04b2776799e11d9a1a80465ba1e1e4","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                  name: {{ .Values.secrets.oslo_db.user }}"},{"line_number":59,"context_line":"                  key: DB_CONNECTION"},{"line_number":60,"context_line":"            {{- if $envAll.Values.manifests.certificates }}"},{"line_number":61,"context_line":"            - name: MARIADB_X509"},{"line_number":62,"context_line":"              value: \"REQUIRE X509\""},{"line_number":63,"context_line":"            {{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/db-init.py"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0eade53e_8ac447f9","line":62,"range":{"start_line":61,"start_character":12,"end_line":62,"end_character":35},"updated":"2021-02-08 14:58:48.000000000","message":"where is this used?","commit_id":"ac0406bc84637a31ea773f57159d16c57ff969b3"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"405c77b3010920965cb72ac5782b922f1de61bb4","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                  name: {{ .Values.secrets.oslo_db.user }}"},{"line_number":59,"context_line":"                  key: DB_CONNECTION"},{"line_number":60,"context_line":"            {{- if $envAll.Values.manifests.certificates }}"},{"line_number":61,"context_line":"            - name: MARIADB_X509"},{"line_number":62,"context_line":"              value: \"REQUIRE X509\""},{"line_number":63,"context_line":"            {{- end }}"},{"line_number":64,"context_line":"          command:"},{"line_number":65,"context_line":"            - /tmp/db-init.py"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f73be0e_8a5723fc","line":62,"range":{"start_line":61,"start_character":12,"end_line":62,"end_character":35},"in_reply_to":"0eade53e_8ac447f9","updated":"2021-02-08 15:10:30.000000000","message":"To clarify, and to echo Sangeet\u0027s feedback, the certs need to be mounted somewhere","commit_id":"ac0406bc84637a31ea773f57159d16c57ff969b3"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8d3722a0fa1762cc807342be5cf8e3d97211d9c4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"              mountPath: /tmp/db-init.py"},{"line_number":71,"context_line":"              subPath: db-init.py"},{"line_number":72,"context_line":"              readOnly: true"},{"line_number":73,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":74,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":75,"context_line":"{{- end }}"},{"line_number":76,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b9a448ac_050f2ce4","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":47},"updated":"2021-02-10 19:59:56.000000000","message":"isn\u0027t this redundant? https://opendev.org/openstack/openstack-helm-infra/src/branch/master/helm-toolkit/templates/snippets/_tls_volume_mount.tpl#L65","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"4928d01f257ac82ad4f5f496d3b443328c67b14c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"              mountPath: /tmp/db-init.py"},{"line_number":71,"context_line":"              subPath: db-init.py"},{"line_number":72,"context_line":"              readOnly: true"},{"line_number":73,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":74,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal \"path\" \"/etc/mysql/certs\" | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":75,"context_line":"{{- end }}"},{"line_number":76,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8dea3065_d9977b99","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":47},"in_reply_to":"b9a448ac_050f2ce4","updated":"2021-02-19 22:49:35.000000000","message":"Yes, will remove in next patch.","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8d3722a0fa1762cc807342be5cf8e3d97211d9c4","unresolved":true,"context_lines":[{"line_number":80,"context_line":"          configMap:"},{"line_number":81,"context_line":"            name: grafana-bin"},{"line_number":82,"context_line":"            defaultMode: 0555"},{"line_number":83,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":84,"context_line":"{{- dict \"enabled\" $envAll.Values.manifests.certificates \"name\" $envAll.Values.endpoints.oslo_db.auth.admin.secret.tls.internal | include \"helm-toolkit.snippets.tls_volume\" | indent 8 }}"},{"line_number":85,"context_line":"{{- end }}"},{"line_number":86,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e7e74395_b53b4a0d","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":47},"updated":"2021-02-10 19:59:56.000000000","message":"ditto","commit_id":"0cdea3502fed177250d12d4455bacb1db938988c"}],"grafana/values_overrides/tls.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7d381415ef0ddcd81d00d3ad2719cff87c854bd4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    dashboard:"},{"line_number":5,"context_line":"      container:"},{"line_number":6,"context_line":"        grafana:"},{"line_number":7,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":8,"context_line":"          runAsUser: 0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"endpoints:"},{"line_number":11,"context_line":"  grafana:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d65c6d3d_8839152b","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":22},"updated":"2021-02-10 21:13:47.000000000","message":"do we need this to be so permissive? what requires root and writeable filesystem?","commit_id":"70fddf7e956dee03fb4a90f345c564606a121c0e"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"e63ad22705529b7afef765b6c1824260266906db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    dashboard:"},{"line_number":5,"context_line":"      container:"},{"line_number":6,"context_line":"        grafana:"},{"line_number":7,"context_line":"          readOnlyRootFilesystem: false"},{"line_number":8,"context_line":"          runAsUser: 0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"endpoints:"},{"line_number":11,"context_line":"  grafana:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"95f61d7a_d21784bf","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":22},"in_reply_to":"d65c6d3d_8839152b","updated":"2021-02-25 20:25:24.000000000","message":"Removed this block","commit_id":"70fddf7e956dee03fb4a90f345c564606a121c0e"}]}