)]}'
{"prometheus/templates/service.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"85c7c9c792f9831fcf6b092bd0cbdfccf2167675","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":34,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":35,"context_line":"    {{ end }}"},{"line_number":36,"context_line":"  - name: https"},{"line_number":37,"context_line":"    port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":38,"context_line":"    targetPort: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":39,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":40,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":41,"context_line":"    {{ end }}"},{"line_number":42,"context_line":"  selector:"},{"line_number":43,"context_line":"{{ tuple $envAll \"prometheus\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":44,"context_line":"  {{ if .Values.network.prometheus.node_port.enabled }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ae6443cb_60d630d9","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":13},"updated":"2021-03-17 18:25:21.000000000","message":"should we also put a \"{{- if .Values.manifests.certificates }}\" block around this?  would this break the public endpoints if it is set to be https?  or maybe default this something else?","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"2822fcb60bacf60a5e8965b8bb6379c03ffa556a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":34,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":35,"context_line":"    {{ end }}"},{"line_number":36,"context_line":"  - name: https"},{"line_number":37,"context_line":"    port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":38,"context_line":"    targetPort: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":39,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":40,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":41,"context_line":"    {{ end }}"},{"line_number":42,"context_line":"  selector:"},{"line_number":43,"context_line":"{{ tuple $envAll \"prometheus\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":44,"context_line":"  {{ if .Values.network.prometheus.node_port.enabled }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3112d84a_594c3742","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":13},"in_reply_to":"828746f0_6bee1fda","updated":"2021-03-17 18:43:20.000000000","message":"Ack","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0130a41fa5b74b2a49b771d4d80caf40f5e81f26","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":34,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":35,"context_line":"    {{ end }}"},{"line_number":36,"context_line":"  - name: https"},{"line_number":37,"context_line":"    port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":38,"context_line":"    targetPort: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":39,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":40,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":41,"context_line":"    {{ end }}"},{"line_number":42,"context_line":"  selector:"},{"line_number":43,"context_line":"{{ tuple $envAll \"prometheus\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":44,"context_line":"  {{ if .Values.network.prometheus.node_port.enabled }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"eb9a7bd0_4343c818","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":13},"in_reply_to":"ae6443cb_60d630d9","updated":"2021-03-17 18:29:19.000000000","message":"Might need some potential coverage here just in case","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"592a0857e8013c417566f646b27cdc29e31b6aaa","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":34,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":35,"context_line":"    {{ end }}"},{"line_number":36,"context_line":"  - name: https"},{"line_number":37,"context_line":"    port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":38,"context_line":"    targetPort: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":39,"context_line":"    {{ if .Values.network.prometheus.node_port.enabled }}"},{"line_number":40,"context_line":"    nodePort: {{ .Values.network.prometheus.node_port.port }}"},{"line_number":41,"context_line":"    {{ end }}"},{"line_number":42,"context_line":"  selector:"},{"line_number":43,"context_line":"{{ tuple $envAll \"prometheus\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":44,"context_line":"  {{ if .Values.network.prometheus.node_port.enabled }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"828746f0_6bee1fda","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":13},"in_reply_to":"ae6443cb_60d630d9","updated":"2021-03-17 18:30:52.000000000","message":"This just means the service can have an additional port name which is https.  http is still need for passing the non tls gate.  In the tls gate, it will reference the https.","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"}],"prometheus/templates/statefulset.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"61f19f9f431eefd4b81be2a14ea744994fea2838","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2580a0ef_bfe19d6c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"updated":"2021-03-17 18:58:01.000000000","message":"why would the scheme change based on the existence of this certificate?","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a34efa9da6c4d58b76aacc9cd16030817d9e01fa","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"886b1429_c43f080d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"2580a0ef_bfe19d6c","updated":"2021-03-17 18:59:31.000000000","message":"Also the interface. We don\u0027t do that for keystone\u0027s health check.","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b80fe84a2a47bcc1633336b0cffc00b6ef82a784","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"0aa3ef64_6f4c775e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"32cd90e8_c44c000a","updated":"2021-03-17 20:40:05.000000000","message":"See https://github.com/openstack/openstack-helm/blob/master/glance/values_overrides/tls.yaml#L83-L87","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c3fee2f7fdd7113b93553f470cdfa337082730ae","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"728d14b7_398b144b","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"3aacc833_096e90ae","updated":"2021-03-17 19:23:55.000000000","message":"That would simply be overriding the endpt in values.yaml - there shouldn\u0027t be a need for this if- statement that split the endpoints. Please see glance for example, I believe the TLS there is terminated by an nginx side car, but the probes don\u0027t split case.","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"427431fe90502abbc1df14daff0c85934c8ed1df","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c977289c_40399599","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"4510e61e_7ebd2256","updated":"2021-03-17 20:27:59.000000000","message":"@Tin, I am making use of what we already have in downstream which specifies default and public for scheme:\n\nscheme:\n  default: \"http\"\n  public: \"https\"\n\nSame for the port:\nport:\n  api:\n    default: 9090\n    http: 80\n    public: 443\n\nThe if/else is to pick up http vs https and 80 vs 443 instead of override the above which gives 2 identical values for the same key.","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"be95f10176d20b3930334d7d5709e057cb740748","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2db6a03f_946f5cc0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"4510e61e_7ebd2256","updated":"2021-03-17 20:26:01.000000000","message":"Ack","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"1660d118780ff08226f088ee6a6ed743e7984bdb","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"4510e61e_7ebd2256","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"728d14b7_398b144b","updated":"2021-03-17 20:19:05.000000000","message":"@Tin I assume you mean this here?\n\nhttps://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L15-L20","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"8f7e614270b34ac52628c8e9ba30ea1e1ed4b65b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aacc833_096e90ae","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"886b1429_c43f080d","updated":"2021-03-17 19:05:55.000000000","message":"Per discussion with Steven F., TLS is terminated to apache side car, not actually at Prometheus. As such, apache is changed to listen to https, not http.","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5a7fcf46ca123bcc585b749f8cb40d424171a69b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $authHeader :\u003d printf \"%s:%s\" $probeUser $probePass | b64enc }}"},{"line_number":19,"context_line":"httpGet:"},{"line_number":20,"context_line":"  path: /status"},{"line_number":21,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":22,"context_line":"  scheme: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":23,"context_line":"  port: {{ tuple \"monitoring\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":24,"context_line":"{{- else }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"32cd90e8_c44c000a","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"c977289c_40399599","updated":"2021-03-17 20:36:24.000000000","message":"Shouldn\u0027t the deployer be making the default: https and the port https: 443 in your deployment downstream instead of changing the chart?","commit_id":"ec7a6d4c387fcdff861ef7ec39200a780e3360fd"}]}