)]}'
{"id":"openstack%2Fopenstack-helm-infra~785672","triplet_id":"openstack%2Fopenstack-helm-infra~master~Iab22d0c986d680663fbe8e84d6c0d89b03dc6428","project":"openstack/openstack-helm-infra","branch":"master","hashtags":[],"change_id":"Iab22d0c986d680663fbe8e84d6c0d89b03dc6428","subject":"Adjust Prometheus http readiness probe path from /status to /-/ready","status":"MERGED","created":"2021-04-09 15:41:21.000000000","updated":"2021-04-14 17:08:31.000000000","submitted":"2021-04-14 17:06:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"785672","meta_rev_id":"f7d08ec9435ce80fe177ea682c133ff8cccf2894","_number":785672,"virtual_id_number":785672,"owner":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-14 17:06:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"recommended":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-04-13 17:20:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":2,"date":"2021-04-13 20:13:49.000000000","_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":1,"date":"2021-04-14 15:35:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":1,"date":"2021-04-14 02:17:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":2,"date":"2021-04-14 16:09:00.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"value":0,"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":1,"date":"2021-04-14 16:09:00.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 16:48:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-13 15:35:28.000000000","updated_by":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"reviewer":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"state":"CC"},{"updated":"2021-04-13 15:39:23.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"CC"},{"updated":"2021-04-13 17:19:43.000000000","updated_by":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"CC"},{"updated":"2021-04-13 17:20:27.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"REVIEWER"},{"updated":"2021-04-13 20:13:49.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2021-04-14 02:17:24.000000000","updated_by":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"reviewer":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"state":"REVIEWER"},{"updated":"2021-04-14 15:35:37.000000000","updated_by":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"reviewer":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"state":"REVIEWER"},{"updated":"2021-04-14 16:09:00.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"}],"messages":[{"id":"bfb96d77f948f10332cc0b3babf56a14958cb651","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-04-09 15:41:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89f0436ab41e0bb1d8865b18aec849914ac0b598","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-04-09 15:55:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4e1c9cd0862add9d6e207944bd32842ca6b75438","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 16:48:18.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5d586bedd0e840c398f7ffeb1f5089d4 : SUCCESS in 4m 06s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/101ebc62bab24e6a8178f53a701bb5ec : FAILURE in 3m 16s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/9467c056a23946aba64f57e26689aab8 : SUCCESS in 36m 10s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/fe479e9ac4714e2bb3462b8e01571660 : FAILURE in 29m 23s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/58d8797f8f1544e5bad224f734d47853 : SUCCESS in 50m 25s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/570219e1a6eb4ae29bbe31331b3601e5 : SUCCESS in 47m 17s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/095c046210374681a6b908215539cf13 : SUCCESS in 14m 14s","accounts_in_message":[],"_revision_number":2},{"id":"b7ee25b50425dff7c6a4345f1d758eeccf880fca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-04-13 15:23:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e81a98b5a6b817d24c4457527f8918e379a39fa2","author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"date":"2021-04-13 15:35:28.000000000","message":"Patch Set 3:\n\nLGTM, you will have to update the release notes as well..","accounts_in_message":[],"_revision_number":3},{"id":"2f8a17624ea74fdecfaf22aae9959f3a498e174f","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2021-04-13 15:39:23.000000000","message":"Patch Set 3:\n\nThis definitely makes sense.\n\nSince you are looking at this ...\n\nAny thoughts about adding the ability to adjust the probe timers?\n\nDoes the same probe make sense for readiness and liveness? (If it\u0027s not ready, is it likely that a pod restart will resolve the issue?)","accounts_in_message":[],"_revision_number":3},{"id":"ca4c725504440f9e9c19ff9a90e398f257f1570d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-13 16:33:05.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca7636b2df5048bca4d13912feeaa557 : SUCCESS in 3m 56s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/abf2864696844b6b9a58b7a55af534f3 : FAILURE in 3m 22s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/70558aea954940ce87b81b54aa173b27 : SUCCESS in 44m 47s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/41cf6f735f214d55b95bef1a1d6d06fb : SUCCESS in 34m 47s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/86a0d3ce48d44941acd1cf92d7710a1a : SUCCESS in 53m 24s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/c2ceac630f6c4b68a34aac01b3bc5739 : SUCCESS in 59m 33s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/6f0e38adac1f452d9a88b6f68e1c768f : SUCCESS in 15m 10s","accounts_in_message":[],"_revision_number":3},{"id":"4cf3dd54cf10c915667e22d35e0116ede27e6c82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-04-13 17:18:35.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"fbe39cee7feaad37960e6508c9c73fc094315db2","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2021-04-13 17:20:27.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"7c18ef3eadf534a8b233ba39c2b2e148df2a7f38","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-13 18:07:26.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd49cf096345453a9af3a17127cb25a9 : SUCCESS in 4m 03s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6655048e89fb42439d80f31cd316b56d : SUCCESS in 3m 49s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/297245a92395413085993cf4b06e3915 : SUCCESS in 3m 55s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/0bf857a678c342dd8ed4ec611ebd3e53 : SUCCESS in 36m 06s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/bd423906577e4cc1baf9419ea105941c : SUCCESS in 31m 34s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/c62af66ccae34915a92f9f6c2dd56bf2 : SUCCESS in 44m 21s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/cce033101ed04b38859b03f9abef566f : SUCCESS in 47m 22s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/aa9a760e97174391928c390a06d73d70 : SUCCESS in 12m 59s","accounts_in_message":[],"_revision_number":4},{"id":"db9f232a83b42f046c90770cdd1b11a714613727","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2021-04-13 20:13:49.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d7fcce17021c59835a18dcf5f2f8745053fa7ea3","author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"date":"2021-04-14 02:17:24.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e4c3fe5fa42bd68e6480f1e7ba84bb5e9905f528","author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"date":"2021-04-14 15:35:37.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"720615832bb8a99eead0146c9d027902519efc44","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2021-04-14 16:09:00.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"300fa5cea82972ed5bea9471173044a2251d2c99","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-14 16:13:10.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"104072856fea7e9e7e93d6253235c58ffe3507ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-14 17:06:53.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ce963dce2fe42f1be22cdb9b12b56e5 : SUCCESS in 4m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c1e1655fa8ce4a8b9211f8689075b186 : SUCCESS in 5m 04s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/430ca5656ff340dabdb7d717864dfaee : SUCCESS in 5m 06s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/e2aaf455d8b04f199e370cbfe77b0f9a : SUCCESS in 39m 31s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/16236308075b4e75b44b5365af6bafed : SUCCESS in 29m 16s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/0192ce28dec24889ac177e7bd71d69b6 : SUCCESS in 52m 02s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/9b68ad00d8914689a1d5724e3a69d60e : SUCCESS in 46m 42s","accounts_in_message":[],"_revision_number":4},{"id":"7a0bcbc84a77476a95ddf4f1ac7d8b34fe9307b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-14 17:06:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"f7d08ec9435ce80fe177ea682c133ff8cccf2894","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-14 17:08:31.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/93772b1910d94044afdfbe64dfbb6ade : SUCCESS in 1m 09s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3fc9d34fe35f42fbbad7e2bc62b2a28e : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"be2584fd7c06a194b7fc0876d36e2062c41b38a0","revisions":{"79f84ad4e177be6f609975f775dbfe40b17fcdf1":{"kind":"REWORK","_number":1,"created":"2021-04-09 15:41:21.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/72/785672/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/72/785672/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/1"}}},"commit":{"parents":[{"commit":"c6786de15257449ef279f912ff7b096218cb4e85","subject":"Merge \"Enable TLS for Ceph RGW\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/c6786de15257449ef279f912ff7b096218cb4e85"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:38:50.000000000","tz":-240},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:38:50.000000000","tz":-240},"subject":"[WIP] adjust Prometheus readiness probe path from /status to /-/ready","message":"[WIP] adjust Prometheus readiness probe path from /status to /-/ready\n\nPrometheus documentation shows that /-/ready can be used to check that\nit is ready to service traffic (i.e. response to queries). [0] I suspect\nthere are some cases where Prometheus may turn Ready in k8s before it\u0027s\nactually ready to serve traffic (using /status).\n\n[0]: https://prometheus.io/docs/prometheus/latest/management_api/\n\nChange-Id: Iab22d0c986d680663fbe8e84d6c0d89b03dc6428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/79f84ad4e177be6f609975f775dbfe40b17fcdf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/79f84ad4e177be6f609975f775dbfe40b17fcdf1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c6786de15257449ef279f912ff7b096218cb4e85","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"2e00b35a50cb5ad802a4cfd2a7247127cdc3a193":{"kind":"REWORK","_number":2,"created":"2021-04-09 15:55:47.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/72/785672/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/72/785672/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/2"}}},"commit":{"parents":[{"commit":"c6786de15257449ef279f912ff7b096218cb4e85","subject":"Merge \"Enable TLS for Ceph RGW\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/c6786de15257449ef279f912ff7b096218cb4e85"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:38:50.000000000","tz":-240},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:55:42.000000000","tz":-240},"subject":"[WIP] adjust Prometheus readiness probe path from /status to /-/ready","message":"[WIP] adjust Prometheus readiness probe path from /status to /-/ready\n\nPrometheus documentation shows that /-/ready can be used to check that\nit is ready to service traffic (i.e. response to queries). [0] I suspect\nthere are some cases where Prometheus may turn Ready in k8s before it\u0027s\nactually ready to serve traffic (using /status).\n\n[0]: https://prometheus.io/docs/prometheus/latest/management_api/\n\nChange-Id: Iab22d0c986d680663fbe8e84d6c0d89b03dc6428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2e00b35a50cb5ad802a4cfd2a7247127cdc3a193"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2e00b35a50cb5ad802a4cfd2a7247127cdc3a193"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c6786de15257449ef279f912ff7b096218cb4e85","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"7b3482776920117d0da64b9ec5560a36afe6da46":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2021-04-13 15:23:58.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/72/785672/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/72/785672/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/3"}}},"commit":{"parents":[{"commit":"25c897fb8992091c3d7f86344813fbeb9058fa53","subject":"Move shaker chart from osh-addons","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/25c897fb8992091c3d7f86344813fbeb9058fa53"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:38:50.000000000","tz":-240},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-13 15:22:11.000000000","tz":-240},"subject":"Adjust Prometheus http readiness probe path from /status to /-/ready","message":"Adjust Prometheus http readiness probe path from /status to /-/ready\n\nPrometheus documentation shows that /-/ready can be used to check that\nit is ready to service traffic (i.e. respond to queries) [0]. I\u0027ve\nwitnessed cases where Prometheus\u0027s readiness probe is passing during\ninitial deployment using /status, which in turn triggers its helm test\nto start. Said helm test then fails because /status is not a good a\nreliable indicator that Prometheus is actually ready to serve traffic\nand the helm test is performing actions that require it to be proprely\nup and ready.\n\n[0]: https://prometheus.io/docs/prometheus/latest/management_api/\n\nChange-Id: Iab22d0c986d680663fbe8e84d6c0d89b03dc6428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7b3482776920117d0da64b9ec5560a36afe6da46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/7b3482776920117d0da64b9ec5560a36afe6da46"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"25c897fb8992091c3d7f86344813fbeb9058fa53","is_merged_in_target_branch":true,"change_id":"Ica2c7668a7ab047f8ed2361234b5810eedc9c1e2","change_number":785263,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"},"be2584fd7c06a194b7fc0876d36e2062c41b38a0":{"kind":"REWORK","_number":4,"created":"2021-04-13 17:18:35.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/72/785672/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/72/785672/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/72/785672/4"}}},"commit":{"parents":[{"commit":"25c897fb8992091c3d7f86344813fbeb9058fa53","subject":"Move shaker chart from osh-addons","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/25c897fb8992091c3d7f86344813fbeb9058fa53"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-09 15:38:50.000000000","tz":-240},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-04-13 17:17:49.000000000","tz":-240},"subject":"Adjust Prometheus http readiness probe path from /status to /-/ready","message":"Adjust Prometheus http readiness probe path from /status to /-/ready\n\nPrometheus documentation shows that /-/ready can be used to check that\nit is ready to service traffic (i.e. respond to queries) [0]. I\u0027ve\nwitnessed cases where Prometheus\u0027s readiness probe is passing during\ninitial deployment using /status, which in turn triggers its helm test\nto start. Said helm test then fails because /status is not a good a\nreliable indicator that Prometheus is actually ready to serve traffic\nand the helm test is performing actions that require it to be proprely\nup and ready.\n\n[0]: https://prometheus.io/docs/prometheus/latest/management_api/\n\nChange-Id: Iab22d0c986d680663fbe8e84d6c0d89b03dc6428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/be2584fd7c06a194b7fc0876d36e2062c41b38a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/be2584fd7c06a194b7fc0876d36e2062c41b38a0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"25c897fb8992091c3d7f86344813fbeb9058fa53","is_merged_in_target_branch":true,"change_id":"Ica2c7668a7ab047f8ed2361234b5810eedc9c1e2","change_number":785263,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}