)]}'
{"elasticsearch/templates/bin/_elasticsearch.sh.tpl":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":19,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function initiate_keystore () {"},{"line_number":22,"context_line":"  set -ex"},{"line_number":23,"context_line":"  bin/elasticsearch-keystore create"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  {{- if .Values.conf.elasticsearch.snapshots.enabled }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"d0fd0ba5_9d3ba2d7","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":1},"updated":"2021-05-03 19:17:55.000000000","message":"What is the reason for removing this? You do not want the script to exit in case of the error. I think you removed it due to the passwords. Please see the other comments at line 35","commit_id":"3435a3a82a42022167d105eb01fb36074b887a31"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"666c1e4aa66e3f8ef81662c1d392f5f20ece426b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function initiate_keystore () {"},{"line_number":22,"context_line":"  set -ex"},{"line_number":23,"context_line":"  bin/elasticsearch-keystore create"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  {{- if .Values.conf.elasticsearch.snapshots.enabled }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"d5c02723_8312e239","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":1},"in_reply_to":"9a705287_8fd60dd0","updated":"2021-05-03 22:19:33.000000000","message":"If there are password involved, I am ok with leaving \"set -e\" on L18.","commit_id":"3435a3a82a42022167d105eb01fb36074b887a31"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":19,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"function initiate_keystore () {"},{"line_number":22,"context_line":"  set -ex"},{"line_number":23,"context_line":"  bin/elasticsearch-keystore create"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  {{- if .Values.conf.elasticsearch.snapshots.enabled }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"9a705287_8fd60dd0","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":1},"in_reply_to":"d0fd0ba5_9d3ba2d7","updated":"2021-05-03 20:11:35.000000000","message":"It will exit with error with line #18.  Setting -e does not need to be done in here.","commit_id":"3435a3a82a42022167d105eb01fb36074b887a31"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  {{- if .Values.manifests.certificates }}"},{"line_number":34,"context_line":"  {{- $alias :\u003d .Values.secrets.tls.elasticsearch.elasticsearch.internal }}"},{"line_number":35,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -storepasswd -cacerts -new ${ELASTICSEARCH_PASSWORD} -storepass changeit"},{"line_number":36,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -importcert -alias {{$alias}} -cacerts -trustcacerts -noprompt -file ${JAVA_KEYSTORE_CERT_PATH} -storepass ${ELASTICSEARCH_PASSWORD}"},{"line_number":37,"context_line":"  {{- end }}"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"84f33fe0_aa1a6514","line":35,"updated":"2021-05-03 19:17:55.000000000","message":"add \"set +x\" above this line to stop showing the output","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  {{- if .Values.manifests.certificates }}"},{"line_number":34,"context_line":"  {{- $alias :\u003d .Values.secrets.tls.elasticsearch.elasticsearch.internal }}"},{"line_number":35,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -storepasswd -cacerts -new ${ELASTICSEARCH_PASSWORD} -storepass changeit"},{"line_number":36,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -importcert -alias {{$alias}} -cacerts -trustcacerts -noprompt -file ${JAVA_KEYSTORE_CERT_PATH} -storepass ${ELASTICSEARCH_PASSWORD}"},{"line_number":37,"context_line":"  {{- end }}"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"c390b839_020c13ca","line":35,"in_reply_to":"84f33fe0_aa1a6514","updated":"2021-05-03 20:11:35.000000000","message":"See comments below.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  {{- $alias :\u003d .Values.secrets.tls.elasticsearch.elasticsearch.internal }}"},{"line_number":35,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -storepasswd -cacerts -new ${ELASTICSEARCH_PASSWORD} -storepass changeit"},{"line_number":36,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -importcert -alias {{$alias}} -cacerts -trustcacerts -noprompt -file ${JAVA_KEYSTORE_CERT_PATH} -storepass ${ELASTICSEARCH_PASSWORD}"},{"line_number":37,"context_line":"  {{- end }}"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"function start () {"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"69185280_3c1c0016","line":37,"updated":"2021-05-03 19:17:55.000000000","message":"add \"set -x\" after this line to start showing the output.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  {{- $alias :\u003d .Values.secrets.tls.elasticsearch.elasticsearch.internal }}"},{"line_number":35,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -storepasswd -cacerts -new ${ELASTICSEARCH_PASSWORD} -storepass changeit"},{"line_number":36,"context_line":"  /usr/share/elasticsearch/jdk/bin/keytool -importcert -alias {{$alias}} -cacerts -trustcacerts -noprompt -file ${JAVA_KEYSTORE_CERT_PATH} -storepass ${ELASTICSEARCH_PASSWORD}"},{"line_number":37,"context_line":"  {{- end }}"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"function start () {"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"2d0fdb18_5f8a4195","line":37,"in_reply_to":"69185280_3c1c0016","updated":"2021-05-03 20:11:35.000000000","message":"There is no need to do -x at all.  The access_key and secert_key is also showing on line 28 and line 29.  I don\u0027t see a need to show secret information in logs.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"}],"elasticsearch/templates/statefulset-data.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            - name: CACERT_OPTION"},{"line_number":120,"context_line":"              value: \"--cacert /etc/elasticsearch/certs/ca.crt\""},{"line_number":121,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":122,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":123,"context_line":"{{- end }}"},{"line_number":124,"context_line":"            - name: NODE_MASTER"},{"line_number":125,"context_line":"              value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"23b00633_ba8444da","line":122,"range":{"start_line":122,"start_character":22,"end_line":122,"end_character":60},"updated":"2021-05-03 19:17:55.000000000","message":"Is this a standard path ? if not, then do you want to read it from values.yaml so that this can be configurable.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            - name: CACERT_OPTION"},{"line_number":120,"context_line":"              value: \"--cacert /etc/elasticsearch/certs/ca.crt\""},{"line_number":121,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":122,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":123,"context_line":"{{- end }}"},{"line_number":124,"context_line":"            - name: NODE_MASTER"},{"line_number":125,"context_line":"              value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"dec31c1b_3ea77f23","line":122,"range":{"start_line":122,"start_character":22,"end_line":122,"end_character":60},"in_reply_to":"23b00633_ba8444da","updated":"2021-05-03 20:11:35.000000000","message":"Yes, it is a standard path.  This path \"/usr/share/elasticsearch/config/\" must be the same as the one in elasticsearch configuration as in L158 and L162. \n\nWhat I can do is to modify L120 to use the same path and not mounting \"/usr/share/elasticsearch/config/\" instead.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ea4b3c6b69ef30f05b08d1db61afaef503b6963b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            - name: CACERT_OPTION"},{"line_number":120,"context_line":"              value: \"--cacert /etc/elasticsearch/certs/ca.crt\""},{"line_number":121,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":122,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":123,"context_line":"{{- end }}"},{"line_number":124,"context_line":"            - name: NODE_MASTER"},{"line_number":125,"context_line":"              value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"8161b07e_c7db81af","line":122,"range":{"start_line":122,"start_character":22,"end_line":122,"end_character":60},"in_reply_to":"a9ad78a2_76f3f5fb","updated":"2021-05-04 00:07:02.000000000","message":"There are 4 other files that can be improved from this hard-coded path.  While I agree on the one stop shop approach, I would prefer not to use my current story to refactor the legacy code. It is better to create a refactor story to fix all 4 or possibly more files.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"666c1e4aa66e3f8ef81662c1d392f5f20ece426b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            - name: CACERT_OPTION"},{"line_number":120,"context_line":"              value: \"--cacert /etc/elasticsearch/certs/ca.crt\""},{"line_number":121,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":122,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":123,"context_line":"{{- end }}"},{"line_number":124,"context_line":"            - name: NODE_MASTER"},{"line_number":125,"context_line":"              value: \"false\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a9ad78a2_76f3f5fb","line":122,"range":{"start_line":122,"start_character":22,"end_line":122,"end_character":60},"in_reply_to":"dec31c1b_3ea77f23","updated":"2021-05-03 22:19:33.000000000","message":"As an option, maybe just define \"/usr/share/elasticsearch\" this as a global and just use it where needed, then if it is ever changed, it\u0027s one stop shop?  I don\u0027t necessary think it has to be configurable unless there is a need to install it somewhere else.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"}],"elasticsearch/templates/statefulset-master.yaml":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- if .Values.manifests.statefulset_master }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":19,"context_line":"{{- $s3UserSecret :\u003d .Values.secrets.rgw.elasticsearch }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mounts_elasticsearch :\u003d .Values.pod.mounts.elasticsearch.elasticsearch }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"37b0a9fb_f0d8699e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2021-05-03 19:17:55.000000000","message":"Why is the need to define a new variable here when the value can be supplied directly at line 132. This is only used at one place.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- if .Values.manifests.statefulset_master }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":19,"context_line":"{{- $s3UserSecret :\u003d .Values.secrets.rgw.elasticsearch }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mounts_elasticsearch :\u003d .Values.pod.mounts.elasticsearch.elasticsearch }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"69ffd3b5_30a16e56","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"37b0a9fb_f0d8699e","updated":"2021-05-03 20:11:35.000000000","message":"I am trying to keep the code consistent in this file and in other files as well in the chart. See L19 for example.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"666c1e4aa66e3f8ef81662c1d392f5f20ece426b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- if .Values.manifests.statefulset_master }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":19,"context_line":"{{- $s3UserSecret :\u003d .Values.secrets.rgw.elasticsearch }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mounts_elasticsearch :\u003d .Values.pod.mounts.elasticsearch.elasticsearch }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e5b3ed2e_a4a6005c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"69ffd3b5_30a16e56","updated":"2021-05-03 22:19:33.000000000","message":"Actually I don\u0027t even see where $s3UserSecret is used, that is kind of weird.  I do agree with Sangeet, if there is just one place where this is set, just supply it directly there then.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ea4b3c6b69ef30f05b08d1db61afaef503b6963b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- if .Values.manifests.statefulset_master }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $esUserSecret :\u003d .Values.secrets.elasticsearch.user }}"},{"line_number":19,"context_line":"{{- $s3UserSecret :\u003d .Values.secrets.rgw.elasticsearch }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mounts_elasticsearch :\u003d .Values.pod.mounts.elasticsearch.elasticsearch }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"07a317d9_851ff970","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"e5b3ed2e_a4a6005c","updated":"2021-05-04 00:07:02.000000000","message":"I removed that in PS17.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"3f1ddeef06cce980a4683f117c09291489e2f504","unresolved":true,"context_lines":[{"line_number":125,"context_line":"              value: \"{{ .Values.conf.elasticsearch.env.java_opts.master }}\""},{"line_number":126,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":127,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":128,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":129,"context_line":"            - name: ELASTICSEARCH_PASSWORD"},{"line_number":130,"context_line":"              valueFrom:"},{"line_number":131,"context_line":"                secretKeyRef:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c7a9ffe4_d5de9a65","line":128,"range":{"start_line":128,"start_character":22,"end_line":128,"end_character":60},"updated":"2021-05-03 19:17:55.000000000","message":"Is this a standard path ? if not, then do you want to read it from values.yaml so that this can be configurable.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"34950561f283908ebc6babaf3eb45bcfdaf117b6","unresolved":true,"context_lines":[{"line_number":125,"context_line":"              value: \"{{ .Values.conf.elasticsearch.env.java_opts.master }}\""},{"line_number":126,"context_line":"{{- if .Values.manifests.certificates }}"},{"line_number":127,"context_line":"            - name: JAVA_KEYSTORE_CERT_PATH"},{"line_number":128,"context_line":"              value: \"/usr/share/elasticsearch/config/ca.crt\""},{"line_number":129,"context_line":"            - name: ELASTICSEARCH_PASSWORD"},{"line_number":130,"context_line":"              valueFrom:"},{"line_number":131,"context_line":"                secretKeyRef:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c29551b0_0e08dbbc","line":128,"range":{"start_line":128,"start_character":22,"end_line":128,"end_character":60},"in_reply_to":"c7a9ffe4_d5de9a65","updated":"2021-05-03 20:11:35.000000000","message":"Yes, it is a standard path.  See L155 and L159 for examples.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"}],"helm-toolkit/templates/manifests/_job-s3-bucket.yaml.tpl":[{"author":{"_account_id":32190,"name":"Frank Ritchie","email":"fr801x@att.com","username":"fr801x"},"change_message_id":"6c1b60a6be9cd897b91cd0dd76671966629c038a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"          env:"},{"line_number":76,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":77,"context_line":"            - name: SSL_OPTION"},{"line_number":78,"context_line":"              value: \"--ca-certs\u003d/etc/elasticsearch/certs/ca.crt\""},{"line_number":79,"context_line":"{{- end }}"},{"line_number":80,"context_line":"{{- with $env :\u003d dict \"s3AdminSecret\" $envAll.Values.secrets.rgw.admin }}"},{"line_number":81,"context_line":"{{- include \"helm-toolkit.snippets.rgw_s3_admin_env_vars\" $env | indent 12 }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"ff2623ba_1b05f254","line":78,"updated":"2021-05-03 20:18:56.000000000","message":"just a thought but what if someone wanted to use this script for something other than elasticsearch?","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"ea4b3c6b69ef30f05b08d1db61afaef503b6963b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"          env:"},{"line_number":76,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":77,"context_line":"            - name: SSL_OPTION"},{"line_number":78,"context_line":"              value: \"--ca-certs\u003d/etc/elasticsearch/certs/ca.crt\""},{"line_number":79,"context_line":"{{- end }}"},{"line_number":80,"context_line":"{{- with $env :\u003d dict \"s3AdminSecret\" $envAll.Values.secrets.rgw.admin }}"},{"line_number":81,"context_line":"{{- include \"helm-toolkit.snippets.rgw_s3_admin_env_vars\" $env | indent 12 }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"74a5cf39_d837abe1","line":78,"in_reply_to":"8e2684b1_de48fd6c","updated":"2021-05-04 00:07:02.000000000","message":"I would refactor this code and just let the service decide what path to pass in.  This can be any path for the s3 bucket creation, unlike the elasticsearch pods which must be /usr/share/elasticsearch/config.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"666c1e4aa66e3f8ef81662c1d392f5f20ece426b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"          env:"},{"line_number":76,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":77,"context_line":"            - name: SSL_OPTION"},{"line_number":78,"context_line":"              value: \"--ca-certs\u003d/etc/elasticsearch/certs/ca.crt\""},{"line_number":79,"context_line":"{{- end }}"},{"line_number":80,"context_line":"{{- with $env :\u003d dict \"s3AdminSecret\" $envAll.Values.secrets.rgw.admin }}"},{"line_number":81,"context_line":"{{- include \"helm-toolkit.snippets.rgw_s3_admin_env_vars\" $env | indent 12 }}"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"8e2684b1_de48fd6c","line":78,"in_reply_to":"ff2623ba_1b05f254","updated":"2021-05-03 22:19:33.000000000","message":"Good thought, since we are passing the service in as $serviceName, why not just use it here, although I am not sure if /etc/$serviceName is a standard path to all.","commit_id":"d42351e34db4146e87f06319787a40dce47c2518"}]}