)]}'
{"id":"openstack%2Fopenstack-helm-infra~791623","triplet_id":"openstack%2Fopenstack-helm-infra~master~Ia77e1da627b7f7e0056fc1ef13194c83222657d9","project":"openstack/openstack-helm-infra","branch":"master","topic":"fix/sh","hashtags":[],"change_id":"Ia77e1da627b7f7e0056fc1ef13194c83222657d9","subject":"fix(shell): polishes bash scripts","status":"ABANDONED","created":"2021-05-16 17:31:32.000000000","updated":"2022-01-21 21:07:29.000000000","total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"cc88f361ff5895f3603b01762e7ac8c7a8a9427d","_number":791623,"virtual_id_number":791623,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-05-18 02:57:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},"disliked":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2022-01-21 21:07:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":-1,"date":"2021-05-24 21:37:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":1,"date":"2021-05-19 03:39:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}],"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-16 18:18:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-17 21:39:42.000000000","updated_by":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"reviewer":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"state":"REVIEWER"},{"updated":"2021-05-19 03:39:47.000000000","updated_by":{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},"reviewer":{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},"state":"REVIEWER"},{"updated":"2021-05-19 22:09:48.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"CC"},{"updated":"2021-05-24 21:37:50.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"}],"messages":[{"id":"deff014091363a99f72ca69ada8fa6d188ecf90b","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-05-16 17:31:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb46445af11aaa99e030edbb7d4b973d227bed87","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-05-16 17:32:09.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"404c9f42c7e4585653385d13bdde37ced65d31a4","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-05-16 17:32:26.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"7b1b70138ae7fdfb039f30610f90c61ead665278","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-16 18:18:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13111016d3174153b2f80de699a71b4e : SUCCESS in 6m 24s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/3df79dcc88dd4527b9783b5fd1c0412d : SUCCESS in 5m 40s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/7be14100cfb74e6281ce45aa25e4de48 : SUCCESS in 44m 39s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/bf096345527b41ff98af0d1b08cafd7f : SUCCESS in 27m 31s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/a9258df094ae47ad8c887631c273b268 : SUCCESS in 44m 45s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/e202b9878a394e678d034604387dfb03 : SUCCESS in 45m 30s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/b7e5ab93c2bb492b83e3c97c677bf362 : SUCCESS in 14m 23s","accounts_in_message":[],"_revision_number":3},{"id":"d25fb13640afbabc60c79fefa1b1acfdaa94d16a","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-05-16 22:30:18.000000000","message":"Patch Set 3:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":3},{"id":"3846d42cc2924d1289775934c5d5a8e6b8908dda","author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"date":"2021-05-17 21:39:42.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"2a56636639ff6e37ccaee4ebd77d5a8a3acf69e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-05-18 02:06:07.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"541dfb8010f21210fee923e16dbf89d13ca571ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-18 02:57:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ba18b227d09e41f1bf31b35fec7c6de3 : SUCCESS in 3m 39s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/c606ed125fd440ae9031740887b679d4 : SUCCESS in 4m 06s\n- openstack-helm-infra-aio-logging https://zuul.opendev.org/t/openstack/build/50d0bd200e9c46538deb659d6d85b02c : SUCCESS in 34m 15s\n- openstack-helm-infra-aio-monitoring https://zuul.opendev.org/t/openstack/build/e0ef6cb26d4649d4bc8d00444fae8049 : SUCCESS in 27m 17s\n- openstack-helm-infra-openstack-support https://zuul.opendev.org/t/openstack/build/322cccf412534a5c971bf328ca556205 : SUCCESS in 44m 23s\n- openstack-helm-infra-openstack-support-ssl https://zuul.opendev.org/t/openstack/build/254e348649fa42cca9920514dcda6976 : SUCCESS in 48m 29s\n- openstack-helm-infra-metacontroller https://zuul.opendev.org/t/openstack/build/6a067978cba941cc8c4883f6bcbbae1f : SUCCESS in 14m 02s","accounts_in_message":[],"_revision_number":4},{"id":"6438fc02d696e96217d5e174659d864d2183c250","author":{"_account_id":33173,"name":"liupeng0518","display_name":"Samuel Liu","email":"liupeng0518@gmail.com","username":"liupeng0518"},"date":"2021-05-19 03:39:47.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"95990c9c5954799e843a90e206ea3a7bdfe2ba3a","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-05-19 22:09:48.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c93130b334fb74411fc3dc49cc97edbd203cc1be","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2021-05-24 21:37:50.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f3ec77f1473c239066cfe61fc8c3b99878075edb","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2022-01-21 21:07:29.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2ff1f40aebf357d6b312f0f0c31820e2385334f8","revisions":{"090c3329c7ee9acae4aa6406af5eefc5f1fff19b":{"kind":"REWORK","_number":1,"created":"2021-05-16 17:31:32.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/23/791623/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/23/791623/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/1"}}},"commit":{"parents":[{"commit":"6c861be27295e067a1ba7bdd23ae062144cbf1dc","subject":"Merge \"Remove deprecated svc annotation tolerate-unready-endpoints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/6c861be27295e067a1ba7bdd23ae062144cbf1dc"}]}],"author":{"name":"Tin","email":"tin@irrational.io","date":"2021-05-16 17:29:42.000000000","tz":-300},"committer":{"name":"Tin","email":"tin@irrational.io","date":"2021-05-16 17:29:42.000000000","tz":-300},"subject":"fix(shell): ppolish bash scripts","message":"fix(shell): ppolish bash scripts\n\nFixes some issues in the shellscripts raised by shellcheck.\n\nChange-Id: Ia77e1da627b7f7e0056fc1ef13194c83222657d9\nSigned-off-by: Tin \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/090c3329c7ee9acae4aa6406af5eefc5f1fff19b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/090c3329c7ee9acae4aa6406af5eefc5f1fff19b"}]},"branch":"refs/heads/master"},"a2311fe7da97dc67b1d74b76eb727fd7a6b3e8a5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-05-16 17:32:09.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/23/791623/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/23/791623/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/2"}}},"commit":{"parents":[{"commit":"6c861be27295e067a1ba7bdd23ae062144cbf1dc","subject":"Merge \"Remove deprecated svc annotation tolerate-unready-endpoints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/6c861be27295e067a1ba7bdd23ae062144cbf1dc"}]}],"author":{"name":"Tin","email":"tin@irrational.io","date":"2021-05-16 17:29:42.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2021-05-16 17:32:09.000000000","tz":0},"subject":"fix(shell): polishes bash scripts","message":"fix(shell): polishes bash scripts\n\nFixes some issues in the shellscripts raised by shellcheck.\n\nChange-Id: Ia77e1da627b7f7e0056fc1ef13194c83222657d9\nSigned-off-by: Tin \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/a2311fe7da97dc67b1d74b76eb727fd7a6b3e8a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/a2311fe7da97dc67b1d74b76eb727fd7a6b3e8a5"}]},"branch":"refs/heads/master","description":"Edit commit message"},"019f4b9489fae2bfce1a454952776018a1279e9e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-05-16 17:32:26.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/23/791623/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/23/791623/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/3"}}},"commit":{"parents":[{"commit":"6c861be27295e067a1ba7bdd23ae062144cbf1dc","subject":"Merge \"Remove deprecated svc annotation tolerate-unready-endpoints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/6c861be27295e067a1ba7bdd23ae062144cbf1dc"}]}],"author":{"name":"Tin","email":"tin@irrational.io","date":"2021-05-16 17:29:42.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2021-05-16 17:32:26.000000000","tz":0},"subject":"fix(shell): polishes bash scripts","message":"fix(shell): polishes bash scripts\n\nFixes some issues in .sh raised by shellcheck.\n\nChange-Id: Ia77e1da627b7f7e0056fc1ef13194c83222657d9\nSigned-off-by: Tin \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/019f4b9489fae2bfce1a454952776018a1279e9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/019f4b9489fae2bfce1a454952776018a1279e9e"}]},"branch":"refs/heads/master","description":"Edit commit message"},"2ff1f40aebf357d6b312f0f0c31820e2385334f8":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2021-05-18 02:06:07.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/23/791623/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/23/791623/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/23/791623/4"}}},"commit":{"parents":[{"commit":"bbe6c506afecd9c92b1c1ed2d8847d1a35473a0a","subject":"Merge \"fix(yaml): corrects Charts.yaml reference\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/bbe6c506afecd9c92b1c1ed2d8847d1a35473a0a"}]}],"author":{"name":"Tin","email":"tin@irrational.io","date":"2021-05-16 17:29:42.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2021-05-18 02:06:07.000000000","tz":0},"subject":"fix(shell): polishes bash scripts","message":"fix(shell): polishes bash scripts\n\nFixes some issues in .sh raised by shellcheck.\n\nChange-Id: Ia77e1da627b7f7e0056fc1ef13194c83222657d9\nSigned-off-by: Tin \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2ff1f40aebf357d6b312f0f0c31820e2385334f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/2ff1f40aebf357d6b312f0f0c31820e2385334f8"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[],"submit_requirements":[]}