)]}'
{"ceph-client/templates/bin/pool/_init.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"0e84ada7217027d9a05fd4379103ac33226b9b6e","unresolved":true,"context_lines":[{"line_number":345,"context_line":"if [[ -n \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .name }}$)\" ]] \u0026\u0026"},{"line_number":346,"context_line":"   [[ -z \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .rename }}$)\" ]]; then"},{"line_number":347,"context_line":"  ceph --cluster \"${CLUSTER}\" osd pool rename \"{{ .name }}\" \"{{ .rename }}\""},{"line_number":348,"context_line":"  pool_name\u003d\"{{ .rename }}\""},{"line_number":349,"context_line":"fi"},{"line_number":350,"context_line":"{{- end }}"},{"line_number":351,"context_line":"{{- if and .delete .delete_all_pool_data }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"babbb548_a853bd46","line":348,"updated":"2021-05-25 14:34:59.000000000","message":"Was this part of the solution?","commit_id":"bcc31f98218192f059b7209dcea407c2c681a1c5"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"0e26d2ae0d9ef10c71e7cccc65f64fe9e7b2e747","unresolved":false,"context_lines":[{"line_number":345,"context_line":"if [[ -n \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .name }}$)\" ]] \u0026\u0026"},{"line_number":346,"context_line":"   [[ -z \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .rename }}$)\" ]]; then"},{"line_number":347,"context_line":"  ceph --cluster \"${CLUSTER}\" osd pool rename \"{{ .name }}\" \"{{ .rename }}\""},{"line_number":348,"context_line":"  pool_name\u003d\"{{ .rename }}\""},{"line_number":349,"context_line":"fi"},{"line_number":350,"context_line":"{{- end }}"},{"line_number":351,"context_line":"{{- if and .delete .delete_all_pool_data }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"f7853261_b832daf1","line":348,"in_reply_to":"babbb548_a853bd46","updated":"2021-05-25 14:40:37.000000000","message":"Yes, but not generally. This allows delete to work correctly in the case where both rename and delete are specified. Not expected to be a typical case, but it will work this way. You can see that pool_name is used on lines 356 and 357 to delete the pool.","commit_id":"bcc31f98218192f059b7209dcea407c2c681a1c5"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"6796b4bfbb8a40aeb78afd6c96dd5dbce6b1d18f","unresolved":true,"context_lines":[{"line_number":345,"context_line":"if [[ -n \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .name }}$)\" ]] \u0026\u0026"},{"line_number":346,"context_line":"   [[ -z \"$(ceph --cluster ${CLUSTER} osd pool ls | grep ^{{ .rename }}$)\" ]]; then"},{"line_number":347,"context_line":"  ceph --cluster \"${CLUSTER}\" osd pool rename \"{{ .name }}\" \"{{ .rename }}\""},{"line_number":348,"context_line":"  pool_name\u003d\"{{ .rename }}\""},{"line_number":349,"context_line":"fi"},{"line_number":350,"context_line":"{{- end }}"},{"line_number":351,"context_line":"{{- if and .delete .delete_all_pool_data }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"37441654_c994ea6a","line":348,"in_reply_to":"babbb548_a853bd46","updated":"2021-05-25 14:40:54.000000000","message":"nevermind.  after looking at the code a bit more, I think you added it just in case the pool got renamed at the same time, you need to have the pool name set to the new name.","commit_id":"bcc31f98218192f059b7209dcea407c2c681a1c5"}]}
