)]}'
{"ceph-rgw/values.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"912586c0e559e8bc0921bde1d25c721cc01038e5","unresolved":true,"context_lines":[{"line_number":408,"context_line":"      # Set \u0027delete\u0027 to true to delete an existing placement target. A"},{"line_number":409,"context_line":"      # non-existent placement target will be created and deleted in a single"},{"line_number":410,"context_line":"      # step."},{"line_number":411,"context_line":"      # delete: true"},{"line_number":412,"context_line":"  rgw:"},{"line_number":413,"context_line":"    config:"},{"line_number":414,"context_line":"      # NOTE (portdirect): See http://tracker.ceph.com/issues/21226"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"68ec5a12_a14b5470","line":411,"range":{"start_line":411,"start_character":8,"end_line":411,"end_character":20},"updated":"2021-05-26 19:04:01.000000000","message":"so what happens if someone set \"delete: true\" but left it there unattended, would that cause any problem for subsequent deployment?  I just worry this introduces some unintended headache.\nMaybe instead of doing it this way, add a new section for \"delete_placement_targets\" and list them out explicitly perhaps?   so only the ones listed will be deleted, and if they don\u0027t exist, the code can just skip the deletion attempt?","commit_id":"948e07e1515fafc2c841b4f0012205e2403125a7"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"99f7242b38e402c8cc58ecb7abd969079cf85de7","unresolved":true,"context_lines":[{"line_number":408,"context_line":"      # Set \u0027delete\u0027 to true to delete an existing placement target. A"},{"line_number":409,"context_line":"      # non-existent placement target will be created and deleted in a single"},{"line_number":410,"context_line":"      # step."},{"line_number":411,"context_line":"      # delete: true"},{"line_number":412,"context_line":"  rgw:"},{"line_number":413,"context_line":"    config:"},{"line_number":414,"context_line":"      # NOTE (portdirect): See http://tracker.ceph.com/issues/21226"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0d95b42_d87e697e","line":411,"range":{"start_line":411,"start_character":8,"end_line":411,"end_character":20},"in_reply_to":"3abbbce8_c4a251d1","updated":"2021-05-26 22:04:40.000000000","message":"That\u0027s fair.  I was most concerned if by accidentally leaving \"delete: true\" would cause problem subsequently, and your explanation addressed my concern.","commit_id":"948e07e1515fafc2c841b4f0012205e2403125a7"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"e059a8a54f7bb287f1ffcc1213dbfddec85782f7","unresolved":true,"context_lines":[{"line_number":408,"context_line":"      # Set \u0027delete\u0027 to true to delete an existing placement target. A"},{"line_number":409,"context_line":"      # non-existent placement target will be created and deleted in a single"},{"line_number":410,"context_line":"      # step."},{"line_number":411,"context_line":"      # delete: true"},{"line_number":412,"context_line":"  rgw:"},{"line_number":413,"context_line":"    config:"},{"line_number":414,"context_line":"      # NOTE (portdirect): See http://tracker.ceph.com/issues/21226"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7cd3aa14_a73b80a7","line":411,"range":{"start_line":411,"start_character":8,"end_line":411,"end_character":20},"in_reply_to":"68ec5a12_a14b5470","updated":"2021-05-26 19:24:39.000000000","message":"The current design is that \"delete: true\" deletes the placement target after it is created if it didn\u0027t exist previously. So in the case of a clean deployment or a deployment subsequent to a prior delete, the placement target would get created and immediately deleted, which achieves the target state. Once an existing placement target has been deleted it can be removed from the manifest completely, including its \"delete\" key, in order to avoid re-creating and deleting the placement target on subsequent deployments.\n\nAdding a \"delete_placement_targets\" section would present the same challenges in the case where the placement target definition wasn\u0027t removed when the delete was added. Deletes would naturally have to happen after creates to account for this, and a placement target specified in both places would get created and then deleted, which is the same behavior as the current implementation. It would provide an optimization in one case do to it that way, but there wouldn\u0027t be any logical difference.","commit_id":"948e07e1515fafc2c841b4f0012205e2403125a7"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"0712924d909d9d775856e59bc19d49595362823d","unresolved":true,"context_lines":[{"line_number":408,"context_line":"      # Set \u0027delete\u0027 to true to delete an existing placement target. A"},{"line_number":409,"context_line":"      # non-existent placement target will be created and deleted in a single"},{"line_number":410,"context_line":"      # step."},{"line_number":411,"context_line":"      # delete: true"},{"line_number":412,"context_line":"  rgw:"},{"line_number":413,"context_line":"    config:"},{"line_number":414,"context_line":"      # NOTE (portdirect): See http://tracker.ceph.com/issues/21226"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3abbbce8_c4a251d1","line":411,"range":{"start_line":411,"start_character":8,"end_line":411,"end_character":20},"in_reply_to":"7cd3aa14_a73b80a7","updated":"2021-05-26 19:43:34.000000000","message":"The same optimization could also be made by adding a condition to the if statement on line 55 of the script to skip creation of the placement target if it is being deleted. Delete is already skipped if the placement target doesn\u0027t exist. This would also keep management of a placement target to a single section in the yaml. Would this be an acceptable solution?","commit_id":"948e07e1515fafc2c841b4f0012205e2403125a7"}]}