)]}'
{"rabbitmq/Chart.yaml":[{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"202d88bb169cd85c61c4664e1d5485a039ad6c6a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"appVersion: v3.7.26"},{"line_number":16,"context_line":"description: OpenStack-Helm RabbitMQ"},{"line_number":17,"context_line":"name: rabbitmq"},{"line_number":18,"context_line":"version: 0.1.9"},{"line_number":19,"context_line":"home: https://github.com/rabbitmq/rabbitmq-server"},{"line_number":20,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f234196b_5cf873ff","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":14},"updated":"2021-06-02 13:21:55.000000000","message":"Should this be 0.1.8?","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"}],"rabbitmq/templates/monitoring/prometheus/exporter-deployment.yaml":[{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"c23c912fa26c962f881d63d3be5f848bd4f489a8","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            value: \"{{ .Values.conf.rabbitmq_exporter.rabbit_timeout }}\""},{"line_number":69,"context_line":"          - name: RABBIT_URL"},{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f1283d8_69e92453","line":71,"range":{"start_line":71,"start_character":19,"end_line":71,"end_character":24},"updated":"2021-06-01 19:28:23.000000000","message":"Can you not change the scheme to https in downstream values instead of if..else in here?","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"fe01dd11b025962be3bc1251c7ae40de7a5e5246","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            value: \"{{ .Values.conf.rabbitmq_exporter.rabbit_timeout }}\""},{"line_number":69,"context_line":"          - name: RABBIT_URL"},{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a7059d91_02457f02","line":71,"range":{"start_line":71,"start_character":19,"end_line":71,"end_character":24},"in_reply_to":"6cda878e_c40dc6c2","updated":"2021-06-02 14:57:53.000000000","message":"You can create a PROTOCOL variable and use {{ tuple \"oslo_messaging\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }} to pull in http or https without if..else.  Downstream will have the scheme.default changed to https.  This is what we have been doing. No need to do if..else.","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"9a64b942aa24a45442d5bb031832400b6abe03c2","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            value: \"{{ .Values.conf.rabbitmq_exporter.rabbit_timeout }}\""},{"line_number":69,"context_line":"          - name: RABBIT_URL"},{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7b4a6a1_60163031","line":71,"range":{"start_line":71,"start_character":19,"end_line":71,"end_character":24},"in_reply_to":"8f1283d8_69e92453","updated":"2021-06-02 14:04:25.000000000","message":"Also to avoid duplication, maybe better to simply define a \"protocol\" variable and set it first, then use it here?\n\n{{- if $envAll.Values.manifests.certificates }}\nPROTOCOL\u003dhttps\n{{- else }}\nPROTOCOL\u003dhttp\n{{- end }}","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"fdff500ae28b6171ce28f2ce97585ea0ae92244d","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            value: \"{{ .Values.conf.rabbitmq_exporter.rabbit_timeout }}\""},{"line_number":69,"context_line":"          - name: RABBIT_URL"},{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6cda878e_c40dc6c2","line":71,"range":{"start_line":71,"start_character":19,"end_line":71,"end_character":24},"in_reply_to":"b7b4a6a1_60163031","updated":"2021-06-02 14:43:53.000000000","message":"No this can not be done downstream Chi Lo, because this part of whole TLS deployment and not customized configuration.","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"9a64b942aa24a45442d5bb031832400b6abe03c2","unresolved":true,"context_lines":[{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"},{"line_number":75,"context_line":"          - name: RABBIT_USER"},{"line_number":76,"context_line":"            valueFrom:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1057b426_66ecca61","line":73,"range":{"start_line":73,"start_character":133,"end_line":73,"end_character":138},"updated":"2021-06-02 14:04:25.000000000","message":"are we using the same port for both protocol?  Should we consider using a different one to avoid confusion?","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"fdff500ae28b6171ce28f2ce97585ea0ae92244d","unresolved":true,"context_lines":[{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"},{"line_number":75,"context_line":"          - name: RABBIT_USER"},{"line_number":76,"context_line":"            valueFrom:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"01270815_97321ae2","line":73,"range":{"start_line":73,"start_character":133,"end_line":73,"end_character":138},"in_reply_to":"1057b426_66ecca61","updated":"2021-06-02 14:43:53.000000000","message":"Yes we are using the same port. Rabbit does not like a different port.","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"c15f18840eb903ae58d0054b7f98f4a1b89b5e6e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            value: \"{{ .Values.conf.rabbitmq_exporter.rabbit_timeout }}\""},{"line_number":69,"context_line":"          - name: RABBIT_URL"},{"line_number":70,"context_line":"{{- if $envAll.Values.manifests.certificates }}"},{"line_number":71,"context_line":"            value: https://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15673"},{"line_number":72,"context_line":"{{- else }}"},{"line_number":73,"context_line":"            value: http://{{ tuple \"oslo_messaging\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}:15672"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"31bcd5a4_134d2947","line":71,"range":{"start_line":71,"start_character":134,"end_line":71,"end_character":139},"updated":"2021-06-03 19:32:43.000000000","message":"Please use helm-toolkit.endpoints.endpoint_port_lookup to get port number instead of hard-coded value.","commit_id":"14053f8c31a4c4209a7a3ce8f6e93ca11a8ef8d4"}],"releasenotes/notes/rabbitmq.yaml":[{"author":{"_account_id":30746,"name":"Travis Neely","email":"travis.neely@att.com","username":"travis.neely@att.com"},"change_message_id":"202d88bb169cd85c61c4664e1d5485a039ad6c6a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - 0.1.5 Update Rabbitmq exporter version"},{"line_number":8,"context_line":"  - 0.1.6 Disallow privilege escalation in rabbitmq server container"},{"line_number":9,"context_line":"  - 0.1.7 Adding TLS logic to rabbitmq"},{"line_number":10,"context_line":"  - 0.1.9 Add TLS support to rabbitmq prometheus exporter"},{"line_number":11,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"99335d9d_90b95927","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":9},"updated":"2021-06-02 13:21:55.000000000","message":"As in the Chart.yaml, why are we skipping 0.1.8?","commit_id":"00834530cd3944abac248e5eed224af5cbb6a9fd"}]}