)]}'
{"ceph-rgw/templates/bin/_create-rgw-placement-targets.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b4f763c81f8f7d71253c0225d41f871ab11628cc","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  add_rgw_zone_placement \"$RGW_ZONE\" \"$RGW_PLACEMENT_TARGET\" \"$RGW_PLACEMENT_TARGET_DATA_POOL\" \"$RGW_PLACEMENT_TARGET_INDEX_POOL\" \"$RGW_PLACEMENT_TARGET_DATA_EXTRA_POOL\""},{"line_number":58,"context_line":"  RGW_PLACEMENT_TARGET_EXISTS\u003d$(radosgw-admin zonegroup placement get --placement-id \"$RGW_PLACEMENT_TARGET\" 2\u003e/dev/null || true)"},{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":"if [[ -n \"$RGW_PLACEMENT_TARGET_EXISTS\" ]] \u0026\u0026"},{"line_number":61,"context_line":"   [[ \"true\" \u003d\u003d \"$RGW_DELETE_PLACEMENT_TARGET\" ]]; then"},{"line_number":62,"context_line":"  rm_rgw_zone_placement \"$RGW_PLACEMENT_TARGET\""},{"line_number":63,"context_line":"  delete_rgw_placement_target \"$RGW_PLACEMENT_TARGET\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"cd64f1f1_6f50689f","line":60,"range":{"start_line":60,"start_character":3,"end_line":60,"end_character":42},"updated":"2021-07-14 17:39:17.000000000","message":"when should this ever not be true, considering the if statement preceding this one? would it not be cleaner to simply remove this conditional, rather than adding a line to ensure its always met?","commit_id":"62f5cab7707d128eb90cbe0a5651cac6b85ce0b8"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"386c60f4b4827f712c06f423df93528fa6191792","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  add_rgw_zone_placement \"$RGW_ZONE\" \"$RGW_PLACEMENT_TARGET\" \"$RGW_PLACEMENT_TARGET_DATA_POOL\" \"$RGW_PLACEMENT_TARGET_INDEX_POOL\" \"$RGW_PLACEMENT_TARGET_DATA_EXTRA_POOL\""},{"line_number":58,"context_line":"  RGW_PLACEMENT_TARGET_EXISTS\u003d$(radosgw-admin zonegroup placement get --placement-id \"$RGW_PLACEMENT_TARGET\" 2\u003e/dev/null || true)"},{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":"if [[ -n \"$RGW_PLACEMENT_TARGET_EXISTS\" ]] \u0026\u0026"},{"line_number":61,"context_line":"   [[ \"true\" \u003d\u003d \"$RGW_DELETE_PLACEMENT_TARGET\" ]]; then"},{"line_number":62,"context_line":"  rm_rgw_zone_placement \"$RGW_PLACEMENT_TARGET\""},{"line_number":63,"context_line":"  delete_rgw_placement_target \"$RGW_PLACEMENT_TARGET\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"b3cbc9ab_1654838a","line":60,"range":{"start_line":60,"start_character":3,"end_line":60,"end_character":42},"in_reply_to":"60b7c214_4641c137","updated":"2021-07-14 18:14:58.000000000","message":"I should note, however, that the current logic maintains the same behavior that the script had previously, meaning that a failure to create a placement target isn\u0027t fatal. This logic simply skips an intended placement target deletion in that case.","commit_id":"62f5cab7707d128eb90cbe0a5651cac6b85ce0b8"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"af45553f1edbaed58afbc68cb048ae73b5e2462f","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  add_rgw_zone_placement \"$RGW_ZONE\" \"$RGW_PLACEMENT_TARGET\" \"$RGW_PLACEMENT_TARGET_DATA_POOL\" \"$RGW_PLACEMENT_TARGET_INDEX_POOL\" \"$RGW_PLACEMENT_TARGET_DATA_EXTRA_POOL\""},{"line_number":58,"context_line":"  RGW_PLACEMENT_TARGET_EXISTS\u003d$(radosgw-admin zonegroup placement get --placement-id \"$RGW_PLACEMENT_TARGET\" 2\u003e/dev/null || true)"},{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":"if [[ -n \"$RGW_PLACEMENT_TARGET_EXISTS\" ]] \u0026\u0026"},{"line_number":61,"context_line":"   [[ \"true\" \u003d\u003d \"$RGW_DELETE_PLACEMENT_TARGET\" ]]; then"},{"line_number":62,"context_line":"  rm_rgw_zone_placement \"$RGW_PLACEMENT_TARGET\""},{"line_number":63,"context_line":"  delete_rgw_placement_target \"$RGW_PLACEMENT_TARGET\""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"60b7c214_4641c137","line":60,"range":{"start_line":60,"start_character":3,"end_line":60,"end_character":42},"in_reply_to":"cd64f1f1_6f50689f","updated":"2021-07-14 18:05:29.000000000","message":"This could still be false in the case where the placement target creation fails and radosgw-admin on line 58 doesn\u0027t return a placement target name. It could be argued that the \"|| true\" is incorrect in that case and the script should fail though.","commit_id":"62f5cab7707d128eb90cbe0a5651cac6b85ce0b8"}]}