)]}'
{"libvirt/templates/daemonset-libvirt.yaml":[{"author":{"_account_id":33519,"name":"Tin Lam","email":"tinlam@outlook.com","username":"tlam"},"change_message_id":"7c539952df189b25ce91e4b865063cf7c2370444","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    - -c"},{"line_number":20,"context_line":"    - /usr/bin/virsh list"},{"line_number":21,"context_line":"{{- end }}"},{"line_number":22,"context_line":"{{- define \"libvirtlivenessProbeTemplate\" }}"},{"line_number":23,"context_line":"exec:"},{"line_number":24,"context_line":"  command:"},{"line_number":25,"context_line":"    - bash"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a8a51c67_5004d391","line":22,"updated":"2021-07-13 15:17:48.000000000","message":"nit: Liveness","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"0e392eaa945c0cae841dd1caf66f8be357017e22","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - -c"},{"line_number":20,"context_line":"    - /usr/bin/virsh list"},{"line_number":21,"context_line":"{{- end }}"},{"line_number":22,"context_line":"{{- define \"libvirtlivenessProbeTemplate\" }}"},{"line_number":23,"context_line":"exec:"},{"line_number":24,"context_line":"  command:"},{"line_number":25,"context_line":"    - bash"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"470572ad_5c883d4f","line":22,"in_reply_to":"a8a51c67_5004d391","updated":"2021-07-13 19:41:52.000000000","message":"Updated.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"}],"libvirt/values.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2c1b2443ff1e31bd86856230b0d2bb3850dbfbb9","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        liveness:"},{"line_number":109,"context_line":"          enabled: true"},{"line_number":110,"context_line":"          params:"},{"line_number":111,"context_line":"            initialDelaySeconds: 0"},{"line_number":112,"context_line":"            periodSeconds: 10"},{"line_number":113,"context_line":"            timeoutSeconds: 1"},{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b205c068_d824b2f8","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":29},"updated":"2021-07-09 16:31:31.000000000","message":"These values are way too aggressive IMO. The exec overhead of these probes is likely too much to only wait 1 second, I would up to at least 5 for the timeout.\n\nRunning every 10 seconds seems a bit much as well, once a minute may be better.\n\nThe delay should also be bumped up imo.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"87749b16c8b75dd3b3c82d3caf82c04f6caa07b6","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        liveness:"},{"line_number":109,"context_line":"          enabled: true"},{"line_number":110,"context_line":"          params:"},{"line_number":111,"context_line":"            initialDelaySeconds: 0"},{"line_number":112,"context_line":"            periodSeconds: 10"},{"line_number":113,"context_line":"            timeoutSeconds: 1"},{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fd89393_374ecea6","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":29},"in_reply_to":"1565ec9d_3325f59a","updated":"2021-07-12 16:06:40.000000000","message":"Generally speaking I loath having any probes run so frequently anyway and timeout so quickly, I mean, we don\u0027t set API or gateway timeout this short right?  If there is an opportunity to back this off some, I am all for it, although I am not exactly pushing for it, but if the opportunity presents itself such as now....\n\nThe value Gage suggests works for me, but probably appropriate to add some delay to liveness probe, maybe half of the frequency of the readiness, so 30s?","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"0e392eaa945c0cae841dd1caf66f8be357017e22","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        liveness:"},{"line_number":109,"context_line":"          enabled: true"},{"line_number":110,"context_line":"          params:"},{"line_number":111,"context_line":"            initialDelaySeconds: 0"},{"line_number":112,"context_line":"            periodSeconds: 10"},{"line_number":113,"context_line":"            timeoutSeconds: 1"},{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7c8b2350_4276b1b2","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":29},"in_reply_to":"9fb3315c_cb042149","updated":"2021-07-13 19:41:52.000000000","message":"Updated as suggested.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ead717f7644075a8886f8f6e6d726e8bb6a1b473","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        liveness:"},{"line_number":109,"context_line":"          enabled: true"},{"line_number":110,"context_line":"          params:"},{"line_number":111,"context_line":"            initialDelaySeconds: 0"},{"line_number":112,"context_line":"            periodSeconds: 10"},{"line_number":113,"context_line":"            timeoutSeconds: 1"},{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb3315c_cb042149","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":29},"in_reply_to":"9fd89393_374ecea6","updated":"2021-07-12 16:13:11.000000000","message":"The default values per kubernetes spec are likely fine for a simple web service, but for libvirt here the computational overhead of exec\u0027ing in and running virsh list is much higher than a simple HTTP probe.\n\nWe want the defaults in this chart to match the use case here.\n\n30s is probably fine for the delay.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"0d5b4e57332f20b2da7ad3fa6e05e4557012a196","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        liveness:"},{"line_number":109,"context_line":"          enabled: true"},{"line_number":110,"context_line":"          params:"},{"line_number":111,"context_line":"            initialDelaySeconds: 0"},{"line_number":112,"context_line":"            periodSeconds: 10"},{"line_number":113,"context_line":"            timeoutSeconds: 1"},{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1565ec9d_3325f59a","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":29},"in_reply_to":"b205c068_d824b2f8","updated":"2021-07-09 19:35:40.000000000","message":"These are the default values per K8s pod.spec. The original intent was simply refactor the charts to enable overriding the probes without altering the functionality or behavior. If the default values are considered aggressive, it can be adjusted accordingly per deployment specific requirements.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2c1b2443ff1e31bd86856230b0d2bb3850dbfbb9","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"},{"line_number":117,"context_line":"            initialDelaySeconds: 0"},{"line_number":118,"context_line":"            periodSeconds: 10"},{"line_number":119,"context_line":"            timeoutSeconds: 1"},{"line_number":120,"context_line":"  security_context:"},{"line_number":121,"context_line":"    libvirt:"},{"line_number":122,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"66eb4fba_cadf0749","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":29},"updated":"2021-07-09 16:31:31.000000000","message":"Same here","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"0e392eaa945c0cae841dd1caf66f8be357017e22","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        readiness:"},{"line_number":115,"context_line":"          enabled: true"},{"line_number":116,"context_line":"          params:"},{"line_number":117,"context_line":"            initialDelaySeconds: 0"},{"line_number":118,"context_line":"            periodSeconds: 10"},{"line_number":119,"context_line":"            timeoutSeconds: 1"},{"line_number":120,"context_line":"  security_context:"},{"line_number":121,"context_line":"    libvirt:"},{"line_number":122,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"631bab19_5066f869","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":29},"in_reply_to":"66eb4fba_cadf0749","updated":"2021-07-13 19:41:52.000000000","message":"Updated as suggested.","commit_id":"bffd637c80aadc6b154712ce6240fc077724c418"}]}